- 04 Mar, 2020 40 commits
-
-
Tibor Goldschwendt authored
This includes adding title navigation to the customize dialog to switch between collections and images. NOTE: This does not embed actual images. Will do this in a follow up CL. Bug: 1032328 Change-Id: I3f9931aca673590dcd05dd4e4fa6dcf046aee3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076554 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#746634}
-
Brian Osman authored
Bug: chromium:1045995 Change-Id: If8d5873d355c12587bc231091145b0312726b667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085293Reviewed-by:
Mike Klein <mtklein@google.com> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#746633}
-
Lukasz Anforowicz authored
Fixed: 1054974 Change-Id: Ica1b44284e99f9b56f49bcbb602bfd0cdb6de648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081263Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746632}
-
Dan Harrington authored
StreamModel ingests DataOperations and provides the set of content to be rendered by the UI. Also supports ephemeral changes which can be undone later. We'll add some additional features to this class soon, as it is only a subset of what we need. Bug: 1044139 Change-Id: I1b8d6c6196c9102c0cd6696033b3083ccf350c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083433 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#746631}
-
Robert Liao authored
This test helps ensure that color values do not change when the Color Provider feature is enabled. BUG=1057754 TBR=sky@chromium.org ui/base Feature Addition for the Color Provider. Change-Id: Ifd115ee7d4b6f73e337e5e74269d521960de7250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086191 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#746630}
-
Nicholas Hollingum authored
When the user is back up their container in-advance of an upgrade the user is shown a file-chooser. If they cancel, currently they will be shown a "backup successful" window for 2 seconds. We track this now by removing the 2 second timeout when the user cancels. Technically the "backup successful" screen still flashes up while the pre-checks run, but this is practically instant so i don't think its worth making a more involved change. Bug: 1052719 Change-Id: If99e5e6775ac81b6dede0c8e2a2f35b77e26fe2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079776Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#746629}
-
Brandon Wylie authored
Bug: 1049829 Change-Id: Ia262b370239816d02c58f2066e20c907169865f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080818 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#746628}
-
Evan Stade authored
This improves on CountDownLatch by adding a default timeout and turning the InterruptedException into an assertion failure. The biggest advantage of a timeout is that the test will fail with a stack trace, as opposed to failing with no trace or logs. Bug: 1052802 Change-Id: I236a996b4da1870644fddfa6da28c7d9e51191e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079909Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#746627}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/83af90cf49de..024aa8877850 git log 83af90cf49de..024aa8877850 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 hjd@google.com Merge "Disable ftrace_procfs_integrationtest" Created with: gclient setdep -r src/third_party/perfetto@024aa8877850 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia098908a329bdb116e7328c5996708e7141889ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086172Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746626}
-
Anastasia Helfinstein authored
This is a step towards incorporating Rose and Sophie's code (see links below) for text navigation and selection from last summer into the new navigation paradigm. Ex: https://chromium-review.googlesource.com/c/chromium/src/+/1772301 https://chromium-review.googlesource.com/c/chromium/src/+/1727242 Bug: 982004 Change-Id: I9a3c9e86dfdf15c3cdaea0086f64273192c06491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076445 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#746625}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e1318818e6ab..fe6f75240a8c git log e1318818e6ab..fe6f75240a8c --date=short --first-parent --format='%ad %ae %s' 2020-03-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/depot_tools@fe6f75240a8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I3f884b2c182c5d8bbf21f7963c7619dda3b15efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086174Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I498dc4650403679f81766867cd67fe58c63a1f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086177Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4036cb1f0b6e..a54af923929b git log 4036cb1f0b6e..a54af923929b --date=short --first-parent --format='%ad %ae %s' 2020-03-03 bsalomon@google.com Make AHWBuffer generator responsible for MIP maps. Created with: gclient setdep -r src/third_party/skia@a54af923929b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: Iaa77263c14e8e1525d8ea13821b6550ae2fd827e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086173Reviewed-by:
-
Azeem Arshad authored
This reverts commit f4914fbf. Reason for revert: The paper-tooltip overflows outside of modal dialog boxes and results in unwanted horizontal scrollbars. see https://crbug.com/1055266. This fix should implement the tooltip in such a way that fits correctly inside the container. Original change's description: > Network settings: Add tooltip to eye icon-button > > > Bug: 873114 > Change-Id: I05cef0d2a7e53c1bc965764e2b83aefd502753cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993828 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Cr-Commit-Position: refs/heads/master@{#732662} TBR=dpapad@chromium.org,raleksandrov@google.com,johntlee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 873114, 1055266 Change-Id: I0b7561abaf41a597556cc2e0e8d0481101eeab10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086351 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#746621}
-
Andrew Grieve authored
This is a reland of 91ac1e45 TBR=agrieve@chromium.org Original change's description: > Android: Speculative crash fix for DelayedScreenLockIntentHandler > > Stack is: > Caused by: android.util.AndroidRuntimeException: Calling startActivity() from outside of an Activity context requires the FLAG_ACTIVITY_NEW_TASK flag. Is this really what you want? > at android.app.ContextImpl.startActivity (ContextImpl.java: 952) > at android.content.ContextWrapper.startActivity (ContextWrapper.java: 405) > at org.chromium.chrome.browser.ChromeApplication.startActivity (ChromeApplication.java: 206) > at org.chromium.chrome.browser.ChromeApplication.startActivity (ChromeApplication.java: 199) > at org.chromium.chrome.browser.DelayedScreenLockIntentHandler.onReceive (DelayedScreenLockIntentHandler.java: 40) > at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$getRunnable$0$LoadedApk$ReceiverDispatcher$Args (LoadedApk.java: 1550) > ... > > From history on DelayedScreenLockIntentHandler, repro steps involve > launching a page via NFC while locked. > > This restriction is listed as a new one in Android P: > https://developer.android.com/about/versions/pie/android-9.0-changes-all#fant-required > > Bug: 1034440 > Change-Id: Ibe13fb99a34d36a15e266d9369393dd6060a1e93 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972135 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746442} Bug: 1034440 Change-Id: Ie7be9554e9ab2818894ef67e543f9c7249c6665f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086251 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746620}
-
Darwin Huang authored
https://crrev.com/c/2080256 disabled these tests on all platforms. This CL re-enables these tests when not on Android, so that bots can continue to verify correct behavior on other platforms. Bug: 1056650 Change-Id: Id057bd3fe5c0dfbcdc405d60c9a6d58133999aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086252 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746619}
-
dalyk authored
During the DoH auto-upgrade experiment we disabled OCSP/CRL fetches for connections to DoH servers. This change takes a different approach to breaking the potential deadlock and instead disables DoH for all OCSP/CRL/AIA fetches. Bug: 990827 Change-Id: I9885cac230aafaa41ba183b5799e771ba7c524e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843334 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#746618}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f796ed84..05f974d7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I093ac585504e289eb6ff2e8aeafb8990c798319a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085512Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746617}
-
Zain Afzal authored
Addresses some of the final comments on message_pipe.js from crrev/c/2049404. Namely adds a assertCast for better safety when casting our targetWindow reference, and removes some unnecessary type casts. Bug: 996088 Change-Id: I91f9af2329feafcaab45395e8290631697afb7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084271 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#746616}
-
Xinghui Lu authored
The token is obtained from safe_browsing_token_fetcher and set in the request header. After the request is sent, the token is also set in the RTLookupRequest proto, which is used for displaying in chrome://safe-browsing. Bug: 1041912 Change-Id: Ic4a6c9e9eb1370e8fa90ff0b0292d1f3a206bd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079809Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746615}
-
Wan-Teh Chang authored
https://chromium.googlesource.com/codecs/libgav1.git/+log/8e8c13b9e821..fa1c3c4e673c $ git log 8e8c13b9e..fa1c3c4e6 --date=short --no-merges --format='%ad %ae %s' 2020-02-19 wtc Change libgav1's frame buffer callback API. 2020-02-18 vigneshv Move tile_scratch_buffer_pool_ to FrameScratchBuffer 2020-02-18 jzern film_grain.h: remove unused fn decls 2020-02-18 jzern libgav1_decoder.cmake: rm commented out header 2020-02-18 vigneshv trivial: Rename EncodedFrame to TemporalUnit 2020-02-18 johannkoenig blend: remove stride from average blend 2020-02-18 johannkoenig prediction: remove prediction_stride 2020-02-18 vigneshv trivial: Refactor ApplyFilmGrain parameters 2020-02-17 wtc Rename YuvBuffer::displayed_width+displayed_height 2020-02-17 vigneshv trivial: Fix ApplyFilmGrain return status on success Created with: roll-dep src/third_party/libgav1/src Update the libgav1 frame buffer callbacks in media/filters/gav1_video_decoder.cc to the final prototypes. In particular, omit the OnFrameBufferSizeChangedImpl callback. Tested: $ gn args out/Default # In the editor, add the following build argument: # enable_libgav1_decoder = true $ autoninja -C out/Default media_unittests $ out/Default/media_unittests $ out/Default/media_unittests --enable-features=Gav1VideoDecoder R=tomfinegan@chromium.org,johannkoenig@google.com,jzern@google.com Bug: 1026522 Change-Id: I8f316131b74bdd1242ab7394346c043c355736e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085593 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#746614}
-
Hongchan Choi authored
In cross-thread messaging, the associated execution context can be already gone when a posted task is performed sometime later in the task runner's queue. By using WeakPtr, the task runner will not perform a scheduled task in the queue when the target object is invalid. Test: Locally confirmed that the repro does not crash. Bug: 1057627 Change-Id: I51737594c918f6a4924c9a7ffe30db3e8de9a683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082897 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#746613}
-
Taylor Brandstetter authored
This change allows network_priority to change from a double to an enum in WebRTC without breaking chromium. After the WebRTC change is made, this will be cleaned up using helper functions and a switch statement. Bug: webrtc:5658 Change-Id: I0c0f7da85d94fd7969df4f1cf184b76a05174e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078849Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Taylor <deadbeef@chromium.org> Cr-Commit-Position: refs/heads/master@{#746612}
-
Zhuoyu Qian authored
Bug: 1043732 Change-Id: I31a1cf9a6fe4e3a839c6b082aae1ff4c90e4c4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076752Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#746611}
-
Alex Newcomer authored
This was broken a while ago but went unnoticed. We should show the back button, pointing downwards, so users can get out of the ime VK. Also we should show the in-app shelf to hide the apps. Bug: 1058149 Change-Id: I170f1c24fc405d7ff322ada5a9816cde4e198078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083758Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#746610}
-
Anand K. Mistry authored
ChromeAsyncExtensionFunction is deprecated and its behaviour is not well documented. Migrating to ExtensionFunction allows the function's result behaviour to be more explicitly defined. Bug: 634140 Change-Id: I1be112d7c1188c698650e9ecbf2ac5e88c45f3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066502 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#746609}
-
Darren Shen authored
Change-Id: I1ed54d34f2cc2b81078144facb47941405702d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082653Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#746608}
-
Yulun Wu authored
Bug: 991767 Change-Id: I26ba9da8a01a20efed9634cf9a8c462b14b999d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084719 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746607}
-
Jinsong Fan authored
According to http://crrev/c/1742171, Java AwQuotaManagerBridge is not a singleton and owned by Java AwBrowserContext. The JNI GetDefaultNativeAwQuotaManagerBridge is no longer used. Bug: None Change-Id: I4714c9a703ccbddf62b9667dde3e4a2cde5bda74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082870Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#746606}
-
Bettina authored
SBER and Standard protection are offered by Enhanced Protection. To prevent multiple places checking enhanced protection, one check is added into the pref service and all other code calls the code. Bug: 1057191 Change-Id: Ic79b9acb17578eaa32dac47178cb48903864ae7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083863 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ccefde95b3bb..40d8cb5fc0ae git log ccefde95b3bb..40d8cb5fc0ae --date=short --first-parent --format='%ad %ae %s' 2020-03-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 20a0a16e..0380a339 (746350:746487) Created with: gclient setdep -r src/third_party/webrtc@40d8cb5fc0ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6c8d6f9786e06ccad77c785b35170e4f4fa68524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085194Reviewed-by:
-
Hiroki Sato authored
This CL cleans up the a11y bounds computations in ARC++; - Aggregate the bounds computation logic inside AccessibilityInfoDataWrapper. - Explicitly use |offset_container_id| of AXRelativeBounds. _ Keep the device scale factor in AXTreeSourceArc. Set and update it from ArcAccessibilityHelperBridge. This CL also fixes the bounds computation of notification window and input method window, which were currently not adjusted by device scaling. Bug: b:147707554 Test: manual. Open PlayStore, change device scale factor by Ctrl +/-, bounds are correct. Test: manual. Open TalkBack-test app, create notification windows, bounds are correct. Change-Id: Ie5f6904fcf8c18fd86d9fc1e99a1db7970a14be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066411 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#746603}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e3e152bd3a29..970291c5e024 git log e3e152bd3a29..970291c5e024 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 jarhar@chromium.org Improved cookie blocked reason ui strings 2020-03-03 sigurds@chromium.org [COEP] Report detailed blocked reason for requests blocked by COEP Created with: gclient setdep -r src/third_party/devtools-frontend/src@970291c5e024 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051466 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I90102f67410ada7ef85ddf0f97ba6a82f56718e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085179Reviewed-by:
-
Matt Menke authored
Previously, when idle sockets were closed by the socket pool, there was no information as to why (Closed by remote side, received data unexpectedly, low memory notification, flushing socket pools with an error, etc). This CL adds an event that logs a text string when the socket pool closes a socket, which should help debug sockets cases where sockets are unexpectedly closed. Bug: 1054186 Change-Id: Id4db0394b006ab434b3548a521bf6d7b324e145f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067684 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Noel Gordon authored
Make the Files app window frame white in files-ng. The frame color of Video Player, Gallery, and Audio Player are not changed. Minor: Fix var/let/const pre-submit nits. Add eslint var exception to the var loader = {} ... line, since per the patchset #1 try jobs, the KeyboardOperations/FilesAppBrowserTest*/keyboardOpenNewWindow* tests fail if const (or let) is used instead of var. Bug: 1057918 Change-Id: Ic7beb58e34b9d152bff90de1c775d7dd16442a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084335Reviewed-by:Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#746600}
-
Xing Liu authored
UserLevelMemoryPressureSignalGeneratorTest.GenerationPauses is failing on some Android builders. This CL disables it. TBR=slangley@chromium.org Bug: 1058178 Change-Id: I5bbee637ee9a23589bfe7d5c0be93406bf372c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086311Reviewed-by:
-
Nektarios Paisios authored
R=aleventhal@chromium.org, dmazzoni@chromium.org Change-Id: I2b26abd652e0797e70ad3c869ff2f1ad922b3152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085115 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#746598}
-
Michael Sun authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/a4d130010ec6..2302d21944c8 $ git log a4d130010..2302d2194 --date=short --no-merges --format='%ad %ae %s' 2020-02-20 kevinptt runtime_probe: Modify probing type of wireless 2020-02-29 michaelfsun system_api: Add CRAS media player D-Bus constants 2020-02-26 juwa vm_tools: add extensions to Application message Created with: roll-dep src/third_party/cros_system_api Bug: b:147365563 Change-Id: Ieee9f156c4a834b8f71ce2bd34cd8713c1a670cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081187Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Michael Sun <michaelfsun@google.com> Cr-Commit-Position: refs/heads/master@{#746597}
-
Eric Willigers authored
CreateAppIdLaunchParamsWithEventFlags is used by system web apps. We move the function from extensions to app service, eliminating a dependence of web apps on extensions/ code. Change-Id: Ie406bdd4aa0e69752d5ad671925310a11da29e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082669Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#746596}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f096a8f4. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I5302bf94f97bafb0111ec63d2647f041b25f86ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084833Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746595}
-
