- 23 Jun, 2020 40 commits
-
-
Kushagra Sinha authored
Cleanup all usages of test fixture member access from tests. They should go through member methods instead of being accessed directly. Change-Id: I7b8730d470ae051a2ca4e4b9768fc16ac84179ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255079 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#781390}
-
John Williams authored
This change also factors out functionality from CastActivityRecordTest into ActivityRecordTestBase so it can be shared. Bug: b/155649299 Change-Id: I84ff6c2527e7bcb0da53ffa86078f1c09278b6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244125 Auto-Submit: John Williams <jrw@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#781389}
-
Ted Choc authored
This does the conversion of content/public tests. As part of this transition, Criteria.equals is being replaced in tests to allow its removal. BUG=1071247 Change-Id: I27f336db7e66e01834945b7fa1df073093641b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255658 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#781388}
-
Colin Blundell authored
Neglected in the initial wiring up of infobars in WebLayer. Bug: 1093846 Change-Id: I5fff123f3948c930ec78cfe80de3ed31785d287b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257218Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#781387}
-
David Van Cleve authored
Currently, we have three places where we compute requests' referrers, nominally according to [1, Algorithm 8.1]. This change makes a couple alterations to SecurityPolicy::GenerateReferrer (one of the places) to bring it in line with the behavior in content::Referrer::SanitizeForRequest (another implementation of the algorithm). After this change, SecurityPolicy::GenerateReferrer will: - truncate requests with referrers longer than 4096 bytes to the initiating origin, as specified in [1, Alg. 8.1, step 6]; - strip URLs for use as referrers as part of the referrer generation process [step 4]; and - explicitly return "no referrer" when given an invalid URL (motivation: this will align the behavior with the other two implementations of the algorithm once they also strip URLs for use as referrers as part of the referrer generation process, because this is how GURL::GetAsReferrer behaves). In order to implement the second of these in a manner consistent with the non-Blink code, this change alters KURL's referrer stripping logic to move from "return a default value if the URL is not http(s)" to "return a default value if the scheme is not suitable for use in a referrer", bringing it in line with GURL::GetAsReferrer. [1]: https://w3c.github.io/webappsec-referrer-policy/#parse-referrer-policy-from-header Bug: 1094526 Change-Id: I515fd9e832e99c1fdd2ca207560b865d06edc39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246987Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#781386}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bf296fb827fe..fc5464c325c9 2020-06-23 ahassani@chromium.org cros_update: Remove quick provision code 2020-06-23 ahassani@chromium.org auto_updater_transfer: Fix issue with GetPayloadSize() 2020-06-23 ahassani@chromium.org auto_updater_transfer: Fix issues with ssh fallback 2020-06-22 pprabhu@chromium.org commands: Delete dead code 2020-06-22 pprabhu@chromium.org config: Introduce constants for quota accounts 2020-06-22 pprabhu@chromium.org config: Delete dead code 2020-06-22 pprabhu@chromium.org config: Delete unused constants 2020-06-22 pprabhu@chromium.org config: Update default HWTest pool and quota_account 2020-06-22 pprabhu@chromium.org config: Explicitly set Skylab quota account for tryjobs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I41d50d42b062041b1ede751fba7f1b4745842fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260832Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781385}
-
Joe Mason authored
Callers can create MeasurementRequest objects to perform per-frame memory measurements at different frequencies. The decorator is automatically created when the first request is issued. Bug: 1080672 Change-Id: I20ac9d24ffceb6000ff595d4536a6d3daefa7d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243444 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781384}
-
Xianzhu Wang authored
We have finished diagnosing crbug.com/1086968 about dirty layout after layout for custom scrollbars and legacy flexboxes and fixed several bugs. Now change the CHECKs to DCHECKs before M85 branch. Bug: 1093281, 1086968 Change-Id: I6cd29c4d38f11f300b91088bb937df04d086e2f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261092 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781383}
-
David Maunder authored
Following moving rootId to a UserData object (CriticalPersistedTabData) it is now necessary to check if the Tab is destroyed before attempting to access root id from the CriticalPersistedTabData object. Previously root id was available right up until the object no longer existed. Bug: 1097009 Change-Id: I78ca61cdff2ccc3275a48425a76514790c59daac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257500Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#781382}
-
Raphael Kubo da Costa authored
Make sure |line| is a string and not a bytes object. Bug: 941669 Change-Id: Ief610b426326f849b49353c5cbce68deb0cd4b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260872 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#781381}
-
Sahel Sharify authored
According to PH w3 spec the "details" input of the changePaymentMethod should be optional[1]. Even though payment_request_event.idl honors the spec[2],the blink implementation and the mojom file treat "details" as a mandatory field. This cl fixes the issue. Test coverage: I reproduced the bug by removing the "details" field from changePaymentMethod call[3]; The following two tests pass only after applying the fix in this cl and fail without it: MerchantResponse/PaymentHandlerChangePaymentMethodTest.Test/0 MerchantResponse/PaymentHandlerChangePaymentMethodTest.Test/1 [1]https://w3c.github.io/payment-handler/#the-paymentrequestevent [2]https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/payments/payment_request_event.idl?l=23 [3]https://chromium-review.googlesource.com/c/chromium/src/+/2254084/2/components/test/data/payments/change_payment_method_app.js#32 Bug: 1083193 Change-Id: Ia479401d021be2d110a7a7ad4fe652d2eae4d88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254084 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#781380}
-
Devlin Cronin authored
MessagingUtilTest.TestMaximumMessageSize exercises our extension message limits by trying to send large messages. Unfortunately, large messages take a long time to construct, which, it appears, can result in the test timing out. The test currently runs two virtually-identical cases (a massive string and a massive JSON-ified string). Remove the JSON-ified case to cut the effective test duration in half. Bug: 1093817 Change-Id: I597b8ad1c66fb894c8b1520230c779aa70107c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259473Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781379}
-
Jordan Bayles authored
This TODO isn't going to be completed, so deleting it from source. Bug: 1015461 Change-Id: I5dbfbbf9751cd8fb089614138d5759a668f08523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258682Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#781378}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2bf27f21f8d1..2eb3c17ba30a 2020-06-23 dmazzoni@chromium.org Add appendNodeIdArray to avoid code duplication. 2020-06-23 jmbetancourt@google.com Reland the new module for skia lib for g3 2020-06-23 kjlubick@google.com [canvaskit] Fix CPU build 2020-06-23 brianosman@google.com Remove GPU read-back logic in SkSpecialImage 2020-06-23 robertphillips@google.com Update image_from_yuv_textures GM for *ooprddl configs 2020-06-23 fmalita@google.com Revert "[skottie] skottie_tool updates" 2020-06-23 fmalita@chromium.org [skrive] Parse color paints If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:607777 Tbr: lovisolo@google.com Change-Id: I79fce18802108a47219aa0049b6c16f2ef3b6038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260525Reviewed-by:
-
Peter Kotwicz authored
This CL addresses the two potential reasons that ChromeActivity#getCompositorViewHolder() == null when SplashController#hideSplash() is called Reason #1: ChromeActivity#onInitialLayoutInflationComplete() has not yet been called Reason #2: SplashController#hideSplash() is called after ChromeActivity#onDestroy() BUG=1096171 Change-Id: If46daf4bcf007fab26c6c9066d355b3c4506eb38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259483 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#781376}
-
Mikel Astiz authored
The modern codepaths within the sync engine have barely any special- handling for bookmarks. The relevant bits already have unit-test coverage, such as in ModelTypeWorkerTest, and most bookmark-related logic lives in components/sync_bookmarks, where there is good test coverage. Besides that, most scenarios are also covered by sync integration tests for bookmarks. Change-Id: Ife306e8924fabaef518400ed0b210fcfdaaaea5a Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259859Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#781375}
-
Hiroshige Hayashizaki authored
Change-Id: I2d1d7835f1434c665f6382c0da33e0eacee9b7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259698Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#781374}
-
nancylingwang@google.com authored
Based on go/respectful-code, modify blacklist to blocklist. FYI: https://tools.ietf.org/id/draft-knodel-terminology-00.html BUG=1097644 Change-Id: I271542cc8103e2488d7d27b7df805d020e70ede3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256113Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#781373}
-
Vladimir Levin authored
This patch adds a use counter for each value of content visibility other than the default. R=chrishtr@chromium.org Fixed: 1096676 Change-Id: I71dcb549b04b249f701bcc0b5b68f966052f0c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257540 Commit-Queue: vmpstr <vmpstr@chromium.org> Auto-Submit: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#781372}
-
Nohemi Fernandez authored
The ClearSyncedData feature has been enabled by default. Bug: 1005509 Change-Id: I799683d3cd1e9194d66751c1d4ac52f578949f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260732Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#781371}
-
Kushagra Sinha authored
Split InitializeAccountManager utility method into two methods - InitializeAccountManager and InitializeAccountManagerAsync - to clearly communicate the contract of these methods. Change-Id: Ifbc16205cea0ba37ab3d7cc5d8be287510a07082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255358 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Lei Zhang authored
Also fix files that failed to do IWYU and stopped building as a result. Bug: 1010217 Change-Id: I6ab8e88728d33853ea62426046ecc1f92430cb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257994Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#781369}
-
Chris Sharp authored
Fixes lint warning: SlowTests:487 Expectation 'virtual/gpu/fast/canvas/canvas-composite-text-alpha.html' is redundant with 'fast/canvas/canvas-composite-text-alpha.html' in line 488 TBR=yiyix@chromium.org Bug: 1093836 Change-Id: I041f5856a658527e70bb1c334c6dca651b090f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260425Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#781368}
-
Lei Zhang authored
When calling chrome.fileSystem.chooseEntry() to perform saves, the PDF Viewer currently sets a suggested file name that ends with ".pdf". This is sufficient for the file pickers on Linux and Chrome OS to suggest saving using the suggested file name. However, the file pickers on Windows and Mac will only show the suggested file name without an extension. So trying to save "foo.pdf" and accepting the default results in a new file named "foo". Fix this by setting a value for the "accepts" key in the chooseEntry() parameter dictionary. Specify "pdf" as the extension here to get file pickers to make the correct suggestion. Bug: 1098072 Change-Id: I5b7a3ca7ffadfe14364fdc17b08d1a3133f8a747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259478 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#781367}
-
Theresa authored
This reverts commit e8ad9107. Reason for revert: crbug.com/1098208 Original change's description: > Replace IdentityServicesProvider functions in history classes. > > This CL replaces deprecated functions of IdentityServicesProvider with > the newer service getters with profile parameter. By this CL, > HistoryManager uses IdentityServicesProvider functions with the profile > generated regarding to isIncognito parameter from the constructor. > > Bug: 1041781, 1075562 > Change-Id: I04c0a14b5f9e912cda7fb34a581bea4d18023518 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242078 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780206} TBR=twellington@chromium.org,rhalavati@chromium.org,sideyilmaz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1041781, 1075562, 1098208 Change-Id: Ie08a1ae7d60e3c35f4b5f2ed9cc714bf907cea8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259150Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#781366}
-
Stephane Zermatten authored
With this change, we can express elements as "the button that's closest to the text containing 'click here'" and "the button above the text 'checkout'" This is implemented by measuring the distance between the element's bounding boxes and choosing the closest pair of elements. Bug: b/157970373 Change-Id: I287f0db80279f2342b2b12b1c8aa9f6f9b883b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228315 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#781365}
-
Dominik Röttsches authored
Tbr: kojii Bug: 481430 Change-Id: I5005b7c3232506ba5a1a1e988832576f9ee9cd81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260694Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#781364}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87cae0e24e81..d15ec1eec289 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC beverloo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: beverloo@google.com Change-Id: I5446bb3b12a77ab7760703ce993e34c4de524bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260519Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781363}
-
ckitagawa authored
This CL completes the implementation of embedding token per-document. Now every cross-document navigation comes with an embedding token (for both local and remote frames). These tokens are to be used for a parent document to opaquely reference a child document. Bug: 1072422 Change-Id: Ic3c9b02eafe5874d484bde6bedfd89b2c5fcfbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150814 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781362}
-
Marc Treib authored
The DCHECK ensured that there are no unsynced deletions, which is only correct if the |success| param is true. Bug: 1086433 Change-Id: I2f8de54e33d48384b7499a9bfaf3affb968344ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260774Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#781361}
-
Abigail Klein authored
of the DumpAccessibility tests. Change-Id: I833af7699a8317366930ca2e071c34585ab0ff8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259254 Auto-Submit: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#781360}
-
Chris Sharp authored
TBR=lanwei@chromium.org Bug: 1025944 Change-Id: I059356aa818dce87429db6120e005515d747a3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260852Reviewed-by:
-
Mahmoud Gawad authored
Add telemetry-extension-dir command line switch name to be able to load the Telemetry System Web Extension from disk. Bug: b:156583406 Test: Not needed. chrome build is green Change-Id: Id8ae2a8c6a27fa0637264ac9e6e14467e66e8de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257235 Commit-Queue: Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#781358}
-
Eero Häkkinen authored
This CL refactors video capture device creation on Windows, removes some code duplications related to DirectShow device enumeration and adds mocking points for unit testing. This CL has no functional changes. Bug: 934063 Change-Id: I2df08b3a361ffd702761bd9d6b400f4418390c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247797 Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Auto-Submit: Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#781357}
-
Xianzhu Wang authored
Change-Id: If25a2df97a3bf5a322c02d650eb5aaeff86f7722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258423Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781356}
-
Clark DuVall authored
Now that references in clank have been switched over to the version in //components, it's safe to remove this. Bug: 1025606 Change-Id: Id453032a8237d11d94dcc32d102bf5de243a10d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256850Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592909179-8c9bd637e5cbc50bd35bf53946c51dca562e57cb.profdata to chrome-win64-master-1592917001-f92b525a65d0a85552634ba3f6ed8ed822d9ee38.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I66ef0c9c6e9a1b6220d16f99d3bcfd3f6da86daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260522Reviewed-by:
-
Michael Ershov authored
Add a field to certificate provisioning policies to disable Verified Access checks for a certificate profile. Modify CertProvisioningWorker to bypass all Verified Access related methods and use PlatformKeysService to generate keys instead. Bug: 1045895, 1094814 Test: CertProvisioning* Change-Id: I9318e2734a897189e3b25f6b9cdeca951c6e1526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238069 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#781353}
-
Becca Hughes authored
Add connect-src to CSP so we can override it in untrusted WebUI. BUG=1087443 Change-Id: Ib93c326e629c2225ddfad0740c4befc26d39b757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246902 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#781352}
-
Becca Hughes authored
This is a reland of e5a8add0 Original change's description: > Split kaleidoscope resources in two > > Split the kaleidoscope resources and strings > into two since they are going to be moved > around. > > BUG=1087037 > > Change-Id: Iee08832b837a18bbb102fcd8cc6ea98c5dbdf819 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254706 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780879} Bug: 1087037 Change-Id: I5d2910992ff1dd3229fd12ab732a1e2a6293f890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258573Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#781351}
-
