- 23 Oct, 2019 40 commits
-
-
Christian Dullweber authored
The test is failing on linux and windows. ChromeOS seems fine. Tbr: thestig@chromium.org Bug: 978948 Change-Id: Ia1d3f6077f3da1e6ba8ec15c111e8b6019c0e56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876411Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#708606}
-
Martin Robinson authored
Make the conversion between an AtkRole and the string representation a bit more robust and share it between all accessibility formatters. Bug: 1017106 Change-Id: Idfd77b4b2687fcbbcb2d4c8266115f68ba7bd041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875096Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#708605}
-
Sophie Chang authored
Bug: 969558 Change-Id: I842006ad992bec31b814205b6fae6ddb0f698414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856662Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708604}
-
Robert Kaplow authored
Bug: 1016906 Change-Id: Ibf0bce1a5528b6e9495413342b84128687d5ba7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872477Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#708603}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c4aff1dc..1c5bed7f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2b1dc1d39260418db52b085ba4001053f567b003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876367Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708602}
-
Avery Musbach authored
Change-Id: I52750f7838d3d7f043ca83de02c274168bdb4a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874716Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#708601}
-
Max Li authored
Bug: 923594 Change-Id: I44f33f94538bcb7a52a889377523bb9048e4d266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874591 Commit-Queue: Max Li <themaxli@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#708600}
-
Nasko Oskov authored
The HasWrongProcessForURL method on SiteInstanceImpl is a bit awkward to read and returns negative of what we usually want to ask. The real question this method answers is whether the input URL parameter is one that can be hosted in the SiteInstance. As such a better name for this would be IsSuitableForURL. TBR=halliwell@chromium.org Bug: 1015882 Change-Id: I4957b6fa62e1a5d81b3b6b67b64a45c20e452ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869810Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#708599}
-
Fergus Dall authored
BUG=none TEST=none Change-Id: I2a5c89498267c28320c1af04d4167564712333c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868565 Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#708598}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c833c0c59253..1f6c8c4d5495 git log c833c0c59253..1f6c8c4d5495 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 cwallez@chromium.org Make dawn_native use the webgpu.h header Created with: gclient setdep -r src/third_party/dawn@1f6c8c4d5495 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I9720ac99133dd1996e8d9313b2312f69cef193f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876188Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708597}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/27c293665e3a..d81a04e7b288 git log 27c293665e3a..d81a04e7b288 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c0cca6e4..6dc3a51e (708426:708537) 2019-10-23 cz.theng@gmail.com Add multipleTouchEnabled for subview of RTCMTLVideoView and RTCEAGLVideoView Created with: gclient setdep -r src/third_party/webrtc@d81a04e7b288 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ifcbdf13e82584e8873e0bfd845589efc7a234837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876189Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708596}
-
Aaron Leventhal authored
Link to I2E: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hxV0yjyS8_4 Bug: 1006767 Change-Id: I26e453bcc5eb21e38388a4f152e85134a22d1531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873886 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#708595}
-
Alex Ilin authored
This reverts commit 1e252fbf. Reason for revert: this change broke the internal build https://ci.chromium.org/p/chrome/builders/ci/android-internal-chromium-tot/b8898843520461106640 Also, TabTestUtils.setIsShowingErrorPage() isn't defined as static, so the error couldn't be fixed in 1 internal CL. Original change's description: > Android: Private-package Tab.setIsShowingErroPage > > The method is called by a class in chrome.browser.tab package > in production code. Makes it a private-package method. > > Bug: 995903 > Change-Id: I5f8b73200ae4a3c966b140a44e63cfc991f9b249 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872079 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708466} TBR=dtrainor@chromium.org,jinsukkim@chromium.org Change-Id: Ieed0cf2e34f59cf4f7e68a4eb44dea0ea2f561aa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876389Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708594}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9c790bc02512..faebe62aa330 git log 9c790bc02512..faebe62aa330 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 hjd@google.com Merge "trace_processor: fix initialization of eof_ field" 2019-10-23 rslawik@google.com Merge "Execute queries from file even with run-metrics" 2019-10-23 hjd@google.com Merge "Remove std::sto* from Perfetto code base" Created with: gclient setdep -r src/third_party/perfetto@faebe62aa330 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic1a1909a0a8c2d9a0d60c1704a485b05a5f65711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876190Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708593}
-
Greg Thompson authored
This test is flaking/failing on Win10 Tests x64 1803 for some reason. In this change, we switch to using a gMock matcher for the failing assertion so that we can see the actual and expected values. BUG=1001597 Change-Id: Ie4ace9c741c352da675564b167de406e3db2aa43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875249 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#708592}
-
Christian Dullweber authored
The test is flaky on Linux and ChromeOS Tbr: arthursonzogni@chromium.org Bug: 796135 Change-Id: I39b8d47740a4c22fbd6118dba58fa87cf8d49fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876328Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#708591}
-
Thomas Tangl authored
Screenshots: https://drive.google.com/file/d/15byLhToggWs-whPy7-fxJxIcJpMMbNkO/view?usp=sharing https://drive.google.com/file/d/1VWQuo6TPG7R6mUid_UtJ9P-LzxZ3UXdU/view?usp=sharing https://drive.google.com/file/d/1xUccQH98t4GY4tuf-nXrDfBAOz_RxXg8/view?usp=sharing Bug: 1016915 Change-Id: I00c9cf3094e4d3a870a0bba8cc9413dd14428462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874466 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#708590}
-
Sophie Chang authored
This will basically only affect painful page loads since we would taint the data but made the method more general since logic is in the keyed service. Bug: 1001194 Change-Id: Ib19113a08251a17346697ef860a0270d5d8f6457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856439 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#708589}
-
Vadym Doroshenko authored
This is a regression after the old parser removal. PasswordManager::ShowManualFallbackForSaving uses the result of the old parser. This CL makes using the result of the new parser. Bug: 1011732 Change-Id: I0537b472984e029aa2b002ee4d79717ac3f86765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875102 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#708588}
-
Miguel Casas authored
This CL adds a flag to explicitly enable using the HDR monitor(s) EDID-provided transfer function, if present at all. By default this flag is disabled because blindly using an HDR transfer makes HDR content look great and SDR content look faded (naive SDR-HDR mixing). The idea is to enable the flag for development. Bug: 1012846 Change-Id: I4d21aafa0a2b6114f68dc6a3615f72674dc0979c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872794Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mitsuru Oshima (slow) <oshima@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#708587}
-
Ehimare Okoyomon authored
Populate NIK for websocket requests to provide a TopFrameOrigin for cookie access checks. Bug: 989067 Change-Id: Ic3bceee832a33abea84d2f0fc5ab0291c5f30336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859986Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#708586}
-
Christian Dullweber authored
This reverts commit 283a0491. Reason for revert: Suspected to cause failures on Mac https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/15082 and ChromeOS https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/14943 Original change's description: > Mark some blink testing targets testonly > > This forbids production code depending on these targets, and enables > these targets to depend on other testonly targets in the future. > > The only dependency prevented core:testing from being testonly was > from BlinkLeakDetector. > Add Page::SetInternalSettingsPrepareForLeakDetectionCallback() > to reverse the dependency. > > Change-Id: I64cba73f0c4d1383a192e468220f3d55e926a8f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864720 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708516} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org Change-Id: I26980f1a48f56e75f167a99437a33a4967e464dd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875733Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#708585}
-
Christian Dullweber authored
The test wasn't renamed to Maybe_* Tbr: avi@chromium.org Bug: 954217, 1017102 Change-Id: I38eff297b3adacc8b88873140c77ebeb62785508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876028Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#708584}
-
Peter Kasting authored
Bug: 82078 Change-Id: I681414f063900b5bd60ea95a97f4ba589df005b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871251 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#708583}
-
deleplace authored
After exiting a profile having several windows, reopening the profile will now restore all of its browser windows instead of only one. Bug: 912852 Change-Id: I7267a3b4b4247263ac4fa24e9ff0b61d63994862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1367669 Commit-Queue: Valentin Deleplace <deleplace@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#708582}
-
Henrik Boström authored
Unblocks https://webrtc-review.googlesource.com/c/src/+/157444 which introduces an overload of SetLocalDescription(). Bug: chromium:980885 Change-Id: I9947240e9449cd39067361ab4ea3d2be54aebe30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871565Reviewed-by:
Steve Anton <steveanton@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#708581}
-
Gauthier Ambard authored
This CL enables the feature by default. It also runs directly the closure instead of posting it to have the sequence_checker validated. It also removes the observation of the browsing data removal in the WebController. This is because disabling the WebUsage is supposed to be tied to the spinner displayed on browser. We should find a way of synchronizing both of them. Bug: 981375 Change-Id: Iac47974e0d34f6977b2879dc00cd049e3950e387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847308 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#708580}
-
Torne (Richard Coles) authored
During WebView initialization we wrap the application context with ResourcesContextWrapperFactory before storing it in ContextUtils, but the original unwrapped context is still stored in a local variable of the init function. There isn't a bug here at present because the local is never used again (the later uses all call ContextUtils to get the wrapped one) but to avoid anyone introducing one in future, we can just update the local variable. This also means the later uses in the function can now just use the local which is less verbose than calling ContextUtils.getApplicationContext() repeatedly. Change-Id: I5e74c8e16283820fa670fad50812ec859071e5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862661Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#708579}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6dc3a51e. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 707870e6 "CSS: WPT tests property values are supported." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ib0b9b15a1a40f8d74490cb6fdbd8514b332751b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875634Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708578}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ed680bea92a2..9c790bc02512 git log ed680bea92a2..9c790bc02512 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 ilkos@google.com Merge "Discard null oom scores for the score breakdown" Created with: gclient setdep -r src/third_party/perfetto@9c790bc02512 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I921936da0c18fafa88b179a728eb1b8302368a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876069Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708577}
-
Rune Lillesveen authored
In the presence of ::-webkit-scrollbar rules, author styling is applied to scrollbars, but only if they actually contain declarations. Before introducing lazy parsing of declaration blocks, we would not consider empty style rules for matching. With lazy parsing, we do not necessarily know if the rule is empty before we perform the actual parsing. That caused a discrepancy between sheets from <style> elements and external stylesheets for empty scrollbar rules because <style> element sheets do not do lazy parsing of declaration blocks. To make this consistent, check if a matched style rule is empty before we mark the ComputedStyle as having pseudo element style. Bug: 897100 Change-Id: I8b808271ca322f42b5ae5e5627a5d17a81658885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874467Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#708576}
-
Rune Lillesveen authored
https://drafts.css-houdini.org/css-properties-values-api/#extensions-to-css-rule-interface Bug: 1008886 Change-Id: Ie587ec75864b856b2c020ba28ce209718c772c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875256Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#708575}
-
Vasilii Sukhanov authored
There was a code that does it. However, it regressed at some point. In https://chromium-review.googlesource.com/c/chromium/src/+/1638126/4/ui/views/controls/editable_combobox/editable_combobox.cc#273 it was suggested to compare event->flags() == event->changed_button_flags(). It doesn't work anymore because changed_button_flags is EF_LEFT_MOUSE_BUTTON and flags is EF_LEFT_MOUSE_BUTTON | EF_NUM_LOCK_ON. Bug: 1016289 Change-Id: I463cdc5007161cf6a909c41bf8a96fd01ac841f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872578Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#708574}
-
Jan Scheffler authored
This patch fixes the read-cached-response web_test to work with the latest protocol version. Fixed: chromium:778745 Change-Id: Ie91473bd7d04c0cf44687a817b0222cb44b5cc3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875730Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#708573}
-
Peter Kasting authored
Bug: 82078 Change-Id: I9b6f6c5fcd9b8a7235033f7d4e48dc70f3274591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870416 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#708572}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/261fc5197ea8..27c293665e3a git log 261fc5197ea8..27c293665e3a --date=short --no-merges --format='%ad %ae %s' 2019-10-23 hbos@webrtc.org Implement an OperationsChain, to be used by PeerConnection in follow-up. 2019-10-23 asapersson@webrtc.org Add estimatedPlayoutTimestamp to RTCInboundRTPStreamStats. Created with: gclient setdep -r src/third_party/webrtc@27c293665e3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I285eb5ea5f2bde9c417ca151b7fa0851877b1e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876070Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708571}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b307010280b7..a9f11bf14bce git log b307010280b7..a9f11bf14bce --date=short --no-merges --format='%ad %ae %s' 2019-10-23 jmadill@chromium.org GN: Separate out constructor/destructor warnings. 2019-10-23 lehoangq@gmail.com Move Vulkan GlslangWrapper code to a shared location. 2019-10-23 jmadill@chromium.org Vulkan: Roll validation layers. 2019-10-23 jmadill@chromium.org Vulkan: Fix sampler object lifetime. 2019-10-23 jie.a.chen@intel.com Remove forceNonZeroScissor workaround Created with: gclient setdep -r src/third_party/angle@a9f11bf14bce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: Idc38de741248dc64cd3e02a83594d04a9f6099c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708570}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9d832da5228b..1f4478ca7839 git log 9d832da5228b..1f4478ca7839 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 vapier@chromium.org clean up more dict iter warnings Created with: gclient setdep -r src/third_party/chromite@1f4478ca7839 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Icc75ac29c79dae4f491b6e702f6389cebc8d5a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876067Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708569}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2fad46eb..c4aff1dc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I11bcdb34c82507f1c7cb3f94ebe441df3ee7e180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875643Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708568}
-
Olya Kalitova authored
Changes CrostiniAnsibleManagementService::Observer to reflect only start and finish of container configuration. In all mocks states installation and application are reflected as one - configuring so there is no need to disctint them yet. Also renames functions the way it is clearly reflected what happened so that classes that would implement CrostiniAnsibleManagementService::Observer would have more understandable methods (for example installer). Test: browser_tests --gtest_filter="Crostini*" Bug: 998097 Change-Id: I32ea22c96d8987c25dfc06557596ce43561bfa93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869416Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#708567}
-