GitLab

BUG=649684
TBR=courage@chromium.org

Review-Url: https://codereview.chromium.org/2366953002
Cr-Commit-Position: refs/heads/master@{#420635}

BUG=649389

Review-Url: https://codereview.chromium.org/2360733002
Cr-Commit-Position: refs/heads/master@{#420634}

BUG=627517
TBR=(api change)

Review-Url: https://codereview.chromium.org/2361613002
Cr-Commit-Position: refs/heads/master@{#420633}

https://chromium.googlesource.com/skia.git/+log/5a9c2f110e4f..1cd88c4b759b

$ git log 5a9c2f110..1cd88c4b7 --date=short --no-merges --format='%ad %ae %s'
2016-09-23 reed use SkCanvas::ClipOp
2016-09-23 bungeman Json ide script for gn to output cmake.
2016-09-23 brianosman Change SkSpecialImage::makeSurface and makeTightSurface to take output properties (color space), bounds, and (optional) alphaType.
2016-09-23 brianosman Make GrRenderableConfigForColorSpace argument const
2016-09-23 borenet Add swarming task for nanobench upload
2016-09-23 caryclark split tight quads and conics

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=borenet@google.com

Review-Url: https://codereview.chromium.org/2363103002
Cr-Commit-Position: refs/heads/master@{#420632}

PolicyTest.FullscreenAllowedApp: after r349290, the ScriptContext is delayed until navigation commits. So the test has to wait for navigation first before executing the JS in the app, or else it fails because the chrome app bindings aren't registered yet.

AppWindowAPITest.TestCreate: the badWindow part of this test isn't compatible with PlzNavigate. Or more specifically, the condition isn't possible with it. Without PlzNavigate, creating an app window with an invalid URL would first create that frame with the provisional load URL of the chrome app. So the chrome apps ScriptContext would be setup correctly and view.chrome.app.window.initializeAppWindow would be called with an undefined window. However with PlzNavigate, the frame isn't created until after the navigation commits. At that point, we know that it failed and the URL of the frame becomes the error page url, and as such the chrome apps ScriptContext isn't used since the (error page) url isn't an extension. This can't even be fixed by adding a null check in app_window_custom_bindings.js because the security origin of the background page and the error page is different so Blink disallows the scripting call.

BUG=504347

Review-Url: https://codereview.chromium.org/2366843002
Cr-Commit-Position: refs/heads/master@{#420631}

BUG=617971

Review-Url: https://codereview.chromium.org/2366533002
Cr-Commit-Position: refs/heads/master@{#420630}

Intel devices put CPU temperatures in a devices/ sub directory of hwmon*. ARM
devices and non-CPU sensors on Intel don't use a devices directory and also may
not contain labels. Use the name file for a label if label doesn't exist.

BUG=530499
TEST=configure managed device to auto-start kiosk. ARM devices should show temps. Intel devices should show non-CPU temps.

Review-Url: https://codereview.chromium.org/2115723003
Cr-Commit-Position: refs/heads/master@{#420629}

File creation of tab states is done in an async fashion.
TabsTest should correspondingly use a polling mechanism
to verify files are actually being created.

BUG=649429

Review-Url: https://codereview.chromium.org/2362793002
Cr-Commit-Position: refs/heads/master@{#420628}

BUG=

Review-Url: https://codereview.chromium.org/2364953002
Cr-Commit-Position: refs/heads/master@{#420627}

The TODO in time.h was about removing time_t functions. When I wrote this I was optimistically thinking we wouldn't use time_t any more now that we have the awesome new Time class. This was fantasy so the TODO is removed.

SmallMap uses ManualConstructor. The TODO was that these could be removed when we have C++11 unions. This is true, but the syntax looked worse. There was a use in ConvertToRealMap that still required ManualConstructor for optimum allocations, so it seemed best to just keep using ManualConstructor.

However, the necessity of having the dummy value in the union due to an MSVC error seems no longer applicable. The dummy value is removed.

Review-Url: https://codereview.chromium.org/2363023002
Cr-Commit-Position: refs/heads/master@{#420626}

It is not safe to assume that ImageData::create always returns
a valid point.  Internally it uses DOMUint8ClampedArray::createOrNull
which returns null instead of crashing when allocation fails.
This change adds the appropriate null pointer checks to take
that into account.

BUG=647824
NOTRY=true

Review-Url: https://codereview.chromium.org/2361493003
Cr-Commit-Position: refs/heads/master@{#420625}

This removes the code to selectively enable reporting, and enables the
reporting. It was blocked by crbug.com/630303, which is now fixed.

BUG=630303

Review-Url: https://codereview.chromium.org/2364033002
Cr-Commit-Position: refs/heads/master@{#420624}

BUG=641413

Review-Url: https://codereview.chromium.org/2367543002
Cr-Commit-Position: refs/heads/master@{#420623}

Because Chooser tests interact with the UI they should be marked as
@LargeTests

> As a rule of thumb most functional UI tests are large tests.

https://developer.android.com/reference/android/support/test/filters/LargeTest.html

Also remove the flaky and disabled annotations.

BUG=646097,629579

Review-Url: https://codereview.chromium.org/2354183002
Cr-Commit-Position: refs/heads/master@{#420622}

BUG=501432
R=csharrison@chromium.org

Review-Url: https://codereview.chromium.org/2363743005
Cr-Commit-Position: refs/heads/master@{#420621}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/547cdab7f263971624422ea5b8ac665981c26514 Add Windows 10 location for debugger in process_dumps.py (pschmidt@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=649291

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2366883003
Cr-Commit-Position: refs/heads/master@{#420620}

Updated several Handler instances to use static inner classes with
WeakReferences to the outer class to avoid memory leaks. Created
TidyHandler to make this cleaner.

BUG=635567

Review-Url: https://codereview.chromium.org/2327833002
Cr-Commit-Position: refs/heads/master@{#420619}

https://pdfium.googlesource.com/pdfium.git/+log/917d24852841..3f4111fbff12

$ git log 917d24852..3f4111fbf --date=short --no-merges --format='%ad %ae %s'
2016-09-23 tsepez Make CPDF_Font::Create() return a std::unique_ptr.

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2361423002
Cr-Commit-Position: refs/heads/master@{#420618}

BUG=646384

Review-Url: https://codereview.chromium.org/2361643004
Cr-Commit-Position: refs/heads/master@{#420617}

Reland of HTMLImageElement: do not use fallback content for ImageDocument (patchset #1 id:1 of https://codereview.chromium.org/2365523003/ )

Reason for revert:
As per comment #8, this CL wasn't the cause of bot failures.
https://codereview.chromium.org/2365523003/#msg8

Original issue's description:
> Revert of HTMLImageElement: do not use fallback content for ImageDocument (patchset #2 id:20001 of https://codereview.chromium.org/2343613002/ )
>
> Reason for revert:
> Speculatively reverting to fix broken layout tests on Windows (https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10, https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7)
>
> Tests are
>
> fast/backgrounds/border-radius-split-background-image.html
> fast/backgrounds/border-radius-split-background.html
> fast/borders/border-styles-split.html
> paint/invalidation/background-resize-height.html
>
> Original issue's description:
> > HTMLImageElement: do not use fallback content for ImageDocument
> >
> > After https://codereview.chromium.org/1879793003,
> > ImageLoader::hasPendingActivity() became false for ImageDocument and thus
> > HTMLImageElement::selectSourceURL() didn't consider the image as still loading
> > during load (|imageStillLoading| became false).
> > This caused ImageDocument not to be displayed progressively.
> >
> > This CL makes HTMLImageElement to use primary content for ImageDocument.
> > This causes ImageDocument not to be replaced with fallback content, but I
> > expect that is more acceptable than images not displayed progressively.
> >
> > BUG=632495
> >
> > Committed: https://crrev.com/c5e43f7edf4e55155fcda51be0285f37b20c2e76
> > Cr-Commit-Position: refs/heads/master@{#420432}
>
> TBR=yhirano@chromium.org,japhet@chromium.org,ellyjones@chromium.org,hiroshige@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=632495
>
> Committed: https://crrev.com/70e44d10fc52150a6af5a7de760cb9181587fbb4
> Cr-Commit-Position: refs/heads/master@{#420499}

TBR=yhirano@chromium.org,japhet@chromium.org,ellyjones@chromium.org,gcasto@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632495

Review-Url: https://codereview.chromium.org/2364073002
Cr-Commit-Position: refs/heads/master@{#420616}

BUG=

Review URL: https://codereview.chromium.org/2365693003 .

Cr-Commit-Position: refs/heads/master@{#420615}

(Primarily) because of their inclusion in the SVGTests interface, these
two make their way into a lot more compilation units than has use for
them. The principal access to this data is the SVGTests::isValid()
method, so only the actual bindings should need any deeper insight into
these. Shuffle declarations and definitions to make their inclusion more
scarce. (From ~194 -> ~13 total dependencies for the latter, based on
"ninja -t deps".)

Review-Url: https://codereview.chromium.org/2360383003
Cr-Commit-Position: refs/heads/master@{#420614}

BUG=600717

Review-Url: https://codereview.chromium.org/2362113002
Cr-Commit-Position: refs/heads/master@{#420613}

BUG=541543

Review-Url: https://codereview.chromium.org/2364733004
Cr-Commit-Position: refs/heads/master@{#420612}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/7e4eda9791069bd4c447040611fa0554869e804c V8: Archive builds of node integration bot. (machenbach@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=v8:5378

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2364783003
Cr-Commit-Position: refs/heads/master@{#420611}

BUG=649633
TBR=grunell@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2353393005
Cr-Commit-Position: refs/heads/master@{#420610}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/1fb4c10e66e8a0c4c445e2a28a5bd66752a4634c Split dart2js test steps into observatory, co19, and others. (whesse@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=https://github.com/dart-lang/sdk/issues/27412

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2361853004
Cr-Commit-Position: refs/heads/master@{#420609}

Reland of Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called (patchset #1 id:1 of https://codereview.chromium.org/2365463004/ )

Reason for revert:
Relanding this CL because the fix to the original crash has been landed in https://codereview.chromium.org/2364693005/

Original issue's description:
> Revert of Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called (patchset #11 id:200001 of https://codereview.chromium.org/2317483005/ )
>
> Reason for revert:
> Speculatively reverting for https://crbug.com/649272
>
> Original issue's description:
> > Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called
> >
> > This CL clears LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called.
> > This means that LifecycleObserver::context() starts returning false after the context gets destroyed.
> >
> > The new behavior makes a lot of more sense, but the problem is that some existing code is assuming that
> > LifecycleObserver::context() keeps returning the context even after the context gets destroyed.
> > This CL fixed the problematic code to make all layout tests pass, but I'm not sure if I've updated all of the problematic code
> > (because the coverage of the layout tests is not sufficient).
> > However, the worst thing that can happen is that code that had been assuming that LifecycleObserver::context()
> > returns a context even after the context gets destroyed will stop working (it may cause a null-deref crash).
> > I think the risk is low.
> >
> > BUG=610176
> >
> > Committed: https://crrev.com/b729a998b05ec916731171d59de95e0aea31bbac
> > Cr-Commit-Position: refs/heads/master@{#419951}
>
> TBR=haraken@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=610176,649272
> NOTRY=true
>
> Committed: https://crrev.com/04b1826356a37de2a322e7e6e0e80f07d05f210f
> Cr-Commit-Position: refs/heads/master@{#420498}

TBR=wfh@chromium.org,dcheng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=610176,649272

Review-Url: https://codereview.chromium.org/2367753002
Cr-Commit-Position: refs/heads/master@{#420608}

Revert of Roll Syzygy DEPS to v0.8.21.0 (patchset #1 id:1 of https://codereview.chromium.org/2364613002/ )

Reason for revert:
Break the official builders.

BUG=644608

Original issue's description:
> Roll Syzygy DEPS to v0.8.21.0
>
> Committed: https://crrev.com/b7f4d860d580c5b0c2981356b181859d219bbe0d
> Cr-Commit-Position: refs/heads/master@{#420491}

TBR=siggi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2369483002
Cr-Commit-Position: refs/heads/master@{#420607}

I never quite found what the original issues were, but apparently they've been fixed in the mean time.

Revert "Disable faiilng tests under mac/asan"
This reverts commit 6585cde1.

BUG=

Review-Url: https://codereview.chromium.org/2364593002
Cr-Commit-Position: refs/heads/master@{#420606}

Ensure the GAIA Id is attached for Drive domains even when the path
isn't empty.
Follow-up of http://crrev.com/2343073002.

BUG=647260

Review-Url: https://codereview.chromium.org/2353923003
Cr-Commit-Position: refs/heads/master@{#420605}

If BaseTextInputType::patternMismatch() was called twice, the second call
skipped ScriptRegexp::isValid() check.

BUG=639324

Review-Url: https://codereview.chromium.org/2366803002
Cr-Commit-Position: refs/heads/master@{#420604}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3721449f..8358e322

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2364823002
Cr-Commit-Position: refs/heads/master@{#420603}

This patch also removes the Editor::firstRectForRange(const Range*)
overload because it has no call site.

BUG=647219

Review-Url: https://codereview.chromium.org/2352763004
Cr-Commit-Position: refs/heads/master@{#420602}

The introduced 'emplaceAppend()' method provides more efficient code path when a new object instance requiring multiple constructor arguments is appended to a vector.

Note: the existing 'append()' method is already implicitly emplacing new items for a single constructor argument case.
Review-Url: https://codereview.chromium.org/2365533003
Cr-Commit-Position: refs/heads/master@{#420601}

This CL invalidates the serialized page state any chrome:// URLs,
causing the page to get reloaded rather than restored. This will prevent
the upgrade to MD History from breaking things since it lives at a
different physical URL than classic history.

BUG=614758
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2355543003
Cr-Commit-Position: refs/heads/master@{#420600}

The CacheCounter class in chrome/browser/browsing_data could not be
componentized (unlike other counters in components/browsing_data) because
of its usage of StoragePartitionHttpCacheDataRemover that has a dependency
on content/.

This CL implements a separate CacheCounter class for iOS with the same
functionality. The core of the implementation, a series of IO thread
callbacks, is delegated to the private IOThreadCacheCounter class that
mimics StoragePartitionHttpCacheDataRemover.

BUG=620317

Review-Url: https://codereview.chromium.org/2354643002
Cr-Commit-Position: refs/heads/master@{#420599}

This CL is connected to Issue 2312093003, which generates bindings for
IDL callback functions. This CL exteneded implementation to be able to
use not only string or long but also interface as arguments of callback
functions.

BUG=569301

Review-Url: https://codereview.chromium.org/2367543004
Cr-Commit-Position: refs/heads/master@{#420598}

No change in behavior.

BUG=631960
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2352563002
Cr-Commit-Position: refs/heads/master@{#420597}

We report deprecation warnings when the old
motion* property names are used.

Discussed in the offset-path Intent To Ship,
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/sbaLF1MbAgAJ

BUG=637543

Review-Url: https://codereview.chromium.org/2366493002
Cr-Commit-Position: refs/heads/master@{#420596}