- 19 Apr, 2019 40 commits
-
-
Alexei Filippov authored
The BacktraceStorage object livespan is local to ConnectionManager::HeapProfileRetrieved and accessed from a single thread. BUG=923459 Change-Id: I97dfa2642d5efd06461ea69cb833d4a6aba1083d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574942 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#652639}
-
asteinha authored
Deleted in https://chromium.googlesource.com/chromium/src.git/+/ba49d00fddeb39c0816090dad7d359df0dce9a1a Bug: 74848 Change-Id: Ia3d5c796ad34857f4e84fdb3a6f53fce3f00d63b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574829Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Anthony Steinhauser <asteinhauser@google.com> Cr-Commit-Position: refs/heads/master@{#652638}
-
Chris Harrelson authored
This code was accidentally removed in an earlier commit (*). It seems fixed-position elements with compositing descendants need to be promoted for the existing compositing system to work. (*) https://chromium-review.googlesource.com/c/chromium/src/+/1407922 Bug: 950418 Change-Id: Iec04435bb1a20a17c54ce4f5ff35f4e00704e6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574686 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#652637}
-
Ken Rockot authored
Adds minor API features and fixes some bugs in the Remote/Receiver types to support further conversion of code away from InterfacePtr etc. Bug: 875030 Change-Id: Ia001195c8fd0feed669d3cd65f501ace55de3015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574896Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#652636}
-
Dale Curtis authored
This moves decoding of AV1 content via dav1d to a task pool instead of sharing the media thread -- which was apparently leading to underflow of the audio. This probably only fixes pausing and audio drop outs, if a video frame is taking more than 200ms (audio buffer size) to return, we've probably exhausted the video frame buffer too. This would result in video apprearing frozen for a moment, but would not trigger underflow since we have a 3 second threshold for underflow on video. Unlike the VP9 offloading, we offload for all resolutions of AV1 content, since we seem to be getting these issues even with 360p content. This removes an unnecessary BindToCurrentLoop for the OutputCB in the non-offloaded case for clarity. BUG=940686 TEST=all existing tests pass with offloading decoder. Change-Id: I7426a0353249646600c12019f868aa058c40e456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574830 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#652635}
-
Prashant Malani authored
Bug: 945564,945565,945566,945567,945568,945570 Test: None Change-Id: I49a379e125084600b85cc721d0bfaac27b1d8417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574361Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Prashant Malani <pmalani@chromium.org> Auto-Submit: Prashant Malani <pmalani@chromium.org> Cr-Commit-Position: refs/heads/master@{#652634}
-
Charlene Yan authored
This is needed so Buttons can be not a subclass of MenuButton but still install a MenuButtonController for the same behavior. Bug: 901183, 819854 Change-Id: Iccd82dab68ba243f86a8784916332030a295b9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503349Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652633}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/377befab7175..ba1602896d72 git log 377befab7175..ba1602896d72 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 halcanary@google.com SkQP: new docker test code 2019-04-19 ethannicholas@google.com fixed Metal code generation for recursive functions 2019-04-19 michaelludwig@google.com Don't batch across domain modes in GrTextureOp 2019-04-19 brianosman@google.com Convexity checker: Wait for significant x-product when walking edges Created with: gclient setdep -r src/third_party/skia@ba1602896d72 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I8ba3c8a8c0213eb8507aee18e4ed912bb0a3a96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575867Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652632}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/40beee366962..7be19dbfabac Created with: gclient setdep -r src-internal@7be19dbfabac The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: Ife9c0d4d0a4a2925cbbdbc442b9db91fb8824cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575862Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652631}
-
Jacob Dufault authored
- KioskEnableScreenView - MarketingOptInScreenView - WrongHwidScreenView - SyncConsentScreenView Also remove the Delegate classes on the moved views where applicable. Bug: 928555 Change-Id: Ia833a286b49dda8af7c93f7b5aacebe239f021d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572539 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#652630}
-
David Tseng authored
This change allows a target process or anything outside of the context of a source tree to request that its source tree be invalidated. We make use of this new action in the Automation Internal browser side api, when a client extension's automation bindings requests an enable frame. Typically, chrome.automationInternal.enableFrame gets called whenever the extension process encounters a new child tree. This, in turn, resets state within the tree source and triggers a re-send of all tree data and node data on the next event. The action is hooked up to one tree source (ARC++). TBR=dominickn Bug: 929522 Test: toggle on ChromeVox, interact with Play Store. Toggle off and then back on ChromeVox, interact with Play Store. Repeat this several times. ChromeVox should work throughout. Change-Id: I8e2a729f079f932d06a615bb5fcca9ebbe7365f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573859 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#652629}
-
Bret Sepulveda authored
Test is flaky on Android CFI bot. TBR=changwan@chromium.org Bug: 954578 Change-Id: I325856bd34a5f86c47c9370fb32f718aeb45923a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575161Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#652628}
-
Paul Miller authored
Work around bug b/120099466 in Android < Q in which faild reflection causes disk reads. BUG=948308 Change-Id: I38ab4c55a9e11f2bb2a5153740894f9f4f6c88d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574940Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#652627}
-
Michael Giuffrida authored
Bug: 945438 Change-Id: I314f5aecb5e12fa17fc033b51af0305c80039b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568310Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#652626}
-
Johannes Henkel authored
Change-Id: I78a34f2375794dae7aa7b6fb9f8ae0a45c193b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574953Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#652625}
-
James Cook authored
The prefs are all browser-settings-specific and are registered in SettingsUI::RegisterProfilePrefs(). Bug: none Test: compiles Change-Id: I6fc2610b834a66f5ae502963aac19c93e19de61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574962 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#652624}
-
chrome-search://ntpiconDan Beam authored
Instead of using custom dir/like/things, let's use the more standard: ?param1=val1¶m2=val2 Because it allows us to use URLSearchParams[1] in JS: url.searchParams.set('param1', 'val1'); And net::QueryIterator in C++: for (net::QueryIterator it(url); !it.IsAtEnd(); it.Advance()) { // use it.GetKey() and it.GetValue() } R=kristipark@chromium.org BUG=953962 [1] https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams Change-Id: I8159e0f6d70b35bc803e9e1064c67ee27a93244b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574690 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:Kristi Park <kristipark@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#652623}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b60ce313b947..1ff0422ebea4 git log b60ce313b947..1ff0422ebea4 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 crouleau@chromium.org [Telemetry] Provide full error for metrics calculation failure. Created with: gclient setdep -r src/third_party/catapult@1ff0422ebea4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:953365 TBR=charliea@chromium.org Change-Id: I91e0b588adcadf869997787709f84bd331cfb82a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574642Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/97035bde89e6..c9ca99eecf1d git log 97035bde89e6..c9ca99eecf1d --date=short --no-merges --format='%ad %ae %s' 2019-04-19 chrisforbes@google.com Fix comment describing compare/exchange behavior Created with: gclient setdep -r src/third_party/swiftshader@c9ca99eecf1d The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I43b1fba71a4a96aed9450163f4f95548c234448e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574217Reviewed-by:
-
Mason Freed authored
With this CL, "trivial" transforms, which only produce at most a 2d translation, will be de-composited if possible (see below). They will be replaced by an offset that is set on the cc::Layer in offset_to_transform_parent. With this change, the layer offset will be stored in ForeignLayerDisplayItem, so that it can be used to update the cc::Layer, and cc::Layer::SetOffsetToTransformParent() will be used in many fewer cases directly. The conditions required to de-composite a transform are: 1. It is not the root transform node. 2. It is a 2d translation only. 3. The transform is not used for scrolling - its ScrollNode() is nullptr. 4. It has no direct compositing reasons, other than k3DTransform. Note that if it has a k3DTransform reason, check #2 above ensures that it isn't really 3D. 5. It has FlattensInheritedTransform matching that of its direct parent. 6. It has backface visibility matching its direct parent. 7. No clips have local_transform_space referring to this transform node. 8. No effects have local_transform_space referring to this transform node. 9. All child transform nodes are also able to be de-composited. Bug: 952386,938563 Change-Id: I666e1609b48046372196c3864912a59e462bea77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568195 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#652620}
-
Sinan Sahin authored
This CL fixes a bug where a tinted drawable would preserve its tint when the same drawable is used in a different dialog. This is fixed by making the drawable mutable. Bug: 954127 Change-Id: I66578ffc409d0e160d238b62680676a322bd8e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574251Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#652619}
-
Peter Boström authored
This removes the confusing behavior where a user clicks a button, expecting an action to happen, but there is no associated action so we would instead spawn a context menu. This now does not look like a clickable button (no hover state) and the three-dot menu is used to access the context menu for extensions without actions. Bug: chromium:943702 Change-Id: I9ae6fe7d549dd2dac2d003fb6f1fecdab66e9c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575859Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#652618}
-
Piotr Bialecki authored
Change-Id: I735de5c7f56cad4fec89dd3033ad6748a875ebee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575360 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#652617}
-
Simon Pelchat authored
The default_integration policy should be used when no exp= is otherwise specified to make sure that the GFE cache is not used. Bug: 950734 Change-Id: I6129845bed78f84175fb440003575f626431ccbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560454Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Simon Pelchat <spelchat@chromium.org> Cr-Commit-Position: refs/heads/master@{#652616}
-
BUG=762641 TBR=agawronska@google.com Change-Id: I26b7b542d8172a9743da9a2fc5bf404be25f3c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574262Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
-
Torne (Richard Coles) authored
Improve the doc comment for the GN arg "system_webview_package_name" to mention that it controls TrichromeWebView as well as SystemWebView, and to explain more about why you might want to use it. Change-Id: I4c4c6e003416c9e2f39ab2492078baaa049237b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575732 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#652614}
-
Roman Sorokin authored
TBR=xiyuan@chromium.org CQ-DEPEND=CL:1570024 Bug: 952855 Change-Id: I783e41a3c810764d8118dda3643f2a1964186966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572405Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/4a8c05ffe826c61d50fdf13483b35097168faa5c..e55c64fdd3f47413e17eaa8e4f4d2a62622a01eb Bug: none Change-Id: I0f0220cfd3cd3288281d85808645eca3dc7fefb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574296 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#652612}
-
Brandon Wylie authored
Bug: 953893 Change-Id: Ic30e369768a6c154209ef7fdd9b881374b3f8f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572534 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#652611}
-
Dana Fried authored
Affects folders in the bookmark folder as well as subfolders. We could also log this at the event source using the existing BookmarkBar_ContextMenu_OpenAll event, but since it's a click/gesture rather than a context menu action I created a new event type for it. Bug: 954254 Change-Id: I4ae18d9f2dbdda5448fdc3993e06b6ef76159570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574147 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#652610}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fcc3ec31b83b..c467f7b54188 git log fcc3ec31b83b..c467f7b54188 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 spang@chromium.org Compute usage from format properties cache in glTexStorageMem2DEXT Created with: gclient setdep -r src/third_party/angle@c467f7b54188 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ic5bd49ac7a44e0d08263f331d0d91e4a10d20803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575656Reviewed-by:
-
Yuwei Huang authored
* Implement a MuxingSignalStrategy to be used exclusively by JingleSessionManager to handle messages from both signal strategies. * Integrate all the signaling stuff into remoting_me2me_host, which can be enabled by passing a `--enable-ftl-signaling` flag. This has been tested with ftl_signaling_playground and I'm able to finish candidate exchange for ~99% of the attempt. I did see one DCHECK failure when JingleSession receives a duplicated message, but that will be tracked and fixed in a different bug/CL. Bug: 947337 Change-Id: Id6a6a183041a2668a0dd31deb735b01ceb4c4aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565537 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#652608}
-
Jacob Dufault authored
TBR=xiyuan@chromium.org TBR=rsorokin@chromium.org Bug: 928555 Change-Id: Iae26e383c7fe81cbd5a0bf638c432bf1947f77da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572234 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
-
Dana Fried authored
Requested by Chronav logging initiative. See attached bug for details. Bug: 951906 Change-Id: Ia532b16cde546b3cbadc1c52cafc2503a452f9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574601 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
-
Frank Poole authored
This change adds the GetInnerRangeBoundsRect interface to AXPlatformNodeDelegate. Similar to GetRangeBoundsRect, GetInnerRangeBoundsRect also calculates bounds for a range. Unlike GetRangeBoundsRect, GetInnerRangeBoundsRect accepts text offsets relative to GetInnerText in which text offsets on descendant nodes are included. This interface is intended for clients which calculate text offsets relative to GetInnerText, such as the UIA ITextRangeProvider implementation which relies on AXNodePosition. This change also adds values to the result of BrowserAccessibility::GetInnerText so that it has parity with AXNodePosition::GetInnerText. GetHypertext and GetInnerText interfaces are added to AXPlatformNodeDelegate although they are currently only implemented on BrowserAccessibility and its subclasses. Bug: 928948 Change-Id: I5607ee796a9f4bfc4352e43b2f7209200685b155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558708 Commit-Queue: Frank Poole <frpoole@microsoft.com> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#652605}
-
sczs authored
This CL also makes some improvements to InfobarContainerCoordinator so the test can pass: - isPresentingInfobarBanner is now directly based on the ChildCoordinator Banner presentation and not just the existence of a VC. - A disconnect method is added to make sure the mediator stops observing WebStateList before being dealloced (This is a common pattern throughout mediators since the memory de-alloaction order in unittest can cause this) - Adds a legacyContainerFullscrenSupportDisabled to disable FullScreen support in the legacyContainer. This is needed to avoid a crash after cleaning up each test case, in order to properly fix this we'd need to know when the legacyContainer has been dismissed, that would require some refactoring and the effort/risk is not worth it at this point. - Removes a DCHECK in the legacyContainer since now the count of total Infobars doesn't necessarily match the count of total Infobars in the legacy Container. This because one of them can be a message. The iOS implementation of the container was merely sending infobar.count() for position, meaning we were never using position anyways. Bug: 911864 Change-Id: Ie46c9dc88d2f5277401eb1d08aa54a09d4dbaf82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566756 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#652604}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/726fdfaee1e0..7ef31b3e5b93 git log 726fdfaee1e0..7ef31b3e5b93 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 jclinton@chromium.org Revert "chromeos-config: disable boards affected by crbug.com/954446" Created with: gclient setdep -r src/third_party/chromite@7ef31b3e5b93 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I043ed8d16da0a2d4db0082bb7f7770413a05cfcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575655Reviewed-by:
-
cjamcl@google.com authored
For terminology alignment with CruX. Bug: https://github.com/googlechrome/lighthouse/pull/6163 Change-Id: I90ebd73384947114f9b237f4afee3fdd4683db15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575823Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Commit-Queue: Connor Clark <cjamcl@google.com> Cr-Commit-Position: refs/heads/master@{#652602}
-
Charlie Harrison authored
This experiment has been disabled for a while. It should be pretty easy to reland if we decide we want to do it. Bug: 829042 Change-Id: I273d7a757312f1628ce3878e266311455eb73eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574281 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/847d55be4e62..377befab7175 git log 847d55be4e62..377befab7175 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 michaelludwig@google.com Update compositing benchmark to use image-set API 2019-04-19 csmartdalton@google.com ccpr: Indicate path fill type by winding direction of cover triangles 2019-04-19 ethannicholas@google.com added error detection for writing to a constant swizzle mask 2019-04-19 kjlubick@google.com [spec] Initial commit for web spec 2019-04-19 ethannicholas@google.com Revert "Revert "added more SPIR-V RelaxedPrecision decorations"" 2019-04-19 reed@google.com use char-to-glyph cache in freetype typeface 2019-04-19 brianosman@google.com Remove SK_TREAT_COLINEAR_DIAGONAL_POINTS_AS_CONCAVE 2019-04-19 robertphillips@google.com Allow GrShadowRRectOp::Make to fail 2019-04-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 82bcffa78747..145ec7fa7c81 (10 commits) 2019-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader abaecd5f2ba7..a16238df3f28 (12 commits) 2019-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src f968f64c..a55917cb (433 commits) 2019-04-18 martin@mainframe.co.uk Properly retrieve memory block in SkTextUtils 2019-04-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-18 halcanary@google.com SkPDF: move type1 font code into single file 2019-04-18 csmartdalton@google.com Swap front and back stencil sides when rendering bottom-left 2019-04-18 bsalomon@google.com Swap x/y radii for EllipticalRRectOp depending on matrix. 2019-04-18 halcanary@google.com SkQP: consolidate cut_release scripts 2019-04-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-18 reed@google.com remove experimental from some APIs (that are no longer experiments) 2019-04-18 michaelludwig@google.com Fix quad type detection from SkPoint array 2019-04-18 brianosman@google.com Remove the axis-aligned vector special case to convexity checker 2019-04-18 ethannicholas@google.com fixed assertion failure in skslc SPIR-V output 2019-04-18 bungeman@google.com Make more SkTypeface virtuals pure. 2019-04-18 borenet@google.com [infra] Fixes for chrome_release_branch 2019-04-18 hcm@google.com Update Skia milestone to 76 Created with: gclient setdep -r src/third_party/skia@377befab7175 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:935198,chromium:946965 TBR=herb@chromium.org Change-Id: I23c6433ad9bc7d5e0982253667916e854515899c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575654Reviewed-by:
-
