GitLab

See https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/3784
for a sample failing run for both tests.

Bug: 999079, 999080
Change-Id: I1b7e6ec449828fb971a708d77b5297ff25f9711b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776020Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#691980}

use_counter.h is included from document.h, which is one of the most
popular header in Blink, and the pre-processed size of
web_feature.mojom-blink.h is very large.

This CL updates use_counter.h so that it includes
web_feature.mojom-blink-forward.h instead of web_feature.mojom-blink.h.
Many files need to include web_feature.h or web_feature.mojom-blink.h
explicitly.

Change-Id: I1f827fc7f6017dfd8d2345018f019ccb6ce02bd1
Bug: 242216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775679Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691979}

Following WebGPU spec change at https://github.com/gpuweb/gpuweb/issues/378,
vertexInput descriptor from GPURenderPipelineDescriptor should not be
required anymore.

Bug: 877147
Change-Id: Ifdd0ba7ff6af2b8648ad45d029e5ef7b8484f8a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776023
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691978}

Implement copy of TraceWrapperV8Reference. Note that this will require
write barriers during marking.

Bug: 998099
Change-Id: Id6921083a6ce29e25386ef7ac159814ec42beb6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774624
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691977}

Tested on:
 -- light mode
 -- dark mode
 -- KitKat

that will later be used for experiments. Eventually we will only
use one of them. I have already used avocado.

Binary-Size: Adds 3 images as well as their dark mode counterparts
Bug: 983445
Change-Id: I077dace271bc85fc626ba3cc57334cdc1d0ee0e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773222
Commit-Queue: Andrei Chulkov <achulkov@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691976}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e12f9bdfbf6a..12e3f76c1c73


Created with:
  gclient setdep -r src-internal@12e3f76c1c73

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I21ee116ad4ef37770b0ad6f0c1e3c8dc70596588
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777206Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691975}

Since http://crrev/c/1743432, the BottomSheet background has rounded
corners with a shadow. The shadow has now a height of 16dp (vs 8dp
before that CL).

This CL introduces a new dimension to store the new height of the
shadow. This height is used to compute full/peek ratios of the bottom
sheet that are now computed correctly.

Before:
 * https://screenshot.googleplex.com/YZ67ok7O9br.png
 * https://screenshot.googleplex.com/SOVPh2N9GaA.png

After:
 * https://screenshot.googleplex.com/8HjjkL2Gt62.png
 * https://screenshot.googleplex.com/C0LTHSnBF1f.png

Bug: 985644
Change-Id: Iafbf4cda004bd03a7931a3ef7045bed9d5a05a7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776040Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691974}

This CL fixes an issue with scrollbar thumb drags being jittery. The
pointermove(s) are not Vsync aligned. When the first GSU is processed,
it gets queued in the compositor thread event queue. A second request
(to get a GSU for a pointermove) within the same frame will end up
calculating an incorrect delta (as ComputeThumbQuadRect would not have
accounted for the delta in the first GSU that was not yet dispatched).
This leads to generating a GSU with a delta that is larger than what it
is supposed to be. When these queued GSUs are finally dispatched, the
subsequent pointermove will make the thumb jump backward and this
problem continues on leading to a jittery thumb drag experience. To fix
this, we process only 1 GSU per frame when thumb drag is in progress.

Bug: 986174
Change-Id: Ied8103ffc447966fc15d0052c5295f896dcbcc29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770088
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691973}

This reverts commit a1b5aec5.

Reason for revert: suspect causing views_unittests failure on Linux MSan Tests:
views_unittests failed because of:
DesktopDragDropClientAuraX11Test.HighDPI200
DesktopWidgetTest.ValidDuringOnNativeWidgetDestroyingFromClose
DesktopDragDropClientAuraX11Test.Basic
DesktopDragDropClientAuraX11Test.RejectAfterMouseRelease
...34 more failure(s) (38 total)...

Sample build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/18965

Sample log:https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8903719865586190112/+/steps/views_unittests/0/logs/Deterministic_failure:_DesktopDragDropClientAuraX11Test.Basic__status_CRASH_/0

[ RUN      ] DesktopDragDropClientAuraX11Test.Basic
==26851==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x556c6767c618 in OnXWindowStateChanged ./../../ui/platform_window/x11/x11_window.cc:262:7
    #1 0x556c6767c618 in non-virtual thunk to ui::X11Window::OnXWindowStateChanged() ./../../ui/platform_window/x11/x11_window.cc:0:0

Original change's description:
> X11 and Ozone: Make DWTHX11 subclass DWTHPlatform and use PWD.
> 
> This CL makes the DWTHX11 subclass the DWTHPlatform and use
> the X11Window, which subclasses the XWindow. Also, DWTHX11
> uses PlatformWindowDelegate instead of ui::XWindow::Delegate now.
> 
> That is, to migrate X11 to Ozone, we need to make sure DWTHPlatform
> is mature enough. To avoid code duplicate, it was decided to
> make DWTHX11 subclass DWTHPlatform and move its code to DWTHPlatform
> step by step ensuring nothing is broken.
> 
> However, it was not enough to just make DWTHX11 a subclass of DWTHPlatform.
> The way how we communicate with XWindow has had to be changed as well.
> 
> The plan is to move all the code to DWTHPlatform and make the
> WTHPlatform create the X11Window. However, there are many intermediate
> steps to be done before doing it. As described before, first, DWTHX11
> subclasses the DWTHPlatform and starts to receive messages and
> events from the XWindow through the PlatformWindowDelegate.
> 
> It was ensured that the DWTHX11 intercepts all the calls to DWTH,
> WTH and PWD and does everything as it was doing previously. In the
> follow up CLs, I will start to move the code slowly to DWTHPlatform
> and WTHPlatform so that DWTHX11 no longer implements PDW and DWTH
> methods and the DWTHPlatform manages everything on its own
> for both Ozone and non-Ozone builds.
> 
> Bug: 990756
> Change-Id: If45b05d09609cf8aa826cc4894ec559f210dc0b7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771397
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Maksim Sisov <msisov@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#691944}

TBR=sadrul@chromium.org,sky@chromium.org,thomasanderson@chromium.org,msisov@igalia.com

Change-Id: I1e967e5b5958307cc6fc60962a45db0016b4f25d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 990756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777352Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#691972}

Can use equality with kSubtreeStyleChange instead.

Change-Id: I50a37545a31de438311e14f4a2020caf69578b87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774457Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691971}

Many Mac accessibility API use an AXTextMarker, which is an
opaque application-specific struct representing a position in
a document. Chrome implements these using AXPosition
(in particular a subclass BrowserAccessibilityPosition).

The code used the word "serialized" but it was actually
copying the raw bytes from a BrowserAccessibilityPosition
and then constructing a new C++ object with these bytes
later, which isn't defined behavior and may be causing
problems on macOS 10.15.

Instead, implement actual Serialize and Unserialize methods
on AXPosition and make use of those instead.

Tested with a unit test of AXPosition (based on the existing
test of Clone) and by manually manipulating some editable
text in Chrome with VoiceOver running, to ensure the code is
working correctly.

Bug: 998896
Change-Id: Ifb64b19ebdc96a8d36522456c77bca23cb58d552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776901
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691970}

Now that we have per-device settings to allow Android applications
read/write files on it, we don't need to refer the global preference
kArcHasAccessToRemovableMedia.

kArcHasAccessToRemovableMedia will be completely removed in a follow-up
CL as a fix for crbug.com/998512.

Bug: 954228
Change-Id: Idd570106f0bdfd031dc00837b5f128b91d2078fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774426Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691969}

This patch replaces the base::RunLoop().RunUntilIde() with base::RunLoop loop,
which will reduce the time delay and make those unit tests deterministic.

Bug: 973005
Change-Id: I3fa718ef0926b38385c53f0af9d6ce8865a87660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760670
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691968}

This reverts commit 7800a3fe.

Reason for revert: Suspected culprit (which was reverted) was not the real culprit, so the test is still flaky :(

Original change's description:
> Revert "Disable SingleClientWalletSyncTest.SameUpdatesAreIgnored on ASan/TSan"
> 
> This reverts commit 55420155.
> 
> Reason for revert: I have rolled back one suspect change.
> Enabling the test again to verify it was indeed the culprit.
> 
> Original change's description:
> > Disable SingleClientWalletSyncTest.SameUpdatesAreIgnored on ASan/TSan
> >
> > The test is disabled due to high flakiness.
> >
> > TBR: treib@chromium.org
> > Bug: 997912
> > Change-Id: Ifa5e1cc89354163622a6a6ca593498c6fe3a6028
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771974
> > Commit-Queue: Jan Krcal <jkrcal@chromium.org>
> > Reviewed-by: Marc Treib <treib@chromium.org>
> > Reviewed-by: Jan Krcal <jkrcal@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#690763}
> 
> TBR=treib@chromium.org,jkrcal@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 997912
> Change-Id: I275345a29e2917d5abe5a402fa03cac0d107703c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774630
> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#691582}

TBR=treib@chromium.org,jkrcal@chromium.org,mamir@chromium.org

Change-Id: I8bf6cc11e7bcd912cead0e4b4c4d2491cf41d544
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 997912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776262Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691967}

SubtreeStyleChange on Document has a special meaning that we need to
update the viewport style in addition to all elements in the document.
This is the start of separating these two concerns.

This is in preparation for flat tree style recalc for which the plan is
to only mark elements or text nodes as style dirty and use flat tree
element traversal for marking ancestors child-dirty.

This CL marks the root element instead of document in the cases where we
don't need to update the viewport styles.

We already did that for layout tree reattach in [1].

[1] https://crrev.com/df2ed4afdfaf3b30adc3d4d80cc7559965eb8519

Bug: 972752
Change-Id: I52a906ed1c30d878cdb34dc004943eadc9448fa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774453
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691966}

When custom scrollbar pseudo element style changed on the viewport
defining element (root or body), we did not propagate those styles
unless something else changed.

Bug: 999348, 972752
Change-Id: I52ed46a191d87034bee95bff4d823d92a28031a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774935
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691965}

https://chromium.googlesource.com/catapult.git/+log/8fe3e6ac1d7a..d10eb04b772a

git log 8fe3e6ac1d7a..d10eb04b772a --date=short --no-merges --format='%ad %ae %s'
2019-08-30 dberris@chromium.org Clean up links to waterfalls

Created with:
  gclient setdep -r src/third_party/catapult@d10eb04b772a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC skyostil@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=skyostil@google.com

Bug: chromium:994762
Change-Id: I94a2b4b80680cdb940a9172d95c2135e6b98f263
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777213Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691964}

The original CL (crrev.com/c/1763521) didn't remove
unnecessary comments. Remove it.

Bug: 955171
Change-Id: I66cc285260a196cd29710218eb65ffc8810b7769
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777464Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691963}

This CL removes |onSheetStateChanged| that updates scrim alpha
to the height of the sheet view. Scrim alpha in opened state
stays constant.

Bug: 993032
Change-Id: Idabf5735e282bbd28e4e290a67ce033c5a9c8f08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760834
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691962}

Delete or replace with the appropriate base/ headers. Fix a few lint
errors and do IWYU along the way.

Change-Id: If2066861079a6b7c82d5431b03f2da1db0b7159b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775447Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691961}

chrome://file_manager_test/

Add js_test_gen_html build template and script that works similarly
to js_unit_tests, which generates a HTML file with all JS dependencies
to be able to run the JS unit tests.

The new js_test_gen_html has 3 different behaviours from
js_unit_tests:

1. Point scripts to chrome:// URLs instead of using file system files
and directories. The files are served from either regular
chrome://resources or from the test-only chrome://file_manager_test/.
This allows to run tests for Polymer elements that load JS/HTML from
chrome:// URLs.

2. Takes care of special cases where file paths aren't directly
served from chrome://resources e.g.: jstemplate and some Polymer
pahts.

3. Add the "html_import" boolean config to allow to use HTML Imports
instead of <script> for unittesting Polymer elements.

Change TestFilesDataSource (which backs chrome://file_manager_test/)
to serve:

1. From //src/ and from //$OUT/gen/. From //$OUT/gen is to be able to
serve the generated HTML file, all other files are served from
//src/.

2. Serve both roots //src/ and //$OUT/gen/ instead of narrowing down
only to ./ui/file_manager/, this makes simpler to keep the difference
from previous path style for all apps (Files, Gallery, etc).

Convert all unittests from //ui/file_manager/file_manager/ to use
js_test_gen_html instead of js_unit_tests.


Test: browser_tests --gtest_filter="FileManagerJsTest.*"
Bug: 991105
Change-Id: I61c17edd4af10ac5ba739725585c23472b27b49e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767297
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691960}

Ownership has been refactored in https://crrev.com/c/1477233 some time
ago. Since we are not accessing the shared data through weak
cross-thread references there is no reason to try to get the lock.

Bug: 992395
Change-Id: I344c4fb84353bb580f1eba46b8856903df4c56ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776038Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691959}

https://skia.googlesource.com/skia.git/+log/ba0a2c7ad992..7409b73fa546

git log ba0a2c7ad992..7409b73fa546 --date=short --no-merges --format='%ad %ae %s'
2019-08-30 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
2019-08-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5d27a6961601..120b61d34ba8 (9 commits)
2019-08-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 2dd36fa7..a461132e (466 commits)

Created with:
  gclient setdep -r src/third_party/skia@7409b73fa546

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@google.com

Bug: chromium:None,chromium:None
Change-Id: I464c1922bd9cec3899f5b4d924fa154a4294c689
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777210Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691958}

PointerID was defined indirectly through scroll_types.h. This CL splits
out the PointerID definition from web_pointer_properties.h, and
element.h includes the new header.

This CL reduces estimated pre-processed size of element.h from
3.11MB to 2.37MB.

Bug: 242216
Change-Id: Idfd35d73d315a9bdcc89938fb42915a41832877c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775885
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691957}

This patch moves chrome/renderer/page_load_metrics to
components/page_load_metrics/renderer, and is mostly
moving the file, no feature change.

OWNER file has been move to components/page_load_metrics,
is changed to same as chrome/browser/page_load_metrics/OWNERS
components/page_load_metrics/common/OWNERS is deleted.

Bug: 995880
Change-Id: Idbd70e7dda295db2cacb0bdcad1c5ba13fb48fea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773919
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691956}

This CL converts BlobURLTokenPtr and BlobURLTokenPtrInfo
to new Mojo types.
It updates BeginNavigation from frame.mojom,
CreateWorkerHostAndStartScriptLoad from
dedicated_worker_host_factory.mojom, and Connect from
shared_worker_connector.mojom

Bug: 955171, 978694
Change-Id: If9cbac3e3500803e9f9bb8914c59c8ba14ea2149
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774422
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691955}

Bug: 839389
Change-Id: I996d2415fff94a084f1a48a7ec92b8d741fde42d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777344Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691954}

When checking for a V4L2 workaround, we first open the decoder device in
order to check its name, before querying its supported profiles using
GetSupportedDecodeProfiles().

However GetSupportedDecodeProfiles() DCHECKs that no device is currently
opened, since it needs to open one itself - and the device is still
opened at this time.

Fix this by reinitializing the device before calling
GetSupportedDecodeProfiles().

Bug: b:140222972
Test: assert of b:140222972 not triggered.
Change-Id: I6ec44f6f6113c4fc69965d6012128b61a27cb473
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775887
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691953}

Change-Id: I7e0eab7e405074df9c9de4922123938442dae5b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772900Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Rika Fujimaki <rikaf@google.com>
Cr-Commit-Position: refs/heads/master@{#691952}

This CL converts UsbDeviceManagerClient{AssociatedPtr, AssociatedPtrInfo}
in chrome, components, extensions and services to the new Mojo types,
and uses pending_associated_remote<device.mojom.UsbDeviceManagerClient>
in usb_manager.mojom and web_usb_service.mojom.mojom.

Bug: 955171, 978694
Change-Id: Ic64f0e43ef60cb184a35b5bf6391a7fb3bc38dd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772837
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691951}

This patch makes |DirectionGranularityStrategy::UpdateExtent()| to check null
position fo vertical movement to prevent constructing invalid selection for
avoiding crash.

This patch is similar to the CL[1], but we are not sure actual HTML causes
this crash. This CL is an experimental to reduce candidates of crash.

[1] http://crrev.com/c/1669133 Make DirectionGranularityStrategy::UpdateExtent()
to check null position for word bounds

Bug: 978784
Change-Id: Ica41e0dd75c0ded2beafa171f1d027bf5de9cae5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775956
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691950}

https://skia.googlesource.com/skia.git/+log/165ca3f85b7a..ba0a2c7ad992

git log 165ca3f85b7a..ba0a2c7ad992 --date=short --no-merges --format='%ad %ae %s'
2019-08-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader eea9d35b8757..680d37610656 (7 commits)

Created with:
  gclient setdep -r src/third_party/skia@ba0a2c7ad992

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@google.com

Bug: chromium:None
Change-Id: I1bb076f24afccfd921234468f874306ddf81805f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777125Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691949}

Bug: 997759
Change-Id: I0d74d90617a0d3a72d22d34de4f830dcc6f3c0a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777065
Commit-Queue: Andrew Luo <aluo@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691948}

If a driver doesn't support the drain operation, the drain is
simulated but the buffer ready timer is not cancelled.
If the buffer ready timer is not cancelled, the unittest will return
an error if the unittest doesn't end before 3s since processing the last
frame.
This patch simulate the drain operation by calling FlushEncoderDone
function and cancelling the buffer ready timer in the same time.

BUG=999013
TEST=tast with tast video.EncodeAccel* on veyron_minnie-kernelnext
Signed-off-by: Francois Buergisser <fbuergisser@chromium.org>
Change-Id: Id2a8bcd71a8bf82e84970bebf6eb18f3b68ee636
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772853Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691947}

Some devices select the video decoder implementation by the video
configuration (e.g. codec). VideoDecoderPipeline needs to select a
proper video decoder in Initialize() when a video configuration is
specified.

This CL implements the mechanism of selecting VD at Initialize()
instead of Create() method.

BUG=chromium:952730
TEST=Run video_decode_accelerator_tests on Kevin and Eve

Change-Id: I76077df0bc1e1eeae730e618a62c6e1049e02500
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708693Reviewed-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691946}

The GPU process is now armed to detect hangs during shutdown. This also fixes
a problem that ReportProgress() is called without Arm() first and a DCHECK is
triggered due to the wrong Arm/InProgress/Disarm order. Calling Arm() when the
GPU starts to shut down fix this order issue.

Bug:949839, 674475

Change-Id: I5f8ec78787945a09ad6cf519506175386e24a646
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775214
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691945}

This CL makes the DWTHX11 subclass the DWTHPlatform and use
the X11Window, which subclasses the XWindow. Also, DWTHX11
uses PlatformWindowDelegate instead of ui::XWindow::Delegate now.

That is, to migrate X11 to Ozone, we need to make sure DWTHPlatform
is mature enough. To avoid code duplicate, it was decided to
make DWTHX11 subclass DWTHPlatform and move its code to DWTHPlatform
step by step ensuring nothing is broken.

However, it was not enough to just make DWTHX11 a subclass of DWTHPlatform.
The way how we communicate with XWindow has had to be changed as well.

The plan is to move all the code to DWTHPlatform and make the
WTHPlatform create the X11Window. However, there are many intermediate
steps to be done before doing it. As described before, first, DWTHX11
subclasses the DWTHPlatform and starts to receive messages and
events from the XWindow through the PlatformWindowDelegate.

It was ensured that the DWTHX11 intercepts all the calls to DWTH,
WTH and PWD and does everything as it was doing previously. In the
follow up CLs, I will start to move the code slowly to DWTHPlatform
and WTHPlatform so that DWTHX11 no longer implements PDW and DWTH
methods and the DWTHPlatform manages everything on its own
for both Ozone and non-Ozone builds.

Bug: 990756
Change-Id: If45b05d09609cf8aa826cc4894ec559f210dc0b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771397Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#691944}

We now return rgb() values instead of color keywords in
getComputedStyle() results for gradient images.

Not yet addressed: lengths should also be made absolute,
e.g. we should never have 'ex' units in getComputedStyle()
results.

Bug: 977042
Change-Id: If20dc6b773f8948370fbda63397e06c784e3d55c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765133
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691943}

Add image processor to the V4L2SVDA, which is required in order to
decode on Kukui.

Bug: b:132589320
Test: VDA unittest passing on Minnie, Kevin and Kukui.
Test: VD tests passing on Minnie, Kevin and Kukui.

Change-Id: Ia5d4af8b35e71a81e5b56759d0f35d7d39689931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743437
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691942}

This reverts commit 74c69a75.

Reason for revert: causing first build failure on Deterministic Fuchsia (dbg).

Sample build: https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Fuchsia%20%28dbg%29/561

Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8903731569632286240/+/steps/First_build/0/stdout?format=raw

[47036/47333] SOLINK ./lib/libweb_engine_core.so
...
ld.lld: error: undefined symbol: switches::kEnableFeatures
>>> referenced by context_provider_impl.cc:208 (../../fuchsia/engine/context_provider_impl.cc:208)
>>>               obj/fuchsia/engine/web_engine_core/context_provider_impl.o:(ContextProviderImpl::Create(fuchsia::web::CreateContextParams, fidl::InterfaceRequest<fuchsia::web::Context>))

ld.lld: error: undefined symbol: gl::kGLImplementationStubName
>>> referenced by context_provider_impl.cc:212 (../../fuchsia/engine/context_provider_impl.cc:212)
>>>               obj/fuchsia/engine/web_engine_core/context_provider_impl.o:(ContextProviderImpl::Create(fuchsia::web::CreateContextParams, fidl::InterfaceRequest<fuchsia::web::Context>))
clang: error: ld.lld command failed with exit code 1 (use -v to see invocation)
[47037/47333] AR obj/components/password_manager/core/browser/libbrowser.a
[47038/47333] AR obj/components/sync_sessions/libsync_sessions.a


Original change's description:
> [Fuchsia] Handle VULKAN feature flag in WebEngine
> 
> Now WebEngine will enable Vulkan only when ContextFeatureFlags::VULKAN
> is specified for web::Context. Also Context process now explicitly
> disables hardware-accelerated compositing when VULKAN is not enabled
> (otherwise it restarts the GPU process several times before it falls
> back to software compositing).
> 
> Bug: 962617, fuchsia:35009
> Change-Id: I74a463a1514df99134d929981fe44151c1d9dd17
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774967
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Jonathan Backer <backer@chromium.org>
> Reviewed-by: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#691856}

TBR=backer@chromium.org,wez@chromium.org,sergeyu@chromium.org

Change-Id: I71d9bb87b79928bbffa9f123408b4e4bafad31bc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 962617, fuchsia:35009
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775955Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#691941}