- 05 Aug, 2019 40 commits
-
-
Chris Palmer authored
An old form of a double-free check was present in comments. The new form is in live code. Also remove a TODO we likely won't be able to do. Bug: None Change-Id: Ibbd18b6c98ae7729f46cf8f314e34b0634458d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733803Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#684173}
-
Bettina authored
Previously the listener only listened on changes to kPasswordHashDataList. This is only good if the account that has changed has already been given us. For all content area account password changes, the username is needed in order to find the appropriate account to report the password change event to enterprise. Bug: 914410 Change-Id: Iadf2753ddfc17570dbeb85a4936b72f12a166980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719975 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#684172}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cc4114d75878..8be476e7a4e0 git log cc4114d75878..8be476e7a4e0 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 saklein@chromium.org call_templates: add templates for the package service endpoints. Created with: gclient setdep -r src/third_party/chromite@8be476e7a4e0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I9008aba14faac9bb06d085f6873c18dd3dfe5bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737591Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684171}
-
Adenilson Cavalcanti authored
Usage of CRC32 Castagnoli as a hash function for the hash table of symbols used for compression has a side effect where for compression level [4, 5] it will increase the required output buffer size by 0.1% (i.e. less than 1%) for a high entropy input (i.e. random data). To avoid a scenario where client code would fail while compressing data, this patch will increase the compressBound by 0.8% (i.e. 8x than worst case scenario). Validated using zlib_bench with the data from the 'Random Compression Challenge' on both Intel and Arm. Bug: 990489 Change-Id: I86c6ab09fce6ab09b45c502221864400b86a7d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733790 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#684170}
-
Kenichi Ishibashi authored
URLLoaderThrottleProviderImpl and WebSocketHandshakeThrottleProviderImpl used content::RenderThread::Get()->GetConnector() to connect mojo interfaces. This prevented us from creating these throttle providers on the IO thread. To allow these throttle providers can be constructed without going to the main thread, create a clone of the main thread's connector in ChromeContentRendererClient::RenderThreadStarted(). The cloned connector is bound to the IO thread and will be used to create throttle providers for off-the-main-thread service worker startup. Bug: 989781 Change-Id: Ic4d20813e18c6238700545946cbcfd6f4534d974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724754Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#684169}
-
Jarryd authored
For origins with unlimitedStorage permission, the Quota system will now return available disk space + usage by origin as the quota for that origin. Change-Id: Ic49b0488c35c0396fbfc1754da2fba063f38452e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736002 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#684168}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c13ca2affeed..7c8928d0a054 git log c13ca2affeed..7c8928d0a054 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 lujc@google.com Add more tests covering gl::vertexAttribPointer 2019-08-05 lujc@google.com FrameCapture dump GLenum to enum instead of value 2019-08-05 jmadill@chromium.org Capture/Replay: Capture entry point enum when possible. Created with: gclient setdep -r src/third_party/angle@7c8928d0a054 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Bug: None Change-Id: If64232ca7d2e2222119bd42a94e2025764e69e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737587Reviewed-by:
-
Fabrice de Gans-Riberi authored
* Replace various implementation of these helpers throughout //fuchsia with a common helper. * Replace a stale bug reference. Bug: 978696 Change-Id: I7bf29ea00312bfcaa3baff8f8d3f5a724367fc12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733419 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#684166}
-
Chris Morin authored
Instead of having the browser do the arc vm setup followed by the call to concierge to launch the vm, make a new process outside of the browser to handle it. Bug: b:136128691 Test: launch arcvm Change-Id: Idae0d505730e248cad5d441b6fa9e5b6ff6e5881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728319 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#684165}
-
Collin Baker authored
Change-Id: Ib245310f3a43dba9d014ba280e7d67dac3212c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737189 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#684164}
-
Marijn Kruisselbrink authored
Bubbles are typically narrower than modal dialogs. Bug: 987285 Change-Id: Ic195d73e8040e45dd8c92f44838b31b5b38abcef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737440 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
David Benjamin authored
If the HttpNetworkSession is configured to ignore certificate errors, the errors will not be surfaced out of OnSSLCertificateError and there is no need to second-guess it. This code dates to https://codereview.chromium.org/2725293003 which simultaneously fixed one bit of --ignore-certificate-errors plumbing and added that check. Only the former was necessary. Bug: none Change-Id: I801da673b5dc538d34969fffd2a62080e73873fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736175 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#684162}
-
Becca Hughes authored
Allow a session to specify a request ID. Normally if a session abandons focus and then requests it again we would give it a new ID. This preserves the ID to avoid making the UI flash. BUG=988106 Change-Id: Iecf95bad2276908bb1d5910d3aebd17c25731f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721039Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#684161}
-
Lukasz Anforowicz authored
Bug: 988764 Change-Id: I73e41bedbf0d6d6da99ff139d8b8735ab73303be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737186 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#684160}
-
Marijn Kruisselbrink authored
Bug: 985602, 987260 Change-Id: I8ee8c01fed607b42c3bf15a97333652c9c74b2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730862 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit a42acfa3. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 684140 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2E0MmFjZmEzOTI0Mzc0ZjM2ZTE5OGNjODcyM2UxNGRhNzU0NDE1Y2QM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/mac-archive-rel/3151 Sample Failed Step: compile Original change's description: > Move file_util service off Service Manager > > Eliminates all Service Manager dependencies from > //chrome/services/file_util/. > > Adds a LaunchFileUtilService() call to //chrome/browser/, which launches > a dedicated service process for file utilities that can be controlled by > the returned Mojo remote. > > Adapts client library call sites to use LaunchFileUtilService instead of > a Connector. > > Bug: 977637 > Change-Id: Ie3e3a583fd00a6d9f77137d0febbccf6a086ff0f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732679 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#684140} Change-Id: Id3704ee28b96680de213702a1cb9693666cfb4aa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735519 Cr-Commit-Position: refs/heads/master@{#684158}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9b1700cfaef9..074f0d2d282d git log 9b1700cfaef9..074f0d2d282d --date=short --no-merges --format='%ad %ae %s' 2019-08-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7c6275bd..2c4c2e2e (683711:684065) Created with: gclient setdep -r src/third_party/webrtc@074f0d2d282d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I2a88e4a3929c9c8898b268f1b48e0e13858149a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736004Reviewed-by:
-
Jinho Bang authored
Before this patch, DOMQuad's bounds doesn't update even if its points are changed because the bounds is calculated in DOMQuad's constructor. So, this patch adds DOMQuadPoint class that extends DOMPoint to recalculate DOMQuad's bounds. Bug: 984951, 985376 Change-Id: I63025aa3238ffeb357b48c1eb8e5cec7c0de433e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714385Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#684156}
-
Jérôme Lebel authored
When sign-in with a new gmail account, the Chrome identity was initialized with no hosted domain since the SSO profile was not fetched yet. The property was never updated later. Even when the AuthenticationFlow was fetching hosted domain using the AuthenticationFlowPerformer. During the sign-in process To fix the issue, -ChromeIdentity.hostedDomain is remove. ChromeIdentity stays just a proxy for SSOIdentity. ChromeIdentityService::GetCachedHostedDomainForIdentity() is added to get the hosted domain. Bug introduced with: + crrev.com/c/1687254 + crrev.com/i/1434627 + crrev.com/c/1687254 Related to: + crrev.com/c/1732084 (adding new API) + crrev.com/i/1560989 (adding new implementation) => crrev.com/c/1732085 (switching implementation) <= + crrev.com/i/1560990 (old implementation cleanup) + crrev.com/c/1732101 (cleanup API) Bug: 987380 Change-Id: I658d3e0b109c68583db58b12a034de072adfc45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732085 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#684155}
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=garykac@chromium.org Change-Id: I17c113c13e6a6f112fba29fe47bf30b0644a920c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733591 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#684154}
-
Antonio Gomes authored
... and its dependent files/classes. This is the last CL that moves main classes from content/renderer/media/stream to Blink. It includes the following files: - user_media_client_impl.cc|h - apply_constraints_processor.cc|h - user_media_processor.cc|h This CL will unblocks new round of Blink exposed API clean ups, mainly in public/web/modules/mediastream and public/platform/modules/mediastream. Additionally, the following actions will also be taken next: - conversion from using base::Bind{Once,Repeating} to the Blink counterparts. - converting various uses from std::vector and std::string to its WTF counterparts. - remove the blink:: namespace use. Bug: 704136 Change-Id: I1b2be80ba7e2a21711359c80c475f64633bae16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731644 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#684153}
-
Takuto Ikuta authored
The builders have 24 and 29 hour hourly resource usage in p99 each. http://shortn/_DN5lAMF5Ld So, I will submit this after https://chrome-internal-review.googlesource.com/c/infradata/config/+/1560185 Bug: 954450 Change-Id: Ia497e9915467ce1e222c5638507bdf64944ae4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735093Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#684152}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I185e2fa6ea43bc361d189c3ab2ce2cf5abd5930b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736521Reviewed-by:
-
Jun Mukai authored
Currently UpdateOpacity() assumes the correspondance for the item and the page doesn't change during the drag. When it happens, some items remain painting to layer with lower opacity after the dragging of app-list is done. This leads to invisibility of some app list which isn't in the current page. I think this is the reason for the reported issue. Bug: 990529 Test: the new test case in ash_unittests Change-Id: I046cdfa62f4305f70a38859a2b71534d016c60ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736177 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#684150}
-
Luum Habtemariam authored
Changed service name to IppParser and namespace to ipp_parser. Added the new IppParser service API, since ServiceManager is being deprecated. New API launches an IppParser service instance in an isolated, sandboxed process. Bug: chromium:945409 Test: confirmed service startup configuration Change-Id: I3123b18627bee46747768db69ebf75a10dadf54f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727719Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
-
Danton Vu authored
From a performance standpoint, it is important that windows that are off-screen don't animate. R=sammiequon@chromium.org Test: manual Bug: 981190 Change-Id: I4ba972c237e51425a4650a3aaba839ddfe2c2df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733718 Commit-Queue: Danton Vu <dantonvu@google.com> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#684148}
-
Alex Cooper authored
Add self as test-related owner, add KlausW to subdirectory to guarantee two OWNERS per file. Change-Id: I6cfc7ec5b2486006829abf5784a5250f4a9bc4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731775Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#684147}
-
Jeremy Chinsen authored
Currently PDFiumEngine::Paint() takes a region of space, |leftover|, that needs to be redrawn and iterates through the visible pages, drawing them. A part of this process is recomputing the region of space that needs to be redrawn. In two-up view, a page does not span the whole width of the document so subtracting the page's area from |leftover| does not result in a rectangle. This CL makes PDFiumEngine::Paint() only recompute |leftover| if |two_up_view_| is false, allowing PDFiumEngine to properly draw two-up view layouts. Bug: 51472 Change-Id: Ia7175d3182bd208e1b20c6ffe0a7f510ba2cff26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731925Reviewed-by:
-
Darwin Huang authored
Removes some remaining mus-specific code and comments. Follow-up of https://crrev.com/c/1729060 Change-Id: Ia51339c768a9965273f073c4695ec710e3be908d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730651 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
David Benjamin authored
Both fields are std::vector<uint16_t> which is copy-assignable. Bug: none Change-Id: I4f770d790abbdc8086d0b809dd8f1ff90475ad23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737369 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
-
Mike Frysinger authored
Copied over from swarming_client/third_party/six/. We'll rely on it to help with porting to Python 3. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: Ie195d79ea07bba3a6bcfb76b2520440a30fa439e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700503 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#684143}
-
Raphael Kubo da Costa authored
Make things less confusing by defining it closer to where it is used. The only other place using CallbackWrapper is orientation-sensor.html, where it was easier to just enclose the calls in a try-catch block. Bug: 987639 Change-Id: I1d27c7ace977f456f7e6b3b604b87a7b0246b845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718707Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#684142}
-
Morten Stenshorne authored
Only create block break tokens if we have more work to do for the node in the next fragmentainer. The concept of finished break tokens was really only sufficient to prevent us from re-laying out a node in the very next fragmentainer, but not enough to prevent us from restarting layout in any fragmentainer after that. A node may overflow into more than one additional fragmentainer, while a subsequent sibling may finish way earlier. Correct and simplify the block child iterator, by first processing all the break tokens in order, and then continuing with unstarted siblings at the sibling after the last break token. We can only perform this second step (unstarted siblings) if we actually have unstarted nodes, though. This isn't something we can tell by examining the child break tokens, so, when we have managed to get to ("see") the last child of some parent node when laying out a fragmentainer, mark the resulting parent break token as such. Note that this change is only for block break tokens. Inline layout still creates finished break tokens (but maybe we could change that as well?). Bug: 829028 Change-Id: I0ce7973b94f1a73720aef943a5fcb3ce82ad5e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733596 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#684141}
-
Ken Rockot authored
Eliminates all Service Manager dependencies from //chrome/services/file_util/. Adds a LaunchFileUtilService() call to //chrome/browser/, which launches a dedicated service process for file utilities that can be controlled by the returned Mojo remote. Adapts client library call sites to use LaunchFileUtilService instead of a Connector. Bug: 977637 Change-Id: Ie3e3a583fd00a6d9f77137d0febbccf6a086ff0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732679Reviewed-by:
-
Findit authored
This reverts commit 4020c38f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 684103 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQwMjBjMzhmZmVkOWIzYWRhMWMyMTZjYjM0NTE2NDQwNWQ1ZmNlOGEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/49342 Sample Failed Step: content_unittests Original change's description: > Remove ByteStreamInputStream class > > This class was previously used by DownloadRequestCore in > non network service code path. We no longer need this now. > > BUG=934009 > > Change-Id: I827d2f644eed739fd95f544b3f402e1bc7e957f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733420 > Commit-Queue: Min Qin <qinmin@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684103} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=934009 Change-Id: I3defc99d39a42b49118f38196956911fa78e2c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737626 Cr-Commit-Position: refs/heads/master@{#684139}
-
Tom Sepez authored
Minimal code change to get new behaviour so that tests can be updated. Code cleanup in a subsequent CL. The third_party/blink/web_tests/http/tests/security/xssAuditor directory is removed entirely. Three other files outside this directory are removed which also triggered the auditor. Bug: 968591 Change-Id: I6374a4c381c8a5210eaff97c8f031a789c7059b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723805 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#684138}
-
Raymond Toy authored
When a setTargetAtTime event has converged (10 time constants), we basically hold the value. However, if there's a setValue event after convergence, and this setValue is within the current render quantum, the current_frame was not getting updated, so when this event and the next are getting processed, the currentTime has the incorrect value. Update current_frame appropriately in this case. Bug: 990393 Test: the-audioparam-interface/set-target-conv.html Change-Id: I4b364d3972e1f5acb454916fdb6455fb75b7e7b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736173Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#684137}
-
Luke Zielinski authored
Bug: 937369 Change-Id: Ief48c90e41affaf469ef80a9e2fd2e86c8f29ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731909 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#684136}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/444cccdb2cdd..cc4114d75878 git log 444cccdb2cdd..cc4114d75878 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 levarum@google.com Revert "chromite: Temporarily move betty-arcnext-pi-android-pfq to experimental" 2019-08-05 tcwang@google.com afdo: Fix OWNERS files. Created with: gclient setdep -r src/third_party/chromite@cc4114d75878 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I40611a64e019799d9a56a1e61ccfc393d19535e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736520Reviewed-by:
-
Xinghui Lu authored
The current implementation in Chrome shows "Security Error". The title should be "Page may charge money" instead. Bug: 913889 Change-Id: I8655217cadc4e481d149ad5a80520367148dc2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732309Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
-
