- 31 Aug, 2020 40 commits
-
-
Victor Hugo Vianna Silva authored
There was a spike in the flakiness of these tests following 2020-08-03. https://findit-for-me.appspot.com/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyagsSBUZsYWtlIl9jaHJvbWl1bUBzeW5jX2ludGVncmF0aW9uX3Rlc3RzQEVuYWJsZURpc2FibGVTaW5nbGVDbGllbnRUZXN0LkZhc3RFbmFibGVEaXNhYmxlRW5hYmxlT25lQXRBVGltZQw&show_all_occurrences=1 https://findit-for-me.appspot.com/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyZAsSBUZsYWtlIlljaHJvbWl1bUBzeW5jX2ludGVncmF0aW9uX3Rlc3RzQEVuYWJsZURpc2FibGVTaW5nbGVDbGllbnRUZXN0LkZhc3RFbmFibGVEaXNhYmxlT25lQXRBVGltZQw&show_all_occurrences=1 Bug: 1111227 Change-Id: Icdb31b999c89c5796bba63330816c44dc6d23a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383024Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#803102}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ic06815193acc870c4639a700f4726f2cd21e2699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385435Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803101}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Icb54c2f9e02ca7efc89d5674d22daed4ac1f971a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383022Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Iecad2dc339be6d352c3cf420a50b3f9c58cbe68f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382594 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#803099}
-
Andrey Zaytsev authored
Bug: 1123075, 1070620 Change-Id: Id3e1a4c13532a846332935c70cdc02059881ccb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385335 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#803098}
-
Maksim Ivanov authored
Drop std::move() call that has no effect and only triggers the "bugprone-use-after-move" clang-tidy warning. Bug: 1122844 Change-Id: I04d191a6a73964dbd58b61bce722d5885b140c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383021 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#803097}
-
Brandon Jones authored
These were accidentally left over from a removed change in a previous CL Bug: 1121762 Change-Id: Iff01ecbd0c78a96535cc0193d03e18eb04d98042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382115 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#803096}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I0af5f12d7e856ec1f128cbe7d5fd08035de6fe72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383654 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#803095}
-
Andrey Zaytsev authored
Bug: 1099233 Change-Id: I9a6a500c706d2a0bb48fdd8e844e2fce4b859da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382860 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
-
Peter Marshall authored
Change-Id: I06732b384f760a235f42078899e54c80123d4e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369312Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#803093}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b4c90eee2f9f..6ec0b23923e9 2020-08-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from af56d31487bb to 0e98e894a84c (2 revisions) 2020-08-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 84714fcf to 1ca2f943 (3121 revisions) 2020-08-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 08291a3a9e22 to f428aa39ca2b (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I197ebed960b18ee6a853b971befd6a0cdf0a9218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384857Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803092}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/79257bae3c9a..19157ee4a2fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0c759755e080e359c4a3b847031e6445949fae86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385236Reviewed-by:
-
Peter Kasting authored
Instead of requiring consumers to use this, have them pass in a callback, and call it with the correct URL directly. This will facilitate further cleanups/simplifications later, e.g. the replacement of StyledLabelListener with setting a callback directly. Bug: none Change-Id: Ia45310b19b6df915739d5a3c9c5567afff029d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384078 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#803090}
-
Henrik Boström authored
Prior to this CL, it was the last event to fire before SLD/SRD's promise resolving. With this CL it fires according to spec, that is after processing all the state changes but before firing any other events. WPT test coverage added. Bug: chromium:1122561 Change-Id: Ie2558a214899814fe6dcdf29d6a628df5e42f171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379753 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#803089}
-
Alexander Surkov authored
DumpAccTree testsuite: utf16 to utf8 conversion, get rid of utf16 version of AccessibilityTreeFormatterBase::WriteAttribute Bug: 1115489 Change-Id: Ieeb4bcda323cdcc27e6a645ac3ab9742dc6e41f4 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364018Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#803088}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I987800bb2b59f29899c308125594d45b4d409a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382759Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803087}
-
Rob Buis authored
Introduce LayoutNGMathMLBlockFlow to mark the block flow as a MathML layout class, currently only used for operators (mo). A follow-up CL will introduce an UpdateFromElement method on it to deal with operator attribute changes. This CL does not yet introduce an operator layout algorithm (which will allow things like stretching) and falls back to the block layout algorithm for operators. Bug: 6606 Change-Id: I5ed10f7e27bdd08be2eb576d297067ac790241bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382601 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#803086}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45c7cc03636d..be19a45481cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kolos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kolos@google.com Change-Id: Ie8193db2cbc16ec72b9327c8fc1ae346b6d5ab88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384853Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803085}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e3e2618b1b05..c2cc4d305a7c 2020-08-31 ilnik@webrtc.org [adaptation] Expose target pixels and max framerate in VideoAdapter 2020-08-31 mbonadei@webrtc.org Move ABSL_MUST_USE_RESULT at the beginning of the method decl. 2020-08-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4bf6d398..a50ca66b (802598:802712) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1116430,chromium:1122891 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib9b42743db058e452398d48bb87b59ce8eb603ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384856Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit cd8566c8. Reason for revert: this CL didn't cause the problem. The root cause was a tricky infra problem. sorry for wrong revert. Original change's description: > Revert "OOR-CORS: Remove BlinkCORS related tests" > > This reverts commit 7d2bed26. > > Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190 > > Original change's description: > > OOR-CORS: Remove BlinkCORS related tests > > > > This patch removes network::features::kOutOfBlinkCors and > > network::features::ShouldEnableOutOfBlinkCorsForTesting() references > > from existing tests as now BlinkCors was deprecated, and we already > > turned down CORS fyi bots. > > > > This is part of the work to remove the kOutOfBlinkCors feature. > > > > Bug: 1053866 > > Change-Id: I4ba14005fd3fb310cbd246e6c0bd6cc18bd005d8 > > TBR: mkwst@chromium.org > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377633 > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#803029} > > TBR=falken@chromium.org,toyoshim@chromium.org,lukasza@chromium.org,karandeepb@chromium.org,mkwst@chromium.org > > Change-Id: I96044df30b8694433c6bad6e9eb719b949f6413e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1053866 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385075 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803044} TBR=falken@chromium.org,toyoshim@chromium.org,lukasza@chromium.org,kolos@chromium.org,karandeepb@chromium.org,mkwst@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1053866 Change-Id: Ic35fa6950fc52873ad3650ce836a015b2a274cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382761Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 1c8be55e. Reason for revert: this CL didn't cause the problem. The root cause was a tricky infra problem. sorry for wrong revert. Original change's description: > Revert "[WebAuthn] Add UseCounter for WebAuthn in cross-origin iframes" > > This reverts commit 0426308f. > > Reason for revert: I suspect it caused compilation failures https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190? > > Original change's description: > > [WebAuthn] Add UseCounter for WebAuthn in cross-origin iframes > > > > The feature policy to enable WebAuthn get requests in cross-origin > > iframes shipped in M84 but did not include a use counter. This CL adds > > one. > > > > Change-Id: Ie404ab62de3cfe665a1927883a31d7f17c329c1b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384651 > > Commit-Queue: Martin Kreichgauer <martinkr@google.com> > > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > > Cr-Commit-Position: refs/heads/master@{#803026} > > TBR=kenrb@chromium.org,martinkr@google.com > > Change-Id: I07e8edb0aeed3c53118f69bb4c7304cb6f34342f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383026 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803037} TBR=kenrb@chromium.org,kolos@chromium.org,martinkr@google.com # Not skipping CQ checks because this is a reland. Change-Id: I7ba02d1cf109b2a6026ccd8c90c19ba5d00bd8c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382607Reviewed-by:
-
Maksim Ivanov authored
Refactor the code to make it clearer that there's no use-after-move bug, both for the reader and for the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I9e1983c60ca76992c87d825223e0c24c5b818002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382114Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803081}
-
Maxim Kolosovskiy authored
This reverts commit 1d850b0b. Reason for revert: this CL didn't cause the problem. The root cause was a tricky infra problem. sorry for wrong revert. Original change's description: > Revert "Reland "cros: Implement ClipboardImageModelFactory"" > > This reverts commit 57af2c42. > > Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190 > > Original change's description: > > Reland "cros: Implement ClipboardImageModelFactory" > > > > This reverts commit 5822a03a. > > > > Reason for revert: > > It turned out that the test is flaky regardless of this change. > > Probably this just made it easier to reproduce the flakiness. > > > > Original change's description: > > > Revert "cros: Implement ClipboardImageModelFactory" > > > > > > This reverts commit 056d2885. > > > > > > Reason for revert: > > > This is a speculative revert for failures on > > > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38382 > > > > > > This could fail the following test: > > > ClipboardHistoryWithMultiProfileBrowserTest.ShouldPasteHistoryAsPlainText > > > > > > Original change's description: > > > > cros: Implement ClipboardImageModelFactory > > > > > > > > Implements ClipboardImageModelFactoryImpl. > > > > Previous CL landed ClipboardImageModelFactory, and all > > > > ash-side usages of the factory. > > > > > > > > This CL implements rendering of HTML via > > > > ClipboardImageModelRequest. > > > > > > > > Bug: 1117230 > > > > Change-Id: I2f7ac67eadac5ef1a3c7cfca9918de438f02ff8e > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367395 > > > > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > > > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > > > Auto-Submit: Alex Newcomer <newcomer@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#802779} > > > > > > TBR=xiyuan@chromium.org,newcomer@chromium.org > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > Bug: 1117230 > > > Change-Id: Ibc178e2d0b50bb423bc5a128aead30a5f471bd18 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383532 > > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#803003} > > > > TBR=xiyuan@chromium.org,nhiroki@chromium.org,newcomer@chromium.org > > > > # Not skipping CQ checks because this is a reland. > > > > Bug: 1117230 > > Change-Id: I49fe530783a23a65e06456ca3c4ab3703dde35e2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384712 > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#803027} > > TBR=xiyuan@chromium.org,nhiroki@chromium.org,newcomer@chromium.org > > Change-Id: Iad7614b249091bfcce8a27f10ae4e67de86a2a29 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1117230 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382603 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803043} TBR=xiyuan@chromium.org,nhiroki@chromium.org,kolos@chromium.org,newcomer@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1117230 Change-Id: I410473bc38efce068f1c3d2a2158489ff4eb4f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382122Reviewed-by:
-
Viktor Semeniuk authored
This change adds metrics recording for password check interactions. Bug: 1121906 Change-Id: Ib044e6174d4ef70a55500a21401fe2c69d1b833e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377725Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#803079}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598834860-65570273a8a9241ebf147440a3fd9be058e3b8e7.profdata to chrome-win32-master-1598857126-da6d6f9c34b393846886ccd27545501972c5d864.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie47829d64d373873ec38092cac9a8f8bfa996794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384852Reviewed-by:
-
Mohamed Amir Yosef authored
This CL introduce a new API to fetch all compromised from both the profile and the account stores. Bug: 1108422 Change-Id: I41998de212ad5d83f2c489aad98b43e343296828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378030 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#803077}
-
Maxim Kolosovskiy authored
This reverts commit cebb96ff. Reason for revert: this CL didn't cause the problem. The root cause was a tricky infra problem. sorry for wrong revert. Original change's description: > Revert "[Telemetry SWX] Add battery capacity routine" > > This reverts commit 437b61ae. > > Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190 > > Original change's description: > > [Telemetry SWX] Add battery capacity routine > > > > Add implementation to chrome://. > > > > Add implementation to chrome-untrusted://. > > > > Add tests. > > > > Bug: b:162051831 > > Change-Id: Ib2d618c4eacce43e6cd588c766e8d40af9ae318b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362933 > > Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> > > Reviewed-by: Tom Sepez <tsepez@chromium.org> > > Reviewed-by: Oleh Lamzin <lamzin@google.com> > > Cr-Commit-Position: refs/heads/master@{#803030} > > TBR=tsepez@chromium.org,lamzin@google.com,mgawad@google.com,lolteanu@google.com > > Change-Id: I675879ec1c65f834362901ba862923acadfa9551 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b:162051831 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383028 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803041} TBR=tsepez@chromium.org,kolos@chromium.org,lamzin@google.com,mgawad@google.com,lolteanu@google.com # Not skipping CQ checks because this is a reland. Bug: b:162051831 Change-Id: I1e09e1a56feba44f2079c2b459337a88e622d30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382838Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/79257bae3c9a..19157ee4a2fd 2020-08-31 treehugger-gerrit@google.com Merge "Creation of permalinks for config" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I411f4c2f5d07f15d01f5e70ffc436fb8f2691a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384854Reviewed-by:
-
Benoit Lize authored
All 64 bit ABIs have 64 bit pointers, except for NaCl (using something similar to x32 on Linux). Instead of repeating this exception everywhere, replace it with a single define in a single place, PA_HAS_64_BITS_POINTERS. Change-Id: Ie64a47c77a68de2bc22703d0e10db7347481b922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377708 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#803074}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I7f67d4dde85e191cba0337a1bffe270c4a407658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383016Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803073}
-
Henrik Boström authored
This CL migrates to the spec-compliant OnNegotiationNeededEvent[1], only firing it it the Operations Chain is empty. It also makes the "negotiationneeded" and "icecandidate" events fire without additional delay. This is important, because Perfect Negotiation is very timing-sensitive, and the way we've been firing these events is wrong. A bug in the Perfect Negotiation WPT is discovered: if an incoming follow-up offer is sent to the impolite peer while the SRD(answer) of the previous O/A exchange is still pending, the impolite peer would incorrectly ignore the offer. This is fixed with the introduction of a boolean variable to keep track of if SRD is pending, allowing the impolite peer to predict that it is about to become "stable" and can thus chain the incoming offer onto its Operations Chain. With these changes, we pass the Perfect Negotiation WPTs! Hurray! [1] https://webrtc-review.googlesource.com/c/src/+/180620 Bug: chromium:1060083 Change-Id: I8e8c684ef6cfc1faac0256d33b8fc89be3fc614f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330014 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
Christian Dullweber authored
The boolean BlockThirdPartyCookies preference was replaced by CookieControlsMode enum. Existing settings were migrated since M83. Bug: 1104836 Change-Id: I1afabd42053515a0b436f7f92bac5eed0a14c2fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366935Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#803071}
-
Maxim Kolosovskiy authored
This reverts commit 6d7617fa. Reason for revert: this CL didn't cause the problem. The root cause was a tricky infra problem. sorry for wrong revert. Original change's description: > Revert "Add Media Capture and Generic Sensors mojom.js files to mojojs.zip" > > This reverts commit 1edcb047. > > Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190 > > Original change's description: > > Add Media Capture and Generic Sensors mojom.js files to mojojs.zip > > > > This is the first step before removing those files from WPT. > > > > Bug: 1119858 > > Change-Id: I461ba09d1aaf9573c8f79b0fd6ee59a724be0fd0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378325 > > Reviewed-by: Robert Ma <robertma@chromium.org> > > Reviewed-by: Michael Moss <mmoss@chromium.org> > > Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> > > Cr-Commit-Position: refs/heads/master@{#803031} > > TBR=mmoss@chromium.org,raphael.kubo.da.costa@intel.com,robertma@chromium.org,arnaud.mandy@intel.com > > Change-Id: I94a722412f3cd37ef6ad9ab15274f6951855e9c7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1119858 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383027 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803040} TBR=mmoss@chromium.org,raphael.kubo.da.costa@intel.com,kolos@chromium.org,robertma@chromium.org,arnaud.mandy@intel.com # Not skipping CQ checks because this is a reland. Bug: 1119858 Change-Id: I96db7fc48ab349c86a23c972071dea8e534a4cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384034Reviewed-by:
-
Friedrich Horschig authored
This CL adds favicons to each credential row or a fallback if no icon is available for a site. Screenshots in the bug. Bug: 1106724, 1092444 Change-Id: I246f128fc76838142f599b75666912a1187bf9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362895Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#803069}
-
Jeroen Dhollander authored
This example code is really useful, but it contained a few minor C++ mistakes. Bug: N/A Test: compiled Change-Id: If0b110c89657a4f018e2b406b0e4b2213a4fe420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354594 Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#803068}
-
Sergei Glazunov authored
This CL allows the CheckedPtr constructor to quickly skip unsupported pointers. Change-Id: Ibabb8802f4feb3734e1e7740fd86bd8df9a4e657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379831Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Danila Kuzmin authored
After migrating eula screen to LoginScreenBehaior the screen is temporarily named as "oobe-eula-md". This CL is a follow up name update. Bug: 1121655 Change-Id: Ifcfbc0d8a3528d33deda01d9227c5ec449b0c1bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378029Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#803066}
-
Tanmoy Mollik authored
This cl is the second part that implements the onClickListeners for SyncErrorCard buttons. It also adds the preference to ManageSyncSettings page. The preference is not visible unless MOBILE_IDENTITY_CONSISTENCY feature is enabled. Bug: 1107420 Change-Id: I55a1fcf73747e9e75d950daad0794220226ed0d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346439 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#803065}
-
chrome://flagsJan Wilken Dörrie authored
Bug: 927473 Change-Id: I86ea71e72d2d3db4473c7a0b9687c700212d5975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379765Reviewed-by:
-
Morten Stenshorne authored
The containing block of a rendered legend of a fieldset that also establishes a multicol container is the fieldset itself, not the flow thread (and also not the anonymous fieldset contents wrapper). However, since dynamic changes may change which legend is the rendered legend, we'll keep it simple, and always let them be treated as part of the flow thread - so that they trigger creation of a LayoutMultiColumnSet - so that we are guaranteed to actually have a LayoutMultiColumnSet if the rendered legend ceases to be the rendered one. Bug: 1122722 Change-Id: I5a287e367f8824dc0c5a27620c74d2ec6eedfd34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379723Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#803063}
-
