- 23 Jun, 2020 40 commits
-
-
Mahmoud Gawad authored
Add telemetry-extension-dir command line switch name to be able to load the Telemetry System Web Extension from disk. Bug: b:156583406 Test: Not needed. chrome build is green Change-Id: Id8ae2a8c6a27fa0637264ac9e6e14467e66e8de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257235 Commit-Queue: Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#781358}
-
Eero Häkkinen authored
This CL refactors video capture device creation on Windows, removes some code duplications related to DirectShow device enumeration and adds mocking points for unit testing. This CL has no functional changes. Bug: 934063 Change-Id: I2df08b3a361ffd702761bd9d6b400f4418390c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247797 Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Auto-Submit: Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#781357}
-
Xianzhu Wang authored
Change-Id: If25a2df97a3bf5a322c02d650eb5aaeff86f7722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258423Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781356}
-
Clark DuVall authored
Now that references in clank have been switched over to the version in //components, it's safe to remove this. Bug: 1025606 Change-Id: Id453032a8237d11d94dcc32d102bf5de243a10d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256850Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#781355}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592909179-8c9bd637e5cbc50bd35bf53946c51dca562e57cb.profdata to chrome-win64-master-1592917001-f92b525a65d0a85552634ba3f6ed8ed822d9ee38.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I66ef0c9c6e9a1b6220d16f99d3bcfd3f6da86daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260522Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781354}
-
Michael Ershov authored
Add a field to certificate provisioning policies to disable Verified Access checks for a certificate profile. Modify CertProvisioningWorker to bypass all Verified Access related methods and use PlatformKeysService to generate keys instead. Bug: 1045895, 1094814 Test: CertProvisioning* Change-Id: I9318e2734a897189e3b25f6b9cdeca951c6e1526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238069 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#781353}
-
Becca Hughes authored
Add connect-src to CSP so we can override it in untrusted WebUI. BUG=1087443 Change-Id: Ib93c326e629c2225ddfad0740c4befc26d39b757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246902 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#781352}
-
Becca Hughes authored
This is a reland of e5a8add0 Original change's description: > Split kaleidoscope resources in two > > Split the kaleidoscope resources and strings > into two since they are going to be moved > around. > > BUG=1087037 > > Change-Id: Iee08832b837a18bbb102fcd8cc6ea98c5dbdf819 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254706 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780879} Bug: 1087037 Change-Id: I5d2910992ff1dd3229fd12ab732a1e2a6293f890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258573Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#781351}
-
Hazem Ashmawy authored
Always connect to nonembedded metrics when WebView connects to the variation service to lood seed. This should help to avoid spinning the WebView service process each time WebView starts up just for metrics service. However, this means that now collecting nonembedded metrics is ALWAYS enabled and not guarded by a feature flag anymore because feature flags cannot be checked at this point of execution before initializing variations. This also means that collecting nonembedded metrics will follow the same throttling criteria applied to loading variation seed. Remove kWebViewCollectNonembeddedMetrics feature flag since it's not used anymore. Bug: 1001185 Test: Locally add logs and set finch experiment throttling flags Test: test with enabling and disabling the feature flag Change-Id: Ie8e0ea2204aa9df03dbc7b42bd66d12b11fb6d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252082 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#781350}
-
Joe DeBlasio authored
This CL improves edit distance lookalike matching by not warning on two classes of matches that are commonly false positives: 1. Numeric suffixes, such as domain1.tld and domain2.tld. 2. First-character edits, such as domain.tld and xdomain.tld. Bug: 1096309 Change-Id: I9cdf46060ef00949435c7429b86a835de796fb49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255025 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#781349}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ee0e894a. With Chromium commits locally applied on WPT: ee0c101e "[COOP] access reporting toward the opener." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: igrigorik@chromium.org, yoavweiss@chromium.org: external/wpt/preload NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I776df6d72f6f4467f9c93b4d31fbbe1c8420cfa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260394Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781348}
-
Guillaume Jenkins authored
Moves report_request_definition namespace to components/enterprise. It had previously been moved to components/policy, but it makes more sense to keep reporting code under components/enterprise. Bug: 1091914 Change-Id: I7aaaabc10c3f1efba152465c1405ebe90b42c96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258676 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781347}
-
Dave Tapuska authored
This global lookup API is no longer used. Yeah! BUG=1097816 Change-Id: I7b8abed232bb9c035c8394dbfc30b8e298d42155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258673 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781346}
-
Nohemi Fernandez authored
This patch removes the old, unused APIs for adding an account to Chrome. Bug: 1078815 Change-Id: I0ec5d29af7566d8287090ee83b8a67d4a1abb9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226809 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#781345}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592902529-27c1b0c2ad05930b1841cdb3fc1b8d5f930926e0.profdata to chrome-win32-master-1592913526-aa0369974c74051e60d9fc3c83a0a362a402bc87.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3d8de61c0c4529a761ac6fb9ddc6225d08fcac46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260518Reviewed-by:
-
Sebastien Marchand authored
Use "(dis)allowlist" instead of non-inclusive term "(white|black)list". This affects some UKM entry but it's not something that we're recording now (and this code could maybe be removed anyway). Bug: 842296 Change-Id: Ie0e9fe16ffc6361c9891d01ff6aaf94f7564f2dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249720 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#781343}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/caa519ca532a..43c639f0906a 2020-06-23 rharrison@google.com Roll 5 dependencies and update tests/expectations (#1087) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I855b004b8364eba303ff05b5bf7c03aded85ec42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260517Reviewed-by:
-
Guillaume Jenkins authored
In preparation for moving BrowserDMTokenStorage to components, this change moves platform-specific DM token management code to delegates instead of using derived classes. In this case, the derived class approach won't work after the move to components because the current code has the derived classes implementing the parent's Get() singleton method, which won't work when the base and the derived classes are in different DLLs. Summary of the changes: - Pure virtual methods in BrowserDMTokenStorage have been moved to a delegate inner class. - Platform-specific token management classes now derive from the delegate instead of the BrowserDMTokenStorage singleton. - CBCMController is responsible for creating the correct platform delegate and assigning it to the BrowserDMTokenStorage singleton during early initialization. - For tests, this refactor is completely transparent, as the FakeBrowserDMTokenStorage creates and manages its own fake delegate implementation. Bug: 1091929 Change-Id: I02ae185cc5cbde46016039b49cefaeb8e963ec4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246979 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bbe343d8..dfc4c1d4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I354475103613638f1fa76b95eee157955fb5c814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260417Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781340}
-
Joe Mason authored
R=siggi Bug: 1096543 Change-Id: I42a0f40fa895117ed03b6173f5f1bb27b905b9e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259485 Auto-Submit: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#781339}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2841ab4841b1..60aab5ad138e 2020-06-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-06-23 mathias@chromium.org Roll Puppeteer v4.0.0 2020-06-23 kimanh@chromium.org Re-enable and adapt disabled e2e tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibc12ebd27e9deb5832810d5c1b268b05d4bee6a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260520Reviewed-by:
-
Gavin Williams authored
This error message will be displayed only on Chrome OS in Print Preview whenever the currently selected printer is in an error state. Bug: 1059607 Change-Id: I14449ff21892c21106b7319b8f99bc421897b8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227860 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#781337}
-
Etienne Bergeron authored
Thread priority should not be modified after a test. If that is happening, it needs to be fixed in the code. This CL remove the code that disable the priority checks. NOTE TO SHERIFF: * please paste failure logs when reverting, the goal is to remove flaky tests related to thread priority. * assigned flaky test to etienneb@ Bug: 1097092 Change-Id: I6462e3aff2a0d1b0febc2eae7cd97bf580292768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254466Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#781336}
-
Charlie Hu authored
This CL adds presubmit check for: - document_policy_feature.mojom & document_policy_features.json5 sync - document_policy_feature.mojom & enums.xml sync Example presubmit warning messages generated by adding kNewFeature to document_policy_feature.mojom: DocumentPolicyFeature enum has been updated and the UMA mapping needs to be regenerated. Please run update_document_policy_enum.py in src/tools/metrics/histograms/ to update the mapping. third_party/blink/public/mojom/feature_policy/document_policy_feature.mojom third_party/blink/renderer/core/feature_policy/document_policy_features.json5 and third_party/blink/public/mojom/feature_policy/document_policy_feature.mojom are out of sync: ['NewFeature'] are missing in json5 config. third_party/blink/public/mojom/feature_policy/document_policy_feature.mojom \ third_party/blink/renderer/core/feature_policy/document_policy_features.json5 Change-Id: I21a73d75075ca9e0b7ddbaf30d934a8047dd6a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248752Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#781335}
-
Miguel Casas authored
This CL fixes three things in the mentioned files: - Removes the unnecessary namespace resolution of ::media::Status. - Comments out unused parameter names in Initialize(). - Remove unimplemented static method GetCreateVDFunctions(). No new code/functionality intended, only style refactoring. TBR=hiroh@chromium.org since changes are just cosmetic. Bug: 1040291 Change-Id: I711683337aca0e018f19131dfad15887d36d0f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259486Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#781334}
-
Jamie Madill authored
This reverts commit 2d9c6117. Reason for revert: Still flaky on Win/Vulkan at least. You can even see one flaky in win_optional in the try job for this CL. Breaking ANGLE CQ. Bug: 1098291 Original change's description: > Remove WebGL suppression conformance/buffers/buffer-data-dynamic-delay.html > > Remove suppression for [win nvidia passthrough] conformance/buffers/buffer-data-dynamic-delay.html > > > Tbr: kbr@chromium.org > Bug: 1082826 > Change-Id: I9ec1ba97527a35fbd0f29601494cb8a98a433228 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255223 > Reviewed-by: Shrek Shao <shrekshao@google.com> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Shrek Shao <shrekshao@google.com> > Cr-Commit-Position: refs/heads/master@{#781153} TBR=kbr@chromium.org,shrekshao@google.com Change-Id: I9e0d036c97d159a3c899504ed5dc63e655c1e1a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260812Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#781333}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6586ab4b6c7b03a9f98209cedc1c205275f54ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259147Reviewed-by:
-
Kushagra Sinha authored
For some browser tests, it is useful to create an in-memory instance of Account Manager. Allow this by checking the provided cryptohome root directory during initialization. If it is an empty path, then Account Manager should not perform any disk I/O. Bug: 1068240 Change-Id: I1e0278bf65631e01f246ea85074af4e2ca5e4807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254780Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#781331}
-
Wan-Teh Chang authored
The ReadYUV() function and the StaticAVIFTests.YUV test in avif_image_decoder_test.cc are adapted from the ReadYUV() function and the JPEGImageDecoderTest.yuv test in jpeg_image_decoder_test.cc. Declare ImageDecoder::CanDecodeToYUV() as a const method. Test: 1. blink_platform_unittests --gtest_filter=*AVIF* 2. Run chrome with --enable-features=AVIF and visit https://resources.link-u.co.jp/avif/images.html. Bug: 1087056 Change-Id: I8cd6375cc0824e71ec80622328f288a19c67bc90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229840 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#781330}
-
Clark DuVall authored
The components scaled resources were added in http://crrev.com/c/2250920, and are only needed for WebLayer. Bug: 1023811 Change-Id: I58d9b8aa331e6a102bc9b97367d095f0bd7ed089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258686 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
-
Ioana Pandele authored
Change-Id: I2327855180203f746dc91e966c7c4a6b18749c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260613Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#781328}
-
Hans Wennborg authored
Bug: 1097990 Change-Id: Ic77aecc775a879a937282698d1dddfcefcf76d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259916 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#781327}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c2f46c16ab67..2bf27f21f8d1 2020-06-23 jvanverth@google.com Revert "Reland "Fill in GrD3DGpu::onUpdateBackendTexture"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I03197af1d990ce054e9f4c1b0b441c2bbb853568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260514Reviewed-by:
-
Chris Sharp authored
This reverts commit 1e56c551. Reason for revert: Broke compile on Mac Builder (dbg) Failure Step compile failed. Error logs are shown below: [724/7143] CXX obj/base/base_unittests/power_monitor_device_source_unittest.o FAILED: obj/base/base_unittests/power_monitor_device_source_unittest.o /b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF...(too long) ../../base/power_monitor/power_monitor_device_source_unittest.cc:32:3: error: use of undeclared identifier 'DVLOG' DVLOG(1) << PowerMonitorSource::DeviceThermalStateToString(current_state); ^ 1 error generated. More information in raw_io.output[failure_summary] Original change's description: > base/power_monitor: Add method to query thermal state > > wip wip > > Add PowerMonitor::GetCurrentThermalState() > > Bug: 1071431 > Change-Id: Id3083e06f16fd2f05e685e77ddee94e274158758 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248729 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781322} TBR=fdoray@chromium.org,mcasas@chromium.org,hbos@chromium.org Change-Id: I54bbdc02423890b8443cb2f1deec909b68d87ebf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1071431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260792Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#781325}
-
Liviu Tinta authored
Adding this TRACE would make it easier to look into wheel events bugs. Bug: 1087088 Change-Id: Id90516476e6112699e8d030107f16c80a97e0773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250592Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#781324}
-
Nohemi Fernandez authored
The NewSigninArchitecture feature has been enabled by default. Bug: 971989 Change-Id: I7289a97541d239edbfc1b3b65aea04abe9c46edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260553Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#781323}
-
Miguel Casas-Sanchez authored
wip wip Add PowerMonitor::GetCurrentThermalState() Bug: 1071431 Change-Id: Id3083e06f16fd2f05e685e77ddee94e274158758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248729Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#781322}
-
Oriol Brufau authored
ListMarker::MarkerText was not checking whether the marker had 'content' set to 'normal' or something else. Therefore, in the accessibility tree, something like <style>::marker { content: "foo" }</style> <li style="list-style-type: decimal"></li> would appear as ▽ listitem ▽ ListMarker "1." text "foo" with the "1." despite 'list-style-type' being overridden by 'content'. This patch turns it into ▽ listitem ▽ ListMarker text "foo" Bug: 457718 TEST=All/DumpAccessibilityTreeTest.AccessibilityListMarkerStyles/linux Change-Id: Id022ab6dab5268101380a06936275598b225a0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255598Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#781321}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592902529-d2a08100040b803a390f39eecb31cf1400764c19.profdata to chrome-win64-master-1592909179-8c9bd637e5cbc50bd35bf53946c51dca562e57cb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I9fbb19589759012404960c28c50f7245aaca4fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260513Reviewed-by:
-
Victor Hugo Vianna Silva authored
This CL adds metrics that record, every time Chrome offers to move a password from the profile store to the account store, what was the user action that triggered the flow to be offered. Bug: 1063852 Change-Id: Ie416b1b234dbd94421ecd13125377abbe6db148e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254028 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781319}
-
