- 05 Aug, 2019 17 commits
-
-
Dominick Ng authored
Chrome's implementation of this web platform feature always requires a user gesture to trigger now. Remove the option and plumbing that passes the require_gesture boolean (which is now always set to true). TBR=mkwst@chromium.org BUG=869780 Change-Id: Iebdd435d8df3baf0996c01eda660b6074affde9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735089 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#683906}
-
Alexey Baskakov authored
This CL erases chrome/browser/extensions/bookmark_app_extension_util.cc completely. That's the last bookmark_app* prefixed file in extensions/. Cleaned up owners files. Bug: 973288 Change-Id: I1f1e094d8e64e9db75c49e4c6b7356124555810f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732170 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#683905}
-
Will Harris authored
This is causing crashes on some configurations and needs investigation. BUG=750886,990640 Change-Id: Idfdd06b219a95bed854cce9048860692ded011b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736106 Commit-Queue: Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#683904}
-
tby authored
The original CL had a potential thread safety issue, which is fixed in this CL. This also adds a sequence checker to RecurrenceRanker to ensure this is fixed. PS1 is the original CL. PS2 is the fix and sequence checker. Original CL: crrev.com/c/1725032 Bug: 931149 Change-Id: Iaa5d87d38fa6a9bd5a5605b9feb9a5fd9154d3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732269Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#683903}
-
Cici Ruan authored
When removing display or adding primary display, Chrome sent bounds based on updated display metrics, while on Wayland side, the display metrics is not updated immediately. So when converting the Chrome coordinates to Wayland coordinates, it converts to wrong position. Instead of sending global bounds, send the local bounds with display id to avoid asychronization issue between Chrome and Wayland on bounds and display metrics. There is remaining issue when ARC window in external and removing the external display. It will be fixed separately. Android side: http://ag/7326868 http://ag/7325387 http://ag/7322138 BUG=b:130897153 TEST=Printed the log to see if correct local bounds sent. Change-Id: Ifdb7644cdfcb1a96ba0ace399b8e0f32eb7a6be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593923Reviewed-by:
Mitsuru Oshima (OOO 8/5,6) <oshima@chromium.org> Auto-Submit: Cici Ruan <cuicuiruan@google.com> Commit-Queue: Cici Ruan <cuicuiruan@google.com> Cr-Commit-Position: refs/heads/master@{#683902}
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=nhiroki@chromium.org Change-Id: I57789b7eb07a5d297bcaef61c979a113252acb40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733615 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#683901}
-
Fergus Dall authored
Drag operations start asynchronously, both because applications may take time before requesting one, and because we wait to read the drag data before starting. It is therefore possible that the drag that triggered the request will be released by the user before the request starts. We avoid this in two ways. Firstly, the wayland layer of exo will reject start_drag requests that have a serial number corresponding to a mouse or touchscreen press that has been released. Secondly, if a release event occurs after a DragDropOperation is queued, but before it starts, the operation will be aborted. Bug: 927324 Change-Id: Ie84131df54f4b5a445c341b35b15d4afadf8fe3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715889 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
-
Hirokazu Honda authored
The alignment to width and height is changed by codec. The v4l2 driver returns a width and height with taking into that account. On the other hand, gbm doesn't know about codec in the allocation. This causes gbm allocates a smaller or larger buffer than a video driver expects. A small buffer is defintely problem. A larger buffer is problem if a v4l2 pixel format is single planar. If there is an extra data between planes unexpected by a driver, the driver reads the next plane from the wrong position because we cannot specify offset for each plane with a single planar pixel format. This CL resolves this issue by asking minigbm to allocate a buffer with width and size already adjusted by a video driver. Bug: 979115 Test: video_decode_accelerator_tests on kevin Change-Id: Ibe865530547055256015f9e734e31cd5ed6fbd0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730910 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#683899}
-
Joel Hockey authored
Web app windows have their toolbar inline in the titlebar. Bug: 846546 Change-Id: Ib460a6729e905b6765fc3c338932767609eadc65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732109 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#683898}
-
Eric Willigers authored
Generalize the existing HostedAppTest suite so that tests can also be run with WebAppBrowserController. Initially, a number of tests cannot use WebAppBrowserController as it does not have all the required functionality. Bug: 966290 Change-Id: Ie6b34ab1f8880ea69a53b0f4afa79a7d698b2a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732073Reviewed-by:
-
Hirokazu Honda authored
components/arc: GAVDA calls AssignPictureBuffers() in ImportBufferForPicture for the first PictureBuffer VDA needs to know a frame size adjusted by gralloc in Android side. A frame size in AssignPictureBuffers() is unknown in secure mode. We can know a frame size of a real buffer in ImportBufferForPicture(). This CL gets the frame size in ImportBufferForPicture() and calls AssignPictureBuffers() for the first PictureBuffer(). Chrome can assume ImportBufferForPicture() is called with PictureBuffer whose id is zero for the first PictureBuffer. So the current flow is, GAVDA::AssignPictureBuffers() (|assign_picture_buffers_called_| <- true) GAVDA::ImportBufferForPicture() VDA::AssignPictureBuffers() (|assign_picture_buffers_called_| <- false) VDA::ImportBufferForPicture() GAVDA::ImportBufferForPicture() VDA::ImportBufferForPicture() ... Bug: 979115 Test: video.ARCDecodeAccel* on kevin Change-Id: I5eef3638be7f9259e051a0f759f6044ddf099770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722468Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#683896}
-
Kenichi Ishibashi authored
This was a hack to ensure service worker script requests go through the browser process. This hack is no longer needed because script requests happen on the worker thread and requests happened outside the main thread are never put into MemoryCache. Bug: 990659 Change-Id: I9450309e95a3116f0d03b5beb22a2e58ed343a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735148Reviewed-by:
-
Eric Willigers authored
The Typed OM types for opacity should not include Keyword. https://drafts.csswg.org/css-color/#transparency Change-Id: I6a476f29fee622d962483aeabe40ff2e1acfb3f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734757 Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#683894}
-
Alan Cutter authored
Instead of destructing all subsystems in WebAppProvider::Shutdown() this CL has us turn down the tasks that need WebContentss and move subsystem destruction into the ~WebAppProvider() destructor. This mirrors the two phase construction of WebAppProvider and its subsystems. Bug: 877898 Change-Id: I2210504c64e8a6f8620c8926e2e20f70d1a77149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732075Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#683893}
-
François Degros authored
Combed log and error messages related to mounting and unmounting of file systems. Change-Id: I07acbdb4ccbc22aa913cb776c1d515c01a226422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732672Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#683892}
-
Yuichiro Hanada authored
Bug: 890677 Test: unit_tests --gtest_filter=ArcInputMethodManager* Change-Id: I0f2531a3e32a5f2c9f6afa499554555614135231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732675Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#683891}
-
Noel Gordon authored
This reverts commit 745a72b8. Reason for revert: Causing continuous failures on Mac Asan 64 bots in test TabMenuBridgeTest.SwappingBridgeRecreatesMenu, with heap-use-after-free from build https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/55415 through to build ... https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/55463 Example failure log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8906016600767217344/+/steps/unit_tests/0/logs/Deterministic_failure:_TabMenuBridgeTest.SwappingBridgeRecreatesMenu__status_CRASH_/0 > mac: add Tab menu > > This change adds a new top-level menu to the system menu, used to > manipulate and select tabs in the current window. This menu contains > some static items, moved from the Window menu, and then a list of > entries corresponding to open tabs in the current window. Specifically, > this change: > > 1) Adds a new class, TabMenuBridge, which binds a TabStripModel to a > NSMenu; > 2) Adds a new menu item to the main menu named "Tab"; > 3) Creates a TabMenuBridge for any tabbed browser window in the > app controller. > > The motivation for this change was twofold: first, to allow easier > access to commands that are currently only present in the tab's > context menu, and second, to allow easier access to tabs in crowded > tabstrips. The first purpose is well-defined and understood but the > second is very much experimental. > > Testing: > Build, run, and enjoy the new Tab menu :). There are some unit tests in > TabMenuBridgeTest.* as well. > > Future work: > * Renaming the static items to better fit their new context. This was > not done here to avoid breaking existing user key equivalents, which > identify items by their full name. > * Exploring other orderings of tabs in this menu. > * Adding other tab actions to this menu, like "Bookmark" or possibly > page actions. > * Adding a search bar to search within tab titles/origins? > * Adding key equivalents for the static actions (which will resolve > the actual accessibility bug this commit is for) > > Bug: 818261 > Change-Id: I790cc2c5a4468719e42b782a318864ecd81bd1f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728718 > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683682} TBR=ellyjones@chromium.org,avi@chromium.org,rsesek@chromium.org,lgrey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 818261 Change-Id: Ie6d80e1a5fbf87575824a17d00b39445629461f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735047 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#683890}
-
- 04 Aug, 2019 21 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80d451499877..f7a047eea7e8 Created with: gclient setdep -r src-internal@f7a047eea7e8 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I04d6e7ef2c71a317fa64bb77eb75dd62cfc90d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735719Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683889}
-
Noel Gordon authored
This reverts commit 8d9e0bcb. Reason for revert: ScreenUtilTest.FullscreenWindowBoundsWithChromeVox is crashing linux-chromeos-dbg. Example build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/13699 Crash log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8906215673747190784/+/steps/ash_unittests/0/logs/Deterministic_failure:_ScreenUtilTest.FullscreenWindowBoundsWithChromeVox__status_CRASH_/0 Original change's description: > [Locked Fullscreen] Fix the vox panel inconsistency with the fullscreen mode. > > > Upon entering the fullscreen/locked-fullscreen while the chromeVox panel is working, You can see an empty bar in the top of the screen. > 1. The fullscreen rect y dimension starts after the height of the chromeVox panel, and as we don't want the chromeVox panel to be displayed, its height should be removed from the calculations. > > UPDATE: This issue got fixed by another colleague. > So I added a unittest, and removed two workarounds were added to fix this issue in the locked-fullscreen mode. > (one was to disable chromevox panel upon starting the lockedscreen mode, and the other was to hide the vox panel specifically for the locked fullscreen mode) > > When a window is set to fullscreen screen_util::GetFullscreenWindowBoundsInParent & AccessibilityPanelLayoutManager::UpdateWindowBounds() are called twice with this stacktraces order: > > [23272:23272:0723/164119.757770:ERROR:screen_util.cc(47)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() > #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() > #2 0x000009a8b57c ash::screen_util::GetFullscreenWindowBoundsInParent() > #3 0x000009b93e62 ash::wm::DefaultState::UpdateBoundsFromState() > #4 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() > #5 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() > #6 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() > #7 0x000008d085f6 aura::Window::AfterPropertyChange() > #8 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() > #9 0x000008d0324c ui::PropertyHandler::SetProperty<>() > #10 0x000009268956 views::Widget::SetFullscreen() > #11 0x00000a088c28 BrowserView::ProcessFullscreen() > #12 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() > #13 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() > #14 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() > #15 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() > #16 0x000009b93fc0 ash::wm::ToggleFullScreen() > #17 0x000009b9177e ash::wm::WindowState::OnWMEvent() > #18 0x000009a153ca ash::accelerators::ToggleFullscreen() > #19 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() > #20 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() > #21 0x000009253988 ui::AcceleratorManager::Process() > #22 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() > .... > #80 0x0000eae970a2 __libc_start_main > > [23272:23272:0723/164121.271202:ERROR:accessibility_panel_layout_manager.cc(103)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() > #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() > #2 0x000009a190fa ash::AccessibilityPanelLayoutManager::UpdateWindowBounds() > #3 0x0000099ebd12 display::DisplayManager::NotifyMetricsChanged() > #4 0x0000099ebf5a display::DisplayManager::UpdateWorkAreaOfDisplay() > #5 0x000009a33610 ash::WindowTreeHostManager::UpdateWorkAreaOfDisplayNearestWindow() > #6 0x000009a94ec6 ash::ShelfLayoutManager::UpdateBoundsAndOpacity() > #7 0x000009a93680 ash::ShelfLayoutManager::SetState() > #8 0x000009a932be ash::ShelfLayoutManager::UpdateVisibilityState() > #9 0x000009b96428 ash::WorkspaceLayoutManager::SetChildBounds() > #10 0x000009b8f6e4 ash::wm::SetBoundsInScreen() > #11 0x000009276346 views::NativeWidgetAura::SetBounds() > #12 0x000009225b72 views::BubbleDialogDelegateView::SizeToContents() > #13 0x000009269980 views::Widget::OnNativeWidgetMove() > #14 0x000009276cd4 views::NativeWidgetAura::OnBoundsChanged() > #15 0x00000a0b4332 BrowserFrameAsh::OnBoundsChanged() > #16 0x000008d0978c aura::Window::OnLayerBoundsChanged() > #17 0x000008d19a6e ui::Layer::SetBoundsFromAnimation() > #18 0x000008d0730c aura::Window::SetBoundsInternal() > #19 0x000009b929a6 ash::wm::WindowState::SetBoundsDirect() > #20 0x000009b93f0e ash::wm::DefaultState::UpdateBoundsFromState() > #21 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() > #22 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() > #23 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() > #24 0x000008d085f6 aura::Window::AfterPropertyChange() > #25 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() > #26 0x000008d0324c ui::PropertyHandler::SetProperty<>() > #27 0x000009268956 views::Widget::SetFullscreen() > #28 0x00000a088c28 BrowserView::ProcessFullscreen() > #29 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() > #30 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() > #31 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() > #32 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() > #33 0x000009b93fc0 ash::wm::ToggleFullScreen() > #34 0x000009b9177e ash::wm::WindowState::OnWMEvent() > #35 0x000009a153ca ash::accelerators::ToggleFullscreen() > #36 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() > #37 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() > #38 0x000009253988 ui::AcceleratorManager::Process() > #39 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() > #40 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() > .... > #97 0x0000eae970a2 __libc_start_main > > [23272:23272:0723/164123.029099:ERROR:screen_util.cc(47)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() > #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() > #2 0x000009a8b57c ash::screen_util::GetFullscreenWindowBoundsInParent() > #3 0x000009b93764 ash::wm::DefaultState::SetMaximizedOrFullscreenBounds() > #4 0x000009b9367a ash::wm::DefaultState::HandleWorkspaceEvents() > #5 0x000009b5ac5e ash::wm::BaseState::OnWMEvent() > #6 0x000009b9177e ash::wm::WindowState::OnWMEvent() > #7 0x000009b968e6 ash::WorkspaceLayoutManager::AdjustAllWindowsBoundsForWorkAreaChange() > #8 0x000009b96af8 ash::WorkspaceLayoutManager::OnDisplayMetricsChanged() > #9 0x0000099ebd12 display::DisplayManager::NotifyMetricsChanged() > #10 0x0000099ebf5a display::DisplayManager::UpdateWorkAreaOfDisplay() > #11 0x000009a33610 ash::WindowTreeHostManager::UpdateWorkAreaOfDisplayNearestWindow() > #12 0x000009a94ec6 ash::ShelfLayoutManager::UpdateBoundsAndOpacity() > #13 0x000009a93680 ash::ShelfLayoutManager::SetState() > #14 0x000009a932be ash::ShelfLayoutManager::UpdateVisibilityState() > #15 0x000009b96428 ash::WorkspaceLayoutManager::SetChildBounds() > #16 0x000009b8f6e4 ash::wm::SetBoundsInScreen() > #17 0x000009276346 views::NativeWidgetAura::SetBounds() > #18 0x000009225b72 views::BubbleDialogDelegateView::SizeToContents() > #19 0x000009269980 views::Widget::OnNativeWidgetMove() > #20 0x000009276cd4 views::NativeWidgetAura::OnBoundsChanged() > #21 0x00000a0b4332 BrowserFrameAsh::OnBoundsChanged() > #22 0x000008d0978c aura::Window::OnLayerBoundsChanged() > #23 0x000008d19a6e ui::Layer::SetBoundsFromAnimation() > #24 0x000008d0730c aura::Window::SetBoundsInternal() > #25 0x000009b929a6 ash::wm::WindowState::SetBoundsDirect() > #26 0x000009b93f0e ash::wm::DefaultState::UpdateBoundsFromState() > #27 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() > #28 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() > #29 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() > #30 0x000008d085f6 aura::Window::AfterPropertyChange() > #31 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() > #32 0x000008d0324c ui::PropertyHandler::SetProperty<>() > #33 0x000009268956 views::Widget::SetFullscreen() > #34 0x00000a088c28 BrowserView::ProcessFullscreen() > #35 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() > #36 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() > #37 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() > #38 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() > #39 0x000009b93fc0 ash::wm::ToggleFullScreen() > #40 0x000009b9177e ash::wm::WindowState::OnWMEvent() > #41 0x000009a153ca ash::accelerators::ToggleFullscreen() > #42 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() > #43 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() > #44 0x000009253988 ui::AcceleratorManager::Process() > #45 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() > #46 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() > .... > #103 0x0000eae970a2 __libc_start_main > > [23272:23272:0723/164124.932334:ERROR:accessibility_panel_layout_manager.cc(103)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() > #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() > #2 0x000009a190fa ash::AccessibilityPanelLayoutManager::UpdateWindowBounds() > #3 0x000009ab0dea ash::Shell::NotifyFullscreenStateChanged() > #4 0x000009b96a4c ash::WorkspaceLayoutManager::OnPostWindowStateTypeChange() > #5 0x000009b92738 ash::wm::WindowState::NotifyPostStateTypeChange() > #6 0x000009b93ddc ash::wm::DefaultState::EnterToNextState() > #7 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() > #8 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() > #9 0x000008d085f6 aura::Window::AfterPropertyChange() > #10 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() > #11 0x000008d0324c ui::PropertyHandler::SetProperty<>() > #12 0x000009268956 views::Widget::SetFullscreen() > #13 0x00000a088c28 BrowserView::ProcessFullscreen() > #14 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() > #15 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() > #16 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() > #17 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() > #18 0x000009b93fc0 ash::wm::ToggleFullScreen() > #19 0x000009b9177e ash::wm::WindowState::OnWMEvent() > #20 0x000009a153ca ash::accelerators::ToggleFullscreen() > #21 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() > #22 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() > #23 0x000009253988 ui::AcceleratorManager::Process() > #24 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() > #25 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() > ... > #82 0x0000eae970a2 __libc_start_main > > Bug: 945794,959786 > Change-Id: If04f70f2c71563e9660c18ca942ef4b798ebcd3a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702312 > Commit-Queue: Aya Elsayed <ayaelattar@google.com> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Ivan Šandrk <isandrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683631} TBR=oshima@chromium.org,dtseng@chromium.org,isandrk@chromium.org,agawronska@chromium.org,ayaelattar@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 945794, 959786 Change-Id: Iff0e849ffbba12b8a36079c2ba484e9285d75780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735720Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Icc0fc18b7a7175fce4df4a1542db285f4d7d196c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735786Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683887}
-
Mike Reed authored
Change-Id: I76cdaa8506ce43e38f15e835cb5c14aa5d4bcea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734746Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#683886}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c57be980429..80d451499877 Created with: gclient setdep -r src-internal@80d451499877 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I44f5bc402ed0d9a15a50c453258f293a9c668a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735767Reviewed-by:
-
Stephen Chenney authored
TBR: fmalita@chromium.org Bug: 831183 Change-Id: Ieecb1a075022c212999f0f2306360a7eca745f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734756Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9728153c447f..5861c8614d48 git log 9728153c447f..5861c8614d48 --date=short --no-merges --format='%ad %ae %s' 2019-08-04 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@5861c8614d48 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I8d6547eaffe7ff898a000fde7bf831cb316927ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735766Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d24cebce9e2f..4c57be980429 Created with: gclient setdep -r src-internal@4c57be980429 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I31f23ba295658877ffd0795c798ca7978263e3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735726Reviewed-by:
-
Koji Ishii authored
This patch fixes PDI/PDF before spaces not to suppress the line breaking opportunity at the space. For example, before this fix, `<bdo dir=ltr>a</bdo> b` could not break between "a" and "b". PDI and PDF are injected by the `unicode-bidi` property, or elements that imply the `unicode-bidi` property such as `<bdi>`, `<bdo>`, or any elements with `dir` attributes. Bug: 989094 Change-Id: I2128774e2b062ecb86880812c54d46299a19a18a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735146 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#683881}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I00403ea7740165cf3ca33a35f808f86f65cab969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735547Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/622aa55d5207..d24cebce9e2f Created with: gclient setdep -r src-internal@d24cebce9e2f The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id5bbc22fe3a1a097d61123491065c7a3c7484d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734974Reviewed-by:
-
Javier Ernesto Flores Robles authored
Renders the background image as a template and tints it with the right color. Cleans up @synthesize instructions. Bug: 976682 Change-Id: Icfb3e4d7b3382c69855d2cf572e10b81a7051514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732087Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#683878}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/20f9bbcd1f02..622aa55d5207 Created with: gclient setdep -r src-internal@622aa55d5207 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia2ea8d0057c78a867c2938802d44cf2a726c08cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734972Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cdd524c5012c..ced601b40b37 git log cdd524c5012c..ced601b40b37 --date=short --no-merges --format='%ad %ae %s' 2019-08-04 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@ced601b40b37 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: None Change-Id: Iff31d1af07b3a91ce25c05f13a618c49dbc5b590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734973Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8e83c857f6b4..9728153c447f git log 8e83c857f6b4..9728153c447f --date=short --no-merges --format='%ad %ae %s' 2019-08-04 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@9728153c447f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I57d73c1bf135f0416eea1f6be18753a01eb8b6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735210Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I70deb4ae32a7834c53f0ba33df1945186aa53c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735208Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/babf84897873..cdd524c5012c git log babf84897873..cdd524c5012c --date=short --no-merges --format='%ad %ae %s' 2019-08-04 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@cdd524c5012c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: None Change-Id: Id5731cf0317f0bf55392605fbaf2fee11cc5a248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735207Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87bfa76af8f1..20f9bbcd1f02 Created with: gclient setdep -r src-internal@20f9bbcd1f02 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id181dac1023d9a1104600bb25a74ef968e0d6209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735206Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I533d69851a093cb0d70674e6b3ba4ce22d7bf215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734750Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683871}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eeb59b3995f0..87bfa76af8f1 Created with: gclient setdep -r src-internal@87bfa76af8f1 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia98c477045890f3731a3985100750c9e1f728e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734812Reviewed-by:
-
Yuly Novikov authored
TBR=kbr Bug: 988833 Change-Id: Ifdd007e7fc3bfb84375d61c62e56dc0602f60357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734023Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#683869}
-
- 03 Aug, 2019 2 commits
-
-
Justin Cohen authored
Bug: 989618 Change-Id: Ie826531bc0e891bcea5524cdecdc662692d0e2de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732350 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#683868}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f09b6e5dd5a8..eeb59b3995f0 Created with: gclient setdep -r src-internal@eeb59b3995f0 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I29e4e1c8dbb0b1acac95b8964e3cca556de1bec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734969Reviewed-by:
-
