- 27 Apr, 2020 31 commits
-
-
Koji Ishii authored
This patch moves all functions that: a. Do not need text, and b. Do not need root/range. to |NGInlineCursorPosition|. This patch has no behavior changes. Bug: 982194 Change-Id: If6fdb5984ad6f96557cca4bef9ae21aa2932c08f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167640Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#762733}
-
John Z Wu authored
Translation are normally offered automatically if the translate internals thinks translation is necessary according to page language and the user's settings. But in cases where the user still wants to translate, this method can be used to manually trigger translation offers. Change-Id: I4f71ed0142a3fec6438b883c87b514c0749a8acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163036 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#762732}
-
Yoshifumi Inoue authored
This patch gets rid of unused enum member |NGOffsetMappingUnitType::kExpanded| for improving code health. Change-Id: I13331a6974e30e6b7b583be2cee1d1989b003ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167637 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762731}
-
Fergal Daly authored
Change-Id: I9e31d6465e4f4cd710611ffea990ded46ee6bb1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154625Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#762730}
-
Christopher Lam authored
This CL plugs cros_colors.json5 into the AshColorProvider by generating a C++ header that maps color names to their final values at compile time. Bug: 1018654 Change-Id: I52f21e859be704504ce430b5d558c96b60b1fb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154350 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#762729}
-
Eric Willigers authored
In unit tests, WebApps::Connect() would previously never lead to never signaled it was ready. WebApps: :StartPublishingWebApps() being called as the web app provider Change-Id: Iadc02947ecca2dd29d74fef91a83279733537bea Bug: 1074111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162433 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#762728}
-
Kramer Ge authored
video_encode_accelerator_unittest failed under OzoneDrmMojo. ui/ozone/public/ozone_gpu_test_helper needs to be changed to binding mojo endpoints instead of forwarding IPC messages. Bug: 620927,806092 Change-Id: I9399eff2f1a681f82feb5e027af76a8fb8712d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163408 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#762727}
-
Sasidhar Sanapala authored
https://screenshot.googleplex.com/hGiyMOp7FLA R=wrlewis@google.com Change-Id: I29c8907d760be6e0332638c29917624c41df5a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147633Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Sasidhar Sanapala <ssanapala@google.com> Cr-Commit-Position: refs/heads/master@{#762726}
-
Johann authored
Pass EC in instead of the task runner. Puts the task type in the dispatcher class instead of the calling class. Dropped std::move: error: moving a temporary object prevents copy elision Also paves the way for some new objects which will need the execution context. Change-Id: Id0608ccf129443532091e7bdfe0afccb146172ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152134Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#762725}
-
Ramin Halavati authored
Extra IsSameProfile is removed from ChromeExtensionsBrowserClient and a browser test is added to ensure it's working as expected. Bug: 1033903, 727487 Change-Id: I7245f8b9491582674a1428d0f09500e4e443ba39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164627Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#762724}
-
Koji Ishii authored
This is a left over from r762697 <crrev.com/c/2166202>. This patch has no behavior changes. 982194, 1035773 Change-Id: I3b094e02b840c0f7bf36abaeb2ac38c8748abb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167635 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
Implement WebAppInstallObserver::SetWebAppInstalledDelegate. It will be used with lambdas in sync tests. Bug: 1020037 Change-Id: I01f5a60bd24f3b74dd52d62f3d7d61bdf477d929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162401 Auto-Submit: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#762722}
-
Yutaka Hirano authored
On Windows the function requires system fonts to be "Segoe UI", which is overly restrictive when we are not interested in layout. Bug: 1074776 Change-Id: I8ac77928c0049eec67b7f0944872f3b5cc2b96b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166232Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#762721}
-
Yuki Shiino authored
This reverts commit 7de90169. Reason for revert: Suspicious to have broken DomDistillerViewerSourceBrowserTest.UISetsPrefs in browser_tests. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/37476 Original change's description: > Refactor Reader Mode's JavaScript tests to use Mocha. > > The tests did not previously use an established test framework, making > tasks like executing certain code before or after every test and testing > asynchronous code more difficult. It should also be easier for > developers familiar with JavaScript testing in general and WebUI testing > in particular to read and write JavaScript tests for DOM Distiller and > Reader Mode. > > Follow-up work includes replacing the custom assert methods with Chai, > as well as writing more tests to cover existing functionality. > > Bug: 1027612 > Change-Id: I39acc923a0424881d2694281d9aa0323c8f9a913 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992504 > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Aran Gilman <gilmanmh@google.com> > Cr-Commit-Position: refs/heads/master@{#762551} TBR=wychen@chromium.org,gilmanmh@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1027612 Change-Id: I78b6b82e98c8f47951ab88e2056595de878f1ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166219Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#762720}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: Id199e13d0bff53e3fb4836d92fb72e61e7097091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167419Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762719}
-
Hiroshi Ichikawa authored
It is now implemented as a proxy object (CRWWebViewScrollViewProxy) which pretends itself to be a UIScrollView, instead of CWVScrollView. Define CWVWebView.legacyScrollView to allow to fall back to the original implementation in runtime temporarily. Change-Id: I2993ab2ccf78de09412c9f607a74165fea8eae2f Bug: 1023250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137201 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Auto-Submit: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#762718}
-
Dean Michael Berris authored
Improve layout of the documentation in the README file. R=johnchen@chromium.org, wenbinzhang@google.com Change-Id: I7f8303ca5a68f78a7b971999463264eb3abd7f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160667Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Dean Berris <dberris@chromium.org> Cr-Commit-Position: refs/heads/master@{#762717}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ife6b456c97b5e9f4a8b96cd441e5fb03cb3cead3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167561Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762716}
-
Alexey Baskakov authored
This reverts commit 36e05e7f. Reason for revert: https://crrev.com/c/2006282 introduced a regression: That CL implicitly (via a level of indirection) converted an OnExtensionUninstalled listener to an OnExtensionUnloaded listener. Original change's description: > WebApp: Handle OS shortcut deletion for bookmark apps in web apps land. > > Make BookmarkAppShortcutManager responsible for bookmark apps. > > Bug: 860581 > Change-Id: I683aebfd3bb321b26cf59f026436a5c78e4daac5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006282 > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733834} TBR=alancutter@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 860581, 1071810 Change-Id: I5f79361cf0a908c094a0743fa45f0b7466c551e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166215 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Auto-Submit: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#762715}
-
Hiroshi Ichikawa authored
Hold an unretained pointer to the observer instead of a weak pointer. Change-Id: I027b53f52a646af9eac02fa396cafd6fa95b2826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164366 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Auto-Submit: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#762714}
-
Yi Gu authored
The test does not seem to be flaky [1] after crrev.com/c/2138167. [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=virtual%2Fthreaded%2Fexternal%2Fwpt%2Fscroll-animations%2Ftwo-animations-attach-to-same-scroll-timeline-cancel-one.html Bug: 1060974 Change-Id: I653d199a032678ae3d33be449dc392b8f895acfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167542Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#762713}
-
Makoto Shimazu authored
I needed to add the entry for virtual/stable too. TBR=bashi@chromium.org No-Try: true Bug: 1074122 Change-Id: I4f3171ba2f47e115927a791dadf7258927400e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166216Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#762712}
-
Hiroki Sato authored
When one task contains multiple windows, AXTreeSourceArc:: BuildImportanceTable calculates importance of nodes only in the first window and other nodes are not calculated, resulting to ignore nodes in non-main window. This can be observed when the autocomplete's candidate window is appearing. Bug: b:150827488 Test: unit_tests --gtest_filter="ArcAccessibilityHelperBridgeTest.*:AXTreeSourceArcTest.*" Change-Id: Ib7fe5675568c30465bfcc470af39e2d9a9e804db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162441 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#762711}
-
Keith Lee authored
As revealed by the bugs reported in CRBUG=1070517 and CRBUG=1067382, there was a flaw in the verification of KeyEvents. The KeyEvent was verified to be valid in the chrome.input.ime.sendKeyEvents API (https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/input_method/input_method_engine.cc;l=152-157;drc=614b7ad7c64bdb05fb55b5649191b6dc442a4f01), but no verification was done to check that the input_context was not changed before processing the PendingKeyEvent in the KeyEventHandled callback. This meant that in between the calls, extensions might be able to change the context, but key events submitted before the context change would go through. This change also disables the ability for extensions to call chrome keyboard shortcuts (Eg; Ctrl-Shift-J to open Devtools), as well as the enter key. This may have been introduced in https://codereview.chromium.org/2077783002. Change-Id: I44f0bab2ca3067896a53bc3920e06eaaed582965 Bug: 1067382, 1070517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154643Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#762710}
-
Tina Wang authored
Currently SafeBrowsingEnabled and SafeBrowsingProtectionLevel should work together to handle the safety level. More context: - now the policy is handled by two prefs. - SafeBrowsingProtectionLevel will replace SafeBrowsingEnabled in the future. - iOS doesn't implement level 2 for now, but use it as a enabling real-time lookups. Bug: 1066480 Change-Id: I17f2bc70f686a4a0ffaae85803054e35d5dca9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154497 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#762709}
-
Chloe Pelling authored
This is in preparation for forwarding these preferences to Exo; see https://crrev.com/c/2131548 Bug: 1062816 Change-Id: I306b06469ba82add5828ae66e156b588abcf50b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143422 Commit-Queue: Chloe Pelling <cpelling@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Chloe Pelling <cpelling@google.com> Cr-Commit-Position: refs/heads/master@{#762708}
-
Alexander Timin authored
R=skyostil@chromium.org,shaseley@chromium.org CC=kouhei@chromium.org,haraken@chromium.org Change-Id: I93d2bcd939c41d16eac6d89f3f942daaa7f8fc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161000Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
-
Jie Jiang authored
For the device connected state change, use a separate callback for Android, and leave the existing callback for reflecting the state of BluetoothGattConnection object we hold. Also move the code for this from DeviceChanged() to DeviceConnectedStateChanged() which will be much clearer than before. This change is needed for the gatt connection management and acl_stated_changed() callback (ag/10312919) on the Android side. BUG=b:148355935 BUG=b:149658771 TEST=unit_tests --gtest_filter=ArcBluetoothBridgeTest.* Change-Id: I8cdd734c88402f61547d8dc1d0b3178d3f8c7f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053748Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Jie Jiang <jiejiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#762706}
-
Timothy Loh authored
InternalAppContextMenu was added to support a custom context menu for Plugin VM but no longer appears to be used. Change-Id: Ide138a0a22eeb1356ad723e533bbfd9f20e1aeec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164136Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I648f46a08c891aafba72231aa65c12c5e05320f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167532Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762704}
-
Chris Blume authored
Dynamic color gamut is already available behind a feature flag. But that feature flag isn't exposed on the about://flags page. This CL adds an entry to about://flags for dynamic color gamut. Bug: 955158 Change-Id: I1475af87bfffb95c391843ea975247cccdc04902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166524 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#762703}
-
- 26 Apr, 2020 9 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b6130e919d8a..1ae3e75a0b4c git log b6130e919d8a..1ae3e75a0b4c --date=short --first-parent --format='%ad %ae %s' 2020-04-26 reed@google.com Fix bug in path clipping (chopping) Created with: gclient setdep -r src/third_party/skia@1ae3e75a0b4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1070835 Tbr: ethannicholas@google.com Change-Id: Ic3939f4b2726b6b5939e57aa455dba131434e3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167523Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6e202ab7045a59f90982abf1ddaaa2fc8ee65522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167526Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/78e140f10397..36de842988ba Created with: gclient setdep -r src-internal@36de842988ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com Change-Id: Ia94f24636b30ba2847e39baee23044998c9ffd97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167383Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762700}
-
Sadrul Habib Chowdhury authored
It is possible to start new stages after a frame has been marked as 'did not produce frame'. Sometimes these reports can go on and produce frames (e.g. if the main-thread comes back late after the deadline). However, in other times, the reporters can terminate as 'did not produce frame'. For such frames, do not report the stages that started after the initial 'did not produce' notification. BUG=1074567 TBR=behdadb@chromium.org Change-Id: I4d45372d8a973247fb129c0964776179d9f009e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167174Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#762699}
-
Jan Wilken Dörrie authored
This change specializes libc++'s __unwrap_iter for base's CheckedContiguousIterator. This results in speeding up STL algorithms like std::copy, which now dispatches to a simple memmove if possible. Bug: 994174 Change-Id: I4970a7cb420a875a6f323f218448d305ab81d44b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875734Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#762698}
-
Koji Ishii authored
This patch removes |NGInlineCursor::MoveToNextSibling| because it relies on |NGFragmentItem::IsSiblingOf| which does not work well with culled inlines. |IsSiblingOf| checks sibling of |LayoutObject|, but when culled inline exists, the |LayoutObject| tree does not match the fragment tree. Existing usages were removed in r761413 crrev.com/c/2160366 and r761415 crrev.com/c/2160448 , and this patch removes the last two usages. Currently we generate |NGFragmentItem| for culled inlines since r729656 crrev.com/c/1774425 but this turned out to consume too much time to allocate memory for them. It is possible to fix it, but since replacement is easy, this patch removes it. Bug: 982194, 1035773 Change-Id: Ic98ca47dbbff53e53814430111a2a7a9699f2b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166202Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch replaces |NGPaintFragment| with |NGInlineCursor| in |LayoutInline::HitTestCulledInline|. The parent cursor needed here is available up in the call stack, plumbing is needed to pass it down. This is in preparation to support culled inline box in |NGFragmentItem|. This patch has no behavior changes. Bug: 982194 Change-Id: Ic06b4d0669ab47e01fbace9dd5071fa3806f9181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164365Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/07d424c4e530..78e140f10397 Created with: gclient setdep -r src-internal@78e140f10397 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com Change-Id: I6fb8e0d4317cf63b31019370b4158de20eda2f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167373Reviewed-by:
-
chromium-autoroll authored
Roll airmont AFDO profile from 84-4103.6-1587379457-benchmark-84.0.4118.0-r1 to 84-4103.6-1587379457-benchmark-84.0.4124.1-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ib797da0eaee9dcec050ccd0ccb1e67efb3f1e881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167249Reviewed-by:
-
