GitLab

This CL removes usage of XLookupString() that was temporarily
introduced by [1].

The issue is that the XKB keyboard map wasn't being used when XKB was
available -- the core keyboard map was always being used.  This meant
that XKB-specific features like keyboard groups and fifth-level shift
became unsupported.

This CL separates the XKB and non-XKB codepaths into 2 classes:
XkbKeyboardState and CoreKeyboardState.  This CL also moves the
keyboard-related code out of connection.cc into keyboard_state.cc.

[1] https://source.chromium.org/chromium/chromium/src/+/a2fd175c6a692351827aacd8e1285d2190ccd4e4

R=sky
BUG=1066670

Change-Id: I26023f87c396f5728ce32c0d1fb0275e0335db15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464786
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821414}

The editor should now be launched directly by tapping on the password
entry in Settings > Password.

This CL also separates the editing-specific tests from
PasswordSettingsTest.java. Only integration tests that actually rely on
PasswordSettings are left there.

Bug: 1141409, 1122310
Change-Id: Ie8d742d64e40b9881b35bf24a333d59c9b4cef02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494922
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821413}

This is required as a prerequisite for landing:
https://chromium-review.googlesource.com/c/chromium/src/+/2464786/

BUG=1066670
R=yhodique@google.com,johnwedig@google.com,dpranke@chromium.org

Change-Id: Id69ddf2b22f31d93b003a632b64f938b0ce3a55e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500268Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821412}

What:
Use a single LazyThreadPoolSequencedTaskRunner for all conversion
storage operations.

Why:
Conversion Storage doesn't have strong ordering guarantees regarding
databases being torn down and recreated for the same profile.

E.g.

Profile closed -> delete posted to task runner A
Profile opened -> create posted to task runner B

We assume that task runner A will finish executing the delete,
freeing the database prior to task runner B trying to open it. However,
if task runner A has a long running operation already sequenced, this
isn't necessarily true.

Using a unified task runner removes this edge case.

This also removes the need to do any dependency injection which is
discouraged for task runners.

Bug: 1114783
Change-Id: If09d0a9a68ec0d461321744f2734c28b0ccbe068
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490256Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821411}

This change is necessary to roll downstream GMS Core, which includes new
proguard rules added via META-INF/proguard in
google_play_services_basement_java.

Change-Id: I0883ffe043a8dae267fa2e82757996e64cefd37f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503813Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821410}

This replaces the restricted_connectivity property to a more versitale
portal_state property and enum.

Bug: 1133376
Change-Id: I2229e2675b95ceea7184bdfd773b85be12e3217d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490252
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kartik Hegde <khegde@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821409}

This CL implements 3 histograms for the phone connected screen:
  * Ash.PhoneHub.NotificationOptInEvents
  * Ash.PhoneHub.QuickActionResult.*
  * Ash.PhoneHub.TabContinuationChipClicked

BUG=1138137,1106937

Change-Id: Ic6cb37d5dd5208a09dee1249540c8f3c877be3a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491243Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821408}

A wrong transform metrix is picked when calling
AddSurfaceDamageToDamageList().

Bug: 1117235
Change-Id: Icf6529448f6973395068ee0601ec975f5c5bdb20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500311Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821407}

This CL makes startSurfaceToolbar act as if it's scrolling with start
surface. And once the omnibox is scrolled up to the top, the real search
box is pinned.
Please see this doc for more information:
http://doc/1m7MBIKFt1qPuv7grxgllAhb6Umaur_T6pwegeWHuDNI#heading=h.xcr03ehfori3

Following work needed to do:
- Add an animation for showing the toolbar container view when
  omnibox is disappearing.
- Remove the progress bar that sometimes shows. crbug.com//1136599

Bug: 1113852, 1041123
Change-Id: I7909bc2fe3caa46758c73e5a4d952ccfdec4fd96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426730
Commit-Queue: Hao Dong <spdonghao@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821406}

This fix gives assistive software a fine-grained control over selection.
In Safari this attribute is settable.

Bug: 1139106
Change-Id: Ibff2665ee0bd2db77ce692385eb7f4965f15626b
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478782
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821405}

The cleanup code was removed in r819537. This CL removes the handling of
the --cleanup command line switch.

BUG=none
R=gab@chromium.org

Change-Id: Iba5e9cd057378ccf2712f12f37589d6b84b0f7d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502161
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821404}

Bug: 1133624
Change-Id: Ifc584797d31485ef53dbc5f29cbc7f97213705bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476516
Commit-Queue: Solomon Kinard <solomonkinard@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821403}

Screen Capture on Android hasn't been updated since it was only exposed
via getUserMedia. This change:
* Adds a UI flag to enable the feature
* Expands the DCHECK to allow getDisplayMedia calls to work
* Removes a DCHECK that width/height are even
  * There was no comment for this DCHECK and if there were a technical
    limitation, it appears to have been removed.

With this change (and the flag enabled) getDisplayMedia seems to work,
at least for a simple golden-path scenario.

Bug: 487935
Change-Id: Ic340345d15798947ba22e9962d5a83a83a974a5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495823Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821402}

This CL polishes the interstitial screen including:
 - Makes progress bar the same width as the bubble.
 - Updates constants to spec.
Screenshot: https://screenshot.googleplex.com/73uEHo56GiKENdQ.png

Misc: removes unused |AddSeparator| function.

BUG=1106937,1126208

Change-Id: If44bd19b8347a0385dd0be975fd42189eb4a4a01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495977
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821401}

This CL add a new shape, round corner rectangle IPH for ChipView.
There will be a follow up CL for renaming the turnOnHighlight to
turnOnCircularHighlight and turnOnRectangularHighlight in ViewHighlighter
to unify the name in the class.

Bug: 1136169
Change-Id: I1c8efefb788942905f8142e04621b350b2c602a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500274Reviewed-by: Gang Wu <gangwu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821400}

Before allowing users to use another password, we should warn users that
they should trust the current website because of the security risk

Bug: 1137459
Change-Id: Id4d003ea1d747862041ce6a521f0f884f63df3cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476154
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821399}

Bug: b/170619368
Change-Id: Id999e5a86a548e874879714e91a13a9475cf3c1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503549
Commit-Queue: Matt Mueller <mattm@chromium.org>
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Auto-Submit: Matt Mueller <mattm@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821398}

The flag for the previous window was reset too early before the
incognito session was restored, and that caused the problem of
not migrating incognito sessions


Bug: 1139894
Change-Id: I40384b3f2051a79f18cdd0fc755cc01b402cdd2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499177
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821397}

There is a reported crash in cases where InsertPerformanceEntry is
called, so add a DCHECK to make debugging easier and determine whether
this is indeed the problem or if it's something else. Also cleanup the
method.

Bug: 1141666
Change-Id: I9d15ff62255b4830ce7abf9fd7569b15195b6524
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495343Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821396}

Bug: 1138715, 1141522, 1141524, 1141523
Change-Id: I6a41af31af14fa20a13ffe93ef99f6ba6fc44a51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488748
Commit-Queue: Elvin Hu <elvinhu@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821395}

Bug: b/171025821
Change-Id: I8cee9bdce4f72e670dfe6e34e0c77bcf59baa8de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502689Reviewed-by: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Rahul Goyal <goyalrahul@google.com>
Cr-Commit-Position: refs/heads/master@{#821394}

This change introduces a DiagnosticsUI::BindInterface specialization
for SystemDataProvider.

Bug: 1128204
Change-Id: I565ad6a77761004de132cb7ca8884d4b50db4289
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495796Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821393}

If a native page is shown as the first thing after startup it is
possible a preview will be shown. This CL avoids that scenario.

Bug: 1142856
Change-Id: Id309d58a810b0f58649dc4b11dba8398fcb8e1ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502391Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821392}

Change-Id: I0f7eac3f7af6a1763024a844d01c66a043d074a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502479
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821391}

This change replaces remaining usages of autofill::PasswordForm with
password_manager::PasswordForm in /chrome/browser and /chrome/renderer.

TBR=treib

Bug: 1067347
Change-Id: Ia168707c1cfcd084dcae921b7bc8811a2866743c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499441Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821390}

Inline action "MobileTabSwitched". All other code is to record
"Tab.RestoreUserPersistence", which is obsolete.

Bug: 1138653
Change-Id: I86b0701713a541d2d448cfb602b86c9b043ee632
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476958Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821389}

There are some of these directives being brought in
through the internal roll.

Change-Id: I9fa30dd0ab859e8f80b5bc3b203ef720afbea837
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503191Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821388}

Previously, with CL 2446353, the context menu was moved to be shown on
dragend and not drop. However, if the user moves their finger by a few
pixels but not enough for a index change, a drop event can occur before
a dragend event which finishes out the DragSession and therefore never
calls the dragend code that shows the context menu [1]. This CL
duplicates the context menu call to also happen on drop for these cases.

[1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/resources/tab_strip/drag_manager.js;l=574;drc=31eb3f4376c66b42eb4fc269025be4a8ee13e357;bpv=1

Bug: 1142608
Change-Id: Ic6daf3dfc38c945e45cf366baea7901ca645ff68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500482
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821387}

Bug: 1137474
Change-Id: I77a10b8910cb78fc1e20056b938d136a774f1e86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500942Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#821386}

This is a reland of 07c000ce

This CL fixes use of initialized memory which was detected by msan.

Original change's description:
> Fix thread checks in HangWatcher
>
> Remove the thread check that would never pass and make the variable
> that is used by multiple threads thread safe.
>
> Bug: 1142155
> Change-Id: Iae33e15733eb78a47a664515e1abec671edbb64d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495579
> Reviewed-by: François Doray <fdoray@chromium.org>
> Commit-Queue: Oliver Li <olivierli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#820817}

Bug: 1142155
Change-Id: I9b642bacbf8b801cd3a549c642c1687449edab86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502748Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821385}

Launcher has a backdrop blur filter so when there is no activity, i.e.
damage, under it, the backdrop filter cached result should be used. The
bug was caused by damage accumulation taking into account the damage
from above or on the RP with the backdrop filter.

Change-Id: Ie98f9e4d32ec9f7b955da505276def18590a623d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494060Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jun Liu <yjliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821384}

This CL changes the 'gn format' call to use the full path for 'gn'.

BUG=1064277

Change-Id: I945a453309fdb451d7ab0dd637b276f84945c74e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501128Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821383}

New baseline are from:
https://test-results.appspot.com/data/layout_results/mac-arm64-rel-tests/530/blink_web_tests/layout-test-results/results.html

Bug: 1130741
Change-Id: Ib1e249e5cdfd9a7e4a18a74f804af40d8ea069ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486992Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#821382}

ScopedServicePublisher and ScopedSingleClientServiceBinding were
updated to allow the service name to be specified explicitly, but
ScopedServiceBinding was missed.  Add the missing functionality
to the ScopedServiceBinding template.

Bug: b/171256428
Test: locally tested and pass unit tests
Change-Id: I0623256895da020eaf3a423e28f72936cf843994
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499625Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Hai Bi <bihai@google.com>
Cr-Commit-Position: refs/heads/master@{#821381}

Updates the expires_after attribute for 20 histograms that have
been used to generate alerts in the past 90 days and do not already have
a date later than or within 60 days of 2021-01-25.

TBR=chromium-metrics-reviews@google.com

Change-Id: I9c5e0d4b1a9ff375429baa6a4f976c67f3e5bea6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503229Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Cr-Commit-Position: refs/heads/master@{#821380}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
TBR=chrome-os-gardeners@google.com

Change-Id: I059347137696bd52d27dbe04149f5f0da04dbf3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502775Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821379}

Android task runner posts Runnable tasks and the tasks are run by native
task runner. All these tasks are recorded with posted location as
post_task_android.cc. To track the correct posted location, this cl adds
new trace events to track the runnable class name.
Note that we still track the wrapper task runner in some cases like
ChainedTasks and AsyncTask$NamedFutureTask, which needs to be fixed.

BUG=1136635

Change-Id: I97b35b003ce7d5571ce4a44c54127da74400cf1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480715
Commit-Queue: ssid <ssid@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821378}

Add new attribute fontVariantCaps to canvas context 2d. Developers can
choose between normal, small-caps, all-small-caps, petite-caps,
all-petite-caps, inicase and tiling-caps.

Bug: 1141671

Change-Id: I5d047f00773f4f2a38eb25c21e13168a316c29d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490789Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821377}

Change-Id: I303149a39f40702d6600fa7409f7cfc03146eb65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500429
Commit-Queue: Nate Chapin <japhet@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821376}

This reverts commit 89540fb3.

Reason for revert: Causing all desktop builds to fail on perf waterfall (crbug.com/1142930)

Original change's description:
> Remove SpawnedTestServer from BrowserTestBase.
>
> The last browser tests using the built-in SpawnedTestServer have
> finally been migrated the EmbeddedTestServer, so nothing is using it.
> This also helps reduce visibility of the SpawnedTestServer, so makes
> accidental use of it harder.
>
> This CL also fixes a bunch of IWYU issues that the removal unearthed.
>
> Bug: 492672
> Change-Id: If2358789b250c62886c352c466cd2ad5c2d6a0d5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495401
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#821288}

TBR=jam@chromium.org,mmenke@chromium.org

Change-Id: Id5e778839d034d0d3c2e7e94241da5e370d1777d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 492672, 1142930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503315Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821375}