- 27 Nov, 2019 40 commits
-
-
David Jean authored
This is a reland of c273c91d Original change's description: > [ios] Move password settings tests to EG2 > > Bug: 987646 > Change-Id: I9e21ec812293136797b80af8c4b189331941a111 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903363 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: David Jean <djean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715258} Bug: 987646 Change-Id: I9bdce59f16eb10493b69f43133bd2316396c51e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917218 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#719606}
-
Alex Turner authored
Improves histogram documentation by adding note warning that sums may substantially differ from the true value due to per-sample rounding. For example, if many tiny resources are loaded, each sample will have a recorded size of 0 KB. The error between the sum of these and the true value will thus accumulate. Change-Id: I5c72b770ed4ad3e9649666d31e64d1e0a68e7924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937772Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#719605}
-
Bret Sepulveda authored
This patch moves PermissionsBubbleDialogDelegateView out of permission_prompt_impl.cc, renames it to PermissionPromptBubbleView, changes most methods on PermissionPromptImpl to delegate to the bubble class instead of manipulating it directly, and rewrites the bubble code to be more idiomatic. This patch also deletes permission_prompt_impl_views.cc and moves the function inside it to permission_prompt_impl.cc, since the latter is now much simpler. Bug: 1019129 Change-Id: I21293657d020cddb61c992b8c34ea90b1b6023de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890337 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#719604}
-
Ioana Pandele authored
The icon is set to appear above all the items in the dialog when enough space to display the image is available and next to the title, when there isn't enough space. There are screenshots at https://crbug.com/1028095#c24 Bug: 1028095 Change-Id: I4e0b363ccea48ecf9588dc5764a61ef7f330639e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937175 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#719603}
-
Mikel Astiz authored
https://chromium-review.googlesource.com/c/chromium/src/+/1886898 has recently switched to reading favicons on demand from a dedicated server, so the traffic caused by sync-ing history favicons can be spared. This patch achieves so by enabling an existing feature toggle. One additional aspect is addressed, overlooked previously in https://chromium-review.googlesource.com/c/chromium/src/+/1653428: the local copy of favicons as persisted by sync (pseudo-USS) must be cleaned up to avoid indefinitely leaking such data locally. Bug: 978775 Change-Id: I7bf0c8d05348b5399cd3c5bc9f8675cd013d600e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917173 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#719602}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fff69a79f984..d1cfda327db2 git log fff69a79f984..d1cfda327db2 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 tvanderlippe@chromium.org Migrate text_editor/ and cm_web_modes/ to ESM 2019-11-27 liviurau@chromium.org [devtools] Whitespace to test devtools recipe 2019-11-27 aerotwist@chromium.org Migrates layer_viewer/ to esm Created with: gclient setdep -r src/third_party/devtools-frontend/src@d1cfda327db2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1018837,chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I06e0c39403f8f8c3871b6cd2458eb27118832f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940290Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719601}
-
Akihiro Ota authored
This change fixes a bug where single letters that appeared after numbers get replaced by units. In the example listed in the bug report, text such as "Join the 5g Network" would get announced as "Join the 5 grams Network". To prevent this behavior, we look for the pattern [number + single letter] and capitalize the letter; this prevents the TTS engine from replacing the letter with units. Bug: 1005933 Change-Id: Ic5251926d7e78796d4de45632dd817e9a0ac7f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930690Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#719600}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b1ccae253e0b..9f9e20a3dc68 git log b1ccae253e0b..9f9e20a3dc68 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 mbonadei@webrtc.org Fix errorprone issues preventing Chromium Roll. 2019-11-27 phoglund@webrtc.org Turn off Goma for Linux GCC. 2019-11-27 peah@webrtc.org Corrected the aggregation of AGC choices and add fallback solution 2019-11-27 peah@webrtc.org Adding parametrization of the AEC3 howling mitigation behavior 2019-11-27 jonaso@webrtc.org make Connection::port() protected Created with: gclient setdep -r src/third_party/webrtc@9f9e20a3dc68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:None,chromium:b/145243047 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7dcc90277b8e4dfb32f43af4e04e92e903883da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940289Reviewed-by:
-
Chris Sharp authored
This reverts commit 4acb3251. Reason for revert: Tests are very flaky on linux-chromeos-dbg. See crbug.com/1029019 Original change's description: > [directorytree] Add a keyboard horizontal scroll test > > CL:1924341 limited the horizontal scroll of the directorytree to 0, to > resolve issue 1025581, and needs a test of this behavior. > > Test: create a nested set of test folders, and use keyboard arrow-left > (provided by expandSelectedFolderInTree, note) to navigate to the last > of those folders. Post navigation, verify the navigation, and that the > directory tree is not horizontally scrolled. > > This new test passes with CL:1924341, and fails before that CL (good). > The CL used requestAnimationFrame (rAF) to limit the scroll. Add async > test rAF helper and call it to ensure the scroll rAF is done, and that > expandSelectedFolderInTree events have been processed. > > Test: browser_tests --gtest_filter="*TreeKeyboardHorizontalScroll*" > Bug: 1025581 > Change-Id: Iff79b963559d282841f1d2045aadcee7e5840cea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936579 > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Alex Danilo <adanilo@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719411} TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org Change-Id: I8a9957779fd6fddc8f53f45cb6118bcfa10b2360 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1025581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940507Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#719598}
-
Yuki Shiino authored
Implements attribute get callback; [CachedAttribute], [SaveSameObject], [CheckSecurity=ReturnValue] Bug: 839389 Change-Id: I1982e5aee40d4800c870e15c5d83b702bcb5945a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940308 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#719597}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ia31c0b27ee034e697551d170a961b131cf8415e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939989Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGLinearGradientElement> as new downcast helper 2. Use IsA<SVGLinearGradientElement>(element) in place of IsSVGLinearGradientElement(element) Bug: 891908 Change-Id: I3f775ab96a3fab152b797aa29d9f7db3ae962b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936609Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#719595}
-
Hans Wennborg authored
CLANG_SVN_REVISION is prefixed with an 'n' these days, e.g. 'n331734'. Bug: 1015315 Change-Id: I6ed404f230be71f745f7febab10a222f8d6c6cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939973Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#719594}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I5da0e1c07c06f17ff9c40ec8ba9fac55b540f875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939083Reviewed-by:
-
Guillaume Jenkins authored
The Spelling Service ("Enhanced Spell Check") was migrated from a JSON-RPC endpoint to a REST endpoint. This migration was rolled out as a finch experiment to ensure nothing had regressed. Now that everything has been working well for a few months, it's time to clean up everything related to the Finch experiment and the old JSON-RPC endpoint. Metrics about the new endpoint: https://uma.googleplex.com/histograms?sid=53ae9a4522ca75cb8f945bf4422baafe Migration bug: https://bugs.chromium.org/p/chromium/issues/detail?id=943108 Migration mini design doc: https://docs.google.com/document/d/1tmqz3QTF-lhbbkBxqOSYMdNZ-OOhlMIhb8hczhbZVhQ Bug: 943108 Change-Id: If46ffbbbdf956f7ed7000ade6c3bd9c5252361f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932095Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#719592}
-
Alexander Timin authored
Restarting navigations synchronously is problematic because we might be in a middle of starting a different navigation and restart is going to be harmful: post a task instead to be able to reason what's on top of the stack. R=alexmos@chromium.org,arthursonzogni@chromium.org BUG=1017594 Change-Id: I2198a4497c960a0903837604f9f20099475d92e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929246 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#719591}
-
Eric Seckler authored
Our webview startup benchmark gets confused if we export to atrace, because it is tracing both via atrace and chrome. If we export correctly to atrace, we end up with duplicate events in chrome. Before my recent begin/end split patch, we only exported END events to atrace, which were pretty meaningless on their own. This patch essentially restores the behavior prior to my patch by not exporting any events to atrace when perfetto tracing is enabled. Long term, we have to figure out how to prevent the duplicate events in our benchmarks. Bug: 1028882 Change-Id: If2595ad4d7f46c37a7bbc464d7fd71ad129d0923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939748 Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#719590}
-
David Jean authored
Bug: 1023605 Change-Id: Idaf448e616a9ba1a0820c7f335595d8ae2d1fb35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917166Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#719589}
-
Monica Basta authored
There is a bug in the new user menu that is the profiles in the other people list is not sorted alphatecially by name. This CL fixes the bug by retrieving the profile attributes entry sorted by name. Bug: 1027809 Change-Id: I4355b35baacc2f374ab3f82e9ee5807db14b468b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940274Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#719588}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/781bb85e9698..27d3c9399925 git log 781bb85e9698..27d3c9399925 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 jmadill@chromium.org Revert "Vulkan: Accelerate Texture PBO updates" Created with: gclient setdep -r src/third_party/angle@27d3c9399925 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1027098 Tbr: cwallez@google.com Change-Id: I353a3d7142fb0513c504adc6dd70c14a386fe9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940076Reviewed-by:
-
Tommy Steimel authored
This CL updates the auto-dismiss logic to only count click-to-tabs as interactions instead of counting when the tab is focused by any means. The only reason we had it that way was to accommodate the "pre-refactor" world where it wasn't feasible to always detect the difference. Bug: 1026079 Change-Id: I8806f64ade7019716413ef54c07693574f192dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937141Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719586}
-
Robbie Gibson authored
The root cause is that, because CALayer uses CGColors, which don't support the whole dynamic color infrastructure, we have to manually set these colors to the correct version in -traitCollectionDidChange. However, CALayer automatically animates any change to these properties. This means that when the color mode changes, the rest of the colors update immediately, but the layer's colors animate to the correct color over the next ~0.5 seconds. To fix this, we can use CATransaction and setDisableActions to disable the automatic animation. Fixed: 1028091 Change-Id: Id217c5387bffc77a5a971aac0e43198a1ffa8200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940328Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#719585}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2a8799ff0874..03e4c95c31e6 git log 2a8799ff0874..03e4c95c31e6 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 robertphillips@google.com Move creation of GrProgramDesc to GrCaps-derived classes Created with: gclient setdep -r src/third_party/skia@03e4c95c31e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I5a86702fd33d4a7cfe9e300e32415c8c1cb19912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940075Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fec12b8a43a1..66a99b6dabab git log fec12b8a43a1..66a99b6dabab --date=short --first-parent --format='%ad %ae %s' 2019-11-27 dberris@chromium.org Fix commit queue config Created with: gclient setdep -r src/third_party/catapult@66a99b6dabab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:985223 Tbr: rmhasan@google.com Change-Id: Ib20a7bebe43c571f6bfaf152c4f344b6ca650ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940077Reviewed-by:
-
Tim van der Lippe authored
Follow-up on crrev.com/c/chromium/src/+/1939791 Bug: 1006759 Change-Id: Ia4932f78b0190732c79d1bdf3112a798dfbe9f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940272 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#719582}
-
Dominique Fauteux-Chapleau authored
Change-Id: Ic4ef01d8a4e07a41253e36b2ea5e9086db81765f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937648 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#719581}
-
Nico Weber authored
Except on Windows for now, https://github.com/KhronosGroup/Vulkan-Loader/commit/6eb61431a4217b3eef75e59b1c70e25fc37b8064#r36147738 Bug: 1002945 Change-Id: Ia9d1c2fd17bf488c69217266cb0c85f59788f03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937654 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#719580}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3d8cdc0a. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 8a0ae33c "Add `Sec-Fetch-Dest: empty` header for application cache." 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I9747e3e2b756f6301e9d315c235f4f4e313a1e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940127Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719579}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d21964d6..6b5843d2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8aea7999d38e3c2699736a0f720d220a47871a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939735Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719578}
-
sczs authored
- Also creates the ConfirmInfoBarController directly on crash_restore_helper since using CreateConfirmInfoBar would also create a Message infobar if the ConfirmInfobar as Messages flag is on. Bug: 1028951 Change-Id: I81fec50e851ed830c49e8306994c0f836d2c8efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939492Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#719577}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/35e1a0ce9060..a64e0786130f Created with: gclient setdep -r src-internal@a64e0786130f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ia5b80a9b9afbe99104f97ace7c88304f64629ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940068Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719576}
-
Jeremy Apthorp authored
This caused build failures for Electron, which builds with MSSTL Change-Id: I5b21d27eb02523e975957befd50bf958a6fa6a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938028 Auto-Submit: Jeremy Apthorp <jeremya@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#719575}
-
Juan Antonio Navarro Perez authored
TBR=twellington@chromium.org Bug: 979189 Change-Id: I4ffc83b13f01d032bbfe5d4be75362bff5d76559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940109Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#719574}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e14cb994086d..b1ccae253e0b git log e14cb994086d..b1ccae253e0b --date=short --first-parent --format='%ad %ae %s' 2019-11-27 sprang@webrtc.org Reland "Fixes dynamic mode pacing issues." 2019-11-27 danilchap@webrtc.org Add VideoCodecType::kVideoCodecAV1 value Created with: gclient setdep -r src/third_party/webrtc@b1ccae253e0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I982644bb2293420496481c445b9b38188bcba223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940070Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ca29ecd5c79b..5b6f642d9c3b git log ca29ecd5c79b..5b6f642d9c3b --date=short --first-parent --format='%ad %ae %s' 2019-11-27 treehugger-gerrit@google.com Merge "Switch TRACE_EVENT to something that is only one line of code." Created with: gclient setdep -r src/third_party/perfetto@5b6f642d9c3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id75eca01d57f5272752d1422115105019645f942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940071Reviewed-by:
-
Tim van der Lippe authored
In https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1934218 we are adding an extra module to these panels. Disable the test for now to land the front_end CL. Once DevTools is rolled into Chromium, the test expectation will be updated and the test will be re-enabled. Bug: 1006759 Change-Id: I7dd5393a884d9f4559d8b7f53d5dc7472a4cea76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940327 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#719571}
-
Anastasiia Nikolaienko authored
Block propagation of secondary accounts to ARC for Child users. Bug: 1017160 Change-Id: I7530ecb07a58b686d0dedb1367ffa1ab543e7a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904074 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719570}
-
Michael van Ouwerkerk authored
Also, use our own constant so that the limit does not get raised again without us knowing in the future. The in-memory limit was recently raised to 5MB: https://chromium-review.googlesource.com/c/chromium/src/+/1866194 Bug: 1018138 Change-Id: I2ce729203fe418d6eca8a0145d2df36be6c4bc92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939707 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#719569}
-
Koji Ishii authored
Hit-testing requires traversing siblings in the reverse order, which is not easy for either |NGPaintFragment| nor |NGFragmentItem|. Currently |NGBoxFragmentPainter| copies all siblings to a list and iterate the list in the reverse order. This is not very efficient, but hit-testing is the only user today, and seems to be fast enough. In order to abstract the operation, this patch adds |NGInlineBackwardCursor|. This is a separate class, to avoid increasing stack size for every use of |NGInlineCursor|. We may revisit this if more users appear. Bug: 982194 Change-Id: Ie07564dccbcfc3ff7222392fc6f483c95e0579eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939152Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#719568}
-
Tim van der Lippe authored
These tests contain race-conditions in the way that CodeMirror is booted up. When making cm_modes/ an ES module [1] these tests started to fail. Closer inspection showed that there are numerous Promises not being awaited, which causes the test to eagerly resume execution. Note however that in the real application, the race-condition is WAI and does not cause any issues. It is only in the synthetic testing environment that this issue occurs. After the ES modules migration, we will refactor the classes to properly handle Promises and enable the test again. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1928924 Bug: 1006759 Change-Id: Ic213897def208c148034632627924f31c012cca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939791 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
-
