- 30 Aug, 2019 40 commits
-
-
Sigurdur Asgeirsson authored
As-is, a late UserMessageReadAckEvent will call Delegate::PortStatusChanged with an invalid PortRef. Change-Id: I9f089df40692fc2c39c2de035b6890a1d2995e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779183 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#692213}
-
Kyle Horimoto authored
Before this CL, clicking on a non-connectable Cellular network in the mobile subpage would result in no action except for some UI jank. This was due to the fact that the network cannot be configured and thus it is not possible to attempt a connection. This CL fixes this situation by navigating to the network's detail page in this situation. Bug: 947351 Change-Id: If390de1f8fd5476fbae193a9597f64dc31fa9143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777067 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#692212}
-
Alex Chau authored
- Added transparent SharedClipboardShareActivity that mimic a BottomSheet to show device list. BottomSheet cannot be used if calling acitivty is not part of Chrome. - Re-used layout of self-share device picker for UI consistency - Implemented sending and error notification in Android Bug: 996318, 996322 Change-Id: I08708e17af3422ebdb19c71f7db387cff6c8ff2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776053 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#692211}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8d7245686774..4ece96d76d9d git log 8d7245686774..4ece96d76d9d --date=short --no-merges --format='%ad %ae %s' 2019-08-30 csmartdalton@google.com Reland "Initiate MSAA resolves during DAG generation" 2019-08-30 ethannicholas@google.com .fp files now support user-defined functions 2019-08-30 ethannicholas@google.com removed dead code from SkSLPipelineStateCodeGenerator Created with: gclient setdep -r src/third_party/skia@4ece96d76d9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: Ia3275e8722a7eb71b6e8dafd2630aafa2bae4f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778631Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692210}
-
Maksim Ivanov authored
Display a big lock icon in the top-left corner of the security token PIN dialog, which is shown during the SAML user sign-in on Chrome OS when a security token (e.g., a smart card) is used. The icon corresponds to the UI mocks prepared for this dialog. Bug: 964069 Change-Id: I39afcb9d5e5776f7c1ec02ca2a0b56015f8aca05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751184 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#692209}
-
Mounir Lamouri authored
As part of the load algorithm, the video gets paused but the pause event is not fired (per spec). As a result, the video wake lock would stay around on the paused video. Emptied is fired in this case and can be used as a proxy. Bug: 980024 Change-Id: I0c6f2e14a8f3732250d339e01fe1e598bea614d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779186Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#692208}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f5980f492582..f06000e894cd git log f5980f492582..f06000e894cd --date=short --no-merges --format='%ad %ae %s' 2019-08-30 avi@chromium.org Support macOS 10.15 Catalina. 2019-08-30 bsheedy@chromium.org Revert "Reland "Reland "Support minidump symbolization on ChromeOS""" Created with: gclient setdep -r src/third_party/catapult@f06000e894cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:998877,chromium:998871,chromium:978952 Change-Id: I1b81f463284b403155eb32d290ee7b9e98e6400c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778648Reviewed-by:
-
Stefan Zager authored
For an observer with multiple observations, this avoids doing redundant work to compute the local bounds of the root and its transform to absolute coordinates. BUG=956071 Change-Id: I587997da1f5f120a1fd276f703aa1e5a1131696b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774246 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#692206}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f0033328dd22..6d684b4c7991 git log f0033328dd22..6d684b4c7991 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 swiftshader.regress@gmail.com Regres: Update test lists @ 680d3761 Created with: gclient setdep -r src/third_party/swiftshader@6d684b4c7991 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Ie198b23e1f2803e66f10cb1615c71e204b961517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778630Reviewed-by:
-
Tommy Nyquist authored
The feature_engagement component needs to be configured according to whatever experiment is being tested. The documentation for how to do this was written a while ago, and has since then become outdated. This CL updates the documentation to how things are supposed to be configured now, since there's been a couple of instances recently as to why the feature engagement does not work as expected. Bug: None Change-Id: Ibdfcb1d118dde660be8de7b59d944a641f1792f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749005 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#692204}
-
Jeevan Shikaram authored
This CL adds an uninstall button that allows a user to uninstall apps from App Management. Bug: 999431, 979531 Change-Id: Ib2e88f5e7bb7f0fac09067a38bfd139a7adf168c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777465Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#692203}
-
Stefan Zager authored
Most of the ideas for improving the performance of IntersectionObserver are contingent on processing the observations for a single observer at the same time. Prior to this patch, the processing model was: document -> element -> observation with element as target -> observation with element as target -> element -> observation with element as target -> observation with element as target With this patch, the model becomes: document -> element -> implicit-root observation with element as target -> implicit-root observation with element as target -> explicit-root observer with element as root -> observation -> observation -> explicit-root observer with element as root -> observation -> observation So, explicit-root observers will process all of their observations together. This isn't possible for implicit-root observers, because the targets of an implicit-root observer may be spread across multiple documents in multiple tabs or windows. BUG=956071 Change-Id: I72e9fe1c4a9d0e0cd37e401cbb3a40774d5589b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774244Reviewed-by: -
Fabrice de Gans-Riberi authored
* Simplify CastComponent constructor to take a single structure. * Spin-off from https://crrev.com/c/1770434 Bug: 976975 Change-Id: Icb42418bfa60e1b6f34bd3f29f1f1c29d754cf07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778915 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#692201}
-
Alex Danilo authored
Bug: 999653 Change-Id: I3c2a65fc04817a1ced86ecbd5157877a6ac07244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778883 Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Auto-Submit: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#692200}
-
Eric Stevenson authored
--sdk-version isn't currently used, but it's a bit misleading that it implies --minimal. This CL changes app_bundle_utils.GenerateBundleApks to enforce minimal to be passed for --sdk-version to work. Bug: 996362 Change-Id: I808273d92f73cd50015101da551df04d53ad6d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779008Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/864bae4cc6a2..adbecedad5e0 git log 864bae4cc6a2..adbecedad5e0 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 natlee@microsoft.com D3D12: clear nonrenderable texture formats Created with: gclient setdep -r src/third_party/dawn@adbecedad5e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ic0bf082ad06e34d6adb19ea2787f071078cc8f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778646Reviewed-by:
-
Findit authored
This reverts commit 2f2b401b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 692146 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzJmMmI0MDFiZjQwMTdjNTA3ZDgyYTNlNjUyZmFjMTMzYWY3MTk2NGQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/android-archive-rel/4128 Sample Failed Step: compile Original change's description: > Android: Make Linker.java optimized out when use_chromium_linker=false > > Two fixes: > 1) Move static getters to a separate LibraryLoaderConfig.java > * Required because of the non-trivial class initializer in > LibraryLoader preventing inlining. > 2) Change JNI proguard rules to not -keep natives when the linker > is not used. > > TBR=agrieve # Renames > > Change-Id: I0f4a40af6168cbe7243f462c24d230d277e642ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703155 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692146} Change-Id: Icfe9c719c7f1fdfa7b95acc41c98319972d50abb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779168 Cr-Commit-Position: refs/heads/master@{#692197}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/56ba54cc03f3..2c5d48a6f0e4 git log 56ba54cc03f3..2c5d48a6f0e4 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 lujc@google.com Use FramebufferID in place of GLuint handle 2019-08-30 syoussefi@chromium.org Move timer functionality from util/ to common/ 2019-08-30 syoussefi@chromium.org Vulkan: Split Vulkan docs from README.md into doc/ 2019-08-30 jmadill@chromium.org SystemInfo: Add Google VendorID. Created with: gclient setdep -r src/third_party/angle@2c5d48a6f0e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: I1ba17f206dcdf3f1bbf4869c381382591bd69292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778649Reviewed-by:
-
Erik Chen authored
On macOS, ExternalPopupMenu queued a timer event to dispatch an event to the main frame widget. This is incorrect and assumes that child frame is an in-process iframe. Instead, the event should be dispatched to the local root widget. Change-Id: I9a89496a333c6788621cca305d618900e3c4be88 Bug: 995981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775600 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#692195}
-
Antonio Gomes authored
PostCrossThreadTask() (and FWIW PostDelayedCrossThreadTask too) are thin wrapper to //base's equivalent in //base/task_runner.h. The goal is to ensure CrossThreadXXX is used when binding the functors. However, the wrappers miss the boolean return type of their //base equivalent. The limination makes switching some code from using base::Bind to use WTF::Bind if not impossible, at least not straightforward. eg.: 484 bool RTCVideoDecoderAdapter::ReinitializeSync( 485 const media::VideoDecoderConfig& config) { 486 DCHECK_CALLED_ON_VALID_SEQUENCE(decoding_sequence_checker_); 487 (...) 499 if (media_task_runner_->PostTask( 500 FROM_HERE, base::BindOnce(&RTCVideoDecoderAdapter::FlushOnMediaThread, 501 weak_this_, std::move(flush_success_cb), 502 std::move(flush_fail_cb)))) { 503 waiter.Wait(); 504 } ... in //third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_adapter.cc. This CL pairs up both wrapper and wrapped behavior, so it unblocks the migration. BUG=787254 R=haraken@chromium.org Change-Id: I518bdd03496f58ffcd36906e19dfc5c4112a493d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778663 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#692194}
-
Gavin Williams authored
-Set a specific dialog width because the default cr-dialog width is too large -Reduced padding to bring the elements closer together Bug: 985108 Change-Id: I0b4f9a958b88a43669dcabceefbc9e9eb3a632da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775219Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#692193}
-
Dominik Röttsches authored
The Windows 7 bot does currently not efficiently cache the font lookup table for layout tests because a cache directory is not configured. Also, Win7 layout tests failed with DCHECKs when a path was not configured. Disable FontSrcLocalMatching on Windows until this is properly addressed. Bug: 996027, 996167 Change-Id: Iaa21ab1a32cda73d8f7e3a2e6bd803c132105781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778491Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#692192}
-
Jamie Madill authored
No longer needed for any integration. Bug: angleproject:3320 Change-Id: Ie963ab28f9c9f05f57629fb78d5e1bdae6aa061b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779066 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#692191}
-
manuk authored
The triage readme includes a link to bugs.chromium.org filtered to omnibox related but -component:UI>Browser>Omnibox issues. It mentions the view can optionally be filtered to the last week. This CL adds a link filtered to the last 2 weeks. Bug: 871898 Change-Id: Ic7d0d5175fb40e5b7d384c36a4e60768ba815c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779065Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#692190}
-
Tommy Li authored
Works great on my desktop. Needs further testing though. Making this flag available on Desktop. Bug: 925072 Change-Id: I77ced4f1b72694db389ba528b9f1d3cd648bd58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775221Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#692189}
-
Ella Ge authored
This CL makes VariationsFieldTrialCreator::GetShortHardwareClass return base::SysInfo::HardwareModelName() so that we can use hardware class on Android in finch config. Bug: 999341 Change-Id: I4f33a07739005c7cd369a5eb5820725547b767a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776980 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#692188}
-
Xing Liu authored
DexLoaderTest#testLoadFromLocalDataDir is failing on Android O builder. TBR=hanxi@chromium.org Bug: 999363 Change-Id: Ied3e88b74580ab2395e31c651eba0643bb0290ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779063 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692187}
-
Tommy Li authored
These histograms are not being removed, but instead just being moved to the internal histograms.xml file. See: cl/266207076 Change-Id: I5d538d0babeb1e9cc97098be562aef5c25b57a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776591 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#692186}
-
John Budorick authored
Bug: 990885 Change-Id: I84a117cab1873469ad56115d955393f1111c7f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779221 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#692185}
-
Antonio Gomes authored
All its clients have been Onion soup'ed. BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ibbef921caf036d9224de6195371b700057193add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778661 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Sonny Sasaka authored
This reverts commit 4e060f87. Reason for revert: Breaks connection with LE device, for example LE keyboard. Original change's description: > [Bluetooth] Enable by default peripheral battery UI indication. > > Bug: 785758 > Change-Id: I35f3270d0b61b8f0e3e3bde6d64f5b1c54f1a254 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752913 > Commit-Queue: Ryan Hansberry <hansberry@chromium.org> > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Auto-Submit: Ryan Hansberry <hansberry@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686638} TBR=khorimoto@chromium.org,hansberry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 785758 Change-Id: Ief7a8ed1a5bcd925b8e94b4249f52aec89687aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778918Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
-
Connie Wan authored
This also disambiguates the Active, Open, and Pinned states from their -ness suffixed equivalents. The -ness versions are floats that are animation-specific -- TabAnimationState keeps track of the tweened values between 0 and 1. Most implementations only need to care about the binary non-suffixed versions. For now this is just a find-and-replace and does not change any boolean APIs (e.g. https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_strip.cc?l=982,1004-1005&rcl=1ad5374935374da746af65d05b41104c711fd5cc). There are many examples in tab_strip.cc where ternary operators could be removed if a boolean were converted into enum values. That is next on the list of refactors. Bug: 966627 Change-Id: Icc2a0aaea0a06186d0bd3fefda645e97252968cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764419 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#692182}
-
Antonio Gomes authored
This is part of phase 1.11 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ Since there are clients in //content directly referencing to this class, it was temporarily placed in blink/public/platform. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I1b5db2b166f8b698701a8bfa31282f940ee46c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778006 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Antonio Gomes authored
This is part of phase 1.9 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ Since there are clients in //content directly referencing to this class, it was temporarily placed in blink/public/platform. Also, once its clients get moved to Blink, and so this API, it can switch over from STL types (std::string and vector) to its WTF counterparts. TODO is left. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I3519318d5ae6f5b3641442f78d5e6116801dbbe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778005 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Kevin McNee authored
TargetAutoAttacher::UpdatePortals currently adds all inner WebContents including guest views. When devtools closes, SetAutoAttach clears |auto_attached_hosts_| of any portals, but leaves any guest views which leads to the failed DCHECK that all auto attached hosts have been removed. Now in UpdatePortals, we check that the inner contents is a portal before adding it. Bug: 961113 Change-Id: I758b3818c3f390f47c4020d88094387ee85d07e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777022Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#692179}
-
sebsg authored
This reverts commit ba5eedd3. Reason for revert: <Did no fix the issues. Original change's description: > Revert "devtools: Prepare for service worker UI thread core." > > This reverts commit b9e16d2b. > > Reason for revert: Speculative revert for > > Unexpected Failures: > * http/tests/devtools/a11y-axe-core/elements/event-listeners-a11y-test.js > * http/tests/devtools/a11y-axe-core/security/security-origin-a11y-test.js > * http/tests/devtools/a11y-axe-core/sources/sources-editor-pane-a11y-test.js > > See builds > https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/3809 > to > https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/3842 > > Original change's description: > > devtools: Prepare for service worker UI thread core. > > > > The thread ServiceWorkerContextCore lives on (the "core thread") will move from > > the IO thread to the UI thread when the ServiceWorkerOnUI feature is enabled. > > > > This CL makes DevTools aware of the core thread instead of assuming the IO > > thread. This makes https/tests/devtools web_tests pass when the feature is > > enabled. > > > > Bug: 824858 > > Change-Id: I20e38f50998f4b0cd9d8b8cc43526665d92dbf94 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775655 > > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#691689} > > TBR=falken@chromium.org,caseq@chromium.org > > Change-Id: I2d49a0fe27f033a7b8bd74e3a50fd9d78a4f1f58 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 824858 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778403 > Reviewed-by: sebsg <sebsg@chromium.org> > Commit-Queue: sebsg <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692059} TBR=falken@chromium.org,caseq@chromium.org,sebsg@chromium.org Change-Id: I05e78908c372fd01350bd16eca9d45bb5095c152 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779069Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#692178}
-
Elly Fong-Jones authored
This is much more necessary with the view repaint optimization enabled via the EnableViewPaintOptimization feature. Without that optimization, the BubbleFrameView was getting repainted by accident: usually a control in the bubble would change in response to a theme change, and that would damage the BubbleFrameView's bounds rect, which would cause a repaint of the BubbleFrameView. Bug: 999208 Change-Id: Ia71d5e7474a00971502a87dcc2d9cea7c4368853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774787 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
James Cook authored
When SplitSettings is enabled the route to APPEARANCE doesn't exist, so clicking the link throws an error. Instead, open the browser setting in a new browser tab. Test: Open OS settings > Advanced > Accessibility > Manage accessibility features, click "Open appearance settings" Bug: 999354 Change-Id: Ibb1e42dccfef72a42779c330ba189061e398da4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778815Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#692176}
-
Scott Violet authored
This is necessitated by Navigation not having const functions. It would be nice for Navigation to have const functions, but that isn't possible because we generally don't have const functions in content. BUG=none TEST=none Change-Id: I57f7385730e0eca623d8762512fff8403699c779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779002Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#692175}
-
Xing Liu authored
This CL disable ClearBrowsingDataPreferencesTest#testImportantSitesDialogNoFiltering on O+ builders. TBR=dullweber@chromium.org Bug: 999361 Change-Id: I9d40b6f4013f310664f4726349298d63fb2b42bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779004Reviewed-by:
-
