- 23 Jun, 2020 40 commits
-
-
Mikel Astiz authored
The modern codepaths within the sync engine have barely any special- handling for bookmarks. The relevant bits already have unit-test coverage, such as in ModelTypeWorkerTest, and most bookmark-related logic lives in components/sync_bookmarks, where there is good test coverage. Besides that, most scenarios are also covered by sync integration tests for bookmarks. Change-Id: Ife306e8924fabaef518400ed0b210fcfdaaaea5a Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259859Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#781375}
-
Hiroshige Hayashizaki authored
Change-Id: I2d1d7835f1434c665f6382c0da33e0eacee9b7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259698Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#781374}
-
nancylingwang@google.com authored
Based on go/respectful-code, modify blacklist to blocklist. FYI: https://tools.ietf.org/id/draft-knodel-terminology-00.html BUG=1097644 Change-Id: I271542cc8103e2488d7d27b7df805d020e70ede3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256113Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#781373}
-
Vladimir Levin authored
This patch adds a use counter for each value of content visibility other than the default. R=chrishtr@chromium.org Fixed: 1096676 Change-Id: I71dcb549b04b249f701bcc0b5b68f966052f0c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257540 Commit-Queue: vmpstr <vmpstr@chromium.org> Auto-Submit: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#781372}
-
Nohemi Fernandez authored
The ClearSyncedData feature has been enabled by default. Bug: 1005509 Change-Id: I799683d3cd1e9194d66751c1d4ac52f578949f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260732Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#781371}
-
Kushagra Sinha authored
Split InitializeAccountManager utility method into two methods - InitializeAccountManager and InitializeAccountManagerAsync - to clearly communicate the contract of these methods. Change-Id: Ifbc16205cea0ba37ab3d7cc5d8be287510a07082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255358 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#781370}
-
Lei Zhang authored
Also fix files that failed to do IWYU and stopped building as a result. Bug: 1010217 Change-Id: I6ab8e88728d33853ea62426046ecc1f92430cb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257994Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#781369}
-
Chris Sharp authored
Fixes lint warning: SlowTests:487 Expectation 'virtual/gpu/fast/canvas/canvas-composite-text-alpha.html' is redundant with 'fast/canvas/canvas-composite-text-alpha.html' in line 488 TBR=yiyix@chromium.org Bug: 1093836 Change-Id: I041f5856a658527e70bb1c334c6dca651b090f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260425Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#781368}
-
Lei Zhang authored
When calling chrome.fileSystem.chooseEntry() to perform saves, the PDF Viewer currently sets a suggested file name that ends with ".pdf". This is sufficient for the file pickers on Linux and Chrome OS to suggest saving using the suggested file name. However, the file pickers on Windows and Mac will only show the suggested file name without an extension. So trying to save "foo.pdf" and accepting the default results in a new file named "foo". Fix this by setting a value for the "accepts" key in the chooseEntry() parameter dictionary. Specify "pdf" as the extension here to get file pickers to make the correct suggestion. Bug: 1098072 Change-Id: I5b7a3ca7ffadfe14364fdc17b08d1a3133f8a747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259478 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#781367}
-
Theresa authored
This reverts commit e8ad9107. Reason for revert: crbug.com/1098208 Original change's description: > Replace IdentityServicesProvider functions in history classes. > > This CL replaces deprecated functions of IdentityServicesProvider with > the newer service getters with profile parameter. By this CL, > HistoryManager uses IdentityServicesProvider functions with the profile > generated regarding to isIncognito parameter from the constructor. > > Bug: 1041781, 1075562 > Change-Id: I04c0a14b5f9e912cda7fb34a581bea4d18023518 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242078 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780206} TBR=twellington@chromium.org,rhalavati@chromium.org,sideyilmaz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1041781, 1075562, 1098208 Change-Id: Ie08a1ae7d60e3c35f4b5f2ed9cc714bf907cea8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259150Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#781366}
-
Stephane Zermatten authored
With this change, we can express elements as "the button that's closest to the text containing 'click here'" and "the button above the text 'checkout'" This is implemented by measuring the distance between the element's bounding boxes and choosing the closest pair of elements. Bug: b/157970373 Change-Id: I287f0db80279f2342b2b12b1c8aa9f6f9b883b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228315 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#781365}
-
Dominik Röttsches authored
Tbr: kojii Bug: 481430 Change-Id: I5005b7c3232506ba5a1a1e988832576f9ee9cd81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260694Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#781364}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87cae0e24e81..d15ec1eec289 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC beverloo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: beverloo@google.com Change-Id: I5446bb3b12a77ab7760703ce993e34c4de524bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260519Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781363}
-
ckitagawa authored
This CL completes the implementation of embedding token per-document. Now every cross-document navigation comes with an embedding token (for both local and remote frames). These tokens are to be used for a parent document to opaquely reference a child document. Bug: 1072422 Change-Id: Ic3c9b02eafe5874d484bde6bedfd89b2c5fcfbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150814 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781362}
-
Marc Treib authored
The DCHECK ensured that there are no unsynced deletions, which is only correct if the |success| param is true. Bug: 1086433 Change-Id: I2f8de54e33d48384b7499a9bfaf3affb968344ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260774Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#781361}
-
Abigail Klein authored
of the DumpAccessibility tests. Change-Id: I833af7699a8317366930ca2e071c34585ab0ff8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259254 Auto-Submit: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#781360}
-
Chris Sharp authored
TBR=lanwei@chromium.org Bug: 1025944 Change-Id: I059356aa818dce87429db6120e005515d747a3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260852Reviewed-by:
-
Mahmoud Gawad authored
Add telemetry-extension-dir command line switch name to be able to load the Telemetry System Web Extension from disk. Bug: b:156583406 Test: Not needed. chrome build is green Change-Id: Id8ae2a8c6a27fa0637264ac9e6e14467e66e8de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257235 Commit-Queue: Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#781358}
-
Eero Häkkinen authored
This CL refactors video capture device creation on Windows, removes some code duplications related to DirectShow device enumeration and adds mocking points for unit testing. This CL has no functional changes. Bug: 934063 Change-Id: I2df08b3a361ffd702761bd9d6b400f4418390c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247797 Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Auto-Submit: Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#781357}
-
Xianzhu Wang authored
Change-Id: If25a2df97a3bf5a322c02d650eb5aaeff86f7722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258423Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781356}
-
Clark DuVall authored
Now that references in clank have been switched over to the version in //components, it's safe to remove this. Bug: 1025606 Change-Id: Id453032a8237d11d94dcc32d102bf5de243a10d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256850Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592909179-8c9bd637e5cbc50bd35bf53946c51dca562e57cb.profdata to chrome-win64-master-1592917001-f92b525a65d0a85552634ba3f6ed8ed822d9ee38.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I66ef0c9c6e9a1b6220d16f99d3bcfd3f6da86daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260522Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781354}
-
Michael Ershov authored
Add a field to certificate provisioning policies to disable Verified Access checks for a certificate profile. Modify CertProvisioningWorker to bypass all Verified Access related methods and use PlatformKeysService to generate keys instead. Bug: 1045895, 1094814 Test: CertProvisioning* Change-Id: I9318e2734a897189e3b25f6b9cdeca951c6e1526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238069 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#781353}
-
Becca Hughes authored
Add connect-src to CSP so we can override it in untrusted WebUI. BUG=1087443 Change-Id: Ib93c326e629c2225ddfad0740c4befc26d39b757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246902 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#781352}
-
Becca Hughes authored
This is a reland of e5a8add0 Original change's description: > Split kaleidoscope resources in two > > Split the kaleidoscope resources and strings > into two since they are going to be moved > around. > > BUG=1087037 > > Change-Id: Iee08832b837a18bbb102fcd8cc6ea98c5dbdf819 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254706 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780879} Bug: 1087037 Change-Id: I5d2910992ff1dd3229fd12ab732a1e2a6293f890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258573Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#781351}
-
Hazem Ashmawy authored
Always connect to nonembedded metrics when WebView connects to the variation service to lood seed. This should help to avoid spinning the WebView service process each time WebView starts up just for metrics service. However, this means that now collecting nonembedded metrics is ALWAYS enabled and not guarded by a feature flag anymore because feature flags cannot be checked at this point of execution before initializing variations. This also means that collecting nonembedded metrics will follow the same throttling criteria applied to loading variation seed. Remove kWebViewCollectNonembeddedMetrics feature flag since it's not used anymore. Bug: 1001185 Test: Locally add logs and set finch experiment throttling flags Test: test with enabling and disabling the feature flag Change-Id: Ie8e0ea2204aa9df03dbc7b42bd66d12b11fb6d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252082 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#781350}
-
Joe DeBlasio authored
This CL improves edit distance lookalike matching by not warning on two classes of matches that are commonly false positives: 1. Numeric suffixes, such as domain1.tld and domain2.tld. 2. First-character edits, such as domain.tld and xdomain.tld. Bug: 1096309 Change-Id: I9cdf46060ef00949435c7429b86a835de796fb49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255025 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#781349}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ee0e894a. With Chromium commits locally applied on WPT: ee0c101e "[COOP] access reporting toward the opener." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: igrigorik@chromium.org, yoavweiss@chromium.org: external/wpt/preload NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I776df6d72f6f4467f9c93b4d31fbbe1c8420cfa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260394Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781348}
-
Guillaume Jenkins authored
Moves report_request_definition namespace to components/enterprise. It had previously been moved to components/policy, but it makes more sense to keep reporting code under components/enterprise. Bug: 1091914 Change-Id: I7aaaabc10c3f1efba152465c1405ebe90b42c96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258676 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781347}
-
Dave Tapuska authored
This global lookup API is no longer used. Yeah! BUG=1097816 Change-Id: I7b8abed232bb9c035c8394dbfc30b8e298d42155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258673 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781346}
-
Nohemi Fernandez authored
This patch removes the old, unused APIs for adding an account to Chrome. Bug: 1078815 Change-Id: I0ec5d29af7566d8287090ee83b8a67d4a1abb9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226809 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#781345}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592902529-27c1b0c2ad05930b1841cdb3fc1b8d5f930926e0.profdata to chrome-win32-master-1592913526-aa0369974c74051e60d9fc3c83a0a362a402bc87.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3d8de61c0c4529a761ac6fb9ddc6225d08fcac46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260518Reviewed-by:
-
Sebastien Marchand authored
Use "(dis)allowlist" instead of non-inclusive term "(white|black)list". This affects some UKM entry but it's not something that we're recording now (and this code could maybe be removed anyway). Bug: 842296 Change-Id: Ie0e9fe16ffc6361c9891d01ff6aaf94f7564f2dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249720 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#781343}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/caa519ca532a..43c639f0906a 2020-06-23 rharrison@google.com Roll 5 dependencies and update tests/expectations (#1087) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I855b004b8364eba303ff05b5bf7c03aded85ec42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260517Reviewed-by:
-
Guillaume Jenkins authored
In preparation for moving BrowserDMTokenStorage to components, this change moves platform-specific DM token management code to delegates instead of using derived classes. In this case, the derived class approach won't work after the move to components because the current code has the derived classes implementing the parent's Get() singleton method, which won't work when the base and the derived classes are in different DLLs. Summary of the changes: - Pure virtual methods in BrowserDMTokenStorage have been moved to a delegate inner class. - Platform-specific token management classes now derive from the delegate instead of the BrowserDMTokenStorage singleton. - CBCMController is responsible for creating the correct platform delegate and assigning it to the BrowserDMTokenStorage singleton during early initialization. - For tests, this refactor is completely transparent, as the FakeBrowserDMTokenStorage creates and manages its own fake delegate implementation. Bug: 1091929 Change-Id: I02ae185cc5cbde46016039b49cefaeb8e963ec4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246979 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bbe343d8..dfc4c1d4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I354475103613638f1fa76b95eee157955fb5c814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260417Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781340}
-
Joe Mason authored
R=siggi Bug: 1096543 Change-Id: I42a0f40fa895117ed03b6173f5f1bb27b905b9e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259485 Auto-Submit: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#781339}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2841ab4841b1..60aab5ad138e 2020-06-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-06-23 mathias@chromium.org Roll Puppeteer v4.0.0 2020-06-23 kimanh@chromium.org Re-enable and adapt disabled e2e tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibc12ebd27e9deb5832810d5c1b268b05d4bee6a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260520Reviewed-by:
-
Gavin Williams authored
This error message will be displayed only on Chrome OS in Print Preview whenever the currently selected printer is in an error state. Bug: 1059607 Change-Id: I14449ff21892c21106b7319b8f99bc421897b8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227860 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#781337}
-
Etienne Bergeron authored
Thread priority should not be modified after a test. If that is happening, it needs to be fixed in the code. This CL remove the code that disable the priority checks. NOTE TO SHERIFF: * please paste failure logs when reverting, the goal is to remove flaky tests related to thread priority. * assigned flaky test to etienneb@ Bug: 1097092 Change-Id: I6462e3aff2a0d1b0febc2eae7cd97bf580292768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254466Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#781336}
-
