- 08 Jul, 2020 40 commits
-
-
Jing Wang authored
Some details: - Suggestions/settings link will be highlighted when using down/up to navigate - Tab/Right no longer commits suggestions. - If user keeps typing after a suggestion is highlighted, we cancel the highlight. Test: add unit test and tested with Chrome on Linux Bug: 1099498 Change-Id: If890b9d39fa86e55398841c2a8038922d59488f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269157Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#786130}
-
Jarryd authored
Change-Id: I164a3e7233fe2e7d07fc6e5b05adc68b04022ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285909 Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786129}
-
Rakina Zata Amni authored
The new values for ShouldSwapBrowsingInstance are added in crrev.com/c/2121522, so we need to update the label for the corresponding metric values. See https://source.chromium.org/chromium/chromium/src/+/master:content/browser/frame_host/should_swap_browsing_instance.h;l=14;drc=50d126fbc5e2629e3f2eaf69c2da37b57e118532 Bug: 977562 Change-Id: I1ba5d97d7ea3be23e0ce886f57616d1c1be0cb54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282736Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#786128}
-
Michael Crouse authored
This change prevents LiteVideos from being attempted when the navigation is a reload or forward-back page transition. It also adds an entry for host of the navigation to the user blocklist to allow users to soft opt-out of the optimization if they reload frequently on a host. A future change will clear the blocklist when the browser history is wiped. Bug: 1096796 Change-Id: I687d4c9cd0844d7475f6a3baedacebcf73a48845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276681 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#786127}
-
Josh Simmons authored
Also renaming PerformanceHintsRewriteHandler to RewriteHandler, since the namespace already disambiguates. Change-Id: I9a1575b6990fa9736f47d237a71309fa3a6c55a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276765 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#786126}
-
Nate Fischer authored
This extends Safe Browsing histograms. We still use these histograms periodically to compare WebView and Chrome Safe Browsing behavior, so this extends the histograms one year. This adds WebView team as a second owner. Fixed: 1089421, 1089441 Test: N/A Change-Id: I6ed05b4d1b586a5d210190d6c7f615c6bafb4ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285481 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#786125}
-
Brian Sheedy authored
Removes //third_party/pymock, as all uses in Chromium have switched to the version of mock provided by vpython. Bug: 1094489 Change-Id: Ib9c5083557f4ca98ba5439cb836feaa7f80fabb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285482Reviewed-by:
Sam Clegg <sbc@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#786124}
-
John Lee authored
The decision to automatically close the tab strip when activating a tab was made a long time ago, so these prototyping tools are no longer needed. Change-Id: I048af52b5411a2bdf08a87c098d9e4bded6e8bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285530Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#786123}
-
Wei-Yin Chen (陳威尹) authored
Add RSS fetcher and integrate with the UI. Bug: 1099037 Change-Id: Icc0b391b9720a6622f9f3b4e9874d716cfe33937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266028 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#786122}
-
Kunihiko Sakamoto authored
It was flaky because the path to slow-script.pl was wrong. This narrows the failure expectation only to virtual/synchronous_html_parser, where viewport-dependent preloads don't work because DispatchLinkHeaderPreloads() from HTMLDocumentParser::EnqueueTokenizedChunk() is not called. Bug: 944025,901056 Change-Id: Ib76f9367a1eb5ab73ab1c81e40c60b9e331488e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279295Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#786121}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b72434f3d312..a0b4571546bb 2020-07-07 rharrison@chromium.org Roll 6 dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I7078dcec9973332c7fcb93519ae37e9a91a0549b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285594Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786120}
-
Andrey Lushnikov authored
Consider the following situation: - We're running Chromium on Mac - There's an open context menu for the browser's page If at this moment we try to close browser programmatically via DevTools protocol, the browser will not close - it'll hang. This happens because: - context menus on mac spawn nested event loops - `RenderViewContextMenuMacCocoa` is destroyed and doesn't exit the run loop This patch cleans up context menu when `RenderViewContextMenuMacCocoa` is destroyed. Change-Id: Ic2f89806954cb5386d530c6e726386ac7f5d513d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285520 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#786119}
-
Clark DuVall authored
This was mostly mechanical, but had to be a little tricker in extension_updater.cc since FetchedCRXFile is no longer copyable when using a OnceCallback. Bug: 1007786 Change-Id: Ifb091f129066ff4e0b5d290a80b53892263d9c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285914Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#786118}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b2dfd8a6ee8c..7cbda52a2db8 2020-07-07 bsheedy@chromium.org [Telemetry] Swap CrOS shutdown order If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1091553 Tbr: eseckler@google.com Change-Id: I9911f6a9fe8d2a4f00c2329197723f16a092ebcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285216Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/81a9074069be..e62496bafc47 2020-07-07 dpranke@google.com Remove Python 3 warning. 2020-07-07 vadimsh@chromium.org [cipd] Always bootstrap mac-amd64, even on arm64. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1102967 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I9862460812e37109577d2219725c350b176ba027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285592Reviewed-by:
-
Erik Staab authored
This reverts commit b9897c33. Reason for revert: This breaks a few waterfall builders. Original change's description: > GN: switch from check_targets to no_check_targets. > > The list was semi-automatically generated by parsing the output of > "gn check" against various configurations. > > With some exceptions, parsing was done using: > grep -E -A1 '(The target:|It is not in)' | grep '//' | \ > grep -v '//build/toolchain' | cut -f1 -d: | sort | uniq -c | \ > sed -e 's/ *\([0-9]*\) *\(.*\)/ "\2:*", # \1 errors/' > > Note: if this breaks the "gn gen" step of a build configuration that > isn't tested in the CQ please add more entries to this .gn file instead > of reverting this CL. > > Bug: 896680 > > Change-Id: I4e3d2b316ec014f969303f7c4bb809e436447b10 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278172 > Commit-Queue: Erik Staab <estaab@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#786102} TBR=dpranke@google.com,estaab@chromium.org Change-Id: I994a4149f38fe00779045612291b0984b95f9075 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286473Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#786115}
-
Mark Pearson authored
about number of lines in various databases Remove sbirch@ as owner. (Not a Chromium contributor; not an appropriate owner.) Add myself as owner. Add sky@ as secondary owner, as sky@ is familiar with these histograms. Extend for a few months. Bug: 1039298,1041513,1043689,1036899 Change-Id: I33c38247d78b3b55c8d8070d0000239ef5743dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285347Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#786114}
-
Alexander Cooper authored
The tool currently fails to compile, and is breaking the trybots. Normally, we'd revert the commit that caused this to fail, but this tool is scheduled for deletion in the very near future and currently unused; so fix the bots by stopping building it on them. Change-Id: Ic4e8639c3d2f3f083072dd21ffa8b3d5c7df70ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285225 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#786113}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f6f11215cd93..28159ee9c8e3 2020-07-07 swiftshader.regress@gmail.com Regres: Update test lists @ f6f11215 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Icd6c2200371b7549302af8a0d6ab2ab8417c2308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285315Reviewed-by:
-
Jian Li authored
Bug: none Change-Id: I538d5a32853ea8a62b54f25f9c00c69d12fd53ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278344Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#786111}
-
Kurt Catti-Schmidt authored
This change builds upon the previous work in NGGridLayoutAlgorithm to actually perform measuring on the grid items. The next step in the grid algorithm is to determine track column widths. Since column-widths can be content-based (min-content and max-content), these measurements will be necessary at that point. Much like my previous change, this is validated using unit tests, as we cannot currently test end-to-end grid layout until we have more stages of the grid algorithm completed. Note that percentage resolution is currently incorrect. It will require another layout pass with additional sizing data. This is noted in the incorrect test result. Bug: 1045599 Change-Id: Ic10a8522a16e70792e2299dfe3d8eda0231ff877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257403Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#786110}
-
Matt Menke authored
This reverts commit 341bb752. Reason for revert: This broke the CQ. See: https://ci.chromium.org/p/chromium/builders/try/win-libfuzzer-asan-rel/472138? https://ci.chromium.org/p/chromium/builders/try/linux_chromium_tsan_rel_ng/604561? etc. Main builders also look to be failing. Original change's description: > [Nearby Share] Add ToDictionary, FromDictionary to PrivateCertificate > > ToDictionary and FromDictionary methods convert to/from a Value > dictionary to facilitate storing PrivateCertificates in Prefs. > > Change-Id: I92117836af94cd224eeea34edc7dd55dd3eb7484 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284043 > Reviewed-by: Josh Nohle <nohle@chromium.org> > Commit-Queue: Curt Clemens <cclem@google.com> > Cr-Commit-Position: refs/heads/master@{#786027} TBR=nohle@chromium.org,cclem@google.com Change-Id: I3a840d2bcdc09ff8ac6db1926a1a7339e121ca04 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286470Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#786109}
-
Nate Fischer authored
No change to logic. This swaps "whitelist" for "allowlist" in AwContentCaptureTest and components/content_capture. Fixed: 1101006 Test: run_webview_instrumentation_test_apk -f AwContentCaptureTest.* Change-Id: Id4c4fef7cf82c6b5ac9ba719c2ba46ca9c1b093f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285398 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#786108}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594154384-2956366c17c90e62cea6163ad2cfb0a0603637b5.profdata to chrome-mac-master-1594166201-979527694a92667bf62297ee8ba7cd564f63c679.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iae52188e8d4f376cc920d04a0d284dec76b01b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285832Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8f04e3d34cd0479d654c80c9cb7085e96abcb0d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284736Reviewed-by:
-
Chris Blume authored
ImageDecoder::SetMemoryAllocator() said it did not work for multi-frame images. But it did not describe why. This CL adds a comment explaining the reasoning behind it. Change-Id: I8f2f0fa5e36f8eed938b5bfe17f5e82995fd2bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236927Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@google.com> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#786105}
-
Nate Chapin authored
Bug: 1102810 Test: fast/animation/keyframe-effect-on-element-from-inactive-document.html Change-Id: Ie6f1d8014fb1a1ca640b81b828aa4299e57d47d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284090 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Alice Boxhall authored
Bug: 1094565, 817199 Change-Id: Ibf5cea41aa43d5e6f932df69a0b589d8e1d57015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277660Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#786103}
-
Erik Staab authored
The list was semi-automatically generated by parsing the output of "gn check" against various configurations. With some exceptions, parsing was done using: grep -E -A1 '(The target:|It is not in)' | grep '//' | \ grep -v '//build/toolchain' | cut -f1 -d: | sort | uniq -c | \ sed -e 's/ *\([0-9]*\) *\(.*\)/ "\2:*", # \1 errors/' Note: if this breaks the "gn gen" step of a build configuration that isn't tested in the CQ please add more entries to this .gn file instead of reverting this CL. Bug: 896680 Change-Id: I4e3d2b316ec014f969303f7c4bb809e436447b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278172 Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#786102}
-
Alex Turner authored
As each dedicated worker can only have one parent execution context, we simply inherit that parent's UKM source id. Bug: 1085645 Change-Id: I55b0650a6f38d005e9da6c7110a21953b1f83551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270699 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#786101}
-
dpapad authored
Fixed: 1102943 Change-Id: Ic44bf23de891295106fa73092c14f9a17672fd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285383 Commit-Queue: dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#786100}
-
Dominic Mazzoni authored
Most of the magic that connects PDF annotations for hyperlinks to their corresponding struct tree node happens inside of Skia. All that's needed in Chromium is to add the proper node type for a link. Bug: 1100712 Change-Id: Ica08cd04bc9dcb00684af5eb299927353618d0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278173Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#786099}
-
Kyle Milka authored
When the device layout changes invalidate and re-layout the two recycler views that make up the share sheet. Bug: 1099496 Change-Id: I45b883b49d490f9d2c1c3d6f0a0f10dac968c1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278409 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#786098}
-
Xida Chen authored
This is a code health CL, no behavior change is expected. Bug: 1007635 Change-Id: Id0f79710fb70bdf31ad0959e7b8ab92f22ecdacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280201Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Auto-Submit: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786097}
-
Kyle Milka authored
For the initial launch we do not want to show the custom share sheet for CCTs. Bug: 1090470 Change-Id: I60ed2bae711adbe93db2e21866db0f7cb1b48c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284363 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#786096}
-
Xiaohan Wang authored
Make the message more clear about the ban of variants like ReleaseAndGetAddressOf(). Bug: 914910 Change-Id: I16fb4cb51a619aea4f414601cf10279ac482992a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271072 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#786095}
-
Chris Harrelson authored
Bug: 1100711 Change-Id: Ibbc44d0937ef1dd899677e72e1ebff5db40d9ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280590 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786094}
-
Robert Sesek authored
These were missed by the awk script I ran initially. GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I0cf1677e1054f2ffcb54660820fba61d1c3590a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278363Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#786093}
-
Jeffrey Cohen authored
This enables the the image_editor to construct a ShareParam. Bug: 1093365 Change-Id: If1e06d0fea433628540db5d52c73c237f61a4526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285357Reviewed-by:
Travis Skare <skare@google.com> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786092}
-
Nate Chapin authored
We appear to crash in HTMLTrackElement::CanLoadUrl if GetExecutionContext() returns nullptr, so early-exit in that case. Bug: 1102668 Change-Id: I43f0008eefe5d12b63d69c42d0fd341fe0e2f2eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284390 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
