- 12 Jul, 2019 40 commits
-
-
Lei Zhang authored
Nobody is looking at these stats. Change-Id: Ib16fddbd333d7a93e66bc2560f5abffcbae6b46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699249Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#677060}
-
Gayane Petrosyan authored
Remove titles for both colors and default tiles. This change makes crbug.com/976415 obsolete. Bug: 960982 Change-Id: I5138085065566bfad04e84b22ea2337be2e211c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693167 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#677059}
-
Etienne Pierre-doray authored
This CL Creates a new derived JobTaskSource that tracks the number of concurrent worker. It's a precursor of https://chromium-review.googlesource.com/c/chromium/src/+/1582427 which integrates JobTaskSource in ThreadGroups. Bug: 839091 Change-Id: Ie407823bdd6d4c84fd8b3db7d6d6a58a33846045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693182 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#677058}
-
Ian Wells authored
This flag will be used to control whether to show notifications for Feed articles. Also, increase interest-feed-content-suggestions expiry milestone to 78. Bug: 982483 Change-Id: I759721cd0e005612ecc40352f43e5608287591ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693816 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#677057}
-
Chris Blume authored
A series of new tests began failing. Some of these consistent failures have already been added to the test filter. This adds the remaining test to get the bot green again. Since these failures are consistent instead of flaky we'll want to investigate the cause. TBR=jonross@chromium.org Bug: 983204 Change-Id: Ib6f754a7f12dd92a8674b83463e9c9bd8b27d333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700257Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#677056}
-
Dave Tapuska authored
To add a check in the bindings code to check that the agent is the same we need to support WebPagePopups to get the same security origin/agent in test framework. BUG=970360 Change-Id: Ie55eb5cb1b91b72ab0ed2b63ae60be616b4d2b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669750 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#677055}
-
ssid authored
BUG=967008 Change-Id: Ida55fce147ad25f302ec75d783c934f1094df4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699409Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#677054}
-
dpapad authored
Bug: 839707 Change-Id: I14ab2004a6b46153d5299c090fbaf16b119e9c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700364 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#677053}
-
Geoff Lang authored
These extensions were being exposed as requestable but failing to initialize because they weren't requested. BUG=angleproject:3675 BUG=983142 Change-Id: I7b8be3c49860bac5c62cb5df6cfb77f1ecf120b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698643 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#677052}
-
Ted Meyer authored
A few of the helper classes for WebMediaPlayerImpl have had some new methods added to support this. Change-Id: I362a8142338ee79b0c142fa1c7c6bb3e7acabf64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680834Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#677051}
-
Yann Dago authored
Bug: 980124 Change-Id: I7d290370e6cfb8f336dab7c39753a5c369c16eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690706 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#677050}
-
Vlad Tsyrklevich authored
Previously I had enabled GWP-ASan by default because it looked like it was ready to launch with the default parameters. I'm having to tweak the parameters to address some small perf regressions, so disable it by default for now until it's actually ready to launch to 100% with the given default parameters. Change-Id: Ie1a723a70293da2fa4fa05d21025a09ea80230d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699512 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#677049}
-
Geoff Lang authored
ANGLE handles these workarounds internally and some of them generate GL errors when running on top of an ES driver. BUG=angleproject:3672 BUG=angleproject:3671 Change-Id: Ic301f57f882247db1bbe8991647b12b9bb0b4f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697530Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#677048}
-
Shimi Zhang authored
This is a followup of http://crrev/c/1685837. See more at https://docs.google.com/document/d/1Jwfbzbe8ozaoilhqj5mAPYbYGpgZCen_XAAAdwmyP1E/edit I have also changed BindAutofillDriver() in ContentPasswordManagerDriver to BindPasswordManagerDriver(), since it isn't binding auto fill driver but password manager driver. Bug: 955171 Change-Id: I0817d7d54eb1fc46be4d16a2a611f98604ddef58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693890 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#677047}
-
Lukasz Anforowicz authored
Changes in this CL ================== This CL: 1. Updates FrameNavigationEntry::UpdateEntry and FrameNavigationEntry's constructor so that they both take |const base::Optional<url::Origin>& initiator_origin| which gets stored in a new FrameNavigationEntry::initiator_origin_ field. 2. Updates callers of FNE::UpdateEntry and FNE's constructor to provide/propagate the initiator as needed. This includes adding an |initiator_origin| parameter to - NavigationEntryImpl's constructor - NavigationEntryImpl::AddOrUpdateFrameEntry - NavigationController::CreateNavigationEntry (the list above is not necessarily exhaustive/complete) 3. Uses the new |FrameNavigationEntry::initiator_origin()| from NavigationEntryImpl::ConstructCommonNavigationParams (which used to always provide |base::nullopt| initiator for history navigations - always treating them as browser-initiated, rather than replaying the original initiator). The changes above makes sure that the right Sec-Fetch-Site http request header is "replayed" during history navigations. The CL adds browser tests and WPT tests to cover the new, desired behavior. Follow-up changes ================= This CL does not: - Use |FrameNavigationEntry::initiator_origin()| in GetOriginForURLLoaderFactory in render_frame_host_impl.cc (this will be done in a follow-up CL at https://crrev.com/c/1672176) - Handle persisting |FrameNavigationEntry::initiator_origin()| for session restore (this is tracked in a separate https://crbug.com/976055). Bug: 946503 Change-Id: I4f92614873a5ec8d4b52d3ae22031c7089d87ed5 Tbr: skuhne@chromium.org for //components/sessions Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662738 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#677046}
-
Marijn Kruisselbrink authored
Getting more access via permission requests or file pickers is restricted to first party contexts. This adds browser side checks to make sure this is the case. Bug: 980960 Change-Id: I026a6047e0e5587841f275a14558908ab1cf33fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700284 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#677045}
-
Ahmed Mehfooz authored
We do not currently flip the canvas for focus rings when RTL is enabled. This can cause certain focus rings to be drawn incorrectly for their corresponding buttons. Bug: 960284 Change-Id: I1144cee667c626e4978aaff9bd3cd8901494dbb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696443Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#677044}
-
Rakib M. Hasan authored
Previously a conflict between two expectations for the same test meant that one expectation's tag list was a subset of the other's tag list. This CL will change the conflict checker so that it will find conflicts between expectations when they don't have conflicting tags. Example of test expectations without conflicts [ mac ] test1 [ RetryOnFailure ] [ win ] test1 [ Skip ] There is no conflict in the example above because they have different operating systems tags. Example of test expectations with conflicts [ android qualcomm-adreno-(tm)-418 ] test2 [ RetryOnFailure ] [ android opengl ] test2 [ Skip ] There is a conflict in the example above because they do not have any conflicting tags. The first test expectatoin can apply to ANGLE and non-ANGLE configurations on an android device. Bug: chromium:982363 Change-Id: I90b4df7c9d9ce6fd6347e096eab7d02e9023c6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699501 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#677043}
-
Liquan(Max) Gu authored
According to the spec (https://w3c.github.io/user-timing/#extensions-performance-interface), the argument of clearMark() and clearMeasure() should not be default to null; so the implementation should be changed accordingly. Bug: 953851 Change-Id: I19ade10fe52519b620502c57d6203ae865e62fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696113Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#677042}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2a4f36b14f03..375ddfc5992d git log 2a4f36b14f03..375ddfc5992d --date=short --no-merges --format='%ad %ae %s' 2019-07-12 jmadill@chromium.org Signal different dirty bit for vertex buffer change. Created with: gclient setdep -r src/third_party/angle@375ddfc5992d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: Ie16ebe2b65704ce46893190e5a7b0822fdf62f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700346Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#677041}
-
Robbie McElrath authored
This is a reland of b050ee2d with a speculative fix for the underlying issue. According to the most recent failures, the test failed due to the network changing during one of the test requests. This makes the test wait for an ethernet connection before running to make sure the requests don't get interrupted. Original change's description: > Re-enable VariationsHttpHeadersBrowserTest tests on ChromeOS. > > I can't reproduce flakes locally, so I'm going to re-enable them and see > if we've fixed them in the last couple months. I also added additional > assertions to the test so we'll get more information about why they fail > if they do. > > Bug: 964338 > Change-Id: I4a864101de6cfb1b434c3b2157d2323d8e6e522a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693704 > Reviewed-by: Eric Roman <eroman@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#675871} Bug: 964338 Change-Id: I6b3c09d6b3e464b29288a63d1413957cdbaeb46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696009Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#677040}
-
Caroline Rising authored
Bug: 910739, 974916 Change-Id: I89da31d03b93e3650975a1d0aa23e94970eaea91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696266Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#677039}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/57b0b09dfdb6..690e899cff0c git log 57b0b09dfdb6..690e899cff0c --date=short --no-merges --format='%ad %ae %s' 2019-07-12 rmistry@google.com [perf_skottiewasm_lottieweb] Use the new "--use_gpu" flag for GPU bots 2019-07-12 rmistry@google.com [perf_skottiewasm_lottieweb] Add flag for use_gpu 2019-07-12 reed@google.com add savelayer flag to promote the later to half-float Created with: gclient setdep -r src/third_party/skia@690e899cff0c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@google.com Change-Id: I44018943d3b036b316407a9a591b29f2b1238f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700344Reviewed-by:
-
Mugdha Lakhani authored
Refactor browser tests logic so that it can be used by periodic Background Sync browser tests as well. Bug: 925297 Change-Id: I3771a8391082943af796a69146ffac12f3c1226c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698464 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#677037}
-
Mark Pearson authored
This reverts commit b3bb875d. Reason for revert: Causes deterministic failures on bot https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg of test CrSettingsGoogleAssistantPageTest.All More details at http://crbug.com/983568 Original change's description: > assistant: fix race condition on showing hotword options > > Hotword device detection may take some time for cras. Assistant > settings page maybe showing before cras has fully discovered all > audio devices. This change makes sure we handle cras audio > device node changes to update with latest information. > > Bug: b/135137356 > Test: locally build and test on device. > Change-Id: Iea84cd3a9e7e25b324014242799ac88f372a099e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687363 > Reviewed-by: Yue Li <updowndota@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#675922} TBR=stevenjb@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/135137356 Change-Id: I2dd5ee9af4b777d71e3954365796421010525c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699509Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#677036}
-
Gil Dekel authored
This CL refactors VaapiImageDecoder to use std::unique_ptr<ScopedVASurface>, together with a custom deleter to destroy the associated context. This ensures the decoder owns and properly clean the underlying VA surface and VA context. This is useful because it removes clean-up responsibilities from clients of ScopedVASurface. Unfortunately, we have noticed that VaapiWrapper would reduce the manual ref count of the VaDisplayState upon its demise, which may cause some ScopedVASurfaces with stale copies of VADisplay to not be able to self-clean. Therefore this CL introduces a (hopefully) temporary modification to ScopedVASurface in which it holds a scoped_refptr to the VaapiWrapper that created it and uses it to self clean. In addition, the API of image decoders is changed slightly. A scoped_refptr<VASurface> is no longer returned upon Decode() requests. Should a client need access to the ScopedVASurface, the API exposes a GetScopedVASurface(), which returns a const raw pointer to the decoder's ScopedVASurface. This should feel familiar due to the get() call in unique_ptrs. Finally, this CL fixes some of the call-sites that use VaapiJpegDecoder (i.e. VaapiImageDecoder's new API). Bug: 877694, 980379 Test: jpeg_decode_accelerator_unittest Change-Id: I834c3af64813e3004f8a62da4e2ef529585be465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696012 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#677035}
-
Dale Curtis authored
We'll have to limit support to P+, since it's otherwise quite a chore to get the correct MediaCodec status in the renderer. This also does the following: - Strips media:: prefix from media/base/supported_types.cc - Adds warnings to MediaCodecUtil around methods which can't be used from the renderer process. - Moves opus support checks to MediaCodecUtil where they belong. - Moves hevc support checks to MimeUtilInternal::PlatformInfo where they belong. Expands unit test for this. Updates MediaCodecUtil.java to accommodate this. - Removes a unreachable statements from IsCodecSupportedOnAndroid. - Switches MimeUtil to use base::NoDestructor for MimeUtilInternal, required adding const to a few more methods in MimeUtilInternal. BUG=980091, 980682 TEST=passes locally now. R=chcunningham Change-Id: Ib59dce569a5198754e8f5a0df7ee28241f76a5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694241 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#677034}
-
chrome://flagsAndrii Sagaidak authored
When the banner "Your changes will take effect the next time you relaunch Chrome" appears on the page, the screen reader will be alerted. Bug: 982886 Change-Id: Ib148b8a3bc2c2949771ca5e949b9e42b2b182d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696355Reviewed-by:
-
Suzy Li authored
This CL adds the "scamble_message_ids = false" to the mojom_platform target to unscramble message IDs. This CL is a replacement of this CL[1], aims at unscrambling DocumentInterfaceBroker message IDs without build failure. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1688224 Bug: n/a Change-Id: Ieee5d19a8e9e650b402a163606bdd6556d99500b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693810 Commit-Queue: Suzy Li <suzyli@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Henrique Nakashima authored
Tests are largely the same as PrefetchFeedFlowTest with a couple of changes in external code and in the test itself so it works in Reduced Mode. Bug: 959957 Change-Id: I75bdf3e149460e8734572f0b7fe6aaae61b796b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669656 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
-
Aidan Wolter authored
This reverts commit c6b8b53b. Reason for revert: Fixing the debugging issues. Original change's description: > Revert "[Logging] Disable always-log-ERRORs-to-stderr unless LOG_TO_FILE is set." > > This reverts commit ffa05b99. > > Reason for revert: This breaks a lot of debugging workflows. > > Original change's description: > > [Logging] Disable always-log-ERRORs-to-stderr unless LOG_TO_FILE is set. > > > > logging::LogMessage has a special-case to write LOG_ERROR messages > > to stderr, even if LOG_TO_STDERR is not enabled, to make ERROR and > > FATAL messages more visible, especially in tests. > > > > Restrict this behaviour to apply only if LOG_TO_FILE is set, so that > > binaries which only LOG_TO_SYSTEM_DEBUG_LOG will never emit logspam > > to stderr. > > > > Tested by adding a unit test for this case. > > > > Bug: 968387 > > Change-Id: Icfe094e7d7bf9697a70a589eab48edbe79c36091 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638782 > > Commit-Queue: Sharon Yang <yangsharon@chromium.org> > > Reviewed-by: Wez <wez@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#666507} > > TBR=wez@chromium.org,kmarshall@chromium.org,yangsharon@chromium.org > > Change-Id: I857fd9bc95afedf204a5e981e6a362cd8990b4a8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 968387 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647361 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666753} TBR=dcheng@chromium.org,wez@chromium.org,kmarshall@chromium.org,yangsharon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 968387 Change-Id: Id656bff53e3b53e4df981ca8e819f33900c966f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682954Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Auto-Submit: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#677030}
-
Yuly Novikov authored
TBR=kbr Bug: 982086 Change-Id: I63123b0d6daece31a88bc9a672fda6f652b750cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700461Reviewed-by:
-
John Budorick authored
Bug: 981191 Change-Id: I5a2f21226a1d8f72ed2b151df383cf9888dce49e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699799Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#677028}
-
Ian Vollick authored
We currently depend on the IS_FULLSCREEN property being set in TouchlessDialogPresenter. This should always be set, but in case we miss a spot, I've added code to fail gracefully and have added an assert so we can spot these failures in debug. Bug: None Change-Id: I7d210b53c7489cb4757e9b56c9aaa75538266314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699788Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#677027}
-
Rayan Kanso authored
Check that the icon is valid and within the size limits, and also that the launch URL is valid and belongs to the renderer's origin. Remove the `SERVICE_WORKER_UNAVAILABLE` error since it's unused. Bug: 973844 Change-Id: I59f47602174fe5310713460adf50c5f85ebe1459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698405 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#677026}
-
Devlin Cronin authored
Antony is no longer doing Chromium reviews. Bug: None Change-Id: I18eaba51859e55a512a351bc873387693f856de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700283Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
-
Roman Sorokin authored
Will enable the tests in a follow-up CL Bug: 911154 Change-Id: I9741e55cacb4522fdcfedb4c090b7007ef50b9fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697608Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#677024}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/06ab6e5b1330..2a1d8c2b1d32 git log 06ab6e5b1330..2a1d8c2b1d32 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 cwallez@chromium.org Remove ShaderStage that doesn't exist in WebGPU. Created with: gclient setdep -r src/third_party/dawn@2a1d8c2b1d32 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: Id1e17c2ad8ef6966c17063f6850752834bbd20f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699296Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7c146083d510..214323b343e9 git log 7c146083d510..214323b343e9 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 vapier@chromium.org [Typ] fix artifact test encoding 2019-07-12 vapier@chromium.org [Typ] clean up obsolete codereview.settings Created with: gclient setdep -r src/third_party/catapult@214323b343e9 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:983432,chromium:983432 TBR=zhanliang@google.com Change-Id: Iee8a560f09253ebdb96272e75f1a851a328e9133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699408Reviewed-by:
-
Mei Liang authored
In addition, this CL hides the tab switcher button on the top toolbar when duet and clank to start are enabled. Change-Id: Id7f24a5708e9f6136c71346e19e0cd9715d877f7 Bug: 979325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700282Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#677021}
-
