- 14 Oct, 2019 40 commits
-
-
chrome://safe-browsingXinghui Lu authored
Screen shot: https://screenshot.googleplex.com/My1OamJqnYy The CL only includes web UI logic, the code that triggers this UI will be included in a follow up CL. Bug: 1013370 Change-Id: I2b785ea711a0c62c9b7fa3c3dcac811307289d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856804 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#705693}
-
Xianzhu Wang authored
The code had a bug that the same transform was dumped multiple times if it was referenced by multiple layers. Also dumping scrollPosition is not meaningful because we rely on transform/scroll property trees for scrolling. Change-Id: I7ca08ecd2db392e5f8a13ed866321b70d6545f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860681 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#705692}
-
Kristi Park authored
LocationIconView overrides WidthMultiplier() in order to remove the shrinking animation. However, IsShrinking() will still return true during the shrinking phase due to |open_state_fraction_|, causing GetSizeForLabelWidth() to briefly return a non-offset width. Therefore, call a new function, SetUpForAnimation(), which will only animate the label in. Bug: 1012107 Change-Id: I2757003690d12edd6b24e0ea30d03d4ba622eba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850968 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#705691}
-
Lei Zhang authored
The test times out in a flaky manner on several platforms, so disable them there. TBR=mlamouri@chromium.org Bug: 1014229 Change-Id: I2d030a0e26f207e07f1c9a4e4a9b174e1b46e78c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860309Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705690}
-
liberato@chromium.org authored
It seems like CodecImages are sometimes being used for drawing after they have been marked as unused for the MCVD shared image pool. It is likely that this happens when the renderer is torn down before receiving returns from viz (e.g., renderer crash). This CL causes CodecImage to handle these cases gracefully, rather than crash. Bug: 1010621 Change-Id: Ibd25fd13dc477f1702df2b11a3c4ff46413f0f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853113Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#705689}
-
Steven Bennetts authored
Same fix as: https://chromium-review.googlesource.com/c/chromium/src/+/1834203 except for the details dialog. TBR=khorimoto@chromium.org Bug: 1014200 Change-Id: Idc6a7c63ec72995d78dec38497904290197a22f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860874Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#705688}
-
Manas Verma authored
Whenever card suggestions are shown, and the user has server cards and is eligible for FIDO authentication, a preflight call is made to retrieve authentication details. Logging the latency of this call. Bug: 949269 Change-Id: I53a9f00c9427ad26906a927e6a2a97bb4bf4f4e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808481 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#705687}
-
Sidney San Martín authored
Bug: 1014155 Tbr: kinuko Change-Id: I073800ae1c4b5494844798d6615e75032d9f100b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860311Reviewed-by:
Sidney San Martín <sdy@chromium.org> Reviewed-by:
-
Lei Zhang authored
TBR=jityao@google.com,voit@google.com Bug: 1014239 Change-Id: Ic49689798f3c44816c537e2bf26c05c702e5a480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859581Reviewed-by:
-
Alexander Timin authored
Also send the event to the RenderFrameHostImpl. In the future we can use this to store the theme_color in the RenderFrameHostImpl instead of doing it in the WebContentsImpl, which will make it easier to persist the color when the page goes into the BackForwardCache TBR=mtklein@google.com Bug: 1001087 Change-Id: Ifdb81f8b7e71f41801b7bb32a8d1544eed9ed302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821903 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705684}
-
Lei Zhang authored
ServiceWorkerTest.FetchFromContentScriptShouldNotGoToServiceWorkerOfPage is flaky. TBR=horo@chromium.org Bug: 1014222 Change-Id: I8571373c1a7478b6719de10f062b9191866041aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860478Reviewed-by:
-
Daniel McArdle authored
New fuzzers are update_client_protocol_parser_fuzzer and update_client_protocol_serializer_fuzzer. Corpuses were generated by taking examples from protocol_parser_json_unittest.cc and protocol_serializer_json_unittest.cc and then minimizing. Bug: 1012898 Change-Id: Iddab1c9158e2886270930e25045b33506bfe166b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850316 Commit-Queue: Max Moroz <mmoroz@chromium.org> Auto-Submit: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705682}
-
Asanka Herath authored
Based on Justin Tervay's https://chromium-review.googlesource.com/c/chromium/src/+/1731617 Adds a feature flag to //chrome/common that controls whether the browser process enables FTP support when constructing the network service. The feature is enabled by default. Blink I2D: https://groups.google.com/a/chromium.org/d/msg/blink-dev/e1hkwUL4p3w/11sdjpuMAgAJ Chrome feature status: https://chromestatus.com/feature/6246151319715840 Original-Author: Justin Tervay Bug: 333943 Change-Id: Ib1a79809d733345fc80a47a9a4b5e3ee253771a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860693Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#705681}
-
Lei Zhang authored
This reverts commit e0dffd84. Reason for revert: Broke Windows archive bots. (Slightly speculative) https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/6444 https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/6062 Note, the error comes from headless/, where the build config to handle multi-DLL is very fragile. Original change's description: > Set is_multi_dll_chrome to false by default > > This change sets is_multi_dll_chrome to false by default thus merging > chrome.dll and chrome_child.dll to a single dll. This saves disk space > and improves startup performance. It is also consistent with all other > platforms (windows was the only platform the split was enabled by > default). > > Bug: 726150 > Change-Id: Iade2c7f1bbe696d45ebac7483072f7e2e7e84ab4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850272 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705667} TBR=gab@chromium.org,thakis@chromium.org,brucedawson@chromium.org,wfh@chromium.org,chrdavis@microsoft.com Change-Id: I8dd4c4c075c855e1ce68e08c766eab34374ed3e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 726150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860903Reviewed-by:
-
Dmitry Gozman authored
This moves history navigation virtual time pauser from RenderViewImpl to Page, which has two benefits: - slimming down RenderViewImpl; - encapsulating virtual time inside Blink. Most of changes are moving virtual time pauser creation from thread scheduler to page scheduler. Bug: none Change-Id: I9fc2683e974e005d8cea35ced0f5f82931215b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856929Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/033004652faf..1ab0a72d103d git log 033004652faf..1ab0a72d103d --date=short --no-merges --format='%ad %ae %s' 2019-10-14 raphael.kubo.da.costa@intel.com Make upload_to_google_storage.py and tests work with Python 3. 2019-10-14 raphael.kubo.da.costa@intel.com Make download_from_google_storage_unittest.py work with Python 3. 2019-10-14 raphael.kubo.da.costa@intel.com upload_to_google_storage_unittest.py: Make StringIO usage Python 3-compatible 2019-10-14 raphael.kubo.da.costa@intel.com Use assertEqual() rather than assertEquals() in Python tests. 2019-10-14 raphael.kubo.da.costa@intel.com Make the queue module work with both Python 2 and Python 3. 2019-10-14 bsheedy@chromium.org git-cl: Add yapfignore support to git cl format Created with: gclient setdep -r src/third_party/depot_tools@1ab0a72d103d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:984182,chromium:1009819,chromium:984182,chromium:1007872,chromium:1009819,chromium:984182,chromium:1007872,chromium:1007872,chromium:1009819 Change-Id: Ic50960cb2c7dc316da056b23942fd2588671367b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860451Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705678}
-
Qingsi Wang authored
Bug: None Change-Id: Ifadf8f15b4a50a16a11d53f6c499636ec0845420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860145Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Qingsi Wang <qingsi@chromium.org> Cr-Commit-Position: refs/heads/master@{#705677}
-
liberato@chromium.org authored
Change-Id: I831b6ffd1de72c70ffaba12e2d4ab6e7702be8c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857022Reviewed-by:
-
Lily Chen authored
Bug: 978172 Change-Id: I744d4fd879a0b4588c9194b28d1e5a4905a67306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860301Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#705675}
-
Steven Bennetts authored
This fixes a logic bug when the code was changed to use ActiveNetworksChanged and should generally make the code more robust. https://chromium-review.googlesource.com/c/1433113 Bug: 967659 Change-Id: I206b1e3343f7afc6e34e6164bb6b710280a18ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856864Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#705674}
-
George Burgess IV authored
To address issue 1005023, I'm adding indirect call profile removal to our AFDO pipeline. Since that's currently in dry run mode due to recent shakiness/instability (yay, cascading breakages...), I wasn't planning on rolling new profiles until after the branch. So we need a postprocessed profile before the branch, but don't want to roll profiles until after. Hence, use a manually-postprocessed profile. Bug: 1005023 Change-Id: I5c127d6f8ee279ec9f01b90ee9748e5193fb237a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859679Reviewed-by:
Tiancong Wang <tcwang@google.com> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#705673}
-
Ian Kilpatrick authored
There should be no behaviour change. Change-Id: I9de23687e6cf24c76de57f341e4fecd780c66fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860682Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#705672}
-
Dale Curtis authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/a91a03b0e143..62fcd0cb19d2 $ git log a91a03b0e..62fcd0cb1 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 martin ci: Try switching two GCC based arm/aarch64 build configurations to debugoptimized 2019-10-11 martin arm64: ipred: Make sure all symbols are aligned 2019-10-11 jb Update news for 0.5.0: z2-avx2, ipred-neon and wiener-vsx 2019-10-10 martin arm: util: Split movrel into movrel and movrel_local 2019-10-10 ltrudeau Check loopfilter levels prior to calling lf_mask 2019-10-01 martin arm64: ipred: NEON implementation of the cfl_ac functions 2019-09-30 martin arm64: ipred: NEON implementation of the cfl_pred functions 2019-09-26 martin arm64: ipred: NEON implementation of the filter function 2019-09-25 martin arm64: ipred: NEON implementation of palette prediction 2019-09-24 martin arm64: ipred: NEON implementation of smooth prediction 2019-09-19 martin arm64: ipred: NEON implementation of paeth prediction 2019-10-09 gramner x86: Add ipred_z2 AVX2 asm 2019-10-09 gramner Simplify ipred_z C code 2019-10-09 gramner checkasm: Improve ipred_z tests 2019-10-09 jamrial x86: fix generate_grain_uv checkasm crashes on Windows x64 2019-10-09 jb Update NEWS for 0.5.0 2019-10-09 malvanos Add VSX wiener filter implementation 2019-10-08 jb Move snap to package/ subfolder 2019-10-07 martin arm: mc: Port the ARM64 warp filter to arm32 2019-10-07 martin arm64: mc: Use addp instead of addv+trn1 in warp 2019-10-02 martin arm: cdef: Port the ARM64 CDEF NEON assembly to 32 bit arm 2019-10-07 martin arm: Support PIC loading of non-global symbols in the movrel macro on apple platforms 2019-10-08 ltrudeau Remove branch when changing bit in LR edges mask 2019-10-05 martin arm64: cdef: Improve find_dir 2019-10-04 martin arm64: cdef: Calculate two initial parameters in the same vector 2019-10-03 martin arm64: cdef: Use loads with postincrement in more places in the padding function 2019-10-01 martin arm64: cdef: Rewrite an expression slightly 2019-10-07 ltrudeau Don't backup pixels if next restoration unit is NONE 2019-10-07 rsbultje Add AVX2 version of generate_grain_uv (4:2:0) 2019-10-04 martin arm64: mc: Schedule instructions better in the warp8x8 functions 2019-10-03 ltrudeau Check for RESTORATION_NONE once per frame 2019-10-02 martin arm64: mc: Use sbfx instead of ubfx+sxth in the warp function 2019-10-01 gramner x86: Increase precision of SSSE3 IDCT intermediates 2019-09-27 gramner x86: Increase precision of AVX2 IDCT intermediates 2019-10-01 gramner checkasm: Add a function listing feature 2019-10-01 gramner Simplify README build instructions 2019-09-30 rsbultje Minor cleanup 2019-09-18 martin arm64: ipred: NEON implementation of dc/h/v prediction modes Created with: roll-dep src/third_party/dav1d/libdav1d TBR=tguilbert Change-Id: Ie9925a9363001dfd0e5eb41f0078d06824ca502a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860142Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#705671}
-
Livvie Lin authored
Bug: 1008218 Change-Id: I1bdeaa0c31413d701c64acd748a1b196177b3fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857047Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705670}
-
dalyk authored
This is a reland of e4dc12db The only new change made in this reland fixes compile errors in quic_stream_factory_test.cc. Original change's description: > Add disable_secure_dns support to net/quic, net/http, and net/spdy. > > This change is a no-op. It puts into place the needed support in the > net/quic, net/http, and net/spdy directories for disabling DoH. A follow- > up cl will add a similar field to URLRequest. > > Change-Id: I598cc5da88061e04bd234fa70e7f4c306817fd5d > Bug: 1012268 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842220 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Katharine Daly <dalyk@google.com> > Cr-Commit-Position: refs/heads/master@{#705610} Bug: 1012268 Change-Id: I007a04e36cb7876cc08f58b343dc922c04276c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860690Reviewed-by:
-
Elly Fong-Jones authored
These are all mechanical. Bug: 1011446 Change-Id: I7710b18807cad6ad3cb9d6b22d7a07f1c12a8e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860095Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#705668}
-
Chris Davis authored
This change sets is_multi_dll_chrome to false by default thus merging chrome.dll and chrome_child.dll to a single dll. This saves disk space and improves startup performance. It is also consistent with all other platforms (windows was the only platform the split was enabled by default). Bug: 726150 Change-Id: Iade2c7f1bbe696d45ebac7483072f7e2e7e84ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850272Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#705667}
-
Ian Kilpatrick authored
... instead of VisualSelfOverflowRect. Children wouldn't have painted if enabled with FragmentItems, or BoxPainting enabled. Originally added in: https://chromium-review.googlesource.com/c/chromium/src/+/1628634 Bug: 988015 Change-Id: I4925f51b66f67f74504d2a4e1fb25b157aa060ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859681Reviewed-by:
-
Matthew Mourgos authored
Bug: 1012917 Change-Id: Ifd02e7d6b0331e54cf2839b26b9e8bec521d3c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857094Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#705665}
-
Manas Verma authored
Changing "on-click" to "on-change" for the settings-page-button for enabling/disabling FIDO authentication for card unmasking. This makes the toggle a lot more responsive. Bug: 949269 Change-Id: Id8b986c0d74ca9459a40e3a1ba1e287b78bfdee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857547Reviewed-by:
-
Christoph Schwering authored
CL 1388111 / Commit b2020be3 removed timestamps from OnFormSubmitted(), the reason being that they were always Now(). They weren't always Now() in the unit test. This commit re-adds the non-Now() timestamps to the unit test. Bug: 1009364 Change-Id: I1204ee2e6d43685c0ac7a2e77c93236cceadf42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860340 Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Christoph Schwering <schwering@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#705663}
-
Dan Beam authored
R=mahmadi@chromium.org Fixed: 1013833 Change-Id: I3eac331445d5e76917506f52886a461db484fef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857377Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#705662}
-
Alex Chau authored
- Derive ECPrivateKey from secret deterministically using EC_KEY_derive_from_secret - Will be used for VapidKeyManager to generate a ECPrivateKey from 256-bit secret from Chrome Sync, as illustrated in https://crrev.com/c/1848171 Bug: 1010968 Change-Id: Id2445ff802e9598ad3b454dc42972a6812713885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844961 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#705661}
-
Nico Weber authored
...now that this is easy to do after #705630. Bug: 961769 Change-Id: Icfecf48eda96f94f548c1e1d2e772caf9bcfe9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860522 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#705660}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9bc8545214f9..bb3e02a14bb9 git log 9bc8545214f9..bb3e02a14bb9 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 vapier@chromium.org toolchain_util_unittest: do not use __builtin__ Created with: gclient setdep -r src/third_party/chromite@bb3e02a14bb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4dddd9dcf9560df6525544e5f9cc84e0d5dd9028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859818Reviewed-by:
-
Jacques Newman authored
Previously the ui::AXPosition methods, GetText and CreatePositionAtTextBoundary did not correctly ignore ignored nodes. This change ensures that ignored nodes do not contribute to the text specified in "GetText". This change also ensures ignored nodes are not incorrectly identified as text boundaries for all but paragraph and format. Paragraph and format boundary behavior in regards to ignored nodes will be fixed in a follow-up change. To ensure that Movement and ExpandToEnclosingUnit have the same behavior for word and character navigation, ExpandToEnclosingUnit is called after word and character movement where the endpoints are not on the same anchor. Change-Id: Ieacf955435205e194bdd1f937678b84f8728bff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810244 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#705658}
-
Nate Fischer authored
This persists the install date pref, so this will now log the install date of the WebView-embedding application. For existing clients, this will log the first startup in a milestone of WebView which persists this pref. This also includes logic to look up the install date if it's not already logged, otherwise the install_date field would just log the date users updated to a version of WebView which supports this field. This logic is meant to be temporary. I've added a histogram to track when we can safely remove this workaround, and added a tests to verify the logic and that the histogram is logged. Bug: 1012025 Test: startup webview shell multiple times, log install_date inside Test: AwMetricsLogUploader::UploadLog, verify it stays consistent Test: run_android_webview_unittests --gtest_filter=AwMetricsServiceClientTest.* Change-Id: I2d9238120b6bab2e08c116bf8f57e541b905534d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846812Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#705657}
-
Kevin Marshall authored
Chromium's log output to the Fuchsia logging service has a lot of header boilerplate because each log line has concatenated prefixes from both Chromium and Fuchsia. This makes syslog data hard to read because each line is very likely to wrap around on an 80-100col terminal. This CL strips the Chromium logging prefix from the logging data and provides log lines' source location as log "tags". Sample log line prefix, before this CL (146 chars): [00582.348425][130450][130452][ui_base_unittests__exec] ERROR: \ [130450:3944750047:1007/220315.685215:582348409:ERROR:base_paths_fuchsia.cc(21)] ... Sample log line prefix, after this CL (89 chars): [00517.527091][108865][108867][ui_base_unittests__exec] ERROR: base_paths_fuchsia.cc(21) ... Bug: 1012037 Change-Id: Ia51442711ca8575246170b5090a4abafc45fcc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846395 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#705656}
-
Alexander Timin authored
Ensure that RenderFrameHostTester::SimulateLoadingCompleted fires DocumentAvailable / DOMContentLoaded / OnLoadCompleted / DidStopLoading callbacks in addition to DidStopLoading to simulate real-world loading callback sequence more accurately. This patch also adds a browser test to ensure that the loading callback order is the same in the real world. This patch is a prerequisite for exposing the loading stages from RenderFrameHost / WebContents as the tests need these callbacks to be dispatched to work correctly. R=clamy@chromium.org,arthursonzogni@chromium.org,ahemery@chromium.org TBR=jianli@chromium.org,pasko@chromium.org,dbeam@chromium.org,mastiz@chromium.org,drubery@chromium.org CC=bfcache-bugs@chromium.org BUG=1011770 Change-Id: Ibe59b1b131f3911fe9c4bf641e8ea1c6bb1ba545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834343 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#705655}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ifdf602ca013d604dc4fccd270798f70c85d63e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860316Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#705654}
-
