- 22 Apr, 2019 40 commits
-
-
Eric Aleshire authored
As part of the EG2 migration, app-side helpers that used to GREYAssert now return NSError*, which are asserted on in test-side code. ASSERT_IF_ERROR simplifies the modification required for test code that call these app-side helpers, while preserving the line number of the failure. This CL aligns the test code in these 4 CLs to use ASSERT_IF_ERROR: http://crrev.com/c/1562756 http://crrev.com/c/1553085 http://crrev.com/c/1558155 http://crrev.com/c/1559889 Bug: 922813 Change-Id: I2d82dd9cd6a9eab6913418d357649c1f13f3699f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574954 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#652855}
-
Alison Maher authored
This change implements Implement ITextRangeProvider::Move. This implementation uses MoveEndpointByUnit to do most of the functionality, with some edge cases handled. Unit tests were added for all unit types except Format and Paragraph. Unit tests for these will be added once MoveEndpointByUnit is completed for each type. AssertMoveEndpointByUnit() and AssertMove() helper functions were added to the unit tests to decrease the amount of repeated code and to increase readability. Bug: 928948 Change-Id: I22dfa7017d162b83fdc6db66dbcfd5266d98bfcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569522Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#652854}
-
Aran Gilman authored
In particular, the following were changed: * Reduce wordiness. * Run mdformat. * Remove information about SCOPED_TRACE(), since that appears to be outdated (or maybe just misleading). * Replace section on Google-internal script with link to internal Chrome A11y page on the topic. Change-Id: I94e3a47f435f092b225a60ae2e35c06ddba8d2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555417Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6350cb0f4bb3..cbc33b8e3574 git log 6350cb0f4bb3..cbc33b8e3574 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 brianosman@google.com Add SkSL viewing/editing to viewer Created with: gclient setdep -r src/third_party/skia@cbc33b8e3574 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: Icdf90dcfc90ea4e93ece175bf62fa5c0139cbf6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576151Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652852}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1800687a19fc..65dffa4595e2 Created with: gclient setdep -r src-internal@65dffa4595e2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: Ib5e29768284f8532be816d552f1492a31f9f75ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576150Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652851}
-
Ahmed Fakhry authored
This CL adds the remaining desks containers in preparation for using them in the next CL. This CL also makes sure that the correct container IDs list is used based on whether the Virtual Desks feature is enabled or not. BUG=866622 TEST=ash_unittests are passing. Change-Id: I5919b362b484a2eab13d4d6243bdbdc9c10ef442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568766Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Mitsuru Oshima (Slow 4/22-26) <oshima@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#652850}
-
Charlie Andrews authored
NOTRY=true TBR=ulan@chromium.org, mythria@chromium.org Bug: 954959 Change-Id: I685f32972feec1f2f0fc183babf56ebb808669c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577559Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#652849}
-
Charlie Andrews authored
There's a bug (linked) where one story is failing, calling other stories to unexpectedly skip. We originally thought that this was limited to the stories with the Ads prefix, but ebay.fr has started failing and it's clear that our original belief was wrong. NOTRY=true TBR=ulan@chromium.org,mythria@chromium.org Bug: 954229 Change-Id: Id4c3770094b52bf7ec5bacfca12980581e81e276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576156Reviewed-by:
-
Kaan Alsan authored
Sequence numbers are now incremented based on vsync intervals. If two consecutive BeginFrameArgs are created 5 ticks apart, then their sequence numbers will differ by 5 instead of 1. Doc: https://docs.google.com/document/d/1rvC3iBqL41R2dg_QN92yAFxU9ic6Irk89-9LBlyBJ_U/edit?usp=sharing Change-Id: I8b3d8614079cc2ef44f8fad6420314a97b12f260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538540 Commit-Queue: Kaan Alsan <alsan@google.com> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#652847}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4e27c1c2. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e921520 "[Code Health] Remove unnecessary reference file for web test" 40465b74 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" e28269b6 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ife0345ad35fc2890640ac0a7183d4dabd07faa21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576148Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652846}
-
Charlie Andrews authored
The story has been flaky since 3/26. NOTRY=true TBR=sullivan@chromium.org,tdresser@chromium.org, perezju@chromium.org Bug: 954949 Change-Id: I2a60b0faaa723aa5b1dda0e23ab310dc1751714c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576155 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
-
Charlie Andrews authored
The story hasn't passed reliably since 3/26. NOTRY=true TBR=vmiura@chromium.org,sadrul@chromium.org Bug: 954948 Change-Id: I0f2dc1cb5f372dc5cbe9607897de189f65965ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576153Reviewed-by:
-
Bence Béky authored
Make sure every .h and .cc file in //net ends in exactly one newline character. Change-Id: I5c7777055705e6a881b37f8f8386880dd810e9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576437Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#652843}
-
Koji Ishii authored
Following bot results are included. 18534 18536 18541 18547 18559 2 lines were removed and 2 lines were deflaked by consecutive results since 18518. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I94462bd4b20fa7abc2ef163c0d4361d079a3867c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574872Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#652842}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ba1602896d72..6350cb0f4bb3 git log ba1602896d72..6350cb0f4bb3 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 mtklein@google.com Revert "Add explicit GrSurfaceProxy flag to skip explicit resource allocation" 2019-04-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 145ec7fa7c81..c467f7b54188 (4 commits) 2019-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a16238df3f28..bcc71a322953 (7 commits) 2019-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a55917cb..3ed0f757 (344 commits) 2019-04-21 reed@google.com use portable typeface for new gm 2019-04-21 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2019-04-21 rmistry@google.com Skip __init__.py in webpages_playback.py 2019-04-21 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-04-20 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-04-19 jvanverth@google.com Add Metal support for dynamic buffers. 2019-04-19 reed@google.com Add secret draw-behind method 2019-04-19 bsalomon@google.com SkClipStack::isRRect succeeds if stack is an intersection of rects. 2019-04-19 csmartdalton@google.com ccpr: Calculate edge coverage in the coverage processor 2019-04-19 ethannicholas@google.com Fixed internal skslc error with negated literal vectors 2019-04-19 egdaniel@google.com Adjust vulkan memory allocation block size knobs to better match the type of draws we do. 2019-04-19 ethannicholas@google.com reworked SPIR-V binary operations and added support for VectorTimesScalar 2019-04-19 robertphillips@google.com Add explicit GrSurfaceProxy flag to skip explicit resource allocation Created with: gclient setdep -r src/third_party/skia@6350cb0f4bb3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/122296071 TBR=mtklein@chromium.org Change-Id: Ia6c5b3d0d39084ce4babfc479d2e7c8a9fc909aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576147Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b225628db89b..1800687a19fc Created with: gclient setdep -r src-internal@1800687a19fc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I95318907a9c76583de1dfe07853daed88d8047f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576145Reviewed-by:
-
Henrique Ferreiro authored
As advised in [1], this CL ports calls to Foo::Create() factory functions to use MakeGarbageCollected<Foo> from classes in //third_party/blink/renderer/core/html. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I59157e7d12ab3104f28c891fcfe28d8ad89cd8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572348Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#652839}
-
Bence Béky authored
Bug: 954503 Change-Id: I54d5c45d2d2e3a85c6f88a214f19adaefe5e5a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577478Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I0fac9632aff1092a292a054aaf8ce581b15d6feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576146Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0fad4bc4. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e921520 "[Code Health] Remove unnecessary reference file for web test" 40465b74 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" e28269b6 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I5b1b85810fbe60837c437267a010f9bd69fa7d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577404Reviewed-by:
-
Paul Jensen authored
Looks caused by crrev.com/652649 Bug: 820198 Change-Id: Ifa4633140962e1a88097a466370d12f3d39065cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576436 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Auto-Submit: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#652835}
-
Paul Jensen authored
Bug: 954503 Change-Id: Ie52549316bb71e476335f63e95c6c178245cdd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575842 Auto-Submit: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#652834}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f16de09753fe..f66107f9aa31 git log f16de09753fe..f66107f9aa31 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 dgagnon@google.com Point R75 ARC++ branch at nyc-mr1-arc-m75 and pi-arc-m75 2019-04-22 evanhernandez@chromium.org patch: Only submit on CQ+2. Created with: gclient setdep -r src/third_party/chromite@f66107f9aa31 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I2f947c16b7e0514204f33b8352d0c67179c3c1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576829Reviewed-by:
-
Elad Alon authored
Bug: None Change-Id: I4a9274b4c53b0925d2a51b610313fbaf4613ad2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570173Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#652832}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a04941c1f00..b225628db89b Created with: gclient setdep -r src-internal@b225628db89b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: Id5780847d95dd99b5a1ea5c6d7559ad0006d01e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576828Reviewed-by:
-
Matt Falkenhagen authored
This would have been useful in the investigation of the linked bug, otherwise we just see an unknown URLLoaderClient impl taking all the time. Bug: 931193 Change-Id: Ic198315ed6272155eca8a14ca8f3a29b17b93251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574873Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#652830}
-
Jochen Eisinger authored
Change-Id: I20de6b6857351dd8f57fea86e94a0f5a346fb454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576562 Auto-Submit: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#652829}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8845f8e7aec3..9a04941c1f00 Created with: gclient setdep -r src-internal@9a04941c1f00 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I26ce2009b2cbd51bfe7f205bdc7f9c61e2a95a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576827Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9825beff. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e921520 "[Code Health] Remove unnecessary reference file for web test" 40465b74 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" e28269b6 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-text/overflow-wrap NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ic54a1e9808b88e05ba5ef784e66fdafc0730faa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577311Reviewed-by:
-
Miyoung Shin authored
Replace the use of std::map and std::set of std containers with WTF::HashMap and WTF::HashSet in web_frame_test.cc. Bug: 952716 Change-Id: I5978b5cd21bbff120d9ea90ec38dd1bb9f1a8ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577225Reviewed-by:
-
Corentin Wallez authored
These WebGPU IPC commands allows wrapping a mailbox in a Dawn texture and associate it to a given ID in dawn_wire. There is the respective dissociate command too. SharedImageRepresentationIOSurfaceDawn is changed to destroy() the Dawn texture on EndAccess so it is an error to access the texture after the mailbox has been dissociated. The class also gets some refcounting improvements. This also makes some GPU service objects able to be used when no GL context is present, as is the case when running WebGPU unittests. BUG=chromium:877147 Change-Id: I22233d01faf4948385cc028a7ce2a2a140ee7a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566347Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#652825}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c467f7b54188..cff6f150eae1 git log c467f7b54188..cff6f150eae1 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 0e5d1bb66ad3..86c72c9486a9 (3 commits) Created with: gclient setdep -r src/third_party/angle@cff6f150eae1 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Icd4a62b7f9e79bc6f3dd06d67c94a2adba863d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576826Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b9dc9c164f6..8845f8e7aec3 Created with: gclient setdep -r src-internal@8845f8e7aec3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I0322448ae0bf7cf2870e31826ef5d25d558df031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576825Reviewed-by:
-
Kent Tamura authored
Bug: crbug.com/627682 Change-Id: I6f7a7c39c5d7fe0c0e4ba01613bd38886216c918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574874 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#652822}
-
Koji Ishii authored
This is a minor cleanup to move |ClearNGInlineNodeData| to after layout. Avoids calling it when caching is valid, and avoids one call to |FirstChild()| which is not really cheap. Bug: 636993 Change-Id: I6b5dacfc1204a737ed100d2592fc33b9035240ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577221Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#652821}
-
Kai Ninomiya authored
This reverts commit 62e2574d. Reason for revert: M-75 has been branched. Original change's description: > Disable use_dawn on Mac for the branch point > > BUG=chromium:852089 > TBR=kbr@chromium.org > > Change-Id: I63ba202ac4eb937088ee471a84d8d49ef0a2334a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571690 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#651886} TBR=kbr@chromium.org Bug: chromium:852089 Change-Id: I7b4ff29d6240903cc305a849edcb2c5629d3e484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576260Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#652820}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e2b6f2b2ada1..3b9dc9c164f6 Created with: gclient setdep -r src-internal@3b9dc9c164f6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: Ib66760e275cf19bdf9077aef76652894da5a0276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576823Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit 92ecc62f. Reason for revert: suspect ash_unittests failure on Linux Chromium OS ASan LSan Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/32865 ExtendedDesktopTest.KeyEventsOnLockScreen OverviewSessionTest.RemoveDisplay OverviewSessionTest.RemoveDisplayWithAnimation PersistentWindowControllerTest.DisconnectDisplay PersistentWindowControllerTest.MixedMirrorMode PersistentWindowControllerTest.NormalMirrorMode PersistentWindowControllerTest.ReconnectOnLockScreen PersistentWindowControllerTest.RecordNumOfWindowsRestored PersistentWindowControllerTest.ThreeDisplays PersistentWindowControllerTest.WindowMovedByAccel ... https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8915703982173055536/+/steps/ash_unittests/0/logs/Deterministic_failure:_ExtendedDesktopTest.KeyEventsOnLockScreen__status_CRASH_/0 ==31193==ERROR: AddressSanitizer: container-overflow on address 0x6020001da810 at pc 0x55d92be6ea70 bp 0x7ffe03af0a30 sp 0x7ffe03af0a28 READ of size 8 at 0x6020001da810 thread T0 #0 0x55d92be6ea6f in ReparentAllWindows ./../../ash/root_window_controller.cc:256:41 #1 0x55d92be6ea6f in ash::RootWindowController::MoveWindowsTo(aura::Window*) ./../../ash/root_window_controller.cc:622:0 #2 0x55d92bc99cf5 in ash::WindowTreeHostManager::DeleteHost(ash::AshWindowTreeHost*) ./../../ash/display/window_tree_host_manager.cc:563:15 Original change's description: > ash: Keep active window uncovered on display change > > - FocusActivationStore uses ActivateWindow(nullptr) for deactivating > to avoid an arbitrary window covering the active window before > Restore(). > - RootWindowController puts the moved windows under existing ones > on display change. > > Bug: 945754 > Change-Id: I3cacfd3427b8c98c9ce9dd2da05977120c1c1d65 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574824 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652678} TBR=xiyuan@chromium.org,oshima@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 945754 Change-Id: Ibf3b8cb823388837f6b3d3052e8258b78fd9a9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577223Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#652818}
-
Kuo Jen Wei authored
Change-Id: I869182973b24d09fb5477c0f01fc2bb6892d3288 Bug: 954561, 954564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574875Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#652817}
-
Kenichi Ishibashi authored
Follow the spec update. Bug: N/A Tbr: nhiroki@chromium.org Change-Id: I7e3a79257f9c33d0287ddc21a2f135ad2fdbe575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577318Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#652816}
-
