- 17 Apr, 2020 40 commits
-
-
Vasilii Sukhanov authored
Bug: 1049200 Change-Id: Id9aa8e0f60fe010360b0f7c20d456b0375f6e1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153108Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#760244}
-
Nigel Tao authored
Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking result.value (which has a base::Optional type, convertible to bool). Callers don't care about error_code, other than == or != JSON_NO_ERROR. Bug: 1069271 Bug: 1070409 Change-Id: I5483d116ee9d5813815118c495474ba50f4255e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154435Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#760243}
-
Robert Liao authored
Change-Id: I29dc8309d545b4fbc7f51e21573b2582f6c82954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154924 Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#760242}
-
Jonah Ryan-Davis authored
Push back expiry for several ANGLE-related histograms to M85 Bug: chromium:1037116 Bug: chromium:1037111 Change-Id: Ie9cc0aa851d0346f5ea4f7f46eeb0de2e9925398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155012Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#760241}
-
Sami Kyostila authored
We're seeing some crashes during removing cancelled tasks from work queues. Add some debug annotations to help understand where these invalid tasks are coming from. Bug: 1071475 Change-Id: Ic4ba31b8a9585e44e70c7151f461615253291ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153117 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#760240}
-
Badhri Ravikumar authored
Support for opening a link in new tab/window exists using mouse. But after setting focus over link by pressing Tab key, we do not have the provision to open the link in new tab/window using keyboard shortcut. This new API carries keyboard modifier value whenever URI action needs to be performed. Unit tests are added to validate the newly added API. Bug: chromium:994500 Change-Id: Id7936c0ec42115f92a790f4d469f65c6194f9d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154432Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Badhri Ravikumar <bravi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#760239}
-
Ayu Ishii authored
This change adds CookieStoreAPI to UKM use counters to record usage of the API and observe how it is being used to help with improvements to the shape of the API. CookieStoreAPI Explainer: https://github.com/WICG/cookie-store/blob/master/explainer.md Change-Id: Ib27ee0d5c228eb8a3e67540a4f0a4bb8a513187d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149866Reviewed-by:
-
Lei Zhang authored
OnUpdatePrintSettings() handles an IPC message with a base::Value. Bad base::Value inputs can trigger crashes, as found by the ipc_fuzzer. Add some sanity checks to prevent one such crash. Bug: 1013764 Change-Id: I41bdece8766152065808c55260ec1e9884cc4673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154367Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#760237}
-
dpapad authored
Bug: 1069258 Change-Id: I7bc517d3a4a105e79ddf3572573a518dbb8e0a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155006 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
-
Joshua Pawlicki authored
This is a reland of 2fe1a951 The root cause is believed to be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/2154740 SHERIFFS: If this breaks Windows deterministic, then the above fix is incomplete and this CL should be reverted. Original change's description: > Updater: Allow branding in uninstall.cmd and enable --uninstall test. > > Bug: 1070206, 1062285 > Change-Id: Ia5c5222efcf2b90e41f1db9f5cac216a15befb4f > Fixed: 1070206 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147752 > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758812} Bug: 1070206, 1062285 Change-Id: I775e958213ca80c5884b2d3633091ec4b8b3454c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155169Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#760235}
-
Ravi Chandra Sadineni authored
Recently an additional dropdown has been added to allow setting battery idle behavior differently from AC idle behavior. This setting is visible only when battery is present and is hidden behind a dom-if template. For some reason setting a value property on select HTML element that is under dom-if does not work properly. But setting selected boolean property on the option HTML element seem to work fine. Thus changing to setting the selected boolean property on option HTM element. BUG=b:148105990, 1065050, b:154167105 Test= Run browser_tests and manual tests. Change-Id: I83aeb7cd8640c4774853dcdd30f5acaf32ddd038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153604Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ravi Chandra Sadineni <ravisadineni@chromium.org> Cr-Commit-Position: refs/heads/master@{#760234}
-
Kyle Horimoto authored
This function was const, but this required some derived classes to have to be refactored in unintended ways. Removing to help unblock future changes. Bug: 1069849 Change-Id: I612b3b2cde668beca6373792c94cec2422c77583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155175 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#760233}
-
Becca Hughes authored
Add a MediaHistory histogram suffix for the DB. This is already defined in MediaHistoryStore but was not added to the XML file. BUG=1024362 Change-Id: I7c0d9242099febdc822f6bd1c27e044691011f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147886Reviewed-by:
-
Mugdha Lakhani authored
This is in response to feedback here: https://chromium-review.googlesource.com/c/chromium/src/+/2151455/4/chrome/android/java/src/org/chromium/chrome/browser/site_settings/CookieControlsBridge.java#12 Specifically, this makes it so site settings code doesn't depend on page_info code, and inverts the dependency. Bug: 1071776 Change-Id: I63abe25efe46d825fca9783247dee31d89a1962a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153436 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#760231}
-
Gavin Williams authored
- Adds functionality to CupsPrinterManager for allowing other classes to query for printer statuses. - CupsPrinterManager accepts a list of printer ids then kicks off an asynchronous printer status query for each printer. The printer status is cached using SavePrinterStatus. Bug: 1059607 Change-Id: Ie9ea5192fc046b106e3e299bf75cadb43e746605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102770 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#760230}
-
Jon Mann authored
This allows users to configure a custom domain through the UI at chrome://flags allowing for easier development and testing. For simplicity, this also updates the previous command line flags to use custom app/install urls to a new flag: --custom-android-messages-domain which accepts a single domain and appends the correct suffixes in code. Bug: 1055472 Change-Id: Ie3b1a69c258642fbe7e7f579cbf7f0b221d96f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154101 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#760229}
-
Alex Khouderchah authored
This change removes any remaining references to the following unused Shill Service properties: * kConnectedProperty ("Connected") * kEapCaCertNssProperty ("EAP.CACertNSS") * kEapClientCertNssProperty ("EAP.ClientCertNSS") * kEapClientCertProperty ("EAP.ClientCert") * kEapPrivateKeyPasswordProperty ("EAP.PrivateKeyPassword") * kEapPrivateKeyProperty ("EAP.PrivateKey") * kIdentityProperty ("Identity") * kOpenVPNCaCertNSSProperty ("OpenVPN.CACertNSS") * kOpenVPNCaCertProperty ("OpenVPN.CACert") * kOpenVPNCertProperty ("OpenVPN.Cert") * kOpenVPNClientCertSlotProperty ("OpenVPN.Pkcs11.Slot") Bug: None Change-Id: I69a50ee685fd23230d34d4190884f01c60379401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154544Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org> Cr-Commit-Position: refs/heads/master@{#760228}
-
Tommy Li authored
Prevents reentrancy in: TemplateURLService::ApplyDefaultSearchChangeNoMetrics Note there was already an attempt to prevent reentrancy, this CL just strengthens the check. The goal is stop the crashes from occurring, although this CL does not fix the root cause of the strange profile state. This also adds a test to verify that this re-entrancy can't occur. Bug: 953711, 1022775, 1031506 Change-Id: I3d7df640acd392e22182bcef0cb46eb3d54c28b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153886 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium db92a470. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 4de68d38 "fixup! [css-grid] Migrate flex-sizing-columns-min-max-width.html to WPT" f511fde8 "[css-grid] Migrate grid-gutters-and-flex-content.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Id019ff529648dfe63c39dac92f883257a89b4c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154916Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760226}
-
Yuchen Liu authored
Implement Grant/RevokeScreenAccess. GrantScreenAccess -- CastWebContentsComponent.start, or delay until window is created in createWindowForWebContents. RevokeScreenAccess -- CastWebContentsComponent.stop Bug: internal b/152275531 Test: repro steps in the bug. Change-Id: I1d2a4a3483face7899327dbc769b3ae2777e986f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151475 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760225}
-
Tommy Steimel authored
This CL enables picture in picture in the Global Media Controls by default on Windows, Mac, and Linux, since we've launched the feature. Bug: 1071962 Change-Id: Ic8e26af8453d07211e3f96fac05c3c9aa5d32215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154918 Auto-Submit: Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#760224}
-
Natalie Chouinard authored
Now that render tests are disabled on Android CFI bot (crrev.com/c/2154730), remove pixel diff thresholds that were added to address those failures. Bug: 1068294 Change-Id: I3ef98cfec4e183c54bf3c754089a2463282e634c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155011Reviewed-by:
-
Reilly Grant authored
This change removes special casing for composite devices and in the process fixes support for composite devices having multiple functions by adding support for holding multiple file handles open at once. Bug: 637404 Change-Id: I25b1e1c648e1d11c08231765b0843f0121525ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153888 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#760222}
-
Brandon Wylie authored
Bug: 1067717 Change-Id: I95a6dd55f669a3ffd4d2b3fd2c65a27618593b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136116 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#760221}
-
Sadrul Habib Chowdhury authored
Add some DCHECK()s in the code to validate some assumptions (e.g. make sure the reporters are terminated predictably), and update tests accordingly. BUG=none Change-Id: Id01bd571ad1d59b90c297f71097edcf3e6edc59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128448 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#760220}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/414782d132e8..b0aab2c7d1dc git log 414782d132e8..b0aab2c7d1dc --date=short --first-parent --format='%ad %ae %s' 2020-04-17 bsalomon@google.com Reland "Revert "Revert "GrDisplacementEffect uses GrTextureEffect.""" 2020-04-17 fmalita@chromium.org [skottie] Initial inner shadow layer style support 2020-04-17 michaelludwig@google.com Revert "Rename GrShape to GrStyledShape" 2020-04-17 ethannicholas@google.com Revert "Converted texture and runtime effects to use GrMatrixEffect" 2020-04-17 bsalomon@google.com Put top level FPs into their own functions 2020-04-17 mtklein@google.com support JITMode::Stack on ARM 2020-04-17 ethannicholas@google.com Converted texture and runtime effects to use GrMatrixEffect Created with: gclient setdep -r src/third_party/skia@b0aab2c7d1dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Ica8d598edd28bf51aeb04e33dcbcb4db3e9a5920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155187Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760219}
-
Maciek Kumorek authored
Add --simulate-update-hresult and --simulate-update-error-code switches. The first switch can take the HRESULT error code value, the second one specifies a value that corresponds to the GoolgeUpdateErrorCode enum. With these switches, when using VersionUpdaterWin, one can simulate errors in the about page to debug how the UI reflects certain errors conditions. Bug: 1066529 Change-Id: I6500b81108c69d252087ebcdb1cba0ffba86dbed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131019 Commit-Queue: Maciek Kumorek <makumo@microsoft.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#760218}
-
Philip Rogers authored
This patch marks the following test as flaky: virtual/form-controls-refresh-disabled/fast/forms/form-control-with-state-eager-tracing-crashTest.html The non-forms-refresh version is already listed as flaky. TBR=masonfreed Bug: 1042694 Change-Id: I682a326b97860e08ebcbc1fd23d163b874c116d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155245Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#760217}
-
Francois Beaufort authored
This change will allow us to measure image capture constraints usage and to decide if we can put the existing "zoom" constraint behind a permission prompt without much difficulty. Test: Go to beaufortfrancois.github.io/sandbox/image-capture/playground and check chrome://histograms/Blink.UseCounter.Features is updated with requested constraints. Bug: 934063 Change-Id: I4f5bcb6fc2b9b0c860127c4167fd2258fbaee975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151586Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#760216}
-
phillis authored
Add UKM metric that records SetBadge call per web app to track the Badging API usage on SetAppBadge. Review doc is at https://docs.google.com/document/d/1XNamCi2kjjGLQQ3uJtpYcZpxDTY1NlDnMBFBFjlybGk/edit Bug: 1051682 Change-Id: Ia6a1829cd275f873bc5a72d087b873f3f301959e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108537Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#760215}
-
Yuchen Liu authored
Add ClearKey test. ClearKey is handled in renderer process. It should be supported on all the cast builds. Bug: internal b/119043784 Test: CQ Change-Id: I736cb4a6e863d3d92a5c31ab259624b395f550d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155246 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Auto-Submit: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
Render tests are flaky on this bot, and contribute to its consistently red state. No plans to re-enable on this bot in future. Bug: 1068294 Change-Id: I06ff45c4f981e6fb0708dd08a5c711e4fc958de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154730 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#760213}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c572fb7d..d1705a0f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia0d0ee3281be0b39dcb5bb4cdd5cf64ffbf24c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153274Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760212}
-
Brian Sheedy authored
Switches the win10_intel_hd_630_experimental mixin to trigger tests in either chromium.tests.gpu.template or chromium.tests.gpu.experimental.template. The experimental machines will soon be upgraded to Windows 10 1909 for testing, so we want to move them to a separae pool so they don't pick up general traffic. TBR=kbr@chromium.org Bug: 1053803, 1065505 Change-Id: I9596a030ba089f824654ec610a9bed102641fc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154855Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#760211}
-
Xida Chen authored
This particular test case was changed here: https://chromium-review.googlesource.com/c/chromium/src/+/2022618 And that CL made a mistake. In particular, it added a shouldDelay which is meant to be used to delay the start of the main-thread animation, but shouldDelay is not used. This CL fixes that. Bug: None Change-Id: Ia8c2c1fea0918aee69ff07808969d7ac70f48cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154819 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#760210}
-
Thomas Tellier authored
Bug: 993653 Change-Id: I3cf5cf8596b9bb9f576af3b53723c03bd161a74e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153077 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760209}
-
Lei Zhang authored
- Initialize variables in the header; make some const. - Use = delete. - Remove unused Initialize(). - Use more specific DCHECKs. Change-Id: I1a9e2a35882193d7aae216ba09803bb3f8d620ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154230 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#760208}
-
Istiaque Ahmed authored
Instead of a RepeatingClosure, pass OnceClosure as the method would call it at most once and is the correct thing to do. Bug: None Change-Id: I9ad50e31117f0fc677e21878b7c4787431cb8422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154586 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Xinghui Lu authored
Bug: 1041912 Change-Id: If0fe4bf63bb8787cee2b53ad6a3d306406f578e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153939Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#760206}
-
Dominic Farolino authored
This CL cleans up the image lazy loading cross-origin iframe tests. The tests assert that lazy loading works even for images in cross-origin iframes. Before this CL, the main test files didn't make use of promise_test correctly, so the tests would just timeout for implementations that didn't support lazy load. This happened because none of the promises the test awaits actually perform assertions, so in the error case, they never resolve or reject. This CL fixes that by refactoring the tests to use a chain of promises that correctly employ assertions, and return a final fulfilled promise. R=sclittle@chromium.org Bug: N/A Change-Id: I4462cf7fd3d2a67fc1ccfb18ec8196bfdb50891f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154820Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#760205}
-
