- 15 Dec, 2020 13 commits
-
-
evliu authored
This CL adds a check to only register the SODA language pack component if the LiveCaption and UseSodaForLiveCaption features are enabled as well as the Live caption toggle switch. Bug: 1156412 Change-Id: Icede8bd752c6617ca16a0f55da926cd8ab0b1675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590625Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#836870}
-
adamta authored
Upstream implementation for adding a custom UIScrollViewDelegate to the feed. Uses NewTabPageCoordinator as UIScrollViewDelegate for the feed collection view. This allows for us to monitor scroll actions in the NTP when the feed is the primary scroll view. Downstream: crrev.com/c/3466483 google3: cl/347390497 Bug: 1114792 Change-Id: I0b9fc60f6de1856270bdda7cf71ce4dcc40e3bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588639Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#836869}
-
Meilin Wang authored
Bug: b/163064897 Change-Id: I5aa951a9f57ceb63c1f3d1e0d624656e7d3c6ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586270 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#836868}
-
siashah authored
If the autofill suggestion has an offer_title set, then replace the network icon with the offer tag icon. Mock: https://screenshot.googleplex.com/5bbDeGuhcL3vzSJ Implementation: https://screenshot.googleplex.com/3eKqiXgSzvXsqGU Bug: 1156916 Change-Id: I97d13a3fdd5af631747ac1bc00772768d41afdaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580113Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#836867}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607925234-725e190e4680cc41f5e8777dffee5ef8a0b3f956.profdata to chrome-win64-master-1607968714-699bf16f3c6ce2b1b6a355f7ee1c8b08436d6eb2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I36d24203aeba1534103d76b9f6e6ac7f2d2909c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590415Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836866}
-
Timothy Loh authored
Bug: b:163432680 Change-Id: Ief9324452d082dfe4f94e8e9bc7d2bbb998b07ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584630Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#836865}
-
Sophie Chang authored
This also only instantiates the previews opt guide if previews are allowed. The root of the flake is that Previews was registering the opt target which caused the fetch for regular profiles. By disabling the previews feature in our tests, we are able to better isolate the logic we want to test. (Previews was default enabled on Linux) Bug: 1158257 Change-Id: I3bfe66979bb156698e438b26e2bccf6c172dd140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590708 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#836864}
-
Nico Weber authored
lld/MachO currently doesn't produce working TLS for position-independent code. Disable PIE, and for protoc disable TLS (since protoc loads dylibs for plugins at runtime). The produced Chromium Framework still uses TLS and PIC and is still broken, but with this (and https://chromium-review.googlesource.com/c/chromium/src/+/2591007) all host binaries that run during the build at least work. So with this, a build with use_lld=true on a macOS machine at least gets mostly through the build (...and far enough to find new interesting problems in lld). Bug: 1149587 Change-Id: I862308158f4aaa4419f0fb5e98c206294a2835cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590392 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#836863}
-
Koji Ishii authored
Bug: 1154531 Change-Id: I68dbd92b6d4066d4add555be602ece24c714c283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590145 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#836862}
-
Wenyu Fu authored
When test is batching, FirstRunStatus#getFirstRunFlowComplete could stored wrong value to restore due to commandline switch. Replace the original value from the shared preference directly. Bug: 1158467 Change-Id: I5dccfe3b28167c78c04f5ea04b348faff20677a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591232Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836861}
-
Natalie Chouinard authored
Remove no longer used cached feature flag and variation. Bug: 1158020 Change-Id: I3c6023ff7d98f38f8b26159025a45160ac7b025e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587623 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3df29be28445..fd7733e97423 2020-12-14 cwallez@chromium.org GeometryTest: Expand suppressions to AMD Intel OpenGL 2020-12-14 m.maiya@samsung.com Vulkan: Add test for Pixel bug with passthrough GLSL function 2020-12-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0a64a9747555 to c16dc7107fd3 (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I3755ac8f3601ce81d8f329b719c00cfae35b97cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590889Reviewed-by:
-
Mila Green authored
Bug: 1157996 Change-Id: If0c0b401445cb174db2ce0fbd8cbbc5af3a12867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590651Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#836858}
-
- 14 Dec, 2020 27 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1f0dc9cd1b82..1d2b075ce060 2020-12-14 kjlubick@google.com [wasm-gms] Enable filesystem by default. 2020-12-14 johnstiles@google.com Remove sk_OutColor from a handful of fragment processors. 2020-12-14 michaelludwig@google.com Remove UPDATE_DEVICE_CLIP macro 2020-12-14 westont@google.com [infra] Use Mac10.15.7 and xcode 12.2 for CommandBuffer builds. 2020-12-14 csmartdalton@google.com Don't store tessellation tolerances on GrStrokeOp 2020-12-14 johnstiles@google.com Implement findMSB intrinsic in Metal. 2020-12-14 bsalomon@google.com Revert "Revert "Add new SkCanvas methods for Android Framework WebView queries."" 2020-12-14 robertphillips@google.com Separate the playback and recording characterizations in the DDLTileHelper 2020-12-14 kjlubick@google.com [canvaskit] Replace core build with profile build in npm If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: Id8fdce8bffbb9829a39cf1ac0dd962978aff4490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590417Reviewed-by:
-
manukh authored
Rich autocompletion added the |omnibox_additional_text_view_| label adjacent to the |omnibox_view_| in the LocationBarView. When the |omnibox_view_| displays a suggestion's contents, the label (if visible) displays its description and vice versa. The LocationBarView directs mouse button events from |omnibox_additional_text_view_| to |omnibox_view_| so that, e.g., clicking the former will focus the latter. Specifically, the LocationBarView already directs the OnMousePressed, OnMouseDragged, and OnMouseReleased events. This CL also adds ShowContextMenu to be directed. Bug: 1150010, 1062446 Change-Id: I639177a65abdb70e2c34322fb5217827b02c142e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586766Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#836856}
-
Patrick Noland authored
This test was failing due to an NPE when trying to access mActivity, which wasn't set properly in the deferred init case. Bug: 1157659 Change-Id: Ie61d2385a34a36e3822f033dc1fae889f2287c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587478 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#836855}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/afdda12d..84bd4d62 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If5fa16b47cf0b8b79dfb235b97fa6b656164b51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590687Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836854}
-
Joel Hockey authored
This reverts commit 476e192f. Reason for revert: reland with fixed test Original change's description: > Revert "GuestOsSharePath mark paths no longer shared on VM shutdown" > > This reverts commit 56a15a3f. > > Reason for revert: Fails unit tests on linux-chromeos-rel. See > https://crbug.com/1158303 for details. > > Original change's description: > > GuestOsSharePath mark paths no longer shared on VM shutdown > > > > Bug: 1144138 > > Change-Id: I970293c61c9686ab32f574957c028bd3db754ccd > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589049 > > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > > Commit-Queue: Jason Lin <lxj@google.com> > > Reviewed-by: Jason Lin <lxj@google.com> > > Cr-Commit-Position: refs/heads/master@{#836531} > > TBR=joelhockey@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,lxj@google.com > > Change-Id: I4ba6d44fa5b448a4d6899a69dd5848a103a5614c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1144138, 1158303 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588930 > Reviewed-by: Kush Sinha <sinhak@chromium.org> > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836575} TBR=joelhockey@chromium.org,sinhak@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,lxj@google.com # Not skipping CQ checks because this is a reland. Bug: 1144138 Bug: 1158303 Change-Id: I1e53443a212950ac2d66bb736ce3350798d95201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591027Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#836853}
-
Sebastien Marchand authored
This will be used to report UKMs that will let us analyze how different usage scenarios affect Chrome's battery consumption, see https://docs.google.com/document/d/18cX0Aug0YuUAfW7v3eOeDzilS1IzcnCoFp616zzI_Vo/edit#heading=h.ryxkkcajp5g8 Bug: 1153193 Change-Id: Iac7a309b3cd649597ae6a3f6dd92de21080bf6ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567613Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#836852}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b9e29f68c268..d7b94d61efca 2020-12-14 andoli@chromium.org [module.json extensions] Migrate network actions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I15849625ca3b90b8134faf55fed8445ab01e701c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590421Reviewed-by:
-
David Tseng authored
Previously, Switch Access may have not enabled the virtual keyboard when transitioning between profiles, while still remaining enabled. R=dmazzoni@chromium.org Fixed: 1151515 Change-Id: I192c4694747445e408f7fec6aaa600f728dad4d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590370 Commit-Queue: David Tseng <dtseng@chromium.org> Auto-Submit: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#836850}
-
Ali Juma authored
This updates run_cwt_chromedriver.py to account for changes in xcodebuild_runner. This also updates the default OS and device to more recent values. Change-Id: I832419dc1d8247680a8324b09a047824fb56107e Bug: 1158540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585816Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#836849}
-
Basia Zimirska authored
Bug: 929990 Change-Id: If053038c7f97412f792ec98ef2613f9965536552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581005Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Basia Zimirska <basiaz@google.com> Cr-Commit-Position: refs/heads/master@{#836848}
-
Xiaocheng Hu authored
Bug: 687225 Change-Id: Id90bf61c99aabcd464d12f9f43e95ec9bf5d5eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585676 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#836847}
-
Anders Hartvoll Ruud authored
This CL makes RuleSet aware of StyleRuleContainer objects, and adds the inner rules as normal to the RuleSet. Additionally, each RuleData object now stores the currently applicable ContainerQuery as well. In ElementRuleCollector, immediately after selector matching, we evaluate that container query against the size of the current container, and potentially reject the rule based on that evaluation. For now we pretend that any container has a fixed size of 500x500, until we can propagate a proper ContainerQueryEvaluator instance with the actual size of the container. On large sites, we can easily reach 30k+ RuleData objects, so adding even a single pointer (to the ContainerQuery) adds up to hundreds of kilobytes of memory. To avoid allocating this memory unnecessarily, we only store it when necessary, via the ExtendedRuleData class. Deferred for later CLs: - Dealing with things that use MinimalRuleData (mostly ShadowDOMv0). - Nested @container. Bug: 1146095 Change-Id: I1c414c2ef4403179f0a1ec4f9e1c8ee95c4068cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579793Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#836846}
-
Ryan Sleevi authored
This keeps the in-binary CRLSet in-sync with the same set of explicitly blocked CAs as the Component Updater delivered version. Bug: 1155981 Change-Id: I49b15a8304bae8b9113bd6ce4f5c0f5f5c1feb7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590624 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Andrew Whalley <awhalley@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#836845}
-
Emircan Uysaler authored
This CL adds a flag to allow this for clients where we end up re-decoding buffers because of clip. No behavior change unless the flag is used. Bug: 1157548, fuchsia:64868 Change-Id: I3ec3a919ad9a2c8d5af77cf5752be1b5f155bd29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579668 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#836844}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7a0ca4ead94d..236d75a254d6 2020-12-14 srisser@google.com Implement VK_KHR_uniform_buffer_standard_layout 2020-12-14 capn@google.com Update README If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I027e02725432bc81aa28f18f462d6922a7c51aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590414Reviewed-by:
-
Darren Shen authored
Chrome seems to crash when adding a new monitor with the virtual keyboard enabled. The stack trace suggests the keyboard window is null. Check for when the keyboard window is null as a speculative fix. Bug: 1157150 Change-Id: I6475dde46bed1a9c8f5246ace76790e836a312e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585262Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#836842}
-
Song Fangzhen authored
Add TCPReadableStreamWrapper and TCPWritableStreamWrapper which provide stream implementations for TCPSocket. TCPReadableWrapper and TCPWritableWrapper watch the mojo datapipe, create underlying queue strategy, and provide functions like read/write data from/to network. Unittests are also provided. Below documents are from Eric Willigers <ericwilligers@chromium.org>. Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/ARtkaw4e9T4/m/npjeMssPCAAJ Design doc: https://docs.google.com/document/d/1Xa5nFkIWxkL3hZHvDYWPhT8sZvNeFpCUKNuqIwZHxnE/edit?usp=sharing Bug: 905818 Change-Id: I8a0da5d9391c543201e5e9620ca493d192166319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563340Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ke He <kehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#836841}
-
Mario Sanchez Prada authored
Due to the recent migration from legacy IPC messages to mojo, some crashes have been observed because of MediaSessionController and MediaSessionImpl objects being alive after the WebContents object they are associated to has been destroyed. This seems to have been caused because of a race condition that can happen if a call to a method of the MediaWebContentsObserver mojo interface arrives in the browser process once a WebContents is in the process of being destroyed: such messages will call methods of MediaSessionControllersManager that will create new MediaSessionController and MediaSessionImpl objects again, but with an invalid WebContents object associated to them, causing the crashes when later on such objects assume a valid WebContents available (e.g. in MediaSessionImpl::GetMediaSessionInfoSync()). In order to fix this problem, we need to make sure that we destroy the objects holding the MediaWebContentsObserver mojo receivers in the browser process as soon as we know that the either the WebContents associated to them is about to be destroyed, but before the actual destructor is run. Likewise, and similar to what's already done for the map of PlayerInfo objects, we should also make sure we destroy those objects holding the mojo receivers as soon as the associated RFHI is getting deleted, so this CL does that as well. Last, and even though not directly related to this crash, it's probably a good idea to do a similar cleanup for the map of MediaPlayerHostImpl objects (which is indexed by RFHI) and the map of mojo::Remote<media::mojom::MediaPlayer> remotes (indexed by MediaPlayerId), also owned by MWCO, in the two same cases, so this CL takes care of adding that extra cleanup too. Bug: 1157779, 1039252 Change-Id: I4932f43ce8622dbecaf20dbe417f61ee8167647d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587045Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#836840}
-
Michael Crouse authored
This is a global replace of: /cld_language/model_detected_language /is_cld_reliable/is_model_reliable Bug: 1157983 Change-Id: I9471600db6ae3221dd63fa92ee30d8c093748b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587620 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Trevor Perrier <perrier@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836839}
-
Ian Wells authored
Only one is expiring, but since they're closely related, it makes sense to have both expire at the same time next time. Bug: 1140022 Change-Id: I4bfaecaf5e5d07f7576d7840dabb1360d9050f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577109 Auto-Submit: Ian Wells <iwells@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#836838}
-
Nico Weber authored
We disable ICF for v8_context_snapshot_generator on Linux and Windows. Now we also do it on macOS. (I noticed that we weren't doing it because the mac/lld build complained about ld64.lld not understanding --icf=none.) Bug: 617892,1149587 Change-Id: Idf40a021ec70dea394ed7b74826ceaed99d853b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591007 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#836837}
-
Dave Tapuska authored
GuestViewAttachRequest class is never constructed. This means that GuestViewHostMsg_AttachGuest can be removed as well. BUG=1143268 Change-Id: I5631a5aacb68a426ec1f5d101aea28cd180b86ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587373Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
Dave Tapuska authored
The metric has been expired. Remove dead code. BUG=1055384 Change-Id: Ic5df4f8f54adc8057993ab70e66403125e4a5914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587433Reviewed-by:
-
Michael Crouse authored
Initializes varible in case model is not available. Bug: 1158539 Change-Id: I00587372d9ae185b6840a514da2363c1fe7b971d TBR: megjablon@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590588 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#836834}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/99399caeacf6..9c7f6c25c004 2020-12-14 ehmaldonado@google.com [owners] Refactor OwnersClient. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I9e850abd0a5f456bc524f14a74778cabc6629863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590988Reviewed-by:
-
Jae Hoon Kim authored
The enum values should be 1 to 1 with the error codes sent from update_engine as defined in update_engine's: /aosp/system/update_engine/common/error_code.h BUG=b:175337382 TEST=none Change-Id: I7b6c42d2feef052f5e5ee7b746bf18a971382969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586365 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#836832}
-
Mehran Mahmoudi authored
Bug: 1149972 Change-Id: I9614243851fddcb55402caf5a2d8ea6e1410092f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582405 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#836831}
-
