- 27 Oct, 2020 40 commits
-
-
David Black authored
Previously showing holding space context menu via ChromeVox (which is performed via Search + M), we didn't update the holding space selection state. Now we do. Bug: 1142890 Change-Id: I65973be470cea22b582df4895d111eeab790ebc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504192Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#821484}
-
Sergey Ulanov authored
Previously AudioOutputStreamFuchsia wasn't setting stream usage for the AudioRenderer. The usage is required by the system audio service to make correct audio policy decisions for the stream. This change updates AudioOutputStreamFuchsia to SetUsage() appropriately. Bug: 1065605 Change-Id: If96a9b0713b4acdff63035725b7322d1a5ad65a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500431 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821483}
-
Mikel Astiz authored
This addresses some leftovers of the old refactoring effort in https://codereview.chromium.org/2569333003. The unittest file is now renamed to match the name of the class under test, which is TitledUrlIndex. Some mechanical refactoring is included such that the unit-tests don't involve BookmarkModel, which is a higher-level layer. A few tests that actually do exercise the integration with BookmarkModel are now moved to BookmarkModelTest. Change-Id: Icf791ce0f88647c6305a4f460d2398cfb63bb155 Bug: 1129524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498544Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#821482}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome. Bug: 1113033 Change-Id: I24ce584ef282fdd31592d52e6131d381498b2603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492668 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#821481}
-
Yulun Wu authored
Bug: 1142780 Change-Id: I853e483af89d2a4e20da42f7098bda54a842a745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503820Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821480}
-
Asanka Herath authored
I haven't touched this in a while and won't have the bandwidth to keep up with //net work. Bug: None Change-Id: If422a56713caa4ceb77ef28eb0c651061945813a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503584 Auto-Submit: Asanka Herath <asanka@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#821479}
-
Eric Roman authored
Change-Id: I10db78da7491d05138e387f05f09789a5afe99a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503325Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#821478}
-
Aaron Colwell authored
Unable to reproduce flakiness locally. Enabling tests and removing skip test logic for --site-per-process. Code was added to remove this flag in SetUpCommandLine() so the tests can run on all platforms. Bug: 1110497 Change-Id: I552f82d1fe4786e59cd624edf5504b713318d523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500280Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#821477}
-
Lukasz Anforowicz authored
This CL removes entires from manual-fields-to-ignore.txt that are already covered by the exclusions automatically generated by the rewriter tool. This CL was generated semi-automatically by running the rewriter and then: $ cat ~/scratch/automated-fields-to-ignore.txt | \ sed -e 's/#.*//g' | sed -e 's/ *$//g' | \ sort | uniq > ~/scratch/automated.txt $ ... same for ~/scratch/manual.txt $ comm -1 -2 ~/scratch/manual.txt ~/scratch/automated.txt \ > ~/scratch/redundant-fields-to-exclude.txt $ for i in `cat ~/scratch/redundant-fields-to-exclude.txt`; do \ cat tools/clang/rewrite_raw_ptr_fields/manual-fields-to-ignore.txt \ | grep -v "$i" > ~/scratch/tmp cp ~/scratch/tmp \ tools/clang/rewrite_raw_ptr_fields/manual-fields-to-ignore.txt done and then removing stranded comments. Bug: 1069567 Change-Id: Ifd976902da12637cb2698d39c72147135c0b6aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503324 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#821476}
-
Darren Shen authored
This reverts commit 31c7133d. Reason for revert: Suspecting as cause of failure in https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/60360 Apologies if it's an incorrect revert, I will reland your CL if it's not the culprit. Original change's description: > Updater: Implement candidate self-uninstall. > > Bug: 1098934 > Change-Id: I226fc7201e04dfbf1722399434e3900cedc35120 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487940 > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Auto-Submit: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821372} TBR=sorin@chromium.org,waffles@chromium.org Change-Id: Icaef3974d3fbc8325f92bda4df0220ab3f012bc8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1098934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503529Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#821475}
-
Jeffrey Kardatzke authored
This adds parsing of the VUI and methods for returning size and colorspace information based on the SPS. BUG=chromium:1141237,b:153111783 TEST=media_unitests, media_h265_parser_fuzzer Change-Id: I6959bf7706183f5239a91ea201effeed9a735dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495838Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#821474}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome. Bug: 1113033 Change-Id: I427c70063f2d2e21038c3c050f5db34729392fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491994 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#821473}
-
Ahmed Mehfooz authored
Make sure the holding space bubble's position is updated on tablet mode changes and screen orientation changes. Bug: 1142096, 1142046 Change-Id: I5bf4e77dec98ffaa99f7b5461d15ebd9ed8c0564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501781Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#821472}
-
Patrick To authored
This change adds tests to cover a using a WebGL2 XRWebGLLayer for WebXR Bug: 1087356 Change-Id: I26c262bdd4945a5067c14131ba5d32659f3ffc95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460969 Commit-Queue: Patrick To <patrto@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#821471}
-
Lukasz Anforowicz authored
The "const-char" filtering rule was a heuristic that was attempting to proxy/cover cases where a struct stored in a global variable would get one of its fields initialized with a non-nullptr value - such scenario could lead to a build error about user-defined constructors invoked when initializing global-scoped values Earlier patchset of this CL replaced "const-char" rule with a more accurate "global-var-init-with-custom-ctor" rule that was directly catching initialization of pointer fields with non-nullptr values. See: https://crrev.com/c/2490864/2 The final patchset of this CL removes the "const-char" rule without replacing it with a new rule, because of a realization that the "global-var-init-with-custom-ctor" rule would only fire in scenarios already cover by another existing rule: "global-scope" rule (formerly named "global-destructor" rule). See for example: https://crrev.com/c/2490864/2/tools/clang/rewrite_raw_ptr_fields/tests/gen-non-constexpr-initialization-expected.txt Bug: 1069567 Change-Id: I4f01b19d9e512db4a1031749eb5b4eb9a54d0ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490864Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#821470}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=schwering@google.com Bug: 1142671 Change-Id: I1294602053f5e8c40831b7c0bb92633bb149c674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500553 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#821469}
-
Michael Hansen authored
This fixes an issue where a discovery session is never started on the HIDDetectionScreen, leaving the user unable to pair a Bluetooth input device through the automatic connection flow. Bug: b:168247012 Change-Id: I30f09ff661081afe0f71d8624d61cec10dc31093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495832Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#821468}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=mahmadi@chromium.org Bug: 1142671 Change-Id: Ida6f990ab48b6a1dbecb775db783ffe8b7f27f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500559 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821467}
-
John Chen authored
Disabling the following flaky tests on android-pixel2_webview-perf: * blink_perf.css/SelectorCountScaling.html * blink_perf.dom/custom-element-default-style-with-shadow.html * blink_perf.dom/custom-element-default-style.html * blink_perf.layout/ruby.html * blink_perf.layout/chapter-reflow-once.html * blink_perf.layout/flexbox-row-stretch-height-indefinite.html * blink_perf.layout/ArabicLineLayout.html * blink_perf.parser/innerHTML-setter-siblings.html TBR=wenbinzhang@google.com NOTRY=true Bug: 1142315 Change-Id: I88a598703b6d1e8bf0c8d96d380cb7b01ca685d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503823Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821466}
-
Nektarios Paisios authored
This patch modifies AXEventGenerator so that it will now generate any selection and value changed events that apply to text fields in the browser process. Until now, all such events are being fired by Blink. However, the browser process has all the information to fire these events without assistance from the renderer. This change has two benefits which are currently unused but which will be made readily apparent in a followup patch: 1. Will further reduce the number of events that would need to be fired by Blink. 2. Will drastically improve the performance of large content editables, e.g. those found in Google Docs. The latter would be possible because after this patch lands, we'll be able to stop computing the value attribute for text fields in the renderer and unnecessarily sending it over to the browser. Also took the opportunity to 1. Add STL container functionality to AXEventGenerator and improved some of the C++ comparison operators. 2. Split the value changed event into three separate and easier to understand events: A) RANGE_VALUE_CHANGED - for ARIA and native sliders, scroll bars, etc. B) SELECTED_VALUE_CHANGED - for <select> elements. C) VALUE_IN_TEXT_FIELD_CHANGED - for ARIA and native text fields, including content editables. For ARIA popup menus and combo boxes, there is the existing ACTIVE_DESCENDANT_CHANGED event. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1049261 Change-Id: I7f083ad69c47e7215fb83501ef0a3a4d06e5f12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492301 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#821465}
-
Sammie Quon authored
Add anti-aliasing to circles, makes more smooth, screenshot in bug. Damage a larger region on repaint to account for the shadows. Test: manual Change-Id: I4707fd057adcb4d5a0f6f4c412683203fa107ea3 Fixed: 1142935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503400Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#821464}
-
Greg Thompson authored
In the component build, setup.exe requires its dependent DLLs to run. In support of this, mini_installer contains all of those DLLs as extra (uncompressed) resources. These are extracted and placed next to setup.exe in the work directory. This CL adds a titch of cleanup code to delete these extracted resources. BUG=127233 R=gab@chromium.org Change-Id: Icf41e3c2535d07dd1ba1888e4d2e5fbcc8f1c934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501746 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#821463}
-
Dana Fried authored
See attached bug for rationale. This approach is simplest, but will reset counters associated with metrics. However, switch from aero to non-aero in Win7 is extremely infrequent and shouldn't significantly impact actual numbers. Bug: 1140256 Change-Id: I479d996e22be1e4f77e55d00080aa3d7a9ca4ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503838Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#821462}
-
Ryan Hansberry authored
Consume the org.bluez.Adapter1 ConnectDevice() method [1] to allow Chrome clients to connect to a remote device (via their MAC address) which they know is available and nearby, but is not known to the lower-level Bluetooth stack (likely because the device is not discoverable). This change is motivated by a core flow of the Nearby Share feature. In this flow, Nearby Share discovers a remote device via a non-connectable BLE advertisement, determines that remote device's BR/EDR MAC address by deciphering the BLE advertisement with previously downloaded certificates, and then connects via RFCOMM. In this situation, Nearby Share knows a device with the MAC address is available and nearby, but bluez does not -- hence the need for this change. More details at go/nearby-chrome-bt. 1) https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/third_party/bluez/next/doc/adapter-api.txt;l=187 Bug: 1140471 Change-Id: Ibb67f5ca2def444799205394767892b8d651b539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491131 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/heads/master@{#821461}
-
Asanka Herath authored
Bug: 973801 Change-Id: I28dee78a9b9a3d4eedbdc7c2a2f13292a4aade35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463449Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#821460}
-
Dave Tapuska authored
In anticipation of the RenderWidget removal, move RequestPresentation into WebWidgetTestProxy and rename it to match the bindings name. BUG=1097816 Change-Id: I1fa060ee6d3c788bb519830ae61a0e01bebcb859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499741 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#821459}
-
bttk authored
Bug: 1139481 Change-Id: Iff40d93d02e6e35aaf6573ecb1a60b582a263c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500529 Commit-Queue: who/bttk <bttk@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#821458}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a01dd2af4292..5d3967cb630c 2020-10-27 chonggu@google.com [Fuchsia] Add Flags for WebEngine 2020-10-27 landrey@webrtc.org Fix bug when state of a measurement wasn't updated If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1128357,chromium:1130706 Tbr: zhanliang@google.com Change-Id: I44f1ee7418e95c9f671458da6e8513496090c92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503571Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821457}
-
David Bokan authored
This adds the "disables threaded scrolling" flag to web tests unless threaded compositing is enabled (as happens in "threaded" virtual test suites). Traditionally, web tests force-route all input to the main thread unless threaded compositing is explicitly enabled. crbug.com/915926 will change this; like real Chrome, input will always be routed through the compositor first, even when running in single-threaded mode. To preserve existing test coverage, where scrolling would happen on the main thread, this CL adds and disables a "threaded scrolling" WebPreference in web tests which makes Blink give all scrollers a MainThreadScrollingReason. This functionality is already available behind a --disable-threaded-scrolling flag so this preference uses the same mechanism. "threaded" virtual test suites turn threaded scrolling back on by passing --enable-threaded-compositing which will enable the WebPreference. This change means that non-threaded web test input will flow through the compositor but it will fallback to main thread scrolling like it would in the real world (for other compositing-related reasons). However, this CL doesn't change the fact that we force-route input to the main thread. That's done in https://crrev.com/c/2281179. Some tests in compositing/ explicitly check the main thread scrolling reasons so we add an explicit enabling of threaded scrolling in those tests to prevent adding the flag-based reason. Bug: 915926 Change-Id: I43329e86c784c5e116e6a96549fb8676f03f94ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441684Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#821456}
-
Steven Bingler authored
Change-Id: Ie17324e4035eff24b50b6f4111cea2f466a8bcdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503574 Auto-Submit: Steven Bingler <bingler@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#821455}
-
Chong Gu authored
Change the location on Fuchsia target where result and filter files are stored. Remove unused flag --target-staging-path. Bug: fuchsia:47956 Change-Id: Ic8068dcdd48654e672251b76047fcb9b69f9a8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499371Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#821454}
-
Andrew Grieve authored
E.g. chromium-binary-size-trybot-results%2Fandroid-binary-size vs: chromium-binary-size-trybot-results/android-binary-size Bug: 1131568 Change-Id: I8801d04748d0d21bb4bdf2a63a56f78445a23160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503634 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#821453}
-
Yuheng Huang authored
This changes fixed the weird focus collision bug on Linux. Similar patterns can be found in HatsBubbleView and ProfileMenuViewBase. Bug: 1139028,1099917 Change-Id: I4703f631216584feecf117b6a1901fbccfb14e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499086Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#821452}
-
Alex Newcomer authored
We will eventually remove the flag, but due to dogfood messaging we will keep it around for a bit longer. Bug: 1138674 Change-Id: I544fe687f5077e2779e7924e5697c6ce1d9d351f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500022 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821451}
-
Etienne Bergeron authored
This is a reland of b642822f Original change's description: > Move ISpVoice instance to a worker thread > > This CL is moving the speech synthesizer code to a worker thread. > > The TtsPlatformImpl is using an ISpVoice COM interface to perform > text-to-speech actions. The instance was living on the UI Main > Thread which was using STA Apartment. > > This CL is splitting the logic in two parts. The first part is the > control logic which stay on the UI Thread. The second part is the > synthesizer logic which is running on a worker thread. > > Bug: 869399, 1133813 > Change-Id: I8f8d939950cc39637f87d101ed362123a51e985e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462341 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820340} Bug: 869399 Bug: 1133813 Change-Id: I4f1e5bb143472b2d96cf4fe55d3f74d1e5c56877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502948Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#821450}
-
Dale Curtis authored
It ought to be enough for everyone! Tests on Window show that normal audio playback only uses 4kB and WebRTC uses ~68kB, so 256kB seems enough to cover our use cases. Fixed: 1141563 Change-Id: I4f119c3985347b45b4d934432792efb0d6e2dc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500432 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#821449}
-
Lijin Shen authored
Add a new general swipe listener, which is derived from SwipeRecognizer. Bug: 1123947, 1142475 Change-Id: I1e1518300bd4dbf36b889970cb89981b0ff3a15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493364 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#821448}
-
minch authored
Re-upload IDS_ASH_SCREEN_CAPTURE_TOOLTIP_SCREENSHOT.png and IDS_ASH_SCREEN_CAPTURE_TOOLTIP_SCREENRECORD.png. The old ones were cut incorrectly by a tool and can't be interpreted correctly. Bug: 1142099 Change-Id: I79b08c055ce87ca4cb2bcec16fcb06822ac0b6ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503394Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#821447}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=sky@chromium.org Bug: 1142671 Change-Id: Ied44b2bee60ee3724ec79693f74d857e9a48d5a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500577 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#821446}
-
Frank Tang authored
1. Only send out timezone change while the override is different than the host. 2. Not reset the timezone override for every change. 3. Compare equality based on canonical value. Bug: 1135960 Change-Id: I03c0a5fc62207f652ba3371509a3699115cd7dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472466Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821445}
-