- 21 Jan, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b24ca5ac742e..8effa4d0637c git log b24ca5ac742e..8effa4d0637c --date=short --first-parent --format='%ad %ae %s' 2020-01-21 tandrii@chromium.org git cl: warn when landing on chromium/src branch-heads. Created with: gclient setdep -r src/third_party/depot_tools@8effa4d0637c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1043225,chromium:753213 Tbr: agable@chromium.org Change-Id: I3194ebbb4e88cf2a9ce8b6d1204cd1bab3134a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012239Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733600}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. Bug: 1042208 Change-Id: I027bdc72608c52aed8414ce1926fe5b4edd7c074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011820 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#733599}
-
sandromaggi authored
After this change it is possible to completely disable all code execution / changes by disabling the AutofillAssistantChromeEntry feature. This also goes for the AutofillAssistant code, waiting for initial navigation. This CL also removes the temporary workaround that was setting the fallback URL in code if it was missing in the intent. Bug: b/145195894 Change-Id: Ic35b799603c633a310171d9f40574e3ff8d79b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007696 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#733598}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=jlebel@chromium.org Bug: 1042208 Change-Id: I9890a8a1f34b406148f8f6c37d22a6839b03a5db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007727 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#733597}
-
Sylvain Defresne authored
https://gn.googlesource.com/gn/+log/0c5557d173..83dad00afb 83dad00 Add a sample project that allow to target iOS abea271 Consider Xcode console as not a tty a09ec16 Improve support for frameworks in gn e214b5d Add support for ':' in --gtest_filter to gn_unittests Bug: 1037607, crbug.com/gn/119 Change-Id: I0d722f9b66a34c2bc641b8266e4160002b988288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010951 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#733596}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e07936314c2b..215c34be2bd3 git log e07936314c2b..215c34be2bd3 --date=short --first-parent --format='%ad %ae %s' 2020-01-21 reed@google.com SkMScalar is obsolete -- use SkScalar Created with: gclient setdep -r src/third_party/skia@215c34be2bd3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: benjaminwagner@google.com Change-Id: Iae1bb65a1eae779f1bb85d4f5a67ae787d226abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012231Reviewed-by:
-
Rushan Suleymanov authored
Add SharingMessageBridge without wiring it. The bridge does not store any data on persistent storage. Bug: 1034930 Change-Id: I0b19a136a2cc8a3e9ec11b7c1bb0f0b629996e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002524Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#733594}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cda267031787..b5315e84d143 git log cda267031787..b5315e84d143 --date=short --first-parent --format='%ad %ae %s' 2020-01-21 aerotwist@chromium.org Revert "Updates node to latest LTS" Created with: gclient setdep -r src/third_party/devtools-frontend/src@b5315e84d143 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I85496d6aa34dec9f03d4bfb895fc2415219e842c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012236Reviewed-by:
-
Peter Marshall authored
The V8 CPU profiler schedules SIGPROF signals. It is very likely that the signal handler for these will run while the throttling signal handler is already running. V8 can't properly read the stack when there is already a signal handler present. Fix this by using sa_mask to block V8's SIGPROFs while the throttling handler is running. This makes more sense overall as well. Our CPU samples would be skewed by whichever stacks we encounter during throttling pauses. Bug: 1027242 Change-Id: I80e856ce1e7b4744a9af7e36c2022b6d8610cf60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012280Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#733592}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6c13fd907145..b7dc45f8e811 git log 6c13fd907145..b7dc45f8e811 --date=short --first-parent --format='%ad %ae %s' 2020-01-21 mbonadei@webrtc.org Update check_package_boundaries. 2020-01-21 mbonadei@webrtc.org Remove android_junit_tests from the main BUILD.gn file. Created with: gclient setdep -r src/third_party/webrtc@b7dc45f8e811 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I286f6c7631e3e436d7188e2a1e40e8f332952b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012232Reviewed-by:
-
Omer Katz authored
Restarting the markers only checked if the marking worklist is not empty and ignored the write barrier worklist. Also, moved the check so that it's physically next to the concurrent marking method so hopefully if someone changes one in the future, they will the next one right next ot it and change that too. Bug: 986235 Change-Id: I8ce9dc66f0da4bfb1a4f0a37f56b3cdecdb0d0d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006351 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#733590}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1fcd8171290b..ba8cd45333c4 Created with: gclient setdep -r src-internal@ba8cd45333c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib110a619cd3d6be291611b74b7c1d1b6e673c919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012233Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733589}
-
Mohamed Amir Yosef authored
This CL introduce the method PasswordFormManagerForUI::MoveCredentialsToAccountStore() which would be called upon user invocation of the migration flow in the UI, and wires the call to the PasswordSaveManager. This CL doesn't introduce the invocation logic or the UI pieces. Bug: 1032992 Change-Id: I6e887bb1a363d45fc15152a52e6cec5db0e00c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012022 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#733588}
-
Pâris MEULEMAN authored
Follow up of https://chromium-review.googlesource.com/c/chromium/src/+/2007821 Add an expectation for bug tracked by crbug.com/1040059. The test case was split in two and the crash wrongly assumed to occur only on half of the splited test. Also remove a related test that does not timeout anymore. Bug: 1042199 Change-Id: I133b4205cb6348ea32864498634c58731da12c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012282Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#733587}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/056f1769..bfa7cd62 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3550637be078dc32a5c9b23a1c553a9dfc666bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012041Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733586}
-
Nazerke authored
This CL modernizes the SendTabToSelfCoordinator - to use the superclass -initWithBaseViewController:browser: initializer, instead of -initWithBaseViewController:browserState:. - to remove the public property for dispatcher and use the dispatcher from self.browser with HandlerForProtocol. Bug: 1029346 Change-Id: Ie5e0c65148fe374bf388a2eb4e85c7e070e3f0b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011104Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#733585}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8265f5d3dc2a..cda267031787 git log 8265f5d3dc2a..cda267031787 --date=short --first-parent --format='%ad %ae %s' 2020-01-21 aerotwist@chromium.org Updates node to latest LTS Created with: gclient setdep -r src/third_party/devtools-frontend/src@cda267031787 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5dfa4dc0a4539f01be6008bdb7ae4687f33d529b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012226Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8294a64a. With Chromium commits locally applied on WPT: 0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jochen@chromium.org, estark@chromium.org: external/wpt/referrer-policy NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id0c8c2f6272adbba982892ec6db8dc4d60f9fbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012040Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733583}
-
Maksim Moskvitin authored
PeopleHandler somehow gets destroyed after ProfileSyncService shutdown, so |auth_manager_| is nullptr during its destruction. This caused the crash in GetDisableReasons(). Fix is to simply check |auth_manager_| before dereferencing. Avoiding PSS usages after shutdown would be cleaner fix, but it's not clear why they happen atm. Bug: 1043642, 906995 Change-Id: Id6d54a2edee1210a579e36b2b771d360c8c40474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011220 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Vadym Doroshenko authored
PasswordFormManager needs to be updated for the subsequent projects: 1.Suggesting saving in case when there is no HTML submission. 2.Saving manual fallbacks. Bug: 1042196 Change-Id: Ie0bc33b1a7974930a65ddce611b3444542a35fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007412Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#733581}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73a7576e7efb..1fcd8171290b Created with: gclient setdep -r src-internal@1fcd8171290b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6b75c84283fa544a293ec63cad85f313cc6a2eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012224Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/73aa2de3d761..6c13fd907145 git log 73aa2de3d761..6c13fd907145 --date=short --first-parent --format='%ad %ae %s' 2020-01-21 eshr@google.com Move bandwidth overuse detection out of VideoStreamEncoder Created with: gclient setdep -r src/third_party/webrtc@6c13fd907145 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4538995d5dced93f4b07c21bafa5d48f1638a531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012225Reviewed-by:
-
Adithya Srinivasan authored
Bug: 1043455 Change-Id: Ifa7202ec2379446e2c19c593bf45d8a2528f6160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011165 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#733578}
-
Maksim Ivanov authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/e831a312c4ab..938e6c463847 $ git log e831a312c..938e6c463 --date=short --no-merges --format='%ad %ae %s' 2020-01-15 ljusten authpolicy, kerberos: Update owners, clean up 2020-01-17 emaxx system_api: Add constant for "TPM update required" 2020-01-07 victorhsieh system_api: generate boot lockbox's Go proto binding Created with: roll-dep src/third_party/cros_system_api Bug: 1011327 Change-Id: I6dfd3136e2c4c37e599c3b89f5cd9e045d335a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007418Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#733577}
-
Jan Krcal authored
This CL enables all remaining disabled single client wallet integration tests. The underlying issue should be fixed by CL 1998520 so it should be safe to re-enable the tests now. Bug: 997786 Change-Id: Ia5cda9824e3b4a3ffd7f679690020c8d40182bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010849 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Matt Menke authored
This reverts commit 2e1050cd. Reason for revert: Test is flaky. I'll look at it when I have time. Reverting for now. Original change's description: > Don't clear DNS cache when closing last incognito Window. > > The DNS cache is now a per-NetworkContext cache, instead of a global, > so clearing the cache when closing incognito is no longer useful - > destroying the incognito profile will destroy its own DNS cache. > > Bug: 1042354 > Change-Id: Ib3fd2dc03cf48ca1ca1d1fd7fca025fccb2a4a2c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003212 > Reviewed-by: Eric Orth <ericorth@chromium.org> > Commit-Queue: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732622} TBR=mmenke@chromium.org,ericorth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1042354, 1043084 Change-Id: Iece297f7433e1331819c70bb35042e258b5c0dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012081Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#733575}
-
Naoki Fukino authored
We can filter recent files from RecentDriveSource by specifying mime type to the query for DriveFS. Bug: 1040049 Test: Manually tested by checking result from Google Drive. Change-Id: I798965c0544a35daf94e73d54bde4516646f8d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993065 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#733574}
-
Julian Pastarmov authored
Only defines the policy and doesn't influence the behavior at this point. BUG=TBD TEST=browser_tests Change-Id: I14e823a6ed8ef3929ee9ade368172c26ce9ae194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986833 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733573}
-
vitaliii authored
We want to propagate failed commit item errors all the way from server to bridge. This is second step. Propagate failed commit items from ClientTagBasedModelTypeProcessor to the bridge. Bug: 1034923 Change-Id: I4fe5d4448ed337b6ab14e04a749765053b62b249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010774 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
-
Andy Paicu authored
... be removed before the bubble is shown. The exact conditions that trigger the race condition are unknown, I've not been able to reproduce the issue reliably enough to investigate. It appears that before `ShowBubble` gets to run, something happens that calls `FinalizeBubble` which removes the request. It happens so rarely that the DCHECK we have in place has not surfaced the issue. Bug: 1041222 Change-Id: I0413fa70c77f2a24e17646b21d40ad9fa1cec69f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000754 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#733571}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/08a04042c18c..73a7576e7efb Created with: gclient setdep -r src-internal@73a7576e7efb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1042208 Tbr: jbudorick@google.com Change-Id: I8102e451f8d28cfe503157360e28641a2a218415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011860Reviewed-by:
-
Pâris MEULEMAN authored
This updates the timeout to long and splits into smaller tests the flaky COOP web-platform tests. reland of crrev.com/c/2003172 with proper expectations. Bug: 1042199, 1043401 Change-Id: I7edfaaa520ed6c8fd2974d6c7622fb79c8316089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007821 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#733569}
-
David Jean authored
Add a missing null check on context. Also changed navigation not to check state to determine if commit has already happened, since the state machine being uncertain, state not being 'commit' doesn't mean commit has not been called before. Bug: 1041368 Change-Id: I6f77c2137e30c46b8180f35e584833cd57f8f7db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003134Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#733568}
-
Mohamed Amir Yosef authored
This patch introduces the method PasswordSaveManager::MoveCredentialsToAccountStore() and provide an implementation for the MultiStorePasswordSaveManager. Bug: 1032992 Change-Id: Ib6fee5f7bb0dae53a2a5b6372f4299200c80778c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962067 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/845a09b8241e..8075d3edde6c git log 845a09b8241e..8075d3edde6c --date=short --first-parent --format='%ad %ae %s' 2020-01-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 41a96d15fd99..ac02c61ffc63 (16 commits) Created with: gclient setdep -r src/third_party/angle@8075d3edde6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: I755d8637ddf73fb8fbc53621cd3e3c5f7d1864cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011450Reviewed-by:
-
Sylvain Defresne authored
The next roll of gn expects the extension to use the correct case (.framework) so fix the incorrect spelling of UIKit.framework in components/cronet. Bug: None Change-Id: I839de0eafebd694542f9901f2ad805a2cf8cabca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011841 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#733565}
-
Matt Menke authored
This reverts commit 1dd7e2a7. Reason for revert: STill flaky. Reverting both CLs. NOTRY=true Original change's description: > Fix NetworkContextConfigurationBrowserTest.DnsCacheIsolation flake. > > The test makes sure that HostCache entries aren't shared between > NetworkContexts. To do this, it does a DNS lookup in one NetworkContext, > which succeeds, and then cache-only DNS lookups in other NetworkContexts, > which should fail. At the end of the test, it does a cache-only lookup > in the first NetworkContext, which should succeed. It's generally best > to do this at the end of the test, since it makes sure that entries > aren't only usable once, or somesuch. Unfortunately, sometimes the > DNS cache entry is timing out before the last lookup. To fix that, > this CL moves the final cache-only lookup to be right after the > initial lookup that populates the cache. > > This does mean the test can still flakily pass, however, flaky successes > are more tolerable than flaky failures, and the test currently passes > often enough, even with the flake, that I think we can live with it. > > Bug: 1043084 > Change-Id: Ibdcf77e7775943e18c21a9ddd2cd3d5bf127c248 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008058 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: Eric Orth <ericorth@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733036} TBR=mmenke@chromium.org,ericorth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1043084 Change-Id: Ia4bffaad8793e7f660807c39d8e0cdfa95d8766b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012080Reviewed-by:
-
Hazem Ashmawy authored
- Show launcher icon for Standalone WebView and Trichrome WebView prestable channels (dev and canary) but not for Monochrome. - The GN flag still has to be enabled for local builds to show the icon since they have `android_channel=default`. - Use a different activity-alias for Monochrome which is disabled by default i.e the launcher icon for monochrome is disabled by default and the GN arg will not show the icon for monochrome till crrev.com/c/2000724 is merged. Bug: 1026062 Test: Set android_channel="dev", verify standalone WebView and TrichromeWebView show the icon Test: Set android_channel="dev", verify Monochrome does not show the icon Test: Set android_channel="default", verify no WebView icons show up Change-Id: Icd218fac086aa940bca61f2ac6ef3ceea76cf0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993817Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#733563}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1a68679e65af..73aa2de3d761 git log 1a68679e65af..73aa2de3d761 --date=short --first-parent --format='%ad %ae %s' 2020-01-21 mbonadei@webrtc.org Split android_junit_tests and move targets in the right package. 2020-01-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2a6702f0..4c751358 (733412:733512) Created with: gclient setdep -r src/third_party/webrtc@73aa2de3d761 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6f7ef2e57e90b3d42f0da61561a534ea79f5e35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011451Reviewed-by:
-
Thiemo Nagel authored
This reverts commit 2711d4f7. Reason for revert: It looks like this is breaking a lot of tests. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36735 Deterministic failure: CrostiniInstallerTest.InstallerErrorWhileConfiguring (status CRASH) Deterministic failure: CrostiniManagerRestartTest.AbortOnComponentLoaded (status CRASH) Deterministic failure: CrostiniManagerRestartTest.AbortOnConciergeStarted (status CRASH) Deterministic failure: CrostiniManagerRestartTest.AbortOnContainerCreated (status CRASH) Deterministic failure: CrostiniManagerRestartTest.AbortOnContainerMounted (status CRASH) Deterministic failure: CrostiniManagerRestartTest.AbortOnContainerSetup (status CRASH) Deterministic failure: CrostiniManagerRestartTest.AbortOnContainerStarted (status CRASH) Deterministic failure: CrostiniManagerRestartTest.AbortOnDiskImageCreated (status CRASH) Deterministic failure: CrostiniManagerRestartTest.AbortOnMountEvent (status CRASH) Deterministic failure: CrostiniManagerRestartTest.AbortOnMountEventWithError (status CRASH) Deterministic failure: CrostiniManagerRestartTest.AbortOnSshKeysFetched (status CRASH) Deterministic failure: CrostiniManagerRestartTest.AbortOnVmStarted (status CRASH) Deterministic failure: CrostiniManagerRestartTest.AbortThenStopVm (status CRASH) Deterministic failure: CrostiniManagerRestartTest.RestartMultipleThenUninstall (status CRASH) Deterministic failure: CrostiniManagerRestartTest.RestartThenUninstall (status CRASH) Original change's description: > Remove shared ownership of CrostiniRestarter > > It seems to be possible for shared references to CrostiniRestarter to > outlive CrostiniManager. Since all of CrostiniRestarter assumes that > CrostiniManager still exists, this can cause crashes. Switch > CrostiniRestarter to being exclusivly owned by CrostiniManager and > handing out weak pointers to callbacks. > > Bug: 1040797 > Change-Id: Ib65c79c7c81111aad88435b3c95da0c64226e791 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996112 > Reviewed-by: Nic Hollingum <hollingum@google.com> > Commit-Queue: Fergus Dall <sidereal@google.com> > Cr-Commit-Position: refs/heads/master@{#733496} TBR=sidereal@google.com,hollingum@google.com,davidmunro@google.com Change-Id: Ic7f8db4dee861105dd10d7959d94ebbf0a5279b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011922Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#733561}
-
