- 15 Sep, 2020 40 commits
-
-
Yuheng Huang authored
Since CTRL/CMD+SHIFT+E is already used in Google Docs, Product decided to change the shortcut to CTRL/CMD+SHIFT+A to avoid the conflict. Bug: 1099917 Change-Id: Idb3505b619f4dd16778ff3992f65dac507dff722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411228Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#807066}
-
Yi Gu authored
Gives more time to propagate the WebOTP bit. Bug: 1120305 Change-Id: Id350a03de42d3ea5895f01f47cdb5fff7ce801e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405374Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807065}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 1126861 Change-Id: I561acf87ca2955705e2d1b40ced5143a93266d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409688 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#807064}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 316409, 1126958 Change-Id: Ia94f5c26525e8058e23b955845997163b6554641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410101Reviewed-by:
-
Jit Yao Yap authored
Bug: 1101208 Change-Id: Ica3c8f5dd1d2592bb02b3e1c1f6f637732909139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398703 Auto-Submit: Jit Yao Yap <jityao@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#807062}
-
Federico Paredes authored
Bug: 1126671 Change-Id: I86ae7c3ba040fad1c0a09ef646e73687b907dde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402278Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Federico Paredes <fedpar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#807061}
-
David Maunder authored
We now enforce that tab attributes cannot be acquired on an uninitialized Tab (including Tab#destroy). Adding in a fallback. Bug: 1117396 Change-Id: I0e8eeec1a982677e64d6d7f82f2fd883c1e0d4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411160Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#807060}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/68241d4f5af5..9d6bf6eee8b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC iclelland@google.com,poromov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: iclelland@google.com,poromov@google.com Change-Id: Ib15c9c8851db9546a7f53995bdf3eb5f26ca7739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412275Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807059}
-
James Vecore authored
Adds a mojo interface on top of the existing contacts manager and makes it available for binding in both chrome://nearby and chrome://os-settings. Bug: b:166503584 Change-Id: I67b8588fae5c838f4f0a57bffd2078d99c9c83fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402758 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#807058}
-
Fredrik Söderqvist authored
Reflect the computation done by FEImage::MapInputs() in FEImage::CreateImageFilterForLayoutObject() to reduce the size of the destination rectangle to that of the bounding box of the referenced content. Bug: 109224 Change-Id: I24b5550e828f6bf1f4e3b0cbf51a34b8e9df2939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409941Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#807057}
-
Stepan Khapugin authored
When the app is starting and focusing the omnibox at the same time, the layout guides for the popup might not be constrained yet. It does not cause any issues if they are constrained later. Bug: 1112760 Change-Id: I9235ca681f18ea5b1c7882c955c1ffa28b533ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410132 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#807056}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I951ac22d3b517423a7dc1f53afe3a07a607ae7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411734Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#807055}
-
Victor Hugo Vianna Silva authored
runOnUiThreadBlocking() has no restriction on being called from the UI thread, so it should be safe to call the loadNativeLibrary...() methods from the UI thread as well. This CL also fixes one comment cross-reference to NativeLibraryTestRule, which apparently doesn't exist anymore. [1] https://source.chromium.org/chromium/chromium/src/+/master:base/android/java/src/org/chromium/base/ThreadUtils.java;drc=c741e070dbfcc33b2369e7a5131be87c7b21bb99;bpv=1;l=156 TBR=jdoerrie@chromium.org Bug: None Change-Id: Icd38029ac5dddd372485be00f03648068d7e3063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404351 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Victor Vianna <victorvianna@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#807054}
-
Caroline Rising authored
These changes are behind the kReadLater feature flag. This cl updates the read later string and adds capitalcase versions. Bug: 1117023 Change-Id: I26d62e659b06a113e63c3c457cdef85ce366a126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402105Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#807053}
-
Behdad Bakhshinategh authored
This reverts commit f1b689af. Reason for revert: crbug.com/1128390 Original change's description: > [Autofill] Returns all patterns that match given language and fieldtype. > > This CL provides new structure MatchingPattern that replace using > single regular expressions, but store more information about concret > pattern. Also it contains splitted MatchType into MactchFieldTypes > and MatchAttributes and sceleton of PatternProvider class. > > > Change-Id: I5acebf12aafaca67ae87260b2c897bdf35a38bea > Bug: 1121990 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385282 > Reviewed-by: Christoph Schwering <schwering@google.com> > Reviewed-by: Matthias Körber <koerber@google.com> > Commit-Queue: Mariia Shvedchenko <mariiash@google.com> > Cr-Commit-Position: refs/heads/master@{#806125} TBR=koerber@google.com,schwering@google.com,mariiash@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1121990 Change-Id: I9d3b94cddf87dba1579caec56829fe75953ace5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411701Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#807052}
-
Patrick Noland authored
When lazily inflating the MenuButton, the call to setThemeColorProvider doesn't trigger an immediate update, risking starting with the wrong color/useLight combination if inflation occurs in a context where the defaults aren't correct, e.g. incognito. This CL corrects the issue by initializing the color immediately. The need for this code should, however, go away once the color is read from the model instead of directly, since the initial bind will take care of problems like this. Bug: 1127826 Change-Id: I609f42427a0b8fa877f4c165e97372d34047f28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410590Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#807051}
-
Lukasz Anforowicz authored
This CL changes (and slightly renames) CreateWebUIURLLoaderFactory so that it returns mojo::PendingRemote to a WebUIURLLoaderFactory that is owned by its |receivers_| and will self-delete when the last receiver disconnects. This CL removes the ability to directly construct and own a std::unique_ptr<WebUIURLLoaderFactory>, because this ability means that the factory can be destructed while receivers bound via the Clone method are still alive (see the associated bug). This CL mostly just follows the pattern established earlier by https://crrev.com/c/2337411. Bug: 1106995 Change-Id: I6079a8b4b3a17d838539a62234b788a3353c76c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358309Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#807050}
-
Xianzhu Wang authored
BTW fixed a small invisible bug for anonymous LayoutObjects which just affects performance a bit. Bug: 1127474 Change-Id: I926bef2572a1d0099c2e106fdd4eb36756e99fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410816Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807049}
-
Matt Menke authored
The URLRequest constructor could accept a NetworkDelegate argument which would override the URLRequestContext's NetworkDelegate. However, URLRequest's constructor was private, and only URLRequestContext could call it, and URLRequestContext didn't have a method to pass a NetworkDelegate other than its own to URLRequest's constructor. As a result, not only was nothing taking advantage of this ability, but nothing *could* take advantage of it. To the extent of my knowledge, this ability has never been used, yet the per-request NetworkDelegate argument was wired through the entire URLRequestJob creation stack. Since this CL is already touching all URLRequestInterceptors, it also updates the URLRequestInterceptor API to return a unique_ptr. TBR= yuweih@chromium.org Bug: 1126597 Change-Id: I5f0fade639e06a2edc8f514853262af3afa6e110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401854Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#807048}
-
Michael Thiessen authored
native_java_unittests are going away, so these tests need to be migrated to javatests. I had to add a helper to run the required native code for some of the tests. Bug: 1103344 Change-Id: Ia7afbe091eab4f214d0359d88ae2c330dc5cb609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405900Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#807047}
-
Boris Sazonov authored
First part of adding ConsentLevel support to identity_test_utils. This CL merges two separate methods SetPrimaryAccount and SetUnconsentedPrimaryAccount into a single one that takes ConsentLevel as a parameter. Bug: 1046746 Change-Id: I93f7811414b7c1ee583237681c567a881560ce23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401140 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#807046}
-
Xianzhu Wang authored
It was used by only one feature (Portals). It has been agreed that kDefault can meet the requirement of the feature. kDefault is very much like kEnableOnlyIfOverriddenFromCommandLine. The difference is that kDefault also respects status overridden from finch and from --disable-features command line switch (in case the feature is enabled by default at blink side). Bug: 1048656 Change-Id: Ibb946dbdcc5ece7c5f5a08822b80825345c170e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411231Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807045}
-
David Roger authored
This was broken by: https://codereview.chromium.org/2889163002/diff/60001/components/signin/core/browser/about_signin_internals.cc I think this was not intended. See screenshot on the bug. Fixed: 1126375 Change-Id: I782a36cb24f800368faced31548368d44491c7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400619Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#807044}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b0a548c7e6b6..df4ddebf1c60 2020-09-15 lalitm@google.com Merge "tp: remove hack of stripping prefix for --run-metric files" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib7b781460b4bbaf657173f0cdfb61d0d25bc3f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411884Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807043}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bb481754..ff50ca34 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I532d3b334934a0fdf136431afe77edde104e8568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411892 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807042}
-
David Maunder authored
The EndpointFetcher needs to have its own build target so it can be more easily depended on. Bug: 1124800 Change-Id: I27b5d9b81d9d81a7d9a310c91258638e432e9c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401265Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#807041}
-
Olivier Robin authored
Histogram is recorded using base::UmaHistogramTimes and has an expected value of 10-86400 seconds. The current display does not useful as everything is in the 10000+ bucket. Bug: 1127878 Change-Id: I3f2fa6228bdb0313cc2f1cc9edbb42aad2897abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409909 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Miguel Casas authored
This CL follows crrev.com/c/2393629 by batching up SubmitBuffer calls in the JPEG encode accelerator (JEA). This was not verified perf-wise but the savings are obvious given all the other CLs on this bug: we avoid locking-unlocking the |va_lock_| for every buffer submission, and there's 5 of them per JEA Encode() call. Time saving of course will be minimal but the target here is to reduce contention on the lock Bug: b/166646505 Change-Id: I4ad8ba3498cdcb1d1259dc527a7b4799320fc599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405417 Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#807039}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8de6416d85af5cd6a809a997805c78d1bb75aad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412269Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8b068ffba19b..28ecfe40d6ae 2020-09-15 aerotwist@chromium.org [TS] TypeScriptify HeapSnapshotModel 2020-09-15 adithyas@chromium.org Portals: Fix isTopFrame logic 2020-09-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1127046 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iea328be026f6019173152302485bcb4f61d1e48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412272Reviewed-by:
-
Garrett Beaty authored
Change-Id: Id8577e412e9b43cb2f647384ec162c92eee6cfc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410553 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#807036}
-
Reilly Grant authored
The 'brk' signal was renamed to 'break' in r797507 however this manual test was not updated. Bug: 884928 Change-Id: I144e02e6bcca632a6ae4a72fbf31cfb7ba2dcf31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405893 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#807035}
-
Bret Sepulveda authored
This patch changes the request row icons and Flash's learn more button to color-tracking versions of the basic Views, which fixes the bug. This also changes the learn more button to track kColorId_DefaultIconColor instead of kColorId_LabelEnabledColor, but this is more consistent and matches the request row icon. Bug: 1125510 Change-Id: I0931622efbf3a4a6e56ad236a281f4201b9d27d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409958 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#807034}
-
Xianzhu Wang authored
Don't invalidate tiling: - when LCDTextDisallowedReason changes from one reason to another as long as PicureLayerImpl::can_use_lcd_text() is the same as HighResTiling()->can_use_lcd_text(). - if there is no text, but keep the high res tiling with the existing LCD text and raster translation they don't matter without text. This doesn't fix the root cause of the bug (crrev.com/c/2411492 by vmpstr@ does), but is just a performance improvement. Bug: 1127803 Change-Id: I2dfd9523b32cc4a3de828892e726514f3186151f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410580 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#807033}
-
Shawn Gallea authored
Adds rounded corners if the topmost visible window has a visible unmanaged app as a parent. Bug: b/168272523 Test: Locally on device Change-Id: Ic23f38e12b4a3aa873777def8271a5f8c2e3d537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407073Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#807032}
-
David Maunder authored
We no longer allow tab attributes to be acquired after tab#destroy(). This has unveiled a number of places in the codebase where invalid assumptions have been made. This patch fixes one of them in TabPrinter. Bug: 1117396 Change-Id: I7657824663b28eeaaf3f98a40d243a9d7bd6d167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409675Reviewed-by:
-
Javier Ernesto Flores Robles authored
This also makes naming consistent with crrev.com/c/2410250. Bug: 1090776 Change-Id: I29383a78da2847d486a706ab15aaeb5edf6048fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410484 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#807030}
-
Roman Aleksandrov authored
Add thresholds to announce by spoken feedback timeleft and percent progress only after reaching them. Bug: 1124252 Change-Id: I0374fdb9e3ffdf9e16d1cbb664cb6025d8208fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391151Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#807029}
-
Steve Kobes authored
Change-Id: I794f216f0ab263667b7a5d130e38801bd2656f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410821Reviewed-by:
-
Peter Marshall authored
Devtools is adding functionality to do in-product surveys via a non-public API. This CL adds the ability for the chrome-internal repository to set an API key that gets piped through to devtools. The API key is added to google_api_keys in the same way that other API keys are handled, meaning it can be locally overridden, although there is not much point to actually doing this because the API itself is not public. This CL adds a new method 'getSurveyAPIKey' to the InspectorFrontendHost API which the devtools frontend uses to communicate with chrome. The corresponding frontend CL is http://crrev.com/c/2361683/ Doc: https://docs.google.com/document/d/1wMRb1hI2zJ1mzOSJjjF46C2hToGksQf2AxurorxaiTg/edit#heading=h.jc7x7daf69yo Bug: 1112738 Change-Id: Ic3d9d436556f06b8ff8fb3593e4ed40d68ed3507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362182Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#807027}
-
