- 02 Apr, 2019 40 commits
-
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7382a72a748f..d5bcd378e589 git log 7382a72a748f..d5bcd378e589 --date=short --no-merges --format='%ad %ae %s' 2019-04-01 thestig@chromium.org Use CIPD packages for GN instead of GCS. 2019-04-01 thestig@chromium.org Roll build/ a525b65ef..ef1e2b871 (27 commits) 2019-04-01 thestig@chromium.org Roll third_party/zlib/ 1337da531..bb293c33b (3 commits) 2019-04-01 thestig@chromium.org Remove build/secondary usage on Android. 2019-04-01 thestig@chromium.org Roll build/ c899486de..38cbca57e (115 commits) Created with: gclient setdep -r src/third_party/pdfium@d5bcd378e589 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:855791,chromium:947060,chromium:947060,chromium:947060 TBR=dsinclair@chromium.org Change-Id: I1d764cf1510dba98e1691c0d5efb303b056c235d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548501Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646657}
-
Scott Chen authored
The toast needs to be in <welcome-app> because it needs to stay visible after cr-view-manager switches to the next module, so it cannot be in the set-as-default module itself. Bug: 906143 Change-Id: I0215e4aaa54ab37b50d5cf8d88e603657678815f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546191Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#646656}
-
Findit authored
This reverts commit 1dc2db8c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 646299 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzFkYzJkYjhjNWJhZTkzYmE0ZWVmODc1ODY1ZmQ0ZmY0NTI5OWJhZmMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/15927 Sample Failed Step: webkit_unit_tests Original change's description: > Use GrMockContext (rather than NullGL interface) in blink unit tests > > Skia's NullGL interface is deprecated, and this is the last piece of > code to use it. The Mock context is actually maintained (and simpler), > but is functionally a different backend. > > With https://skia-review.googlesource.com/c/skia/+/204221, it supports > exporting textures as "GL", enough to allow CanvasResourceProvider to > work properly in tests. That, plus adding BGRA support (done here) gets > everything passing. > > Change-Id: Id39101ed45f72e2294af9093e4610699936528ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542239 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Auto-Submit: Brian Osman <brianosman@google.com> > Commit-Queue: Florin Malita <fmalita@chromium.org> > Cr-Commit-Position: refs/heads/master@{#646299} Change-Id: I5d42dfc6e68b8c5708819cc84bfbbbb8c3f865f0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546542 Cr-Commit-Position: refs/heads/master@{#646655}
-
Hector Carmona authored
Screenshot in bug. Bug: 947107 Change-Id: I6eaa1dc071379fd169e077b77fb248e20c20d5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548605Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#646654}
-
Jeevan Shikaram authored
The favicon for the App Management page was changed from the default favicon to the favicon of the settings page. Bug: 947895, 906508 Change-Id: Ibfec0f725024430ab883b52aa2231d810a326c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546741 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#646653}
-
Victor Costan authored
This allows the class to be shared between test files. Bug: 945204 Change-Id: I17688c4e1b5564a45c4edef56ae350f31a009dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548562 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#646652}
-
Toni Barzic authored
Fixes a race in recommend_apps screen, where initial message was being sent to the recommend apps webview before the script to initialize it was run (and thus, the code that adds a message listener in the webview could get run after the initial message from the embedder is delivered). Note that recommned_apps_fetcher implementation has not really changed, except for: * Made RecommendAppsFetcherImpl implement RecommendAppsFetcher interface * Moved some logic from RecommentAppsFetcherImpl ctor to newly introduced Start() method Added methods to check whether an element is enabled/disabled to js_checker, and new methods for checking element visibility that test element's offsetHeight and offsetWidth - the approach with checking hidden property does not work for elements that are hidden using "display: none" CSS (e.g. recommend_apps screen buttons). BUG=947203 Change-Id: Ib8653983f202d6215fb637dcecbe8ee10f624294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546961Reviewed-by:Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#646651}
-
Hirokazu Honda authored
As stated in https://crbug.com/929849#c58, there may be a risk to enable low power encoder by default. We should perform A/B test via finch. This CL disables the feature by default, which follows chrome feature release procedure. Bug: 929849 Test: Confirm EncSliceLP is not used in appr.tc on sarien Change-Id: I34638d0490d20746cbd630c5cc7bbc8c647b75f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545437 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#646650}
-
Rakib M. Hasan authored
Bug: chromium:698902 Change-Id: I2311d9df9f822d6fe7ec9fe50a58532f644e1763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548471Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#646649}
-
Xing Liu authored
This CL introduces a core logic class to pick scheduled notifications to show. Basically it checks the configuration and impression history, and iterate all types of notification to return a list of notification. Also implements a unit test frame work for this class, more test cases will be added in following CLs. Bug: 930968 Change-Id: Ia35519fe7a8509c53fa84ab380d42214c59d4e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546672 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#646648}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/310294adacdd..925cad816956 git log 310294adacdd..925cad816956 --date=short --no-merges --format='%ad %ae %s' 2019-04-01 jmadill@chromium.org Add a presubmit builder. Created with: gclient setdep -r src/third_party/angle@925cad816956 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I3bcf262baaa6a9dc7d90ca3f30f0b0291104020b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548498Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6c072efe9f0e..ae4b62318dba git log 6c072efe9f0e..ae4b62318dba --date=short --no-merges --format='%ad %ae %s' 2019-04-01 amithi@webrtc.org Reland "Add bindings for simulcast and RIDs in Android SDK." 2019-04-01 julien.isorce@chromium.org Improve application window picker on Mac that was not listing all apps. 2019-04-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e7b7dc61..29ea6db3 (646176:646310) 2019-04-01 srte@webrtc.org Adds ScaleVideoFrameBuffer to libyuv. 2019-04-01 srte@webrtc.org Adds function to calculate squared error sum to libyuv. 2019-04-01 titovartem@webrtc.org Fix params comments in network emulation layer and its usage in scenario framework 2019-04-01 titovartem@webrtc.org Follow up CL to address clang-tidy suggestions minor issues. 2019-04-01 titovartem@webrtc.org Cleanup: rename endpoint_controller_ into endpoint_container_. 2019-04-01 hta@webrtc.org RTCDataChannel: Ignore "id" when "negotiated" is false 2019-04-01 srte@webrtc.org Processing emulated network on task queue. Created with: gclient setdep -r src/third_party/webrtc@ae4b62318dba The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:516230,chromium:None,chromium:948055 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4075b0c0920adae9e9ae8032f5d72a0fcd3ec46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548106Reviewed-by:
-
Sunny Sachanandani authored
Creating decode swap chain fails with many DXVA frames. Add dump without crashing and alias to investigate. Bug: 848093 Change-Id: Ibac6fa72f5764b0d3081a0e782bba3aca676ba8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548587Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#646645}
-
Suman Kancherla authored
This is a reland of fa29f6dd The original change broke this test: WebXrVrBrowserTestStandard.TestInSessionPermissionNotificationCloseWhileVisible The reason was that the test assumes that BrowserRenderer will not change. But, with this change, BrowserRenderer will be re-created everytime StartOverlay() is called after a StopOverlay(). The fix is to dynamically query for the BrowserRenderer from VRBrowserRendererThreadWin. Original change's description: > [ui/vr] Display different inheadset notifications > > Shows a toast with instructions to exit VR session right after > session starts. > > Also, displays inheadset notifications for previously granted > permissions when entering immersive presentation, and also when > they become in-use. > > Bug: 913502, 732449, 934056, 937383 > Change-Id: I5d17732da62d07cc7d037160e1914b9fa58f1917 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527863 > Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#646117} Bug: 913502, 732449, 934056, 937383, 947927 Change-Id: Ia06d39fa3ba6c6f47072a35fd242757e4c148f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548606Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Cr-Commit-Position: refs/heads/master@{#646644}
-
Alan Cutter authored
PwaIconView was the first PageActionIconView to make use of the label functionality. This revealed two bugs in PageActionIconView: - The text color was hard coded as kColorId_LabelDisabledColor. - OnNativeThemeChanged() didn't call the superclass resulting in uninitialised values for LabelButton::button_state_colors_. This CL fixes both issues. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=386810&signed_aid=781DgZbUS5lVNN4F1taohA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=386811&signed_aid=n-KvGoW3qBU6UsD6x72gnA==&inline=1 Change-Id: I834b7720932bab5eff93892ea7026b8d6140a720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545431 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#646643}
-
Shu Chen authored
1) Makes MojoHelper lives as long as InputMethodEngine. This is because the mojo connection breakage should NOT be triggered by InputMethodEngine::Disable. Otherwise, the engine client and IEFR will both handle the connection error and would have race conditions. 2) Makes sure InputMethodEngineBase doesn't call GetInputContextHandler() and let subclasses to override all the methods to callback to the engine client. Bug: 937167 Change-Id: Ic567e5dca153eca9f1b2eb739c66f25a55a30088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545442Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#646642}
-
Taylor Bergquist authored
Bug: 940388 Change-Id: If05f6c8dce4e089c4214d6105c60bec9ffb9ed86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548607Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#646641}
-
Drew Stonebraker authored
Android arm64 builds of monochrome need to build multiple apks with various combinations of 32-vs-64-bit chrome & webview. Each apk will need a unique version code, distinguished by the second-to-last digit (the architecture digit). This CL modifies the version code logic to support this. Bug: 946281 Test: Check chrome_versions.txt, add automated tests. Change-Id: I78b8d6fedb4c18db2442f50a027f988616e180c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540683 Commit-Queue: Drew Stonebraker <stonebraker@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#646640}
-
Matt Mueller authored
Change-Id: Ib7fa13eb923585646a8168551637fae6bb4a3454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545498 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#646639}
-
Joey Arhar authored
DevTools uses Resource's identifier to track network requests, and by moving it to ResourceRequest, we can send it to the browser process through the URLLoader interface and track network requests in the browser's DevTools instrumentation. Bug: 899386, 849483, 856777 Change-Id: I40c3ce1fb973eda7f388fc81db202f45fd158fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542734Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#646638}
-
Adam Langley authored
Based on other subpages, the first row should not have a horizontal line preceding it. Bug: 947929 Change-Id: I520e78147f3e2e84079993dfabe5041d7bbd6d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548237 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
-
Xing Liu authored
The collection store will be used by notification store and impression store. They both loads data into memory and keep in-memory data synced with the underlying storage. The icon store will not use this because it only moves data through the pipeline and never held by classes in memory. This CL tweaks the collection store interface to better fit the need of notification store and impression store. Bug: 930968 Change-Id: Ia113c3ca9a4074f1673c957e08e82fda6208bdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548633Reviewed-by:
-
Tatiana Buldina authored
Bug: chromedriver:2830 Change-Id: I2363609a6ee64d8114fd9f802aedbb10eac0cbd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548051Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#646635}
-
Brian Sheedy authored
Automates the manual tests for ensuring that the security icons that display in the URL bar and the popups that show when you click on them look correct while in the VR Browser. Bug: 887505 Change-Id: I0d826ab1bafb6926bbc2e0da60b27450077bdd1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544825Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#646634}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3bd0f72522df..ff8d67bfe996 Created with: gclient setdep -r src-internal@ff8d67bfe996 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: I434b91b9e9fcd7d0ae5c8a887bec3e5424adace7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548495Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646633}
-
Ryan Sturm authored
This will allow us to accurately measure prefetch performance on Android to determine if GWS should use prefetch on navigational queries (As Desktop already does). This will also allow us to run a small holdback on Desktop to measure current performance. Bug: 948306 Change-Id: I071116ecba60d77cdaf69540219f57872de734d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547768 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#646632}
-
Maggie Cai authored
This CL shows the intent picker for all desktop platforms (behind intent picker flag). All existing tests are passing except few ARC GetDestinationPlatform tests. Will have a follow up CL to restore these tests. Once the upcoming App Service is available, a single navigation throttle will be able to display the intent picker on all platforms. For now, a Chrome OS specific throttle for querying ARC apps is implemented as a subclass of the parent desktop throttle, which queries for desktop PWAs. BUG=939205 Change-Id: I7f95eeb87fc211a2c8cae0ad8435d6cb6bb03cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517332Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
-
Ben Kelly authored
In crrev.com/c/1457196 we added logic to keep service workers with a FetchEvent handler at foreground priority if they were controlling clients in different processes. This logic basically looped over clients comparing their process id to the worker's process id. Unfortunately, that CL had a bug in that the controlled client for a new navigation to a controlled scope will have an invalid process id to start. Even if it is ultimately placed in the same process as the worker the worker's priority may still be kept at foreground priority incorrectly. It would require a second client to be added/removed in order to for the new process id to be noticed. This CL fixes this bug by re-evaluating the foreground priority criteria when a controlled client's process id changes. The unit test has been verified to fail in previous versions of the code and passes with this CL. Bug: 928904 Change-Id: Id84229da04d0fd4b0eacbba324c312b5448f2175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546888 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#646630}
-
Yuwei Huang authored
* Implement TestOAuthTokenGetter that loads the stored access token and runs the authentication flow. * Move CLI related logic into cli_util.cc These make it easier to implement FtlSignalingPlayground Bug: 947337 Change-Id: I5fb56008f2952f9444d2e0760f4614fb46667484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548599 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#646629}
-
Eugene But authored
The test flakily fails on iPhone and iPad devices. Bug: 944803 Change-Id: I102cfae6ed43d57db7d63deedb1cea61a1bd0405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548534 Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#646628}
-
Charles Zhao authored
This work is for separating TabFeatures calculation from ukm logging. (1) PageMetrics is expanded to also have page_transition. (2) TabMetrics is not needed any more. (3) More tests are added to confirm that each TabFeature is populated correctly. (There will be another cl that confirms features in TabActivityWatcher are all populated correctly.) Change-Id: Ie7f718155c03259513670cd0edce870f07a9c7cd Bug: 945699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538069 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:François Doray <fdoray@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#646627}
-
Staphany Park authored
'string' clashes with 'String' in Googletest. Change-Id: I6b0880e7bbd86d225dfae9e1996f2848c7040ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548603 Auto-Submit: Staphany Park <staphany@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#646626}
-
Bill Orr authored
Fall back to 3dof-orientation only when tracking is lost. If we previously were tracking, use the last position. This doesn't add emulated controller positions - controllers aren't reported if tracking is lost. Bug: 944605, 928814 Change-Id: Idc963f66b30905012a7fb6675c07e0d22a382d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545153 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
-
Daniele Castagna authored
This CL fixes two bugs for rounded corners: - Rounded corners uniforms were not set for YUVDrawQuad. - Rounded corners uniforms were set on the wrong program for TextureDrawQuads. It additionally removes an early out in SetShaderRoundedCorner when there is no current program or the uniform location for rounded corners data is not there. That was likely introduced since we were calling SetShaderRoundedCorner on the wrong program or when a current program was not even set. Bug: 946728 Test: Ran overview mode with a video on Linux and Nocturne. Change-Id: I9902eff8349367199b24c3629e7949a68e453877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544805 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#646624}
-
Daniel Murphy authored
There is no functional or code change with this patch, only re-ordering R=jsbell@chromium.org Bug: 862456 Change-Id: I697154c774b316a5e827967103f005dbf13f3232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544810Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#646623}
-
Sunny Sachanandani authored
Implement a PRESUBMIT check to check that GLES2, raster, and webgpu autogenerated files match the output of the respective script when any of them are changed. Also checks that any changes to autogenerated headers have corresponding generator changes. Bug: 945670 Change-Id: I37e1709647dde25d111af01e945085689a1a4794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546673Reviewed-by:
-
Chris Blume authored
Currently, the wrong context is being used inside the SharedImageRepresentations when using multiple contexts across multiple threads. This CL will route the correct context to each SharedImageRepresentation. Bug: 938594 Change-Id: I5c0e7583258f3e1c7256d39223b4c9b4b738b8ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542785 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#646621}
-
Yue Zhang authored
* Fix some padding and gravity related bugs. * Add elevation for TabGrid card on devices with API 19-22 Bug: 928388 Change-Id: I7833f2cc2eb3025c138533f457702efbb0b5a84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546534Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@google.com> Cr-Commit-Position: refs/heads/master@{#646620}
-
Peter Boström authored
Adds a header area to the top of the Extensions menu. This is not done as a bubble title since the area needs to have non-standard buttons in the captions area + transitions will be made between different pages. Bug: chromium:943702 Change-Id: Ie9c62e0f1d9ea5cf5e53b94a18c5810ca83112af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548244 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#646619}
-
lemeshev authored
With the autofill-captured-sites-rel bots running in the Chromium lab every 6 hours, we can increase the number of tests from 13 to 100. This change checks in an additional ~90 captured sites tests into CIPD, sites that I have verified are stable in the latest Chromium builds. Please also note that the list now only has the FIRST 100 tests that are passing. We actually have 128 tests passing at the moment. Updates the CIPD yaml config file. (I uploaded new files from my local machine by running a cmd against the new CIPD yaml file) Updates DEPS to pull the new test support files. Change-Id: Id962ab050df3bfb6c9a906a2d6f5f418187a6e63 Bug: 847905 Change-Id: Id962ab050df3bfb6c9a906a2d6f5f418187a6e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546670 Commit-Queue: Pavel Lemeshev <lemeshev@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#646618}
-
