GitLab

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /content/browser/service_worker

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().RunUntilIdle()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Includes should have been stripped if the was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=nhiroki@chromium.org

Bug: 781352
Change-Id: Ia1793866f9ebdf502732dcd49861bf3b80c29894
Reviewed-on: https://chromium-review.googlesource.com/995973
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548622}

To improve naming consistency, this changes instances
of "Calculate" prefixes to "Compute". It also prefixes
more methods with "Compute".

Bug: 807463
Change-Id: I9ccebc5ffbdf42e24142e21d850ea4a8e8ac0364
Reviewed-on: https://chromium-review.googlesource.com/981518
Commit-Queue: Brian Anderson <brianderson@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548621}

Protocol implementation was not updated to match new signature.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ife923bfd9ad80962d322594fc7bacaf50a051a4e
Reviewed-on: https://chromium-review.googlesource.com/998678Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548620}

BUG=825218

Change-Id: I003e8f60fd7df7cd469881917f47f0cdb2e1da42
Reviewed-on: https://chromium-review.googlesource.com/996590Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548619}

Updates the ContextualSuggestionsService to call the new
ContextualSuggestionsMetricsReporter to do basic metric
reporting.

BUG=824185

Change-Id: I6db197cd0390abcda1337569e30b2f42961cac0f
Reviewed-on: https://chromium-review.googlesource.com/994709Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548618}

Create the arrows and style element on the overlay on demand when
they are first needed.

BUG=821961,821414

Change-Id: Ic695c7e3aef337e304d225575a40811a25243dbf
Reviewed-on: https://chromium-review.googlesource.com/988686Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548617}

This roll incorporates a SDK fix which includes the QEMU-compatible
build of zircon.bin for arrch64.

Bug: 707030
Change-Id: Ib8efb5cdb5687af4f35b91fceb65a9343207dcf8
Reviewed-on: https://chromium-review.googlesource.com/999092Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548616}

Tab.loadurl is currently called in finishNativeInitialization in
WebappActivity vs in initializeState in ChromeTabbedActivity.
initializeState is called earlier in the async chain in
ChromeBrowserInitializer. This CL moves the call to loadUrl to
initializeState in WebappActivity.

Testing shows that this change leads to a 50-70ms improvement in
startup time:

	                         improvement	 average deviation
Startup (ms)	                  81.86214	 39.11936
StartupToNavigation (ms)	  66.5648        34.37813714
NavigationToCommit (ms)	          56.64914	 20.09670629
NavigationToContentfulPaint (ms)  5.47332	 29.81943543
StartupToContentfulPaint (ms)	  72.03812	 47.7408
NavigationToMeaningfulPaint (ms)  5.4415	 29.80534286
StartupToMeaningfulPaint (ms)	  72.0063	 47.73242286

Bug: 825259
Change-Id: I90aee902d9d0fcef4972fafd40453f6f02b320d1
Reviewed-on: https://chromium-review.googlesource.com/995635
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Dmitry Skiba <dskiba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548615}

BUG=

Change-Id: I447814b1fb250062f4e204b31208c5b9b01f0fc3
Reviewed-on: https://chromium-review.googlesource.com/998738Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548614}

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ifda21ef12190a45dee0046d32f8835abf9f49a1d
Reviewed-on: https://chromium-review.googlesource.com/997101
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548613}

This CHECK was overkill.  Just set something on the object instead to
make sure that the PaintFlags is not bogus.

Bug: 829199
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I24500c9403959d7861575d368c930c1a2ebcfc74
Reviewed-on: https://chromium-review.googlesource.com/998495
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548612}

This fixes a DCHECK crash where we were making a call to bind the GPU
interface that wasn't called on the IO thread. It now makes a call on
the IO thread to get the interface which then posts a task back to the
original thread to then complete the Mojo call.

Bug: 829045
Test: Verified DCHECK is gone and L1 DRM still works
Change-Id: Ia10ce58a2ecef071f33cfc48a49c72af3bc23a8c
Reviewed-on: https://chromium-review.googlesource.com/998530
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548611}

If you don't install a connection error handler before an error can
signal, you're gonna have a bad time.

Bug: 826450
Change-Id: I1a1b16b66449d89783aa8a9fae34e57e91a1d4f9
Reviewed-on: https://chromium-review.googlesource.com/998994Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548610}

I overzealously landed https://crrev.com/c/990493 assuming that if a TCP
connection is open (directly, not through a proxy) with an empty ALPN
list, then the server cannot negotiate HTTP/2.  While there are no
crashes seen during the first day of Canary, https://crbug.com/828865
shows that it is unwise to rely on the TLS layer to fail connection
negotiation if server's ALPN response does not match the client
handshake.  While it is still unclear if this crash can occur in the
while, I am adding a unittest in this CL that triggers it, and removing
the CHECK in favor of just return ERR_NOT_IMPLEMENTED in this weird
case.

Bug: 819101
Change-Id: I2c2f70c62485714e61176d75f95d93a67484b800
Reviewed-on: https://chromium-review.googlesource.com/997152
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548609}

Use a Unicode template string for formatting commit lists, because the
commit subjects can contain non-ASCII characters (and they are Unicode
strings because the underlying host.executive automatically decodes the
subprocess outputs by default).

There are definitely other places that might break when seeing non-ASCII
characters, but nothing can be found around here.

By the way, MockExecutive is changed to match Executive more closely:
run_command now decodes the output and returns a Unicode string by
default. This change isn't required to fix the bug, and doesn't catch
other bugs for now, but hopefully it might be useful in the future.

Bug: 827502
Change-Id: Ib46bfe4cc18d23c2298dfd44bb6ab907dd83e987
Reviewed-on: https://chromium-review.googlesource.com/998676Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548608}

Adds the option to the VR bisect script to specify the expected JSON
output format. This defaults to chartjson, which is the format we expect
out Telemetry tests to output to and is the most common output we use.
However, it also supports the format from tests that use
//testing/perf/perf_test.h, such as our vr_common_perftests target.

Change-Id: I0a457b816aeb85b422be9ca856ef01ba3233cc17
Reviewed-on: https://chromium-review.googlesource.com/998816
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548607}

This reverts commit 9e3e507a.

Reason for revert: Disabled wrong test.

Original change's description:
> Disable test doubletap-to-jump-forwards-too-short on WebKit trusty debug
>
> Likely failing due to incorrect rebaselining from:
> https://chromium.googlesource.com/chromium/src/+/7a8765a7a7e0158e7f82681d06ce798bf8901328
>
> TBR=beccahughes@chromium.org
> TBR=thomasanderson@chromium.org
>
> Bug: 829228
> Change-Id: Icf2894aae0a4c0ed3baa85d82f7dd47417410d23
> Reviewed-on: https://chromium-review.googlesource.com/997197
> Reviewed-by: Darren Shen <shend@chromium.org>
> Commit-Queue: Darren Shen <shend@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548371}

TBR=thomasanderson@chromium.org,shend@chromium.org,beccahughes@chromium.org

Change-Id: I4000d62b9e4802214eabd139d62027d9e5664c50
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 829228
Reviewed-on: https://chromium-review.googlesource.com/999073
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548606}

TryToSetupEncodeOnSeparateThread() in MediaFoundationVEA is not being called at
all and will never be used.
This CL deprecates the function in MediaFoundationVEA. As a result, all the VEA
interface functions are executed by GPU IO thread.

BUG=chromium:828047
TEST=VEA unittest

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie6b236b637ce99a29116dba9fffda89562830067
Reviewed-on: https://chromium-review.googlesource.com/997035Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548605}

https://webrtc.googlesource.com/deps/third_party/openmax.git/+log/63d8cf4708c9..59265e0e9105

$ git log 63d8cf470..59265e0e9 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/openmax_dl

Bug: 812974
Change-Id: Ie6973eb625671b98e3c4ec81dda3bb2cef252609
Reviewed-on: https://chromium-review.googlesource.com/998626Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548604}

The instructions for generating a minimal solution were out of date. The
--no-deps argument is now required. Also explain how to debug all
processes and mention VsChromium and the option to edit without a solution
file.

Change-Id: Iba5b2b00d2f93f9a05d6a5741f4651fec36ed701
Reviewed-on: https://chromium-review.googlesource.com/997100Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548603}

R=amineer@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If4849f9291da8b84518c592734166c35b034250b
Reviewed-on: https://chromium-review.googlesource.com/999023Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548602}

https://chromium.googlesource.com/catapult.git/+log/883d59ef7027..7b821dff5984

$ git log 883d59ef7..7b821dff5 --date=short --no-merges --format='%ad %ae %s'
2018-04-05 dtu [pinpoint] Make "isolate not found" a fatal error.
2018-04-05 bsheedy Fix service starting on N and below

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:828190


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I2c2f761036fccbcdbe0d5ba25bb8e3f5666eb9f7
Reviewed-on: https://chromium-review.googlesource.com/998691Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548601}

Previously, if an SVG embedded frame was not yet attached,
then we would not detect it as SVG and fail to update its style.
As a result, its intrinsic sizing may not be up to date at the time
it is needed to size the embedded content element that contains the
embedded frame.

Bug: 820095
Change-Id: I21c9ee3d3303fb0a773dd3963d238970be25effa
Reviewed-on: https://chromium-review.googlesource.com/997177
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#548600}

When serializing a SkTextBlob, skia flattens it into allocated memory
which is then copied into PaintOpWriter's memory. Change this to
directly serialize into the writer's memory.

R=enne@chromium.org, reed@google.com
BUG:821584

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I644a02aba1b8f5b204596eaf2b04d8763a9cce37
Reviewed-on: https://chromium-review.googlesource.com/961274Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548599}

This patch implements a new method Page.setBypassCSP
that allows disabling content security policy for the given page.

R=dgozman, pfeldman

Change-Id: I29d55aa593c50a24c12fd8b98a8315387dff30b0
Reviewed-on: https://chromium-review.googlesource.com/996905
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548598}

Bug: 790378,790311,790308
Change-Id: I2dc71e077ef3111fdac4ad30f2441e35e7b29bd4
Reviewed-on: https://chromium-review.googlesource.com/989072
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548597}

According to the spec,
https://drafts.csswg.org/css-backgrounds-3/#background-size,
a background-size of "auto" with no intrinsic ratio or size
should use 100% for the auto value.

Instead we were using the positioning area's intrinsic ratio.
Fix it.

R=fmalita@chromium.org
BUG=828842

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia8d665ff2c725c9e40a89c0e160584feedc41b86
Reviewed-on: https://chromium-review.googlesource.com/996214
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548596}

Using wpt-import in Chromium ae1b701e.
With Chromium commits locally applied on WPT:
4f8cac3b "WebBluetooth: Use [SecureContext] instead of manual check"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15370

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
bajones@chromium.org:
  external/wpt/gamepad
bsittler@chromium.org, pwnall@chromium.org:
  external/wpt/cookie-store
garykac@chromium.org:
  external/wpt/clipboard-apis
guidou@chromium.org:
  external/wpt/mediacapture-streams
hongchan@chromium.org, rtoy@chromium.org:
  external/wpt/webaudio
jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org:
  external/wpt/payment-handler
jrummell@chromium.org:
  external/wpt/encrypted-media
jsbell@chromium.org:
  external/wpt/resources
kpaulhamus@chromium.org:
  external/wpt/webauthn
mcasas@chromium.org:
  external/wpt/mediacapture-record
michaeln@chromium.org, jsbell@chromium.org, mek@chromium.org:
  external/wpt/webstorage
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy
mlamouri@chromium.org:
  external/wpt/remote-playback
nzolghadr@chromium.org, mustaq@chromium.org:
  external/wpt/pointerevents
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request
tdresser@chromium.org:
  external/wpt/hr-time
  external/wpt/navigation-timing

TBR=foolip

No-Export: true
Change-Id: Ib5a7434ba08644ce886f602e9c152a6a26c9ab92
Reviewed-on: https://chromium-review.googlesource.com/998253
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548595}

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /content/test/renderer_audio_output_stream_factory_context_impl_unittest.cc

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().RunUntilIdle()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Includes should have been stripped if the was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=miu@chromium.org

Bug: 781352
Change-Id: Icf40891ff0b5b9ef22e588e65104ff70b55b2047
Reviewed-on: https://chromium-review.googlesource.com/995919
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548594}

Only adds the accessory. No rotation happens when toggling between collapsing/showing the sections.
Rotation will be in future CL.

Bug: 825017
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idca5bd47ca06db6ef394b40690e2c3dd0c83345b
Reviewed-on: https://chromium-review.googlesource.com/987094
Commit-Queue: Chris Lu <thegreenfrog@google.com>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548593}

This allows for temporarily stopping the network so that
update engine tasks can be deterministically cancelled in a unit test.

Bug: 822990
Change-Id: I8d9cf5676c2f1d3211fe392e130eb48052307605
Reviewed-on: https://chromium-review.googlesource.com/998737Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548592}

Adds public API {set|get}UserData to WebContents for embedders to
make use to manage objects of WebContents lifetime without hanging
onto WebContents directly.

Coming up next is ContentView refactored to leverage the public API.
Then embedders will be able to get the container view from webContents,
making WebContents a drop-in replacement for ContentViewCore for many cases.

Bug: 789000
Change-Id: Iad1e93143da5a83e19c86112acd2a94c00a208af
Reviewed-on: https://chromium-review.googlesource.com/994499
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548591}

This CL is based on https://codereview.chromium.org/2538883002/.

This CL adds checks similar to H264Decoder::IsNewPrimaryCodedPicture() to
determine if the given H264 slice belongs to a new frame. On Mac and Win,
we can have multiple slices per frame and this causes problems.

Bug: 669678, 828176
Test: Tested VEAUnittest on MBP 2016.
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4781bacd199ae0545a3f46b37765b126f947b92e
Reviewed-on: https://chromium-review.googlesource.com/991198Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548590}

This change displays the Visible URL in the PH header instead of the
last committed. Moreover, it updates the header when an interstitial
(such as Safe Browsing) is attached or detached.

Bug: 829027
Change-Id: Ie1fd0f9f404d571587f4980687bb170d036e76a0
Reviewed-on: https://chromium-review.googlesource.com/998750
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548589}

This reverts commit cb5a488e.

Reason for revert: Forgot to remove the #getUrlContainerViewsForMargin to avoid overlap with the action container. Will create another patch that fixes this.

Original change's description:
> Bring the URL action container to LocationBarTablet.
> 
> On tablets, the layout for the location bar is overridden by the XML
> in layout-sw600dp, which means instead of the url_action_container used
> elsewhere, it's a series of FrameLayouts for action buttons with
> manually calculated margins.
> 
> This CL breaks the url_action_container into its own file to be included
> on both phone and tablet, and gets rid of the tablet-specific layout
> update for calculating the margin of the action buttons.
> 
> Bug: 820273
> Change-Id: I104551325f49dbee0931e9a55c105d61e55f7796
> Reviewed-on: https://chromium-review.googlesource.com/971404
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548580}

TBR=yusufo@chromium.org,mdjones@chromium.org,thildebr@chromium.org

Change-Id: I274354f53cfa71a235abbb475acaec88580dbfba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 820273
Reviewed-on: https://chromium-review.googlesource.com/998593Reviewed-by: Troy Hildebrandt <thildebr@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548588}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7e9556c8..5e02fa85

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I91c2d839f15a07148b27375d5e2778ff353b881f
Reviewed-on: https://chromium-review.googlesource.com/997873Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548587}

Measure time taken for VR UI steps to help catch regressions.
During WebVR/WebXR presentation, these times should ideally
be close to zero if there aren't any active overlays.

Also adds an overlay element counter, this should only be nonzero
during presentation for the beginning toast or temporary overlays
such as permission prompts.

Change-Id: Id6687bf82dc787f20b4bfd26763b1c3d63416d38
Reviewed-on: https://chromium-review.googlesource.com/998515
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548586}

BUG=none
TEST=none

Change-Id: Iaa61d9eeb3813e5d8131c0790693b69e73fe9602
Reviewed-on: https://chromium-review.googlesource.com/998496Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548585}

This roll is mainly to include
https://github.com/w3c/web-platform-tests/pull/10323, which fixes a bug
that `wpt manifest` would fail when the local manifest is invalid.

wpt.config.json is changed to accomodate:
https://github.com/w3c/web-platform-tests/pull/9998
https://github.com/w3c/web-platform-tests/pull/10078

Bug: 822041
Change-Id: I074afd90e32db299fc6f58b870f9b72576fab225
Reviewed-on: https://chromium-review.googlesource.com/997764Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548584}

hr is read from eax as 0 (S_OK) in minidumps, but that's not possible
since the CHECK fails. base::debug::Alias is a sure way of seeing the
value in minidumps.

R=piman
BUG=794735

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2a92c2967cf6786c6540c49fcacfc97b888fa146
Reviewed-on: https://chromium-review.googlesource.com/998734Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548583}