- 11 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/f9e9052e7e6f..605183825318 2021-01-11 jophba@chromium.org Set up Receiver and Sender for remoting If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Id2a8d34b8195f0c7c402484ffa076b93a9745d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622788Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842198}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bf3659d351a..fff8e7632e28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9f14cf08ff5f233502069bf634934764ac494cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622787Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bdc7f626dbce..026943fd29be 2021-01-11 lalitm@google.com tp: fix include path 2021-01-11 altimin@google.com Merge "[ui] Add support for dynamic tab names" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iedbd62a0b29d86b39a79fe6d9c7f306097642446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622790Reviewed-by:
-
Xinghui Lu authored
Currently there are 10k entries in the high confidence allowlist. It's risky if the allowlist is misconfigured and somehow only a small number of entries are left in the allowlist. In this CL, we check the size of the allowlist. If there is less than 100 entries in the allowlist, we consider it as unavailable and fall back to hash-based check. Bug: 1164555 Change-Id: Ie48bf6197c2255830712b956a886f5deec78fdda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618654 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#842195}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/425c25a8ad2d..002828690efc $ git log 425c25a8a..002828690 --date=short --no-merges --format='%ad %ae %s' 2021-01-11 wub Internal QUICHE change 2021-01-11 bnc Do not use std::string::append(absl::string_view) in QUICHE. 2021-01-08 bnc Implement PRIORITY_UPDATE frame in HTTP/2 decoder. 2021-01-08 quiche-dev Renamed this macro. It's been annoying me for months. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: If8707adfadf1920d5386db50a47f8c2941e7b74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622317 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842194}
-
manukh authored
For |OmniboxFocusType::ON_FOCUS| autocomplete inputs, |SearchProvider::Start()| has a DCHECK to verify that previous requests are done; i.e. |SearchProvider::done_| is true. The omnibox avoids triggering this DCHECK by checking |AutocompleteController::done_| before sending on focus inputs. The realbox previoulsy did not do this; clicking the realbox rapidly resulted in multiple on focus queries and triggered the DCHECK. This CL adds a similar check for the realbox. Bug: 1162870 Change-Id: I8ea8b2102a56cef0ba346c329804664e42cc0fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615663 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842193}
-
Mason Freed authored
Prior to this CL, form restoration could erroneously check the checkbox when the same page was re-opened, but the lines were not wrapped. With this CL, the checkbox will no longer participate in form restoration. This CL also removes word-break:break-word, which is deprecated, and replaces it with overflow-wrap:anywhere. Same effect. Change-Id: I8cfd8014d31376d2fdb7415679666b042ee9dcbc Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612464 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#842192}
-
chinsenj authored
When a user tries to drag a visible on all desks window to a specific desk in overview mode, they are unable to. Currently there is no visual indicator that nothing happened. This CL adds a toast for when this happens and also prevents the desks mini views from highlighting when a user drags a visible on all desks window over the mini views. Test: manual Bug: 1163697 Change-Id: I43acbfb9b90567dbeef294ac97c0e6cc5af33bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616319Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#842191}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610365490-cff9cfe8ee50bd1daf2a4d54676a0415ea568ae4.profdata to chrome-mac-master-1610387594-9644082f15d83cc3788996ee889bd06710e6b3cf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I81bf412b65cae1e4fc80c30718ecea31e8a4634b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622794Reviewed-by:
-
Daniel Libby authored
As not all layouts have been converted to NG, we also need to record painted selection bounds in the non-ng text painting codepaths. This CL adds the ability to compute SelectionState from InlineTextBox, similar to crrev.com/c/2567021 did for NGInlineCursorPosition. This state is then used by SelectionBoundsRecorder along with the selection rect to record the painted selection bounds. Bug: 1065049 Change-Id: I6915783f0c1ffdddd269fe43f729872e1f13e219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597884Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#842189}
-
Alexei Svitkine authored
Makes GetFieldTrialParamValueByFeature() not do an extra field trial look up by making it match the GetFieldTrialParamValue() code path. Also merges GetFieldTrialParamsWithoutFallback()'s contains and map access into a single lookup, rather than two. Bug: 1163921 Change-Id: I602e0ee47f679b143ee1666923b53a2760cae6c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617470 Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#842188}
-
Sammie Quon authored
Previously, the menu had capture so it would take some events from the button. To use the bar, users would have to first click the bar to take capture, and then click again to use a bar button. Doing so would also close the menu. This CL changes that by taking away capture from the menu on entering capture mode. Since doing so will normally close the menu, this also introduces a way for ash menus to ignore the mouse capture losses. Bug: 1155223 Test: manual Change-Id: I19d4ed01d874b4f21975f194ae96cd15af830f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581027 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Cammie Smith Barnes authored
This change plumbs the aliases read from DNS CNAME records to NavigationRequest from network::mojom::URLResponseHead and makes them available to subresource_filter::SubframeNavigationFilteringThrottle, which now will perform checks against these aliases in its WillProcessResponse method. This CL also adds a method to perform checks on a vector of URLs to the AsyncDocumentSubresourceFilter, as well as test support and histograms. Relevant tests: content/test:content_unittests out/Default/content_unittests --gtest_filter=*DnsAlias* components/subresource_filter/content/browser:unit_tests out/Default/components_unittests -gtest_filter=*GetLoadPolicy*URLs* out/Default/components_unittests -gtest_filter=*DnsAlias* Bug: 1151047 Change-Id: Ie84e7b1aa87a1b2b4c720c92b963950cb44f457f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576420 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842186}
-
Etienne Pierre-doray authored
This CL avoids expensive and repeating work of filling ModuleCache with modules in NativeUnwinderAndroid::AddInitialModules. Instead, ModuleCache::RegisterAuxiliaryModuleProvider is used to register a provider that lazily creates non-elf modules when needed. To make that possible, this CL makes explicit new constraints on Unwinder: a single ModuleCache is "associated" with a Unwinder for its lifetime and ModuleCache must be outlive by any Unwinders it's associated with. A follow up CL will refactor the Unwinder interface to better fit these constraints. Change-Id: I05374ed8989061c81cde0ba09605b54e6b2309b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514743 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#842185}
-
Eugene But authored
The experiment did not help with reducing UTEs/XTEs Bug: None Change-Id: I4cbb330138e8fc49e13a1dcf0d9787eb1b1946c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613648 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#842184}
-
Fredrik Söderqvist authored
It only has a single user, and folding the function makes it simpler. Relocate the ShadowMode enumeration as suggested by the TODO. Bug: 1159514 Change-Id: I2af6c08da74f199dcffc94f84e21e60da5037ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618139Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#842183}
-
Roman Arora authored
Leverage the ListPropertyUpdateBehavior logic that uses Polymer's splices and calculateSplices functions to efficiently modify a single list item on tab updates, and avoid unnecessary scroll height calculations. Additionally, tab updates for not yet rendered items do not result in DOM updates. Proposal doc & benchmarks: https://docs.google.com/document/d/1FcuhM98moL-BYB1DJGXrpwf-JqMz1aI-RQV08giArBY/edit#heading=h.xzptrog8pyxf Most relevant pinpoint benchmarks: https://pinpoint-dot-chromeperf.appspot.com/job/15db6158d20000 https://pinpoint-dot-chromeperf.appspot.com/job/107ab7f4d20000 https://pinpoint-dot-chromeperf.appspot.com/job/16ccacccd20000 Bug: 1149400 Change-Id: I07fae967033b13830708da3035db3e8b2f0ff9d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578119 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#842182}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6f4e54f003dd..b90a077d51ec 2021-01-11 vidorteg@microsoft.com Reducing ambiguity in some strings 2021-01-11 morlovich@chromium.org Custom UA-CH emulation: initial integration test 2021-01-11 janscheffler@chromium.org Revert "[JSDOC2TS]: Migrate webauthn" 2021-01-11 tvanderlippe@chromium.org Move assertNotNull into platform 2021-01-11 janscheffler@chromium.org [JSDOC2TS]: Migrate webauthn 2021-01-11 jacktfranklin@chromium.org [Dark mode] replace #fff background-color 2021-01-11 altimin@chromium.org [devtools] Remove timeline flow event experiment. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1073909,chromium:1136655,chromium:1152736,chromium:1158760,chromium:1164298 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie45a76f65bfc24c7623c57b6ed47f4f2475c18c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622830Reviewed-by:
-
Michael Lippautz authored
In addition, avoid using base::Optional<> within fields of GarbageCollected objects. This does not work well in general, as emplacing a new value constructs an object in place which does not trigger a write barrier. Eventually, this will lead to heap corruptions. The check is implemented in the GC plugin but compilation now also fails because of missing trace traits. base::Optional<> used from stack or parameters is supported and stay unaffected of this change. Bug: 1056170 Change-Id: I197c0bf0975823a77c873a7dbfd2fdd9f2668ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621892 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842180}
-
James Cook authored
Only two fail. The failures are related to multiple profiles, not context menus in general. Bug: 1150200 Change-Id: I40c9fa722d3e888d77a31e0155afdaf6c4154369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622574 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#842179}
-
Sam Maier authored
Since getting properties from the BatteryManager can occasionally be very slow, we get these properties in the background, and return the result to the UI thread. This prevents the UI thread from hanging on the slow operations. Bug: 1163401 Change-Id: I918b36bdabfdf0a1b41063316b64bb41539ce6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617468 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#842178}
-
Jeffrey Kardatzke authored
When a resolution change event occurred, we would have parsed the curr_frame_hdr_, but then this would cause us to skip extracting the DecryptConfig for the current frame. This retains the DecryptConfig so it can be used when that frame is decoded. BUG=b:155509231 TEST=Encrypted VP9 plays back on volteer w/out corruption Change-Id: Ie005d2bcea0677342e262a96eb3b97d919cbf9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622750 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842177}
-
Daniel Nicoara authored
Bug: None Test: Compiled & ran wayland_webview_client Change-Id: I928ec220a0406dcb13466c00a4c8072d9f7ee326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616832Reviewed-by:
Shawn Gallea <sagallea@google.com> Reviewed-by:
Ryan Daum <rdaum@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#842176}
-
Matt Wolenetz authored
Avoids need to take a lock in ::Trace by changing from an Oilpan-managed |live_seekable_range_| to plain boolean/double members in MediaSource. BUG=1162613,878133 Change-Id: Ic437b4b6f1143faad98750bd6c1d2a9791907ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617351 Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842175}
-
Sammie Quon authored
This reverts commit 9cc64477. Reason for revert: Breaks ChromeOS builder. See https://crbug.com/1165349. Original change's description: > Fix flakiness in ChromeLabsButtonTest.ShowAndHideChromeLabsBubbleOnPress > > This test is very flaky, I believe because it relies on global state, > instead of explicitly setting up the LabInfo used to populate the labs > button. For example, if there were no current labs in SetUpLabs, the > test would fail. So this CL explicitly sets up the LabInfo for the labs > button. It's a bit messy that it requires a change to the production > code, but I didn't see any other way of plumbing that information > through to the model. > > Bug: 956719 > Change-Id: I8078c211e37fc1eeff50a44043eca760cdc4850a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618656 > Reviewed-by: Collin Baker <collinbaker@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842150} TBR=davidbienvenu@chromium.org,collinbaker@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I5cd05c29bb299b97fe8b491d865a9925c642a5f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 956719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622519Reviewed-by:
-
Katie Dillon authored
This CL is a followup to this CL[1] and removes an unecessary call to GetTaskQueue() as a step towards removing direct access to a MainThreadTaskQueue's TaskQueue all together. Specifically, a test was using the task queues name to track whether or not a task had been run off that queue. This CL modifies this to follow the same pattern that is used in MainThreadSchedulerImplUnittest (ie passing a string of letters to a function that posts tasks to the correct queues and records that letter when the queue runs the task). [1] https://chromium-review.googlesource.com/c/chromium/src/+/2453591 Bug: 1143007 Change-Id: Ic76c080c78d0caa0464770872150d4e9bdcdb97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617871Reviewed-by:
Scott Haseley <shaseley@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#842173}
-
Michael Thiessen authored
This mainly lays the groundwork for future changes that will actually compute and record how Chrome was launched. As a starting point, we always record the launch type as the fallback OTHER value, when Chrome is brought to the foreground. Bug: 1163961 Change-Id: I47458950a346c078d1a467418995dd00d833e37f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615484Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#842172}
-
Evan Stade authored
This componentizes SiteEngagementService and dependent code, which is needed for AppBannerManager. Bug: 1147274 Change-Id: Ib740aac1f2e353d84722c53ec50f9e33ae193e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613397 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#842171}
-
Thomas Tellier authored
Bug: 1003885 Change-Id: Iaaf0d34234e7b922e5e68be4e8c35d19aa4deb47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622174 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#842170}
-
Joon Ahn authored
Bug: 1125150 Test: browser_test --gtest_filter=Diagnostics* Change-Id: I3787e7a67259ebafadd78a42957de36aa5ce7186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606192 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#842169}
-
dpapad authored
The API was previously callback-based, instead of Promise-based. Callback-based APIs are more tedious to use. As a concrete example, the PDFExtensionJSTest.ParamsParser tests were incorrectly not waiting for any of the callbacks to execute before declaring the test successful. In the process also - Changed Navigator#navigate() to return a Promise, instead of firing a 'navigate-for-testing' event. - Fixed incorrect type annotation for OpenPdfParams#viewPosition. Bug: None Change-Id: Ib14b6499d3c661bb62c21c1836324ceecf1494ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618219 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#842168}
-
Clark DuVall authored
I noticed most of the exceptions when loading the vr module have logs from SplitCompatAppComponentFactory, which means the chrome ClassLoader is messed up in the ClassLoader cache. When the vr module is loaded, it uses the wrong chrome ClassLoader as the vr ClassLoader parent, which ends up causing a ClassCastException. This CL detects that case and creates a fresh ClassLoader with the correct parent. I tested this locally by faking the situation where the chrome ClassLoader is incorrect, and this loads the vr module and other DFMs which depend on chrome (e.g. image_editor) without crashing. Bug: 1146745 Change-Id: I5960fa2817604a13b90d80b10517b3b416c46013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620939Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#842167}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610365490-2d34930da692ba60039f1162f9ee976fe2d1462a.profdata to chrome-linux-master-1610387594-52fbb832db018eba5e89364d93d0a6bfe8f2e511.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1a55de7957ffd03a68a353cf51670b55597ace87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622792Reviewed-by:
-
Elaine Chien authored
Developers will specify whether their features have beta approval. ChromeBeta will only showcase features on the Beta channel if they have Beta approval Note: We are renaming ChromeLabs to ChromeBeta Bug: 1145666 Change-Id: Iee576ecf0a52d075559b605cfecae5733d539425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613557 Commit-Queue: Elaine Chien <elainechien@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
David Tseng authored
R=akihiroota@chromium.org Bug: none Test: existing editing tests for word feedback. Added new unit-test-like suite for intent_handler character and line speech. Change-Id: If32425cd35ea6504841fef8c7d3eb6245b609c3e AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618558 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#842164}
-
Regan Hsu authored
Using the gn args in the reported failing build link and repeating the test 100 times results in no errors. Fixed: 1121139 Change-Id: Idce10ed5f31d60fcc3ecacf6dd49a2c6a624321b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614850Reviewed-by:
-
Karandeep Bhatia authored
This manifest key was never completely implemented and there are no plans to do so as well. Remove the key and associated code. TODO: Also remove this key from https://developer.chrome.com/docs/extensions/mv2/manifest/. BUG=135628, 1164954 Change-Id: Ia6b11e04f68ca80ea4c91fe1d7a67266f14743b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621972Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#842162}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2779617a..271bd524 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id563e934501fe9b95c0f6d62f0014363e0c89fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622573Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842161}
-
Peter Kasting authored
Bug: 1159562 Change-Id: Iab73f6f6cdacb1bf8cddd69c17e6117511d3acc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618980 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#842160}
-
Alexander Timin authored
EQT calculation was removed and this perftest is a dead code now. R=shaseley@chromium.org Change-Id: I243c0785f2befea9eee399f1264270b7628071d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542162 Auto-Submit: Alexander Timin <altimin@chromium.org> Reviewed-by:
-
