- 21 Nov, 2019 40 commits
-
-
Dana Fried authored
Follow-up work after causing view visibility to invalidate layouts. There were two issues: - Some layout managers were not using SetViewVisibility() which is designed to be safe to the new logic and prevents loops. - A view's visibility being re-set to the same value by non-layout code as a result of something that happens during layout, causing another layout an an infinite layout loop. This CL fixes both of the issues. Bug: 1025196 Change-Id: Ib378c28381802d29128cc99653e94fd1f3186d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926945 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#717538}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/98ba76af00d4..4d15609d269e git log 98ba76af00d4..4d15609d269e --date=short --no-merges --format='%ad %ae %s' 2019-11-21 enga@chromium.org Add a toggle to disable Dawn validation Created with: gclient setdep -r src/third_party/dawn@4d15609d269e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I1644892cb39bd7af5282e10dbe5d13624b41fe16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928217Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717537}
-
Etienne Bergeron authored
This CL is changing the way |layout_text_| is computed. The layout text was recomputed at each text modification. This can cause lot of string copy with a sequence of text append. Example: RenderText render_text; render_text->Append("a"); render_text->Append("b"); render_text->Append("c"); Previously, each call to Append(...) was triggering OnTextAttributeChanged(...) and was causing a whole string copy/rewrite from |text_| to |layout_text_|. The current CL is adding a flag to mark the |layout_text_| as dirty and the layout text is computed on-demand. Bug: 1025561 Change-Id: I185a55cf57d11982c6f80701c904e28886e00c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925950 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:Robert Liao <robliao@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d502e6ae28d..f2843e0643c5 Created with: gclient setdep -r src-internal@f2843e0643c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iaebcf00a776554340fcd647f124a1d1b9995b62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928218Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717535}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=phoglund@chromium.org Bug: 1023677 Change-Id: Ib80453fc3e597cda035157207057512dd6e49128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926878 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#717534}
-
Etienne Bergeron authored
This CL is changing the StyleIterator class. 1) Avoid breaklists copy It is no longer copying the BreakList. Instead, pointers to the original breaklist is kept. 2) Avoid vector scanning The call to UpdatePosition(...) is calling GetBreak(...) which is doing a scan on the vector to find the appropriate position. This scan is overkill since the StyleIterator is moving forward and the break iterator too. This CL replace UpdatePosition(...) by IncrementToPosition(...) which is moving forward break iterator to the right position. Bug: 1025561 Change-Id: I9beac512498af6da991dfba05f66d46b62304b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924618 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
-
Maggie Chen authored
LoadLibrary() may take long time to fininsh. When the system hard drive is busy, prolonged LoadLibrary triggers the GPU watchdog and the GPU process is killed for a restart. This actually doesn't help anything in a busy system. To prevent this, the GPU watchdog is paused in this situation and resumed later. Bug: 988344 Change-Id: I8baec05f0dccfe68941f542ab9dbbb05ea8d4193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927296Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#717532}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4e0255508749..2b3b17304bf8 git log 4e0255508749..2b3b17304bf8 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 7e11f46ddf8e..f2c9ce1e08ed (9 commits) Created with: gclient setdep -r src/third_party/skia@2b3b17304bf8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Bug: chromium:None Change-Id: I191f66988e1c591543581a35f5ab6457a41bb518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928165Reviewed-by:
-
Alex Danilo authored
CL:1928456 changed the functionality for screen readers for summary panels. Add test to check the correct role attribute setting is made. Bug: 1026501 Tests: browser_test --gtest_filter="*FilesDisplayPanel" Change-Id: I25012e8230f026d32b580a4a84b8c8f21f90d0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928102Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#717530}
-
Joel Hockey authored
GetTerminalId will return the old terminal ID, or the new Terminal System App ID if the feature is on. Bug: 1019021 Change-Id: Iee4f3853c746bbe79ad32a05870712418e4c400d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924177 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#717529}
-
nancy authored
Update the pause dialog shown condition: 1. If the app is not running, don't show the pause dialog. 2. Family Link v1 supports Web Apps only. If the Web Apps is opened with browser tabs, don't show the pause dialog. Otherwise, e.g. ARC apps, or Web Apps opened with window, show the pause dialog. The interface ExtensionApps::ShowPauseAppDialog is set as a static, so that Family Link can use that to check whether the app is opened with browser or window. For the Family Link phase 2, the final goal is we support all types of apps, and we should show the pause dialog for all the running apps. Add the interface 'GetWindows' in InstanceRegistry to dump the windows for the app id. It will be used by other functions as well, e.g. close windows when the app is uninstalled, or update windows, when the app is updated. BUG=1011235 Change-Id: I8ec454262d87c5a4350c244fcb9fb67a8b204f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916531 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#717528}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia74b8819d71f5ea0b986d46ada4d4e8fddba7699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928167Reviewed-by:
-
Andreas Haas authored
This CL merges IntegralTypedArrayBase and TypedArrayBase and renames the resulting class to TypedArray. There is no more sub-classing happening anymore, so it makes no sense to have the base classes. Additionally, we now use IntegralTypedArrayBase also for Float32Array. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I4661ff7be878ce0d7d40779ca33f8b70588baf86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926506Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#717526}
-
Hitoshi Yoshida authored
Generates basic code for FillV8Members in dictionary. Bug: 839389 Change-Id: Id6417a438b8fbb93bb9c2c2b062cb197d6862e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906686 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#717525}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=tapted@chromium.org Bug: 1023677 Change-Id: I26538a987de28cd20099f4e7a9a4cfbfbb6ccfdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926882 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#717524}
-
Andreas Haas authored
I removed all uses of ArrayBufferContents that assumed that the start of backing store is always not nullptr. Now we can also remove this invariant altogether. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I479e502a986b4eb9ee3c6d56c7a99b6c677007bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904067 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Samuel Huang authored
Previously update_resource_ids leave a bit of extra space by imposing ID alignment. For tools/gritsettings/resource_ids, the fit is tighter before, leading to more efficient use. Unfortunately, this is also less robust, and is prone to "mid-air collisions", where two CLs that add resources to the same GRD file may not require to update resource_ids, but when both committed, would lead to compile error! This CL alleviates the above problem by activating update_resource_ids' feature to explicitly reserve extra IDs. Now each tag will reserve an extra max(15% * usage, 3) extra IDs. Also update tools/gritsettings/resource_ids. TBR: agrieve@chromium.org Bug: 979886 Change-Id: I06c82fb8dcc08ada97b70881335898afb4a0f7de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928038Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Auto-Submit: Samuel Huang <huangs@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#717522}
-
Jon Mann authored
This is a reland of 137e8082 Originally reverted as it was part of a broken build, but the culprit turned out to be crrev.com/c/1900520. Original change's description: > Remove global CrOncStrings. > > This was used to access translated strings from networking > components inside cr_elements/, now that they have moved to > cr_components/ this workaround is no longer needed. > > Fixed: 990121 > Change-Id: Ie62c0fb5bd5e5cce7f3d916e975f41701b4b2aa5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923608 > Commit-Queue: Jon Mann <jonmann@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717477} TBR=jonmann,stevenjb,khorimoto Change-Id: Ic983ce816c5b9db646db855d967765591057bec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928101Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium a156be32. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." 88c90ec1 "MediaCapabilities: Update EME robustness interface" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4a7b977a8c67f70f0c7913689761f5e838248692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928392Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717520}
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for blink::mojom::Portal with using SelfOwnedAssociatedReceiver instead of StrongAssociatedBinding. Bug: 955171 Change-Id: If54a71a0ad1b067b5bf7f83a23a7a95aea77ba01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926013 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#717519}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2b5d61e4c5f5..4d502e6ae28d Created with: gclient setdep -r src-internal@4d502e6ae28d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ic4e4d289be1c38f226f27a299e2307f37cb9cc7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928164Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=aboxhall@chromium.org Bug: 1023677 Change-Id: I21d0ca80a78cdfd9f5122e6cb8e085a80422feb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925742 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#717517}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5530b3ff7822..b8e748be6b94 git log 5530b3ff7822..b8e748be6b94 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 b.schade@samsung.com Vulkan: Add an end2end test to log GLES capabilities Created with: gclient setdep -r src/third_party/angle@b8e748be6b94 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=courtneygo@google.com Bug: None Change-Id: I4176fa7353d4e3757b70cc7a151f9fd8ab0748bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928157Reviewed-by:
-
Lijin Shen authored
This CL refactors ListMenuButton to adapter MVC styles. Bug: 994362 Change-Id: Idf2d9e322767dbee16927be6b3cfbe8ffb2d156b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829245 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#717515}
-
Koji Ishii authored
This patch changes floating objects to be stored in the fragment tree, instead of the fragment item list. |NGBlockLayoutAlgorithm| handles leading floats even when children are inline. This makes two different ways to handle floats; in the fragment tree and in the fragment item list. Because inline traversals do not need floats, there are no benefits to store floats in the fragment item list. Adds 6 failures but fixes 340. Bug: 982194 Change-Id: I664a4e88d49e3d958f9838151e7cd3d66008a3e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903122 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#717514}
-
Chris Hall authored
'Accessibilty' -> 'Accessibility'. R=jzw,michaeldo Change-Id: I86bc111bde433933e60a0ff5a288faebe65d6089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918798Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#717513}
-
chrome://managementJames Cook authored
The chrome://management page is styled to look like browser settings and has a "back" arrow that takes the user to the browser about page. When we split OS settings into its own surface we and the enterprise team decided to leave the management page as part of the browser UI (for example, it has information about enterprise installed browser extensions). Existing links to management open it in a tab. However, we missed one entry point. Enterprise managed devices show a "Managed" string and icon in the system tray. Fix that entry point to open the management page in a tab as well. I suspect this is causing the management page to be blank in some scenarios (the subject of the bug), though I cannot repro it. Bug: 1026892 Test: added to browser_tests Change-Id: I937fb4a8ce03a619130de3cca51e578e97ddecaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928212 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
Kansho Nishida authored
As same as Build.DEVICE, Build.BOARD and Build.CPU_ABI, fingerprint should be got by Build.FINGERPRINT. BUG=b:141900347 TEST=run arc.AppCrash in the situation below modified Android, modified Chrome not modified Android, modified Chrome modified Android, not modified Chrome Signed-off-by:Kansho Nishida <kansho@chromium.org> Change-Id: Ic6b945be36c924001100f652ea227a2bd08ed7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833036Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#717511}
-
Hiroki Nakagawa authored
is_parent_frame_secure() is a public simple getter. The getter is called only from ServiceWorkerProviderHost, so it is not necessary. Bug: 931087 Change-Id: I5ad034634db977f57caddf22fbe08e85e8dc858f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928514 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#717510}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/65ccdcb8da70..604d935d2770 git log 65ccdcb8da70..604d935d2770 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 vapier@chromium.org signer_payloads_client: rework bytes/strings handling Created with: gclient setdep -r src/third_party/chromite@604d935d2770 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: If6cd694f75da5a03ca808d9abc7fafbeb9337299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928113Reviewed-by:
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL adds ServiceWorkerContainerHost::type() and client_type() that are equivalent to ServiceWorkerProviderHost::provider_type() and client_type(). This is useful for moving functions in ServiceWorkerProviderHost to ServiceWorkerContainerHost in subsequent CLs. In the final state, ServiceWorkerProviderHost will be renamed to ServiceWorkerHost, and its provider_type() and client_type() will be removed. This is because ServiceWorkerHost will work only for a service worker execution context, and those types will be meaningless. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I7ec982ca6cf39519411d897fa78c942a1c37f7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928452 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Add aria-hidden to xf-display-panel element so it doesn't grab the focus when it doesn't have any content. Remove |hidden_| attribute which was defined and never used. Test: browser_tests --gtest_filter="FileManagerJsTest.FilesDisplayPanel" Bug: 1026535 Change-Id: I4c2a74c7ffe3865a299df3d427bb3fcb806d975f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926089Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#717507}
-
Tim Song authored
This CL should now make the collapse/expand feature functional during in-app tablet mode. To make the calculation clean, this CL also refactors the tray buttons, treating them as a vector rather than individual member variables. TEST=manual + unit tests BUG=982511 Change-Id: Icfb0aadc2d4089cb6f77e1cb64fb412f625b3776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923502 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#717506}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/988a272841b9..bb9ade82457a git log 988a272841b9..bb9ade82457a --date=short --no-merges --format='%ad %ae %s' 2019-11-21 dberris@chromium.org Implement a Job Serializer Evaluator Created with: gclient setdep -r src/third_party/catapult@bb9ade82457a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:988912 Change-Id: I6c128365e25e7415b245197d618b748b6a026661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928112Reviewed-by:
-
Connor Clark authored
Bug: 772558 Change-Id: If545da902c199f4162698052cd57a26795337071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928088 Commit-Queue: Connor Clark <cjamcl@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#717504}
-
Alex Danilo authored
Adding role='alert' on the summary panel item type has the side effect of the screen reader repeatedly reading the panel message for each progress update which is excessive. Removes the role='alert' for summary panels only and moves the role='alert' setting to the text on other panel types so that the screen reader reads just the text on the panel for an alert. Bug: 1026501 Tests: browser_test --gtest_filter="*FilesDisplayPanel" Change-Id: Idd7e50690a7e8f36236933f5314d73e016190a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928456Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#717503}
-
Matt Mueller authored
Change-Id: I00c4eec7db9823146a6c776e95c9b7d10d2d5b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915192 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#717502}
-
Eric Lawrence authored
The registerProtocolHandler() and unregisterProtocolHandler() functions should only be permitted for secure contexts. When called on non-secure contexts, a SecurityError should be thrown. Bug: 882284 Change-Id: Iacf3d31f80f5118e9e9aacad2c99a0111d6e7cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892213Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#717501}
-
Alexander Timin authored
Ensure that we always pass the main document to CanStoreDocument as CanStoreDocument always returns false for non-main documents, which then will lead to eviction even when we still can store the document in the cache. R=arthursonzogni@chromium.org,hajimehoshi@chromium.org Change-Id: I021ef8fa0505c9d8eef0d423cde319439f4c612e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905688 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#717500}
-
Darren Shen authored
Was failing just on Mac, but now fails on all bots: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUgsSBUZsYWtlIkdjaHJvbWl1bUBicm93c2VyX3Rlc3RzQENocm9tZU5ldHdvcmtTZXJ2aWNlQnJvd3NlclRlc3QuRW5jcnlwdGVkQ29va2llcww TBR=wfh Bug: 1019655 Change-Id: I0d2025b90d10ac38c28a5f3070adb42cc0a5ae1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928511 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
-
