- 21 Oct, 2020 12 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ce89c83f8ea..fbc6250f7a85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1117577,chromium:1139953 Tbr: reillyg@google.com Change-Id: I59583bfcfe08678ba1ef5a4abf657c6436da7d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488589Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819177}
-
Dominic Farolino authored
This CL removes the content.mojom.RouteProvider and blink.mojom.AssociatedInterfaceProvider implementations from RenderThreadImpl and RenderProcessHostImpl. As a result, we make AgentSchedulingGroup and AgentSchedulingGroupHost fully-fledged RouteProviders and AssociatedInterfaceProviders. Consequently, we: (1) Remove the RenderThread public API addition done in crrev.com/c/2433793, since AgentSchedulingGroup is now wholly responsible for providing a remote mojom::RouteProvider*, and no longer delegates to RenderThreadImpl. (2) Introduce MockAgentSchedulingGroup alongside AgentSchedulingGroupHost to be used in unit tests. This provides a mock for GetRemoteRouteProvider() so we don't have to have a test-only path when RenderThreadImpl::current() == false alongside production code (3) Introduce temporary {RenderProcessHostImpl,ChildThreadimpl}::GetListener() methods for AgentSchedulingGroup and its host to use, to get IPC::Listeners from the routing ID map. This is important for the implementation of AssociatedInterfaceProvider, however it is temporary, and these methods will be removed when the legacy IPC functionality is fully transferred to ASG(H), and these objects have their own IPC::Listener* map. One subtle change that this CL makes is the way that the RouteProvider interface is bound between the RenderProcessHostImpl: Before this CL, the Renderer => Browser RouteProvider was bound lazily, whenever RenderThreadImpl::GetRemoteRouteProvider() was called for the first time. After this CL, the Renderer => Browser RouteProvider is bound at the exact same time as the Renderer => Browser interface. This is done in AgentSchedulingGroupHost::SetUpMojoIfNeeded(), where we call mojom::AgentSchedulingGroup::BindAssociatedRouteProvider(). We pass both a remote pointing to AgentSchedulingGroupHost, and a receiver that AgentSchedulingGroup will bind. Once bound, bi-directional communication is immediately available. One upside to this is that the bind lifetimes of the browser-side remote and receiver pair are 100% consistent. ---- This change is fully described in: https://docs.google.com/document/d/12jyv-8aBwMlSS_Y5roEl_ykZT0_eQszGiiNs7Hxktmk/edit#heading=h.3dn0j414iw3j R=haraken@chromium.org, kinuko@chromium.org, kouhei@chromium.org, talp@chromium.org Bug: 1132901 Change-Id: I819289c4d8d254229d5ad639ec8eb5fbe96d7381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438232 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:Alexander Timin <altimin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#819176}
-
Joel Hockey authored
We currently use the suffix for filesapp open-with, but we also want to have it for the app name displayed in the external protocol dialog, and in any other place where the app name is displayed. Bug: 1140284 Change-Id: Id2df3924c2e7cb7c870e42ec7e4c3ee3892e64cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486521 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#819175}
-
Nate Chapin authored
Change-Id: I212fd68b99ac07343dafc2ae65ca2a6e24b6ccac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487697 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Melissa Zhang authored
Bug: 1136338 Change-Id: I08eba6ee8137088f9a06f02f95ead0c28ce82314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485372Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819173}
-
Darren Shen authored
Add Mojo and protobuf messages for Chrome to send key events to the IME service. Key event handling is a bit special because it requires a callback (whether the key event was consumed by the IME or not). Before, messages were sent from DecoderEngine and received in ClientDelegate, so sending & receiving were independent of each other. However, for key events, we need to track key events and their callbacks, so sending & receiving must go through the same code at some point. Therefore, make ClientDelegate forward messages to DecoderEngine so that DecoderEngine can track pending key events and call the right callback when needed. Change-Id: Ia3a2d976cc79f24a96d6ec390732dc64833afaff Bug: b/161490915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422925 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#819172}
-
Peter Kasting authored
This ends up fixing classes in chromeos/ui/frame/caption_buttons/ as a necessary piece of this work. Bug: 772945 Change-Id: Ifaea958076c28ec956edd207160242cf5e49cdc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488766Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#819171}
-
Scott Violet authored
This does the following: If overflow-clip-margin changes, then need to repaint OverflowClipRect() and VisualOverflowRect() adjust for overflow-clip-margin (overflow-clip-margin is only set if overflow:clip is set along both axis). BUG=1087667 TEST=wpt/css/css-overflow/overflow-clip-margin-invalidation wpt/css/css-overflow/overflow-clip-margin-001.html Change-Id: I9875c724c153600bf8eafe633bc138d99de3099a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468794Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#819170}
-
Matt Menke authored
Pass in NIK to RemoveClient() call from ReportingHeaderParser::ParseHeader() Bug: 993805 Change-Id: Ic58d9ecbba5c5d3dbba9180f13882e23aac40818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485391Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#819169}
-
Alex Turner authored
Many users of FrameMatchingPredicate pass in a predicate constructed with base::Bind. That method is deprecated and should be replaced with the more explicit base::BindRepeating. This resolves all remaining users of base::Bind/base::Callback in chrome/browser/subresource_filter/, so it is removed from the legacy exception list. Bug: 1140547 Change-Id: I3e028360992a853b2b2a5ef7b4d08aeb9809dfbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487620Reviewed-by:
-
Thomas Lukaszewicz authored
This flag enables tab search on all Chrome desktop platforms. It also removes the deprecated kTabSearchFixedEntrypoint flag. Bug: 1099917 Change-Id: I9b695d399fdf7db8e3ae6c6f2c53be001b4f6248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486991Reviewed-by:
-
Chong Gu authored
Some devices take up to 2 minutes for netstack to come up, use BOOT_DISCOVERY_TIMEOUT_SECS to determine timeout time for device-finder. Add -timeout flag for finding devices via resolve as well Bug: 1080853 Change-Id: Ieb56c6ef909721e746b83cd4c915ddc5a723c309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487832Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#819166}
-
- 20 Oct, 2020 28 commits
-
-
Mila Green authored
Bug: 1140270 Change-Id: I4baacdb26df224630ace30810510a9eb312e8d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487693 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819165}
-
Clark DuVall authored
There were three separate issues which were preventing the VR native code from working correctly: - Isolated split class loaders can't load native libraries (b/171269960) - Shared libs for modules were not being added to the module descriptor - The GVR native methods need to be manually registered now that GVR code is not in the base module. Bug: 1126301 Change-Id: I184ea61fe4ef97a598ecf47b6e3cd81f4425ec1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486571 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#819164}
-
Wenyu Fu authored
Change FirstFragmentInflated with V2 suffix; record the time between FreIntentCreated and first fragment inflated, align with other MobileFre.FromLaunch*. Bug: 1138660 Change-Id: Ie02b0f7681b50b81f50efeb71d8349719f8b4cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472711 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819163}
-
Erik Språng authored
Bug: webrtc:11551, b/163310303 Change-Id: I5eb5f59f9c68315305c1bdb380bb7d3d192a02c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487340 Auto-Submit: Erik Språng <sprang@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Andre Le authored
- Add an observer for state change in Silence Phone so that Locate Phone can be disable when Silence Phone is on. - Refactor InitQuickActionsItems() since Locate Phone and Silence Phone is no longer independent. BUG=1106937,1126208 Change-Id: I6f015e868d6d00df6a40447de62f3efd0b2f2ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480662Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/82f373c0d713..2d2f82c00aeb 2020-10-20 brianosman@google.com Always declare sk_FragColor in GLSL, even if unused 2020-10-20 ethannicholas@google.com added SkSLNodeArrayWrapper 2020-10-20 reed@google.com update dox for drawPaint 2020-10-20 johnstiles@google.com Wrap built-in symbol tables during inlining. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I29b88419a03de489725889c724b0aa4bec7809db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487912Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819160}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5c5a7978..a08f3d9f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id27a730ec9aefd211354b6817ef012c4e94ddbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488367Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819159}
-
yilkal authored
The description and mock can be seen in the comments in the bug report. Bug: 1134567 Change-Id: I2ecd7c72629dc96dfbc054f747c6cb2508210709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466618 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#819158}
-
Xida Chen authored
There is a test that is already removed, the code for disabling the test is still there. This CL removes the code that disabling the test. Bug: 728034 Change-Id: I47a6c3e98e8fee64ad776e4ff2c230d0f2733a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488121Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
-
Nate Chapin authored
Change-Id: I906080d37902a87ebbe22c52503972928c10e7aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481786 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Sorin Jianu authored
The current limit is too low and the component build fails parsing the file when the updater is invoked with --install --install-from-out-dir Bug: 1140730 Change-Id: I297d1e1ddf1435faa9304a7084c84a7170227b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488714Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819155}
-
Giovanni Panaro authored
Bug: 1114103 Change-Id: I9fdb97d06cadc5dde6672e9df7e2baca35ab0b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450711 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#819154}
-
Yulun Wu authored
Fix bug where login shelf buttons background color constant and darken wallpaper background color constant were combined incorrectly. Bug: 1137798 Change-Id: Ib0584a990bcb40c4886ede2e402d2f8864705597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487831Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819153}
-
Jonathan Ross authored
Currently we are hitting shard timeouts for angle_perftests on the Android FYI 64 Perf (Pixel 2) bot. Even when we pass it's barely under the 20 minute shard time. This adds a 4th shard for just that configuration. TEST=angle_perftests Bug: 1140626 Change-Id: Ib87d323a28e7c7703bc1af77246a89f2d8087413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488044Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#819152}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/df17a76102df..ee18f390eead 2020-10-20 bclayton@google.com LLVM: Replace legacy ORC JIT with new API If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If6693aaec84dcf0a25b89661998ba517639fa4d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488583Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c55cd6b43d55..637786a9a862 2020-10-20 cnorthrop@google.com Tests: Add Arena of Valor trace 2020-10-20 geofflang@google.com Generate CONTEXT_LOST errors on every GL call. 2020-10-20 geofflang@google.com Add Queries and Setters for resource initialization state. 2020-10-20 courtneygo@google.com Vulkan: functionally complete worker thread 2020-10-20 jmadill@chromium.org Fix missing validation cache update on VAO binding. 2020-10-20 jmadill@chromium.org Suppress timing out GLES 31 tests on GL/Linux. 2020-10-20 syoussefi@chromium.org Vulkan: Pull generic SPIR-V transform functionality into base class If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1132514,chromium:1137241,chromium:1139398 Tbr: jonahr@google.com Test: Test: angle_perftest --gtest_filter="*arena*" Change-Id: I5c86409d0607b087df8fc86d0e6f5c4386b6d4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488022Reviewed-by:
-
phillis authored
InstallOsHooks after InstallWebAppFromInfo is finished for apps that are drag installed from chrome://apps page. Bug: 1138816 Change-Id: Icdd3ee98bd93da20e73633ad602645896535f6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485048Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#819149}
-
Dave Tapuska authored
Checking that the fullscreen element is non-null implicitly means that fullscreen has already been granted. Verified via: out/Release/chrome --register-pepper-plugins="out/Release/libppapi_example_mouse_lock.so;application/x-ppapi-example-mouse-lock" BUG=1097816 Change-Id: I125da5db68346f5cc90279110ce676c70cf27c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488124 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#819148}
-
ckitagawa authored
This CL attempts to fix a crash that was happening when attempting to use a render frame host that might have been deleted or was in the process of being deleted. Bug: 1140163 Change-Id: I9abeaad7c84fa0409c5c152e69610da1db4b44c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485585 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#819147}
-
Yue Ru Sun authored
Bug: 873866 Change-Id: I36b283ee1f2b7dbe878834c2083a1383fda6ddca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471799Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#819146}
-
Vitaly Buka authored
This experimental build option to mark binaries as compatible with Shadow Stack of Control-flow Enforcement Technology (CET). THe option is not any close to enable in official builds, it's here for convenice of evaluation. As it passes base_unittests and components_unittests. Bug: 1136224 Change-Id: I6fcd61c2e76066b444cc37c88228273838300243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454988Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#819145}
-
Ian Struiksma authored
This causes no change in generated json, but allows the migration to newer win10 version to be more straightforward. Bug: 1124829 Change-Id: I483eedee77cb247d81fd32ec874675f53c26b18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488679 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#819144}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/299fe92af960..e03bf7b4af92 2020-10-20 thestig@chromium.org Prevent undefined behavior in CFX_DIBBase::GetOverlapRect(). 2020-10-20 tsepez@chromium.org Make core/fxge/{fx_dib.h,dib/fx_dib_main.cpp} consistently named. 2020-10-20 tsepez@chromium.org Move some FXDIB_Format functions from .h to .cpp file 2020-10-20 tsepez@chromium.org Make FXDIB_format an enum class. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1097499 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I3388f2c572925d3853eb8b3cf8c6e09c8df3c3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487811Reviewed-by:
-
Michael Irani authored
If you navigate to "Manage what you sync" page and then back, the arrow pointing back to "Manage what you sync" is not highlighted when in ChromeVox mode Steps: 1. People 2. Sync and Google Services 3. Manage what you sync 4. Back button Bug: 1029954 Test: Manual Change-Id: I92fc08efdb1f2ea5f1e06232e08df23ab6f03910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488603 Auto-Submit: Michael Irani <michaelirani@chromium.org> Reviewed-by:
-
Katie Dillon authored
[scheduling] Don't pass a queue to record task time on budget pools for find in page and compositor experiments. The cpu time budget pool doesn't use the queue that it is passed when it records task run time, so we will pass nullptr in those spots instead. This will allow us to avoid passing a raw pointer to a TaskQueue in a spot we don't need it as a pre-requisite to this CL: crrev.com/c/2453591. Change-Id: Ifc7de7e94e667c1de1d4bc4de30203becc03fafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485346Reviewed-by:
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I8bcde93c568033282759908ec3e9c212d5ce756b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469464 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#819140}
-
Gang Wu authored
This reverts commit 65967617. Reason for revert: compile failed on https://ci.chromium.org/p/chrome/builders/ci/chromium-internal-arm-builder-rel/5946 Original change's description: > Chime: Add an initialize method. > > Chime needs to be initialized during ChromeApplication.java's startup > code. > > This CL adds ChimeSession.initialize() entry point API, and a upstream > placeholder function for Chime DFM. > > Also clean up the feature flag JNI call for Chime, now it can directly > depends on chrome/browser/flags:java. > > Bug: 1136305 > Change-Id: Id8424fc22d2f419860318b12bd8753da448cd50b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466897 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818755} TBR=dtrainor@chromium.org,qinmin@chromium.org,xingliu@chromium.org Change-Id: I2936cf940241987cc92c12af396658cafc953ace No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1136305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487816Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819139}
-
Victor Costan authored
Bug: 1140635 Change-Id: Idfc0091f79e3efccd3a22de879db698b9bf2bc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487837 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#819138}
-
