- 27 Jan, 2020 40 commits
-
-
Yuly Novikov authored
This reverts commit 97c38202. Reason for revert: miscompiles seen in crbug.com/1045948 Original change's description: > Add UWP support to Windows toolchain. > > Slight update to MSVC - VS version from 16.3.1 to 16.4.3 as a side effect. > Other components kept at the old versions: > Windows SDK 10.0.18362 > Debuggers 10.0.17763 > d3dcompiler_47.dll 10.0.17134 > > Packaging was done on a Windows Server 2019 VM, cleanly created for this > purpose. > > The package was created by downloading VS Professional 2019 installer > from https://visualstudio.microsoft.com/downloads/ > and then running the installer like this: > > $ PATH_TO_INSTALLER.EXE ^ > --add Microsoft.VisualStudio.Workload.NativeDesktop ^ > --add Microsoft.VisualStudio.Component.VC.ATLMFC ^ > --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^ > --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^ > --includeRecommended --passive > > The 10.0.18362.0 SDK was installed by this as well. > Then Add or Remove Programs was used to modify the 10.0.18362.0 SDK to add > the Debuggers package. > > Then the packaging script was run like this: > > python depot_tools\win_toolchain\package_from_installed.py 2019 -w 10.0.18362.0 > > Since the new d3dcompiler_47.dll uses the UCRT and we want to avoid shipping > that the final packaging step was to unzip the package, copy over the two copies > of that DLL from win_sdk\Redist, replace the Debuggers directory with the > 10.0.17763 SDK, and then repackage the toolchain with: > > python package_from_installed.py --repackage=<full-path-to-toolchain-dir> > > UWP support was previously added to package_from_installed.py > in http://crrev.com/c/2007881 and http://crrev.com/c/2013579 > > Bug: 1032635 > Change-Id: I85313de0529aa7591e5066bc697c640c5dc52463 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015984 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734608} TBR=thakis@chromium.org,ynovikov@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1032635 Change-Id: Ib3caeaab51cbc4c133955585c5ab4ba69ac480de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022357Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#735479}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=treib@chromium.org Bug: 1042208 Change-Id: I3461ae666e4338e945492df669a39f0fbeb445bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017526Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735478}
-
Vladimir Levin authored
This patch removes display locking trace events that were not adding any value. They are instead replaced with two new ones: - A count of total locked display locks. - An async slice for forced locks R=chrishtr@chromium.org, flackr@chromium.org Change-Id: Ic3e075767e53054aeb88f6860226f08162948021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022619Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#735477}
-
Andres Calderon Jaramillo authored
This CL fixes VizProcessContextProvider to ensure that context_result_ is initialized on construction. The GLOutputSurfaceBufferQueue tests are re-enabled: they surfaced this issue and MSAN was failing on Linux. Bug: 1045602 Test: Run GLOutputSurfaceBufferQueue tests locally with MSAN. Change-Id: I0e8c3c210d099d4cabe1d583296ec1280ad79cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021543 Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#735476}
-
Joe Downing authored
TBR: pfeldman@chromium.org Bug: 1045980 Change-Id: Ibf77f8c7fcd6dad68e9e4d53869fadaf87908f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023145Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735475}
-
Piotr Bialecki authored
Fixed: 1040289 Change-Id: I759f6bee1bf641f6ca68ddfd8f59926c7e465441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017642Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#735474}
-
Kevin McNee authored
When we detach a portal contents, we destroy its main frame's child RWHV. If there is an ongoing cross site navigation in the portal's main frame which has created a speculative RenderFrameHost, then the speculative RFH's child RWHV is not destroyed. When the navigation commits, the speculative RFH is set. Now the top level RFH has a child RWHV, which leads to bad casts and a crash. We now destroy any speculative RFH's RWHV. Bug: 942194 Change-Id: Icbb2fa2e691c16f28aa37d305f495ce52a0f8880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018183 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#735473}
-
Tommy Li authored
This function has a truly weird contract that I didn't completely understand initially, so I caused a regression. Regression here: https://chromium-review.googlesource.com/c/chromium/src/+/1955787 The weird contract is - it recalculates the match's classifications, except in the case where we pass in a flag to forbid bold-all, and the reclassification would otherwise bold-all. Then the function is supposed to leave the existing classifications alone. It's weird, but it's necessary for flicker-free search queries as the user types with punctuation. This CL fixes it. It also adds some tests to prevent future regressions, as well as to explicitly document the edge case. I'll make a followup CL to do the same fix and test for NavigationResult separately. Bug: 1043440 Change-Id: Ieb4a9b6fd901eff9df553ce846c53e4ae11c0455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021316Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#735472}
-
Josh Nohle authored
Bug: 951969, 936273 Change-Id: I87faaf33217d1d6bccc77710deceb71384babe58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987083 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#735471}
-
Xiaohui Chen authored
This is a reland of c0e15aa2 Original change's description: > assistant: add shelf layout unit tests > > * Add a couple shelf layout tests to make sure when Assistant > is invoked in tablet mode with/without apps, the hotseat state > won't change. > > Bug: None > Test: unit tests > Change-Id: I7103fe9489f780cd441942801aa4d03b71825dbe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013752 > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734728} Bug: None Change-Id: I6b45dfe52c810805426bef07ed182354298958e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020526Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#735470}
-
Rob Buis authored
The mspace should inherit the content width of the parent when determining the initial fragment geometry, so make it shrink to fit. Bug: 6606 Change-Id: I403852521af8f360a08b958253815c35fae01fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022767Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#735469}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/82608c5b..b8d07951 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idbecdd997e4201a85da0be63e1733440568aef6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021345Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735468}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a3114e177561..c9cbb2b2c66b Created with: gclient setdep -r src-internal@c9cbb2b2c66b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022512 Tbr: jbudorick@google.com Change-Id: Id0d1a26a49f9cebf6ece9ed6dc2082ed16c8fec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022972Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735467}
-
Allen Bauer authored
This is a rework of 9204d725. Rather than remove GetThemeProviderForProfile(), it is renamed to GetFrameThemeProvider(). The comments are also updated to better clarify why it's done this way. It should also be noted that GetFrameThemeProvider() is called from various GetFrameXXX methods. Original change's description: > Remove BrowserNonClientView::GetThemeProviderForProfile and just use GetThemeProvider. > > Change-Id: I9c458a7fe05c2ed60c1f9498dd0cea3cc3237455 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019923 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735051} Change-Id: I08c1875bebb4791d69fe7d86ae08efd0fbfa87bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020892 Auto-Submit: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#735466}
-
Robert Ogden authored
This test is flaky, disabling now and will fix later. Bug: 1045971 Change-Id: I2a06ce65f3b1b1a97735e6b7e29878cdef8fca4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022360 Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#735465}
-
vitaliii authored
I.e. take it as bytes instead of actual proto. Bug: 1045883 Change-Id: Id1ebc09799d69d833c49cd5dd0f36bc2ecc2ea1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020946 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#735464}
-
Sajjad Mirza authored
The standard Windows tryjob builder uses an SSD but the coverage builder does not. This discrepancy might explain why compilation is much slower on the coverage builder compared to the standard builder. The expected impact of requesting SSD bots for this tryjob is low because it only runs on 3% of CLs, and if this does explain the performance difference this tryjob will be merged into the standard job and deleted. Bug: 1041689 Change-Id: I1303cccbbfc0d4ecd1d6f36fcfa50fa2699042d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020913 Auto-Submit: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#735463}
-
Armando Miraglia authored
Recently, the spec has changed to guarantee better privacy protection in enumerateDevices()[1]. The spec change prescribes that at most one device per-type should be shown without ID information if the user did not grant permissions. This CL changes the behavior of enumerateDevice as prescribed but keeping it behind a flag to better control the rollout of the change. [1] https://github.com/w3c/mediacapture-main/commit/837ceeff14509ba1e5200c27b9bd190f91f9977c Bug: 1019176 Change-Id: I5a15d15363c50e45d86ddb241eccd9a4bd8698b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964495Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#735462}
-
John Budorick authored
Bug: 1045623 Change-Id: I9bcbc85caa3fe961a5e5b95622600c480065fbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020615Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#735461}
-
David Bokan authored
These tests fail when the BlockHTMLParserOnStyleSheet flag is turned on. The reason is that, with this flag, there is no way to block rendering. Fragment anchors currently defer some behavior while rendering is blocked. When the flag ships, this will no longer be possible. However, the behavior being checked by some of these tests can still occur, just in a different order. This CL fixes these tests so that they continue to guard the intended behavior. This generally means that the fragment will now invoke but we test the behavior between this initial invocation and a subsequent one by delaying the document load event. Bug: 891767 Change-Id: I0564b1f487c48be2f5efbb1c6478e3375a71e518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020503 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#735460}
-
Clark DuVall authored
This also moves ScopedRevocationReporter into PermissionUmaUtil, since it seems to make more sense there and will be a bit more complicated to move to the component. Bug: 1025609 Change-Id: Ic98cabaec50e35a3292e3a4310223cf2cbfaca5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020750 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#735459}
-
Javier Ernesto Flores Robles authored
Test testSignOutAndClearDataFromNonManagedAccountClearsData is being disabled. TBR=jlebel@chromium.com Bug: 1045981 Change-Id: I6682e5f78e2203d73045c3c17cfddaba93dd4c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022653Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#735458}
-
Joshua Pawlicki authored
I've confirmed that the uploads are coming through. Bug: 1024318 Change-Id: I69015590c02cbbe722ab9e91a90574aa76d7f356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022621 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#735457}
-
Toni Barzic authored
Fixes few glitches with switching the drag image widget when rip off drag status changes with scrollable shelf (the drag image is switched between one owned by shelf_view and one owned by the shelf view's drag and drop host): * disables the shelf view's drag image proxy visibility animations (so the icon disappears immediately, instead of fading out while the new drag image keeps moving) * when the icon is dragged back to shelf, and the drag image is replaced with the drag and drop icon, do not update the drag_view_ location - given that HandleRipOffDrag returns false in this case, the drag_view_ bounds will be updated after HandleRipOffDrag (doing it twice misplaces the created drag image, at least until the next drag update is handled). * Make drag image position relative to the cursor consistent between two proxies - scrollable shelf view's proxy keeps the cursor position from the drag start, while shelf view's proxy was centering the cursor. BUG=1042533 Change-Id: If9fa5cea3a8714a22c6b58a75af5cf2fe08efc70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021612 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735456}
-
Jakob Kummerow authored
The original patch moved a CHECK behind an #ifdef NDEBUG in an attempt to ease debugging. According to crbug.com/496653#c73, it was supposed to be reverted, but that never happened. We shouldn't keep shipping a CHECK to users that's disabled in Debug builds, so this revert drops the ifdef again to turn on the CHECK everywhere. Original review: https://codereview.chromium.org/1591543002 Bug: chromium:496653, chromium:1040839 Change-Id: I71a743b6355a0072ed5ae5281f79a2d948da9adb R: mfoltz@chromium.org, avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022791 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735455}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I07fd1dff3c8af9244c867387c4322ddf9370d472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021301Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#735454}
-
Dominique Fauteux-Chapleau authored
Change-Id: I37c2578a6b36e0de25a889bf636e122b7d8987f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022253Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#735453}
-
Nicolás Peña Moreno authored
resource_timing_buffer_full_eventually.html is still flaky. Adding all the flaky combinations in the flake portal after 'fix' landed. TBR=ksakamoto@chromium.org Bug: 989665 Change-Id: I58caec5484fb6dfd5162c50d3819f78f14838f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020895Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#735452}
-
Xianzhu Wang authored
TBR=pdr@chromium.org Bug: 524134 Change-Id: Ic612a760cb4ec7ed951b5026e1e0a81d7966a466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022255Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735451}
-
John Chen authored
Rebaseline of web tests in custom-elements, editing, and fast directories. Bug: 1028242 Change-Id: Idab238ce374bb3fa01bdc0ac8535f74afe090ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022351 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735450}
-
Patrick Noland authored
This reverts commit 6e293feb. Reason for revert: Some of the new tests are flaky Original change's description: > OOR-CORS, WebView: Add CORS tests for requests from custom schemes > > Behaviors have been unclear, but if requests are made from a custom > scheme, the Origin header in outgoing requests should be set to > "<scheme>://" without containing the host:port part those are > officially required to be a proper origin for such special cases > in WebView. > Servers can use "Access-Control-Allow-Origin: *" or > "Access-Control-Allow-Origin: <scheme>://" to permit such accesses. > > This patch adds tests to verify these behaviors to keep compatible > behaviors. > > Bug: 1035366 > Change-Id: Ia08e7b4ed764225566c3b09edef2980cfa1b1b70 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010591 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735332} TBR=toyoshim@chromium.org,torne@chromium.org Change-Id: Ib494a7fc40f6eec0b2c92dd35046b191751931e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1035366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023046Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#735449}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ff0e4dbd1f0b..8c79c6e1af35 git log ff0e4dbd1f0b..8c79c6e1af35 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 srte@webrtc.org Only include overhead if using send side bandwidth estimation. 2020-01-27 hbos@webrtc.org [Overuse] Move GetCpuOveruseOptions() to adaption module. Created with: gclient setdep -r src/third_party/webrtc@8c79c6e1af35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I878d1f84a19f160d4e7125b2cffb6e2b85d2accf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022966Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735448}
-
Leon Scroggins III authored
I am switching everything to my Google account. Change-Id: I68ac60c7243d8520a98c929a636d3ccb32d086f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022254 Commit-Queue: Leon Scroggins <scroggo@chromium.org> Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Mike Klein <mtklein@google.com> Cr-Commit-Position: refs/heads/master@{#735447}
-
Javier Ernesto Flores Robles authored
The following tests are being disabled on iphone-device: BookmarksTestCase/testMoveDoesSaveOnSave BookmarksTestCase/testEmptyBackgroundAndSelectButton BookmarksTestCase/testBookmarkContextBarInMultipleSelectionModes BookmarksTestCase/testBookmarkContextBarInSingleSelectionModes BookmarksTestCase/testKeyboardCommandsNotRegistered_EditBookmark BookmarksEntriesTestCase/testContextMenuForMixedSelection TBR= sczs@chromium.org Bug: 1045966 Change-Id: Idd767cc19e7443825be6f08680813732426770ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020932 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#735446}
-
Avi Drissman authored
Those are needed when compiling against SDKs older than 10.12 or so, but Chromium has compiled against the 10.14 SDK for a while. Bug: 1044838 Change-Id: Id9a70aa1c702b0c1992963c1fbd0a2e26f8e07ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020805 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#735445}
-
Mike Wittman authored
Adds a field to Thread::Options to allow the task queue time domain to be configured, to enable Thread users to test task posting functionality using synthetic time. Bug: 1034758 Change-Id: I9b301f98e856a86045a12bab6e25569d4ef9b330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020480Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#735444}
-
Sylvain Defresne authored
$ git log 34381dd16..e5005ca20 --date=short --no-merges --format='%ad %ae %s' 2020-01-24 featherless Bump the release. 2020-01-24 featherless Notes. 2020-01-16 rsmoore [Chips] Fix `imagePadding` behavior. (#9442) 2020-01-16 rsmoore [Chips] Additional `imagePadding` tests. (#9441) 2020-01-16 rsmoore [Chips] Fix `contentPadding` API. (#9440) 2020-01-16 featherless [AppBar] Annotate MDCAppBarNavigationControllerDelegate's appBarNavigationController:willAddAppBar:asChildOfViewController: as to be deprecated. (#9395) 2020-01-21 featherless Automatic changelog preparation for release. 2020-01-17 featherless Revert "merged release-candidate" 2020-01-17 andrewoverton [TextControls] Restructure Cocoapods and Blaze targets (#9430) 2020-01-16 codyleeweaver [TextFields] Add theming extension for underline controller (#9437) Created with: roll-dep src/ios/third_party/material_components_ios/src Notable fixes: manually updated the list of files to build as part of the framework as some files were added/renamed/removed. Bug: 1045877 Change-Id: I2d4ab61b4ab67161f99baa3907ea3bb499d9867a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022947 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#735443}
-
Tommy Li authored
In this CL, I did a cleanup: https://chromium-review.googlesource.com/c/chromium/src/+/1937773 But the cleanup had a negative side effect, in that repreated presses of Ctrl+E for entering keyword mode would cause the omnibox popup to close and re-open. This CL is a partial revert of the original CL, but keeps the flag deletion portion. It also makes sure a TODO that was wrong is gone. Bug: 1044917 Change-Id: Idceb8c73d4a5907cfca8966bf41f80c09fc130bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020473 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#735442}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c06f226b. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm chcunningham@chromium.org, wolenetz@chromium.org: external/wpt/media-source domenic@chromium.org, ricea@chromium.org: external/wpt/streams futhark@chromium.org, andruud@chromium.org, ericwilligers@chromium.org, shend@chromium.org: external/wpt/css/css-conditional hbos@chromium.org, hta@chromium.org: external/wpt/webrtc jsbell@chromium.org: external/wpt/IndexedDB external/wpt/encoding jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI mcasas@chromium.org: external/wpt/mediacapture-record meade@chromium.org: external/wpt/web-animations mek@chromium.org: external/wpt/webmessaging mkwst@chromium.org: external/wpt/trusted-types mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents raphael.kubo.da.costa@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I829df5abb577665adafb08dbeb61ffda3f40e78f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022325Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735441}
-
Rakesh Soma authored
Bug: 1045536 Change-Id: Idd58ba1153e1e006bc07c54305db39e217e91779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020243 Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#735440}
-