GitLab

Bug: 990399
Change-Id: I5f7727acf55fca3fea3572b2d8a237f43eecb845
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733015Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683783}

We don't want to Send() IPCs on a frozen/provisional RenderWidget. The
DoDeferredClose path in RenderWidget needs to send the IPC from a fresh
call stack, but in the meantime, the RenderWidget may have become
frozen (the main frame may have been swapped out in that RenderWidget's
RenderView).

In that case, we still allow the WidgetHostMsg_Close to go through, and
behave as if the IPC was already in transit to the browser. But since
RenderWidget::Send() should not be used, we use a static method.

This is one step toward allowing us to CHECK() that we don't Send()
IPCs from frozen/provisional RenderWidgets.

R=dcheng@chromium.org

Bug: 419087, 745091
Change-Id: I85f707c3c9bf071f7adf6273d78d40a6f530b10b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733852
Auto-Submit: danakj <danakj@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683782}

Bug: 987905
Change-Id: Id5e8e366cabba5cea56725ff459de0f49c19c4ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728267Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683781}

Bug: 969558
Change-Id: Iebcfcf47a59694b0cac12fb85d06daa7a8735e9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726236Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683780}

A number of HttpServerProperties methods return true if they make a
change that needs to be saved to disk, and false otherwise. These return
values are no longer actually being used, so this CL removes them.

Also rename http_server_props_manager_ to http_server_props_ in
http_server_properties_manager_unittest.h

Bug: 984996
Change-Id: I1cf128d0959507bf1fd93351d5fe076d33b5d99f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732746
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683779}

Change-Id: Ic0b6740fe1b7317d408fd4fc0f7857308194f090
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727398
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683778}

In order to determine what codecs are supported by a specified key
system, the current code attempts to create a decoder for each codec to
determine if it is supported. Improve this by simply querying
MediaCodecList if it is available.

Note that there may be multiple codecs supporting the specified
mime_type, so continue to the next one if the current one doesn't have
FEATURE_SecurePlayback supported as needed.

This reapplies the code removed in commit
fde644c1, along with some additional
changes (check following codecs if this one can't handle it).

Bug: 846120
Test: EncryptedMedia content_browsertests pass
Change-Id: I8a0f79e7a36d203a179c490de3c262add55cffc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729804
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683777}

Bug: 966270
Change-Id: I2e9e0bf0df06e0a4907b7e005de5f87e1d6bb150
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728475Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683776}

https://quiche.googlesource.com/quiche.git/+log/7deaf37e9442..c691071e933e

$ git log 7deaf37e9..c691071e9 --date=short --no-merges --format='%ad %ae %s'
2019-08-02 dschinazi Add missing QUIC_EXPORT_PRIVATE to test client ALPN
2019-08-02 fayang Fix tests to make chromium compile.
2019-08-02 fayang Fix a chromium compile error where local variable shadows member variable.
2019-08-01 dschinazi Support 20byte connection IDs in QUIC v99
2019-08-01 dschinazi Add connection ID length checks
2019-08-01 dschinazi Make QUIC enforce ALPN when using TLS handshake
2019-07-31 bnc Add helper methods to QpackSpdyStreamTest instead of hard-coding QPACK-encoded headers.
2019-07-31 fayang gfe-relnote: Close QUIC connection is there are too many (> 1000) buffered control frames in control frame manager. Protected by gfe2_reloadable_flag_quic_add_upper_limit_of_buffered_control_frames.
2019-07-31 renjietang Add version DCHECK for SPDY frames that are already replaced by HTTP/3 frames in v99.
2019-07-31 dschinazi Deprecate quic_do_not_override_connection_id
2019-07-31 dschinazi Fix a QUIC end_to_end test when some flags are enabled
2019-07-31 bnc Remove Http3FrameLengths.
2019-07-31 bnc Change HeaderBlocksForStream from QuicDeque to std::list.
2019-07-31 fayang gfe-relnote: Let GFE be able to use HTTP2(tree-style) priority write scheduler in QUIC and enable it via a connection option H2PR. Protected by gfe2_reloadable_flag_quic_use_http2_priority_write_scheduler.
2019-07-31 dschinazi Introduce IsConnectionIdLengthValidForVersion
2019-07-31 fayang gfe-relnote: Replace SpdyPriority priority with const spdy::SpdyStreamPrecedence& precedence in GfeQuicServerSession::CreateServerPushStream. No functional change expected. Not protected.
2019-07-31 fayang gfe-relnote: Add a FifoWriteScheduler where the stream with the smallest stream ID will have the highest priority. Not used in prod, not protected.
2019-07-31 fayang Add a const_cast to make chromium build.
2019-07-31 dschinazi Support LengthPrefixedConnectionIds in v99
2019-07-30 bnc Add QpackBlockingManager to track blocked streams and blocking entries.
2019-07-30 fayang Fix comparison of signed to unsigned in htt2_priority_write_scheduler_* and spdy_intrusive_list_test.
2019-07-30 renjietang Remove headers stream from IETF QUIC.
2019-07-30 bnc Refactor incoming SETTINGS logic to QuicSpdySession::OnSetting().
2019-07-30 fkastenholz Wire in the ack exponent trransport config for IETF QUIC
2019-07-29 quiche-dev Create a QuartcMultiplexer which separates streams and datagrams into channels.
2019-07-29 bnc Add QpackHeaderTable::MaxInsertSizeWithoutEvictingGivenEntry().
2019-07-29 renjietang Make OnPushPromiseFrameEnd() return the same value as OnHeadersFrameEnd().
2019-07-29 bnc Clean up HTTP/3 and QPACK settings.
2019-07-29 bnc Internal QUICHE change
2019-07-29 fkastenholz Connect up IETF QUIC Max ACK Delay transport parameter
2019-07-29 fayang gfe-relnote: Fix Http2PriorityWriteScheduler::UpdateStreamParent. Not used in prod. Not protected.
2019-07-27 bnc Update QuicSpdySessionTestClient.Http3ServerPush* tests.
2019-07-26 renjietang Write push promise on request streams.
2019-07-26 fayang gfe-relnote: In QUIC, let write_blocked_list be able to use HTTP2 priorities. Not used yet. Not Protected.
2019-07-26 fayang gfe-relnote: Fix Http2PriorityWriteScheduler::ShouldYield. Not used in prod. Not protected.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: Icf65aae77a4fcb7fab9e22970597a72d1050dfee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732333
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683775}

This CL is fixing the imports of the system fonts. The previous code
was not taking care of the font styles.

The bug was introduced here:
 https://chromium-review.googlesource.com/c/chromium/src/+/1544229

The system font is created only by it's name and size:
 return Font(PlatformFont::CreateFromNameAndSize(font_name, font_size));

Some users are overriding the system font with a custom one. That font
may have some styles. The default windows configuration doesn't allow
to change the font styles, but advanced fonts software may do.

  Advanced System Font Changer:
  https://www.wintools.info/index.php/advanced-system-font-changer-icon-settings

R=robliao@chromium.org,asvitkine@chromium.org

Bug: 989476
Change-Id: Ie88ccf4452c5156de48e4f4a4bda87bd167850e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732733Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683774}

https://skia.googlesource.com/skia.git/+log/f8e5aadbd424..898bbfac2e35

git log f8e5aadbd424..898bbfac2e35 --date=short --no-merges --format='%ad %ae %s'
2019-08-02 michaelludwig@google.com Update gms to use new image filter factories
2019-08-02 stani@google.com Delete unused variant of MakeBackendTexture
2019-08-02 egdaniel@google.com Add table for supported colortypes in GrVkCaps.
2019-08-02 senorblanco@chromium.org Dawn: implement sk_app window contexts for all backends.

Created with:
  gclient setdep -r src/third_party/skia@898bbfac2e35

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=benjaminwagner@google.com

Bug: chromium:b/138674291
Change-Id: I4d4783c1816e62448c1bfc21b072a3262315d1a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733033Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683773}

... instead of /media_stream.mojom-shared.h

BUG=704136
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I6c493da78b25be83c80c93fb81028aa457b0bedd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731873
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683772}

In some cases, ScopedReadLockSkImage is not able to read back the
texture, because it does not know the hardware supports texture
rectangles. In that case, fall back to using CopyTextureCHROMIUM
to copy the mask texture into an SkImage.

Bug: 984766
Change-Id: I0a348a98767405f61810b03217ef96bb2b5bba2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730291Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683771}

- Add switch to enable/disable helpful/unhelpful buttons.
- Complete the logic to build helpful/unhelpful buttons if switch is on.
- TODO: Replace the button text from GRD.

Bug: 988117
Change-Id: Ia46ca3781fb036de4143193031d5906333158cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730254
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683770}

BUG=951455

Change-Id: I0e112271dd6cf0d31c06ec3a135643b7da05aa7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730864Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683769}

Make VizCompositorThreadRunner into an abstract interface and move the
existing implementation to VizCompositorThreadRunnerImpl. Then add
VizCompositorThreadRunnerWebView which will be webview's entry point
into creating and establishing viz objects.

Add code paths to ContentGpuClient so that webview can optionally
override the default instance.

Currently VizCompositorThreadRunnerWebView doesn't do much, except it
uses TaskQueueViz and exposes a simple API to run and block for work on
viz while allowing viz to schedule tasks on the render thread.

Bug: 805739
Change-Id: Ic5d2c45666ebc1fc9381c8cd5c71b0de57dd0136
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731135Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683768}

This is part of EG1 to EG2 migration, which involves moving
EarlGrey code from app-side helpers into test code.
EarlGrey2 has multiprocess architecture,
where Chrome Test and Chrome App are separate processes

Change-Id: Ib41116bb8df8c8383ad8a76460d5643560983716
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732157
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683767}

For enabling "Text you copied" on Clank, we need this function to provide
Text in Android's clipboard.

Bug:989143

Change-Id: I35032a6468f3bbae87b0027caa3924aa8af070b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726276Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Ender <ender@google.com>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683766}

Doesn't actually modify the method bodies at all.

Change-Id: I7354db324deeee4bfeb497038a704d9cbb98d961
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733789Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683765}

Only depend on content/public/common when building for Chrome OS. Since
that is the only time when the dependency is actually needed.

Bug: 990184
Change-Id: Ie7e04f317510b3bcb099acfb81379919b96ffccb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732389Reviewed-by: J Kardatzke <jkardatzke@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683764}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/116752315474..0fca4beb4959


Created with:
  gclient setdep -r src-internal@0fca4beb4959

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Ic231f5d2eec85dee7cab81b0de81453547252c4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733714Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683763}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/be9e4bf1b538..8c79db8a0702

git log be9e4bf1b538..8c79db8a0702 --date=short --no-merges --format='%ad %ae %s'
2019-08-02 miahsanchez@google.com device_unitest: the set up and tests for RunCommand
2019-08-02 achuith@chromium.org command_vm_test: Re-enable TestDeploy
2019-08-02 cjmcdonald@chromium.org Fix settings typo in vscode/settings.json
2019-08-02 omkarvijay@google.com Mark mistral important

Created with:
  gclient setdep -r src/third_party/chromite@8c79db8a0702

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I71a1ee8b2185b5863739ab031a7b5bc8842e1b99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733927Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683762}

TBR=kbr

Bug: 948902
Change-Id: Ida8080795b334b59db61ff688aaae7d909d8a446
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733463Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683761}

Rather than have SpdySessionPool and the socket pools listen to both
SSLClientContext and the CertDatabase separately, lump them both under
SSL-external notifications of SSL state changing.

(Note ClientSocketPoolManagerImpl's SSLClientContext::Observer
counterpart is TransportClientSocketPool. Also note this fixes
an inconsistency between HTTP/1.1 and HTTP/2. HTTP/2 had a
ERR_NETWORK_CHANGED vs ERR_CERT_DATABASE_CHANGED distinction while
HTTP/1.1 did not. I've made them both match.)

Change-Id: Ibde71856fc1d605757dbf869ce1eba482a6bbafc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703232
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683760}

Bug: 990428
Change-Id: I65f3b0b3c2b0f3ed71a5431257636a3bd6bcd735
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733806Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683759}

Also take ownership of all SoftwareReporter.* histograms.
Always use current joenotcharles@google.com email address.

R=rkaplow@chromium.org

Bug: 969962
Change-Id: I61bb0cf0972191ba461df9f9a701f84ae0774bae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732890
Auto-Submit: Joe Mason <joenotcharles@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/master@{#683758}

https://chromium.googlesource.com/catapult.git/+log/1dc9ce56c488..93ee550c1fe8

git log 1dc9ce56c488..93ee550c1fe8 --date=short --no-merges --format='%ad %ae %s'
2019-08-02 rmhasan@google.com Revert "Telemetry: add trace_processor_shell to binary dependencies"

Created with:
  gclient setdep -r src/third_party/catapult@93ee550c1fe8

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=rmhasan@google.com

Bug: chromium:944418
Change-Id: I4cdde616c3d1fc0ba94ab996e1158249aa9487ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733414Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683757}

https://chromium.googlesource.com/angle/angle.git/+log/ad77f55e0183..4c118cb3d371

git log ad77f55e0183..4c118cb3d371 --date=short --no-merges --format='%ad %ae %s'
2019-08-02 hckim.kim@samsung.com Vulkan: Add support for OES_vertex_half_float
2019-08-02 timvp@google.com Vulkan: Implement framebuffers without attachments

Created with:
  gclient setdep -r src/third_party/angle@4c118cb3d371

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@google.com

Bug: None
Change-Id: I4b8fa77e01dd6c23428ed6c4d35743a3011cdd8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733413Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683756}

Apart from the fact that it is not being used anywhere, it is
also an inconvenience, since this file is in the process of being
migrated to Blink [1], where the header is banned.

This CL cleans it up.

[1] https://crrev.com/c/1731644

BUG=704136
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Ie8626c1d139733787b867293c46d768d1ea66eee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731872
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683755}

If a user already has a custom background the refresh timestamp
and collection id in the pref would be initialized causing a crash when
we attempt to access them.

Bug: 850317, 990265
Change-Id: Ic34e3a34516be41b96e279d3c135a4a1912a251a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731922
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683754}

It appears that https://chromium-review.googlesource.com/c/chromium/src/+/1731947
caused some tests to just fail instead of crashing, which lead to
failures on WebKit Linux Leak. The tests still seem to crash on the trybots though.

Sample failure: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/2713

TBR=mstensho@chromium.org

Change-Id: If27c2ac16c86df5d2ecd3682161ab1b9872bf934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732796
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683753}

Changes to mb.py:
371e55885 Fix many misspellings
28bae5501 [vpython] Support vpython3 mode in vpython-native, include symlinks
4a77b0e65 [vpython] Support vpython3 mode

Changes to run-swarmed.py:
371e55885 Fix many misspellings
28bae5501 [vpython] Support vpython3 mode in vpython-native, include symlinks
4a77b0e65 [vpython] Support vpython3 mode
3adcb7a14 [vpythonsmoketest] Add a simple smoke test

Bug: 898348
Change-Id: Iff26b08ddfeeb7827d28b75f3e36c09b1a493295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730868Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: smut <smut@google.com>
Cr-Commit-Position: refs/heads/master@{#683752}

This is a mechanical change and will be TBR'ed after base/OWNERS review
per policy.

TBR=kylechar@chromium.org

Bug: 905412
Change-Id: I8003ea7c4137efdfa5390193d165f80f33f855b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732708
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683751}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=kbr@chromium.org

Bug: 968047
Change-Id: I063d952e16d56b738ee19e8e773d74c1269c0bea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729087
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683750}

It would trigger a preferences write on load error, to overwrite the
bad preferences. However, if we don't overwrite bad prefs, we'll load
them the same way we did before, so it doesn't seem like there's an
actual problem here. It's not a huge amount of code to track when
there's an error in loaded preferences, but it doesn't seem to get us
anything, either.

In some cases, some fields having errors cancels short-circuits reading
other fields. That logic still happens, so the results of loading bad
data should always be the same as before, we just no longer write
repaired data until there have been meaningful changes to it.

Bug: 984996
Change-Id: Ic035646d37f33cecdd267d2815c70ce804461e07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726956
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683749}

Bug: 990208
TBR=boliu@chromium.org

Change-Id: If2222cf76edf31860fcc1f4271c2c85a082d1088
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734006
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Auto-Submit: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683748}

It was only needed for ChannelPosix because Mach ports could not be
transferred with the message data. Now that ChannelMac exists, just
TakeHandles() is needed.

Bug: 973882
Change-Id: I83e754ea9877f4d355654ee069b5a6be0a14c1a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733926Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683747}

PassKit text is not rendered because of iOS 13 system bug. EG1 test
can't test the text (only presentation) so it passes. EG2 is a better
test and fails because of a real bug.

Bug: 989816
Change-Id: I946b862daa244ab3b2ba4c795e6f7e433b254a04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733453
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683746}

OnConnectionError should have been resetting both the data producer
as well as the client.

Bug: 958796
Change-Id: Ibc60dc05f7763e4ac61b43e445b5f2b40adc9246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733018Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#683745}

https://skia.googlesource.com/skia.git/+log/17b9d1d1deaf..f8e5aadbd424

git log 17b9d1d1deaf..f8e5aadbd424 --date=short --no-merges --format='%ad %ae %s'
2019-08-02 csmartdalton@google.com Remove 'dst' argument from GrOpList::copySurface
2019-08-02 michaelludwig@google.com Move SkImageFilter functionality into private SkImageFilter_Base
2019-08-02 mtklein@google.com no need to increment uniform pointers by zero
2019-08-02 robertphillips@google.com Revert "Increase specificity of GrColorType computed for YUV planes"
2019-08-02 mtklein@google.com select, {eq,lt,gt}_i32 on x86

Created with:
  gclient setdep -r src/third_party/skia@f8e5aadbd424

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=benjaminwagner@google.com

Bug: None
Change-Id: Ia8eb3ff0c2edd4eb12f5cb60da0a79ec02a4d849
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733848Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683744}