- 06 Nov, 2019 40 commits
-
-
Michael Lippautz authored
Bug: 1019191 Change-Id: I4a92d28681ce0aa6788642d96cf0d3c4e3c40fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899999Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712956}
-
Andrew MacPherson authored
Benchmarking on both amd64 and arm Chromebooks shows that PFFFT gives a performance improvement on Web Audio tests requiring FFTs. Using the Web Audio Bench at https://spotify.github.io/web-audio-bench/ Dell Chromebook 11 3189 (amd64): TEST Base PFFFT Change Convolver-128f-3ms 3866 3555 -8.04% Convolver-1024f-23ms 10064 8222 -18.30% Convolver-2048f-46ms 12236 9671 -20.96% Convolver-32768f-743ms 26130 19417 -25.69% Lenovo Yoga N23 (arm): TEST Base PFFFT Change Convolver-128f-3ms 5372 5382 +0.19% Convolver-1024f-23ms 10489 9234 -11.96% Convolver-2048f-46ms 12336 10554 -14.45% Convolver-32768f-743ms 25722 20272 -21.19% Bug: 1021027 Change-Id: Ieb5cd7af32d632bf252fcbad2101c1a5d2b91970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893203Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Andrew MacPherson <andrew.macpherson@soundtrap.com> Cr-Commit-Position: refs/heads/master@{#712955}
-
Alice Wang authored
This CL disables the flaky bookmark promo dismiss tests. TBR=bsazonov@chromium.org Bug: 1020068 Bug: 1020069 Change-Id: I003baa162588b14eae1f480fa69fb5e72edf9f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899375 Auto-Submit: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712954}
-
Takashi Sakamoto authored
https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/33985 deterministic failures KeepAliveOperationTest.NotifiesObserversOnResponse KeepAliveOperationTest.RecordsResponseDuration https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8910702062804733408/+/steps/chromeos_components_unittests/0/logs/Deterministic_failure:_KeepAliveOperationTest.NotifiesObserversOnResponse__status_FAILURE_ON_EXIT_/0 Change-Id: I034570a4376e8d39545c31dca035ff4f61c84510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660381Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#712953}
-
Yuzu Saijo authored
This CL fixes a bug where RemoveControllee can be called twice in ServiceWorkerVersion: :OnControlleeDestroyed. Change-Id: I7ea604f09a36e6bf1b63d45bee9623ba13d8e555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900795Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#712952}
-
Yuzu Saijo authored
This CL adds CHECKs to figure out where the crash is coming from around bfcache and ServiceWorker integration. Bug: 1021718 Change-Id: I8cf144618fa79591e9f9b2679b8535b50eeac2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900796 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Icc3f80fdc9a15ad26b50cc27ad5d9bc9a9d018c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900912Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712950}
-
Yoshifumi Inoue authored
This patch changes "inline_box_traversal.cc" to utilize |NGInlineCursor| instead of |NGPaintFragment| for preparation of migraing |NGFragmentItem|. This patch will reduces 1000+ failed web_tests in |LayoutNGFragmentItem| flag. Bug: 982194 Change-Id: I7f889755ff44beaa63e83f47db415b65969394d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888242 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712949}
-
Matt Falkenhagen authored
Bug: 1009795 Change-Id: Ib33c1242228e674442f21dea8a56ef456d84b886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899231Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#712948}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e0d5544c9864..d9fbf0234869 git log e0d5544c9864..d9fbf0234869 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 dneto@google.com Fix Go lint issues: comment exported symbols (#3014) 2019-11-05 afdx@google.com spirv-fuzz: better computation of data synonym facts (#3010) 2019-11-05 afdx@google.com spirv-fuzz: make equivalence classes deterministic (#3011) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@d9fbf0234869 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Bug: None Change-Id: I3e808ddde7f45fabdef640e175c4623228e57bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900909Reviewed-by:
-
Leon Han authored
It just contains a member 'string? record_type' which we can just put into NDEFScanOptions directly. BUG=520391 Change-Id: I161d52de3b28aef2b95724cfe20d95252cbb57b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899841Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#712946}
-
Michael Lippautz authored
Reland "Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map." This reverts commit bdc5aa8e. Reason for revert: Crasher has been stealth-fixed, see https://crbug.com/1021171. Original change's description: > Revert "Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map." > > This reverts commit 481fb0c1. > > Reason for revert: speculative revert for crbug.com/1019839 > > Original change's description: > > Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map. > > > > Change-Id: I6ef8b0098a795dc550037306e7b972ea907b0fc1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884285 > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#710616} > > TBR=jbroman@chromium.org,haraken@chromium.org,mlippautz@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: Iba339b519f2aa602773ceb79c95948c1cffdcbdb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893282 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711289} TBR=ulan@chromium.org,jbroman@chromium.org,haraken@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Iae455af51181d191f08e7af16cd8a1413aea2b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899783Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712945}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1d09b983031b..aae71bda01a7 git log 1d09b983031b..aae71bda01a7 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader aaa64b76c0b4..88264e3e188d (3 commits) Created with: gclient setdep -r src/third_party/angle@aae71bda01a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:None Change-Id: Ic3db40c69e51eef8435a20f0f4987aee3ffcddd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900908Reviewed-by:
-
Bettina authored
Bug: 1020768 Change-Id: If4cd121caffbf35c092e764c2d5de96b403c1872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895330Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#712943}
-
Alexandros Frantzis authored
When running on a system with a CPU family/model beyond the last entry in the CpuUarch table, the CPU id to CpuUarch mapping code tries to access an invalid iterator/entry and crashes. Check for this case and return an empty CpuUarch instead. Bug: 1021000 Change-Id: I2bc19427a03c0fe6906838bdcb2134021fc213df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893200Reviewed-by:
Gabriel Marin <gmx@chromium.org> Commit-Queue: Alexandros Frantzis <alexandros.frantzis@collabora.com> Cr-Commit-Position: refs/heads/master@{#712942}
-
Henrique Ferreiro authored
Remove nonexistent header files from the whitelist. Change-Id: Ibd68cb0ee9d3293da1ef38ed8596bcb5c7669024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891195Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712941}
-
Mihai Sardarescu authored
This CL updates the expire date for the following histograms: * Signin.AccountTracker.CountOfLoadedAccounts is extended for ever as it is used to monitor the number of accounts that are loaded by the AccountTrackerService when the profile is loaded. * Signin.AccountTracker.GaiaIdMigrationState is extended to M84 as this histogram is required for migrating ChromeOS to use Gaia ID as the account ID and we hope to do that early next year. Fixed: 988651 Change-Id: I82fa4e4fd5991ac4fd26bd41b35cac30252e9a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899785 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL converts PingServicePtr and port depending files to adapt to new mojo types. Bug: 955171, 978694 Change-Id: I204668e92136e9b8cf87150e016baa00b15e9fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897404Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#712939}
-
Andy Paicu authored
TBR=benwells@chromium.org Bug: 1017305 Change-Id: I076e6b428335ad9756dbba32fed98a001d676a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899884Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712938}
-
Rune Lillesveen authored
For FlatTreeStyleRecalc enabled, we did not walk the slot and ancestors clearing child-dirty bits when clearing a style recalc root as part of removing shadow host children. That would leave stray child-dirty bits. Here, we find the child-dirty slot and start clearing child-dirty bits from the slot and up the flat tree ancestor chain. If the slot was removed before the shadow host child, fall back to use the light tree parent of the removed nodes as the new style recalc root instead. Fall back to use the light tree parent for Shadow DOM V0 as trying to find the flat tree parent to start from is too complicated. TEST=shadow-dom/crashes/cyclic-detach-crash2.html Bug: 972752 Change-Id: If503bb3e102208440dae5b42c9231e680dc4d0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899372Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#712937}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fed59b5a..ba61465d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3a3f9522e7a7f691e19091ed9607c656edb712f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900886Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712936}
-
Martin Robinson authored
This fixes some issues with the interpretation of AtkCoordType in the platform accessibility implementation. Bug: 1020160 Change-Id: If5458444d224502a6355f74e9548175949751b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897831Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#712935}
-
Peter E Conn authored
Bug: 1019244 Change-Id: I9f8dfdf858e57e78c282d88924ff2e8edb24442e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892961Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#712934}
-
Leon Han authored
BUG=520391 Change-Id: I09a15805e86d2c1a933295587af9a2a99e6de5df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900806 Auto-Submit: Leon Han <leon.han@intel.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Roberto Carrillo authored
This is a reland of http://crrev.com/c/1894619 The issue was that the signature for _validate_and_convert_profraw did not accept the newly added output list `counter_overflows`. I added a test to validate the behavior of this function. R=sajjadm,liaoyuke,nodir Bug: 1020404 Change-Id: I25ab734e2d4c5b2237b00c9b8e7d103d4f8de122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900427 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#712932}
-
Adam Rice authored
Implement the { signal } option for ReadableStream pipeThrough and pipeTo, permitted a pipe to be aborted. Fixed: 902939 Change-Id: I168b3ac2c3f803cdd12611bea05c1ea706824a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899628Reviewed-by:Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#712931}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/215bc7949b35..88264e3e188d git log 215bc7949b35..88264e3e188d --date=short --no-merges --format='%ad %ae %s' 2019-11-06 swiftshader.regress@gmail.com Regres: Update test lists @ 215bc794 Created with: gclient setdep -r src/third_party/swiftshader@88264e3e188d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I95b34f1a912b01a3dd5658861a4ff28400bf398a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899840Reviewed-by:
-
Olivier Robin authored
Change-Id: I5a28eb714a70b84c0e7cada755bce8cb64ee3613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897696Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712929}
-
Zhongyi Shi authored
This change also resets socket_ to nullptr when the socket is closed. Bug: 101492 Change-Id: Ic4942fc580815eb0c062a821ac340138ac98a24a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900569Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#712928}
-
Maksim Sisov authored
We have all the Ozone platforms implementing the PlatformScreen. Now, it's the time to make that method pure virtual. However, there is one point - Ozone/Drm and Cast do not support PlatformScreen, but still implement it and expect that the method is not reached. Bug: 872339 Change-Id: I628878842294a8e99033893a9be42026066c29c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869004Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#712927}
-
Sam Fortiner authored
This change removes position from the GraphicsLayer tree dump format as another step toward the complete removal of position from GraphicsLayer. This is accomplished by intentionally passing through 0, 0 for the offset/position to CCLayerAsJSON which results in no output for position. As a supporting change, this change also renames CCLayerAsJSON's position parameter to be offset_from_transform_node which more accurately reflects what it is intended to be. Finally, removing a dead-code version of GetLayerTreeAsTextForTesting in WebLocalFrameImpl. Bug: 999336 Change-Id: I17f40076ec6bcf6cab9c70034c2466847af3c233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898806Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#712926}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e127e9f93079..f00524707da7 git log e127e9f93079..f00524707da7 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 67527cb45293..1d09b983031b (5 commits) Created with: gclient setdep -r src/third_party/skia@f00524707da7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: chromium:None Change-Id: I3e1d775a4122cf0919c45dffcedb68197163452c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899839Reviewed-by:
-
Greg Thompson authored
Also move ScopedTempDir so that it's cleaned after BrowserTaskEnvironment. BUG=546640 R=amoylan@chromium.org Change-Id: I21361f3d8c40c58ac51ccd4f14638252cd1078f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899611 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#712924}
-
Michael Lippautz authored
Trait::kWeakHandlingFlag can always be retrieved similarly through WTF::IsWeak<T> which is what the GC relies on. The GC supports the existing use cases based on WeakMember<>. If new weakness support is required, then WTF::IsWeak<> needs to be overridden as well as adding new overrides in trace_traits.h. Overriding weakness from user code using custom tracing functions is no longer supported. Why do we not allow overriding from user code? It turned out that it is hard to guarantee well-defined semantics wrt. to ephemerons and heap snapshots if custom weakness and composite types are created from user code. (In theory, all WTF traits, including those used for tracing, can be overridden from outside heap/. This is discouraged though as it requires knowledge of GC internals and will likely require new visitor APIs for new weakness types.) Bug: 1019191 Change-Id: Ie4291fe9e88eda6eb8ebde0fef5e7258a188cbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899874Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Kouhei Ueno authored
The API was previously blocklisted due to: - test failures, which was resolved in [1] - omnibox geolocation icon incompat, which is not available on Android This CL unblocklists geolocation API on Android. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1883428 Bug: 1015377, 989847 Change-Id: I1ee2dd4f9c9496622769431040fd0d99440ad0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886534 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712922}
-
Hiroki Nakagawa authored
The field was non-const because one test lazily initialized it. This CL tweaks the test setup routine and removes the lazy initialization. Bug: n/a Change-Id: Ib12ac76919dda20dfc7d708283e61d6ff1217b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900519Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#712921}
-
Chih-Yu Huang authored
in BUILD.gn, we already restrict all code in media/gpu/chromeos are only compiled when USE_V4L2_CODEC or USE_VAAPI is true. We don't need this buildflag in the source code. Bug: none Test: Run video_decode_accelerator_tests on Kevin and Eve Change-Id: I5449101ca5ae6702d10f4b3bfc233f27d2767aa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900786Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712920}
-
Takashi Sakamoto authored
This reverts commit 29d31a12. Reason for revert: suspect causing compile failure on linux-chromeos-rel Sample build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/30980 Original change's description: > Add App Service Instance related classes. > > Design doc: > go/app-service-instance-registry-design-doc > go/appservice-for-per-app-time-limit-design-doc > > This CL adds the App Service Instance classes: > Instance > InstanceUpdate > InstanceRegistry > > InstanceRegistry depends on Instance and InstanceUpdate to calculate > the instance updates to notify the client. > > BUG=1011235 > > Change-Id: Ife2a25c1ae24b3a5c8e1ef67540ba49939126174 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896484 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712915} TBR=dominickn@chromium.org,nancylingwang@chromium.org Change-Id: Ibd6556f36a71a477b4a3515b9d53a6be1cceb3fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1011235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900793Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#712919}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c761cf33..fed59b5a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I634965541d39fa5f7f4d8c1730d10d1ebea489d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899804Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/00e405553245..70f80e7066ba Created with: gclient setdep -r src-internal@70f80e7066ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:984162,chromium:1004848 Change-Id: Id57dc6860421bcb0d2a52e7f99506240d686b281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900826Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712917}
-
