- 30 Sep, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c8a351eec4f9..a427da0bffc4 Created with: gclient setdep -r src-internal@a427da0bffc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ic1aea4d62470b4895341616e4aa4c19308884419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830511Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701068}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1e9e3d2e9e79..f656f57a367a git log 1e9e3d2e9e79..f656f57a367a --date=short --no-merges --format='%ad %ae %s' 2019-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@f656f57a367a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I18903fbc8e4996f8d5b038b267e4ad991f5ac2d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830512Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701067}
-
Benedikt Meurer authored
For live expressions it doesn't make sense to trigger break points, as that doesn't match the users expectation of the feature. This commit uses the newly introduced "disableBreaks" parameters for "Runtime.evaluate" to suppress break points and explicit `debugger` statements for live expressions. Bug: chromium:1001216 Change-Id: Ie331761ca66afb813816c7d31e77085a5637ea8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831798 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701066}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 093c468a. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I61fbdb26a16765694754e9fba057a6aa5f42c41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831209Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701065}
-
Tim Volodine authored
Re-enable ServiceWorkerClientTest#testServiceWorkerClientInterceptCallback CTS test on the bots (P and up) Re-enable the testServiceWorkerClientInterceptCallback test, as it was updated in http://ag/2336567. Excluding the N and O bots for now, pending fresh N and O CTS release (with http://aosp/1129272 merged in). BUG=675809 Change-Id: I1d2ea6feb242633a411fc394a2b14f4c832a5cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824110Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#701064}
-
Marian Fechete authored
This CL is adding a new UMA histogram for the Autofill Assistant DFM installation. The metric contains the following values: installing of the DFM is deferred, the installation is happening in the foreground and it succeeded, the installation is foreground and failed, the DFM was already installed. The metric cannot currently distinguish whether the deferred installation succeeded or failed. Bug: b/140369065 Change-Id: Ie250567996efeea809bd1be0c5fe5ef037b75be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825358Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#701063}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/578270d9d23a..fc3587418d3b git log 578270d9d23a..fc3587418d3b --date=short --no-merges --format='%ad %ae %s' 2019-09-30 philipel@webrtc.org Use new RtpFrameObject ctor for unittests. 2019-09-30 nisse@webrtc.org Change FrameBuffer::CombineAndDeleteFrames to allocate a new buffer 2019-09-30 danilchap@webrtc.org Propagate task queue to create test::DirectTransport by TaskQueueBase interface Created with: gclient setdep -r src/third_party/webrtc@fc3587418d3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: If9b0ac4daf18e28827229385620e0bcf359763af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830508Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/10951a7c9a13..85c67b5e08ee git log 10951a7c9a13..85c67b5e08ee --date=short --no-merges --format='%ad %ae %s' 2019-09-27 stevenperron@google.com Record trailing line dbg instructions (#2926) 2019-09-27 rharrison@google.com Add removing references to debug instructions when removing them (#2923) 2019-09-27 paulthomson@users.noreply.github.com spirv-fuzz: allow interestingness script arguments (#2925) 2019-09-27 ehsannas@gmail.com Add Kokoro bots for building with Bazel. (#2914) Also rolling transitive DEPS: src/third_party/spirv-headers/src 601d738723ac..842ec9067462 Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@85c67b5e08ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Bug: None Change-Id: I66b89f650aa9e6e2cc8b2de46a9824c81a87ea8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831439Reviewed-by:
-
Sergey Poromov authored
MediaNotificationViewTest.* fails on TSan builds. Example: https://ci.chromium.org/p/chromium/builders/try/linux_chromium_tsan_rel_ng/384740 TBR=steimel@chromium.org TBR=beccahughes@chromium.org Bug: 1009287 Change-Id: I1fe5ce0dca108c294631b0aa70500e7100cc22f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829265Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#701060}
-
Yasmin authored
Bug: 1005813 Change-Id: I7c135ef3a969bd774c735f89fa82413c73aa9ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825601 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#701059}
-
Julie Jeongeun Kim authored
This CL converts PluginHostAssociatedPtr, PluginAuthHostAssociatedPtr, PluginRendererPtr, and PluginInfoHostAssociatedRequest to new mojo types using PendingAssociatedReceiver, PendingRemote, Remote, PendingRemote, AssociatedRemote, and Receiver. Bug: 955171 Change-Id: I4c2994c71c1b3a0e2f00008007b2d665a2b9bd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828725Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#701058}
-
Miyoung Shin authored
This change converts PaymentRequest mojom interface client in blink to use BrowserInterfaceBroker, and converts PaymentRequest{Ptr, Request} in chrome, components and blink to the new Mojo type. Bug: 936482, 955171, 978694 Change-Id: I254e341bfc32086d376e749c6aaa980b9a3bd7bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824791 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#701057}
-
Paul Lewis authored
Change-Id: Ic49e9ca826a645289f1b7819f939ccffd612e9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829700Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in ui/snapshot to the recommended methods/types. Bug: 1007853 Change-Id: I3e8fee3aa46ecd3c2fe5898c5e5294887f4f5eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829338Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#701055}
-
Thomas Tangl authored
... for the sync settings button. Bug: 995720 Change-Id: Ibe4116fb350730c616821164c36791a73a3a302a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831797 Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#701054}
-
Julie Jeongeun Kim authored
This CL converts ChromeOSListener and RendererConfiguration to new Mojo types using AssociatedRemote, PendingReceiver, and Receiver. It also updates SetInitialConfiguration from renderer_configuration.mojom. Bug: 955171 Change-Id: I434fd7f5c4e2495dc53cc3e8b795c7e33d75d833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828728Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/286fb1607d36..1e9e3d2e9e79 git log 286fb1607d36..1e9e3d2e9e79 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@1e9e3d2e9e79 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I935d1d451a1fe843db4922cf771ee406e0991b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831441Reviewed-by:
-
Alex Danilo authored
The 'onclick' handler for panel items was being set up when the panel was attached to the DOM. Side effect from that is creating a panel type with buttons used 'null' for the click handler, causing the buttons to fail to do anything after the panel is attached to the DOM. Set the 'onclick' handler inside the constructor to ensure it's available for reference when setting the panel item type. Needs test. Bug: 1009318 Change-Id: I654626b59715d03e3ee14f6ac00eadb5bd9815ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831618Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701051}
-
Thomas Tangl authored
... to provide the same guest avatar in all surfaces. Bug: 966388 Change-Id: Id69cb896cef6d520a635afbc66019cc0fe6c9b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826889Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Auto-Submit: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#701050}
-
Henrique Ferreiro authored
Convert the remaining references to content::mojom::FrameHostTestInterfacePtr. Bug: 955171 Change-Id: Ia6299a4d04744f5bd21d6c47bf24365b82d44ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816463 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#701049}
-
Jérôme Lebel authored
Removing pre-unity code from settings. Bug: 951313 Change-Id: I3249ca78d3bf80dd728040912e83afeb97be2369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798709Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#701048}
-
Yutaka Hirano authored
RespondToClosingHandshake can fail, and in that case we must stop using the net::WebSocketChannel instance. Bug: 994000 Change-Id: Ibaba2c552cfba59c3d95f63f0d9e807df4c4f564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830492 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#701047}
-
Jit Yao Yap authored
This is a reland of 04e92329 Original change's description: > Chrome OS Oobe: Show Ash dialog only if required > > When starting a managed guest session (with no Terms of Service), a > blank Ash dialog is shown for a brief moment before the session starts. > This is caused by the Ash dialog for Oobe being shown even when all the > Oobe screens are skipped. > > This CL changes the behavior of the Ash dialog to only show when > required by using a OobeUI::Observer. The dialog is not shown by > default, and will be shown when a Oobe screen is shown. > > OobeScreenWaiter now checks that the native window is visible by > default. A small number of tests had to be changed to either show the > native window or ignore the visibility check. The reasoning for the > changes are in the comments for their respective tests. > > The WebUI behavior is unchanged. > > Bug: 1000164 > Change-Id: I9995f4beba85d7c5af7b13f81f1a654e2d52f372 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790450 > Commit-Queue: Jit Yao Yap <jityao@google.com> > Reviewed-by: Denis Kuznetsov <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697539} Bug: 1000164 Change-Id: I3188791f20fc63c69e52a739ce0be28e972ea55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813334 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/71c1138d6739..ceac3320975b git log 71c1138d6739..ceac3320975b --date=short --no-merges --format='%ad %ae %s' 2019-09-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 10951a7c9a13..85c67b5e08ee (4 commits) Created with: gclient setdep -r src/third_party/angle@ceac3320975b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: chromium:None Change-Id: I077c1bed902da7a55b7b075a7bc3d89e28f71f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831679Reviewed-by:
-
Andreas Haas authored
The test uses WTF::ArrayBuffer as a replacement for a std::unique_ptr. Since we are refactoring ArrayBuffer right now, it is better to get rid of such uses. R=urvang@chromium.org Bug: chromium:1008840 Change-Id: Ib294217ecdf7a19c6eb1c19b07a0264c89841895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827403Reviewed-by:
-
Adam Rice authored
Permit any number of connect requests to be pending in the network service. Note that per-server WebSocket connection serialisation is still applied, so this doesn't permit denial-of-service attacks against servers. BUG=1006243 Change-Id: I31a10ec3384f32aa34ff0380f22738271bee0160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829629Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#701043}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/52bd6b7da6a7..55a00c7a1f9a git log 52bd6b7da6a7..55a00c7a1f9a --date=short --no-merges --format='%ad %ae %s' 2019-09-30 jiawei.shao@intel.com Set writemask to 0 when no fs output matches color state on Metal and Vulkan Created with: gclient setdep -r src/third_party/dawn@55a00c7a1f9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ib7613385713e1b29719648190d1520a3a87ae52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831677Reviewed-by:
-
Canon Mukai authored
This is behind a flag. And I added some JavaScript tests. Design Doc: https://docs.google.com/document/d/1TovyqqeC3HoO0A4UUBKiCyhZlQSl7jM_F7KbWjK2Gcs/edit#heading=h.7nki9mck5t64 Bug: 999091 Change-Id: I4c34d9b80fe50242c6547662040439a541b652b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810447Reviewed-by:
-
Kenichi Ishibashi authored
Bug: N/A Change-Id: Ie4d5166b58097a4ab290a74dd1267b2276811682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831622 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701040}
-
Martin Robinson authored
Instead of firing the signal on the node which contains the selection focus, fire it on the first common ancestor of the anchor and focus nodes. This means that if the AT does a tree dive to get the full selection it won't first have to climb to find the full selection extents. Also, along with this new way of firing events we also take into account the anchor and focus nodes when deciding whether or not to avoid firing duplicate caret-changed events. Bug: 1003359 Change-Id: Ia4ac03be3e0548e9b435d6e21512c3c22459e6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816474Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#701039}
-
Shik Chen authored
The original formula misses the 4 bytes of APP1 header in [1] and might crash GPU process when encoding JPEG image due to heap overflow. [1] https://cs.chromium.org/chromium/src/media/gpu/vaapi/vaapi_jpeg_encoder.cc?l=156&rcl=42946e0e99026e840e2067e02ebfdd9f48fc2e2e Bug: b:140071851, b:138933987 Test: Take photo in CCA 20 times on Nocturne with an ASAN enabled Chrome. Change-Id: Ic1809cf5364640dc11b72891243b69b25c38f439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828720Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#701038}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f498f13b418e..c8a351eec4f9 Created with: gclient setdep -r src-internal@c8a351eec4f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0e5839d9400618099e55590737a82730aceb08d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831347Reviewed-by:
-
Kenichi Ishibashi authored
This message was used for setting service worker V8 code caching outside install events. This feature was removed so remove the message too. Bug: 915081 Change-Id: I7cf79c6b59b16e3fc015806594bcb987a22c0b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829621Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
These methods were used for V8 code caching outside install events. The feature was removed so remove these methods too. Bug: 915081 Change-Id: If2635c0a978201c4d63dc697f7754f8e6de26f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829624 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Chih-Yu Huang authored
Originally, CreateGpuMemoryBufferHandle() function only takes one fd as argument, and assume each plane of the video frame stores at the same fd. This CL overloads CreateGpuMemoryBufferHandle() that takes multiple fds as arguments. Now we could pass different fd for each plane. BUG=b:127230761 TEST=autoninja components_unittests Change-Id: Ie6f132074c7125cf926786924dc30165de90ee24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826742 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#701034}
-
Ioana Pandele authored
The leak detection dialog is currently a tab modal, which allows interaction with the omnibox and tab switcher. This CL changes it to an app modal, which blocks interaction with the entire app until it's dismissed. Bug: 1008859, 986317 Change-Id: Ie12f3f2bd06c26860ae95ebc11bb7c97e6014571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825518 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#701033}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0081c0ff173c..286fb1607d36 git log 0081c0ff173c..286fb1607d36 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 vapier@chromium.org gclient: have git operations specify the git dir by default Created with: gclient setdep -r src/third_party/depot_tools@286fb1607d36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1000825 Change-Id: I61cdc381b5050050050a366060309db85caf7d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831480Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7aeabcfa6a73..59d894e2d057 git log 7aeabcfa6a73..59d894e2d057 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 996b3993..26279492 (443 commits) 2019-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6b4b8141e11d..faa2a365b5c0 (1 commits) 2019-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@59d894e2d057 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: chromium:None,chromium:None Change-Id: I28214c0151c2b9958c48fa46081c0c9883834994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831348Reviewed-by:
-
Rika Fujimaki authored
Since we can't trace WorldSafeV8Reference on stack, we use Member<WorldSafeV8ReferenceWrapper>. WorldSafeV8ReferenceWrapper class wraps WorldSafeV8Reference. Note that we remove ScriptValue::ToWorldSafeV8Reference() for now, but revive this once we ensure that TraceWrapperV8Reference's copy assignment is not buggy. Bug: 1007881, 1008258, 1008215, 1007881, 1007868 Bug: 1007865, 1007341 Change-Id: Ief22c6138394a512df9454d3c5bfad0bf35f8425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828783 Commit-Queue: Rika Fujimaki <rikaf@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#701030}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 79-3904.12-1569231291-benchmark-78.0.3902.0-r1 to 79-3904.12-1569231291-benchmark-79.0.3923.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I43cb854f205ec49001bd7b13056e971843274d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831491Reviewed-by:
-
