- 13 Jul, 2020 40 commits
-
-
Owen Rodley authored
Forgot to do this before enabling tree closing... Bug: 1094768 Change-Id: I18cc98051471cdeadbda8540196ee9ef725b40e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294739 Commit-Queue: Owen Rodley <orodley@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Owen Rodley <orodley@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#787660}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If1a41d9b9b1361b09eed0e4b059d47d65ff6efda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294689Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787659}
-
Mugdha Lakhani authored
This change gets rid of the EditText we were using in InstrumentationTestActivity for weblayer instrumentation tests and replaces it with a UrlBarView returned by UrlBarViewController. All relevant methods have been updated, and a small UrlBarControllerTest added to verify expected behavior. This was previously reviewed and submitted here: https://chromium-review.googlesource.com/c/chromium/src/+/2270442 Geolocation tests were failing on Android L after this change: https://luci-logdog.appspot.com/logs/chromium/android/swarming/logcats/4d4937bf36d05911/+/logcat_logcat_org.chromium.weblayer.test.GeolocationTest.testGeolocation_denyFromPrompt_20200708T215038-UTC_05fcae3f0ae58958 but making them load a static HTML page fixes that. Bug: None Test: ./out/<build_dir>/bin/run_weblayer_instrumentation_test_apk Change-Id: Ia455e56c1424af714659b1b32b8af6a7a6dafa54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289976Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#787658}
-
Yuki Shiino authored
Ports https://crrev.com/c/2261270 and https://crrev.com/c/2258781 to the new binding generator. Bug: 839389 Change-Id: If45e62bccbc8244353a9ba9362b70eb11d24ce46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291814 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#787657}
-
Jia authored
This cl moves LSS to chromeos/components and changed some APIs. For background and CL review, please see go/componentize-cros-search-service Bug: 1102232 Change-Id: I31e209e4e27f56a3d8fc8d687052a784829d56c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289270Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#787656}
-
Koji Ishii authored
Following <crrev.com/c/2291181>, this patch cleans up |NGFragmentItems|: * Add |NormalText| and |FirstLineText|. The latter retruns |nullptr| when there is no `::first-line` style. * Change |Text(bool)| to return |NormalText| if |FirstLineText| is not available, instead of returning |nullptr|. This pattern matches |LayoutObject::Style| functions and safer not to return |nullptr|. Bug: 982194 Change-Id: I1d1238e506c0f38223108c5dfbb5ca29d52bb3fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291917 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787655}
-
Miyoung Shin authored
This is a reland of 2c6f0159 The original CL was reverted because this CL had introduced 4% flakiness for OOBE tests on ChromeOS. There were two kinds of regression issues with the origin CL. One was that WebUI APIs didn't work after a crash and reload since the old Mojo connections were kept for WebUI, and another thing was that BrowserInterfaceBroker was not ready but it was used in WebUIExtensionData ctor. This CL fixes the above regressions. - Resets WebUI Mojo connections when the render frame is exited, and adds a test case. - Connects WebUI Mojo connections without BrowserInterfaceBroker dependence right after AllBindings is called. Original change's description: > Convert FrameMsg_SetWebUIProperty and FrameHostMsg_WebUISend to mojo interfaces > > This CL converts FrameMsg_SetWebUIProperty to WebUI mojo interface > and FrameHostMsg_WebUISend to WebUIHost mojo interface, and > introduces those mojo interfaces newly. > > Bug: 1041074 > Change-Id: Ifd47bca7b919647bd7163758826537f7d201dc85 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097795 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Cr-Commit-Position: refs/heads/master@{#768092} Bug: 1041074 Change-Id: Id6f6e0903f9816bd4cc65d8da00e2739c9fbc4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215650 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#787654}
-
Wolfgang Beyer authored
DevTools CL: https://crrev.com/c/2288703 Test was deactivated in https://crrev.com/c/2290935. Change-Id: Id0e61894e2786bae2b1fe237c2e01bcdcd0c6aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292050Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#787653}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f64be13cbf84..041796e60364 2020-07-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 79b4d6eb to b39fabb9 (542 revisions) 2020-07-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 479689912ee2 to b9285f69ba2c (11 revisions) 2020-07-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 6cd27bab06f4 to ad65826a2ab1 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: Ia082a3c29663f1498caf21ceb12971783b05867b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294684Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6723c14bd63c..fb5b460e9d7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yosin@google.com Change-Id: I0f526c4fabe2c4fdc306813995e00158d3728d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294683Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787651}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6711a818ee92..7f675314f19f 2020-07-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4f12d9c57a88126980d9ec81e71036a68078318d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294686Reviewed-by:
-
Side Yilmaz authored
This CL replaces |ImageFetcherFactory#createImageFetcher| functions in LogoDelegateImpl by using newer function with profile parameter. Today, image fetcher is created with regular profile always, even in incognito mode. By this CL, LogoDelegateImpl will create image fetcher with the profile coming via constructor. Bug: 1041781, 1083923, 1075562 Change-Id: I1d6df827b29e8f284a2ee5e7c2859b29399d2433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279201Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#787649}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594598363-c555f7e8a80b40cf8a42d21663f74bad4c776a90.profdata to chrome-mac-master-1594619844-912178519bb1004852ab23f2e1c1769d435241f8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@google.com Change-Id: If79cf875f175b98f534c159dae69dbade42801cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294688Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I54299eb9a7faa485069f43733b413c946bafd2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291521 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594600621-783048b6dd03c460bf0ffdecd7c0b42fb3608f4c.profdata to chrome-win32-master-1594611817-3939336dc9344e90c2a5b4af88e6cee72fe360b0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I52e3ab8d6fbcd7c1bf0d4d75c5c8c30af82c7ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294679Reviewed-by:
-
Owen Rodley authored
This will be submitted shortly after sending a PSA to infra-announc@ Bug: 1094768 Change-Id: I277dade09e7a0299a50b7b776dbd0279cd1f7a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294503Reviewed-by:
-
Quang Minh Tuan Nguyen authored
this is done in crbug.com/1007680 Bug: 1007680 Change-Id: I461787bcd77b1ac0ac6b1845e371cd1985648da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291818 Auto-Submit: Quang Minh Tuan Nguyen <nqmtuan@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#787644}
-
Kenichi Ishibashi authored
This doesn't seem to be used. Bug: N/A Change-Id: I050398b164cb58d86ee7b1af271fa91fdc43a2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294500Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#787643}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ia300db2ed184529cd8ae587b3a40c3a84d100167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291520 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Updates ExceptionState::ContextType so that it better fits with the new IDL interface implementation. Bug: 839389 Change-Id: Ia7e9bed5ceb93718336c07d98156ee89260ea8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291822 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Manuel Rego Casasnovas authored
NGOutOfFlowLayoutPart received a NGBoxStrut representing border and scrollbar sizes, so in layout algorithms we were computing that sizes and passing them to NGOutOfFlowLayoutPart. This has 2 problems: * We're doing this operation even when we don't have positioned descendants. * Some callers are forgetting to add scrollbars which can lead to bugs. With this refactoring we do this computation only in NGOutOfFlowLayoutPart constructor, after the early return (in case we have no positioned descendants). BUG=1098231 Change-Id: I9380d58f74c1034d4dd643073f19535bd3b603fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279758Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#787640}
-
Anand K Mistry authored
This only changes the argument types, not the return type, which will be updated in a follow-up change. Bug: 646113 Change-Id: Idea5cc9bddf13143720aaba17cf43e36b5bf8e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291294 Commit-Queue: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#787639}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/609ea210e2c0..f64be13cbf84 2020-07-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from fe36a64765c5 to 7d82d29398cc (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I2c88b0e4fe4266ad0055ba561e36f7209cbe9d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294478Reviewed-by:
-
Anand K Mistry authored
Bug: 1007788 Change-Id: I1b9323a44a54639707b4f2bb937e5b72bf5ffdd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279340Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Change-Id: I3c106e9decfdd6017db943d07058dfa9138d7e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294338 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#787636}
-
Quang Minh Tuan Nguyen authored
Bug: 1007686 Change-Id: I0e9741b65b522006808d8731d5980e71124f3469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291174 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Auto-Submit: Quang Minh Tuan Nguyen <nqmtuan@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#787635}
-
Maggie Cai authored
This CL gets the icon urls for the file tasks queried from app service. BUG=1092784 Test: Manually tested with files app. Change-Id: I691f09ea9203a419c120caf9caa9d0d80ed22a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291562Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#787634}
-
Eric Willigers authored
File sharing has shipped. We no longer need a separate flag for WebShareV2. Change-Id: Ib865e8389ced9df3cce9b96cd93f17dcc4819861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279513Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#787633}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594598363-0f08cd7fd83096035f2df6543642255aef7772e8.profdata to chrome-win32-master-1594600621-783048b6dd03c460bf0ffdecd7c0b42fb3608f4c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia436075b68f20a8b9bc8326cf9a32a0a39d5f249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294475Reviewed-by:
-
Kent Tamura authored
|run_fonts| should have no items on calling GetRunFontData(). This CL has no behavior changes. Change-Id: Ie5f8220b172543559473cc9a33c484aabc19b3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291803 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
David Munro authored
We don't reset settings.Router between tests, meaning runs after the first start already on the page being tested. A typical pattern for our pages is load data on attached then update as required, starting already on the page introduces a race between how quickly we can set up our test data and how quickly Polymer loads in the page. Bug: chromium:1096432 Test: Since flake mostly happens on buildbots, check Flake Portal after push Change-Id: I41cacffa0ee44428f5fda78c32916a6c56deec7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280776 Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#787630}
-
John Chen authored
NOTRY=True TBR=wenbinzhang@google.com Change-Id: Ib644820981abd902cb6372d3008c1ee0b372b9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288100Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#787629}
-
Jing Wang authored
Also change the variable name from show_tab to show_annotation since we don't have tab icon now. Test: tested with Chrome on Linux Bug: 1099498 Change-Id: I2d4cb00c6e329fd6b59aa730c2efb5827f99fb75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291918 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#787628}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/120e1d66c8ff..7d82d29398cc 2020-07-13 jiajia.qin@intel.com Refactor DisplayGbm::generateConfigs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: Id51043a9e0b92eebfadcc2ec775f6165058bc3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294472Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f8336121437..6723c14bd63c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yosin@google.com Change-Id: I842c3e8c02d498fab45b2833b0383512d7ea247b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294474Reviewed-by:
-
Jing Wang authored
Chrome on linux doesn't have WMHelper, so the DCHECK in exo::WMHelper::GetInstance() will always fail. This bug only repro when you build in debug mode where DCHECK is enabled. Bug: 1095204 Change-Id: I48f6b50bb9a382dcf2b9360d422ed315ece4b81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291921Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 1007635 Change-Id: Ica9e9a0d21bb8359835c606f37eafc191fea81b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280818 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#787624}
-
kouhei authored
Bug: None Change-Id: Icc2e54d85b33c0ddd5110fd5e3921503c2655a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291305 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch implements |LayoutText::PositionForPoint()| by iterating over associated fragment items, like legacy layout wchich iterates over inline text box, instead of iterating over all lines in containing block to avoid handling of hit testing in position:relative in |LayoutBlockFlow::PositionForPoint()|. Bug: 982194 Change-Id: I929d2ec232b82203aec576ae8c1af1f335e64f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291300Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594592389-af5b3849078a14dae1cc2ee4cd89c514efdae653.profdata to chrome-win32-master-1594598363-0f08cd7fd83096035f2df6543642255aef7772e8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id7bf07ed5aded87d69804a7a04af794ce09eafa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294579Reviewed-by:
-
