GitLab

A new test was added to the legacy_input_router_impl_unittest but wasn't
cloned over to the new input_router_impl. Add the missing code.

BUG=727866

Change-Id: Id7df047f173be06e4447d9ff99c383b85f2e3fed
Reviewed-on: https://chromium-review.googlesource.com/598545
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491793}

This reverts commit 1737b40c.

Reason for revert:
Reland after removing base::TimeTicks::since_origin() usage that
does not exist in M61 branch.

Original change's description:
> Revert "Add animated voice interaction icon."
>
> This reverts commit 875aa3d7b80dd3d6a2f0a265d4ca1875b502abc6.
>
> Reason for revert:
>
> Breaks the M61 branch build
>
> cc -o obj/ash/ash/voice_interaction_overlay.o
> ../../ash/shelf/voice_interaction_overlay.cc:170:43: error: no member named 'since_origin' in 'base::TimeTicks'
>     uint64_t now = base::TimeTicks::Now().since_origin().InMilliseconds();
>
> Original change's description:
> > Add animated voice interaction icon.
> >
> > BUG=b:62276007
> > TEST=build flash locally, see animation as spec
> > TBR=xiaohuic@google.com
> >
> > (cherry picked from commit cc92f7ae)
> >
> > Change-Id: I5542b68e084fe465c2f8b424b521c8faef51f686
> > Reviewed-on: https://chromium-review.googlesource.com/585245
> > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> > Cr-Original-Commit-Position: refs/heads/master@{#490447}
> > Reviewed-on: https://chromium-review.googlesource.com/595143
> > Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org>
> > Cr-Commit-Position: refs/branch-heads/3163@{#198}
> > Cr-Branched-From: ff259bab-refs/heads/master@{#488528}
>
> TBR=kaznacheev@chromium.org,oshima@chromium.org,xiaohuic@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: b:62276007
> Change-Id: Ie8e554ca79f054e0e4d18621402123455950aa9c
> Reviewed-on: https://chromium-review.googlesource.com/597071
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Original-Commit-Position: refs/branch-heads/3163@{#229}
> Cr-Original-Branched-From: ff259bab-refs/heads/master@{#488528}(cherry picked from commit 020cdf35035e30942aa34ca571fce561bff18cf6)
> Reviewed-on: https://chromium-review.googlesource.com/598507
> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491521}

Bug: b:62276007
Change-Id: I7c07a6edca4f853cd8e73664217c662eb29fc27d
Reviewed-on: https://chromium-review.googlesource.com/598688Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491792}

This CL removes most of the usages of
RenderFrameHostTester::SimulateNavigationStart outside of content/ in
favor of using NavigationSimulator. The goal is to have embedders of
content/ use the NavigationSimulator exclusively when writing unit tests
that involve navigation. This allows several tests to work with
PlzNavigate or OOPIF enabled.

BUG=728571

Change-Id: Iab0efe63d3c892da62ffe4e5cc2641e9af0f03a3
Reviewed-on: https://chromium-review.googlesource.com/582949
Commit-Queue: Camille Lamy <clamy@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491791}

This reverts commit 90a73c37.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [WebPayments] Clicking selected row goes back
> 
> Changing behavior when clicking on the currently selected item in an
> ItemList. Was a no-op; now goes back to the main sheet.
> 
> Bug: 748552
> Change-Id: I43f716145c059b6d95d5f01526b1224528fb0ad3
> Reviewed-on: https://chromium-review.googlesource.com/585370
> Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
> Commit-Queue: Tommy Martino <tmartino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491751}

TBR=anthonyvd@chromium.org,tmartino@chromium.org

Change-Id: I8a5d7de3da2f0e7f47bff11e9c6980e31590c38d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 748552
Reviewed-on: https://chromium-review.googlesource.com/600847Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491790}

- Moved device count metrics into its own class
- Added Cast device count metrics

Bug: 687377
Change-Id: Id7ca7b7a529a79a8827889ad63f51b1da74db1db
Reviewed-on: https://chromium-review.googlesource.com/596615
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491789}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ee634fd9..ad701e38

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Id86ce5d4109e5142f098cbadb1a456a8b5810521
Reviewed-on: https://chromium-review.googlesource.com/600113Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491788}

This is copy of https://codereview.chromium.org/2867063002 with all
the install_static refactoring removed to avoid bug:748949.

Bug: 718437
TBR: alexclarke@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: I3341f9af6a73dd83fc631bbde5f5b0473ff9de55
Reviewed-on: https://chromium-review.googlesource.com/591827
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Pierre-Antoine Manzagol (departed) <manzagop@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491787}

ScopedTaskScheduler is deprecated.

Bug: 708584
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I583be368ed89cdc687078bd8b72fcf2edf240afa
Reviewed-on: https://chromium-review.googlesource.com/586912Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491786}

Also enables services_unittests on the linux asan bots.

Bug: 751853
Change-Id: Ia4ea33100405c657fd0ee40fe15306e997193ce8
Reviewed-on: https://chromium-review.googlesource.com/599038Reviewed-by: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491785}

Per discussions with the Android team they recommend we skip resampling
when using low power audio. This CL expands the workaround we already
have in place for ChromeOS into a more maintable state by introducing
AudioLatency::IsResamplingPassthroughSupported(). This method returns
true on ChromeOS and on Android when the right criteria are met.

There are several changes to the buffering size logic, but none should
result in any actual changes to the buffering size outside of the new
pass-through case. The pass-through case will prefer the larger of the
hardware buffer size or ~20ms to avoid issues with massive bluetooth
output buffers.

As part of this change I've cleaned up the logic in the mixer manager
for determining when to allow passthrough.

Per a battor run done by liberato@ this is a ~34% power reduction (!),
with a basic mp3 playback going from 0.265W to 0.175W.

BUG=731860,747541
TEST=verified resampling is not invoked for basic playback.

Change-Id: Ia885f41bc50d6fe36934587d34ae646d1ef89364
Reviewed-on: https://chromium-review.googlesource.com/590737
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491784}

Initial version of the README.md covers how cc/animation itself works
(with some TODOs for trickier details), and dips briefly into the
clients of cc/animation. Future CLs will expand on the details of how
clients interact with cc/animation.

Bug: 740070
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib89a29a77630e46abcd1bd0f90e4158e9ffc0f23
Reviewed-on: https://chromium-review.googlesource.com/579587
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Walter Korman <wkorman@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491783}

Previously we would only clone the stdio FDs into the child if the
option.fds_to_map was empty. Callers instead expect that stdio FDs will
always be cloned into the child, but can also be overridden via the
fds_to_map option.

Bug: 706592
Change-Id: Ifd401b75ceda3b8fe1fb69604ff361ba50b2f40d
Reviewed-on: https://chromium-review.googlesource.com/598749
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491782}

and enable previously failing tests

Should fix: 
https://bugs.chromium.org/p/chromedriver/issues/detail?id=1852
for python tests, but not java tests

Bug: chromedriver:1852
Change-Id: Iebe5ec09bff943ab54200590c9943713c899f05f
Reviewed-on: https://chromium-review.googlesource.com/594653
Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491781}

Bug: 742592
Change-Id: I5d263b00a4d5d1ab0489217f09e73a353c3021b0
Reviewed-on: https://chromium-review.googlesource.com/599568Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491780}

When running battor_agent.exe for the first time one is likely to
encounter the message "Unable to find a BattOr." Once a BattOr is found
and battor_agent starts running there is a more informative help message
printed if you type <enter>, but that is too late. This change prints an
informative help message when a BattOr cannot be found, and also adds a
bug link to the code to explain why BattOrs are not auto-found on
Windows.

BUG=588244

Change-Id: I1206f906b32c2f2e6ec18517e6c184aaf44bb7a7
Reviewed-on: https://chromium-review.googlesource.com/598657Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491779}

ScopedAsyncTaskScheduler is deprecated.

Bug: 708584
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I89b92c36e714f4eb02b84f5130a75edf377cd8bf
Reviewed-on: https://chromium-review.googlesource.com/591880Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: John Bauman <jbauman@chromium.org>
Commit-Queue: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491778}

Bug: 730036
Change-Id: Ib893e60b94f4c8798f02f856990fb017bbba0459
Reviewed-on: https://chromium-review.googlesource.com/600489Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#491777}

This CL makes PerformanceObserver an ActiveScriptWrappable so it is not
destroyed by the garbage collector when it goes out of scope but it's
still observing (i.e. disconnect has not been called). Currently, GC
can destroy it and it will stop firing the callback at an arbitrary
time.

Bug: chromium:742530
Change-Id: Iec216f7c870d887f2b258536edd9164e1806c259
Reviewed-on: https://chromium-review.googlesource.com/587596
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491776}

Right now the BrowserTest.* tests are racy. Most of them eventually block on
loading a page.

Unforunately in --mash this is currently too slow, often going past the test
launcher's internal timeouts for output. (15s) Testing locally found they are
sometimes blocked for 25s

This leads to the entire mash_browser_tests flakily timing out, which prevents
us from bringing it back on the main waterfall.

TBR=sky@chromium.org
TEST=mash_browser_tests

Bug: 687687
Change-Id: Ib12e07e75664e8d45dc6c6745db13907c6827e23
Reviewed-on: https://chromium-review.googlesource.com/600487Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491775}

This reverts commit 6163e501.

The original CL's test fails on iPhone 5s, iOS 9.0 because the 
accessibility identifiers of the buttons are not set even though 
setAccessibilityIdentifier is called explicitly in the code, and it
looks like there is nothing we can do about it. This CL fixes the issue
by keeping using accessbilityLabel on iOS 9 and iOS 10, and switch to
use accessibilityID on iOS 11, and will clean this code up once the
support for iOS 10 is dropped.

Original change's description:
> Add AX ID for Cancel and Done button on Translate Language Picker.
> 
> Currently, the test uses the following matchers to find the cancel and
> done button on language picker:
> 
> grey_allOf(chrome_test_util::ButtonWithAccessibilityLabel(@"Cancel"),
>                     grey_userInteractionEnabled(), nil);
> 
> This is not bullet proof and may break any time, and this CL fixes the
> issue by adding AX ID to both the cancel and done buttons.

Bug: 750344
Change-Id: I57d1c716118049516d93853da77c25d85385aae0
Reviewed-on: https://chromium-review.googlesource.com/599124
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491774}

In this CL, the QueueingTimeEstimator only uses visible steps for
calculating Expected Queueing Time. A step is considered visible if
the renderer was never backgrounded throughout the step (excluding
possible changes at exact start or end of step). A window may thus be
made up of steps that are not contiguous in time. The objective of this
CL is to start reducing the massive concentration of the UMA stats for
Expected Queueing Time on the 0-1 ms bucket, because that is not very
useful and not a good indicator of latency.

Bug: chromium:729033
Change-Id: I3cfd4d3268d0f2858fc77de25c08d35a7a1cfc36
Reviewed-on: https://chromium-review.googlesource.com/587588
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491773}

This CL adds the interface to get estimated network capacity from
Remoter. A follow up CL will check whether the network bandwidth is
sufficient to activate media remoting.

Bug: 739972
Change-Id: Ica6aee81b23894748951fc8f27afcf74dabb6a28
Reviewed-on: https://chromium-review.googlesource.com/587507
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491772}

Otherwise it is vulnerable to an entity bypass. The fix to bug
384077 solved the otherwise difficult problem of finding a match
endpoint by using decoded data to find an actual semicolon, which
solved one problem but resulted in this issue.

To do these accurately, we'd need an HTMLSourceTracker than can
track the position of each decoded byte within a value back to the
raw content, rather than just the start and end position. Doing this
would be expensive.

So just stop at any semicolon in the attribute. I'd worried that
this would not give enough signal, but we are already checking for
an animate tag containing a javascript: URL, which is likely only
ever used by the bad guys.

Tweak the one existing testcase to cover the variation involving
entities. Two other existing testcases show that we don't re-introduce
384077.

I'd deferred fixing this hoping for animate to be deprecated, but
those plans are on hold.

Bug: 517547
Change-Id: Ib63dbdc691f11b143dc6e2fdd4b4232cfdf9629d
Reviewed-on: https://chromium-review.googlesource.com/599045Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491771}

Per discussion with rockot and others, StructTraits and typemap files are
language specific and should live in public/cpp instead of public/interfaces.

Change-Id: Id7fb1f5e733f6b2913f0da2332062c72f386ebab
Reviewed-on: https://chromium-review.googlesource.com/596751
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491770}

This cl adds a guest viewport to a scroll chain only if the viewport can
consume the given delta hints while handling GSB. Before applying this
change scrollbubbling from guests was broken when they were using oopif.
This was because the viewport of the guest would always get added to the
scroll chain and the GSB acks were always consumed even when the viewport
couldn't scroll in the given delta directions.

To know whether a guest needs to bubble GSB or not the "bubble" flag is added
to scroll_status. When viewport is the currently scrolling node and it cannot
scroll in GSB's delta hint directions, the bubble flag is set for the returned
scroll_status. The input_handler_proxy returns event disposition =
DID_HANDLE_SHOULD_BUBBLE. The equivalent ack for this event disposition is
INPUT_EVENT_ACK_STATE_CONSUMED_SHOULD_BUBBLE which tells
render_widget_host_view_child_frame to bubble the GSB and the rest of the
current scroll sequence.

The same problem used to exist for oopif with viewport, setting the bubble
flag in the returned scroll_status addresses this issue as well. 

To test the change enable TouchpadAndWheelScrollLatching and run the
below tests. They will fail without applying this cl.

BUG=526463
TEST=WebViewScrollBubbling/WebViewGuestScrollTouchTest.TestGuestGestureScrollsBubble/2,
WebViewScrollBubbling/WebViewGuestScrollTouchTest.TestGuestGestureScrollsBubble/3,
SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest(on Android)

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I2395f52fcbbfe0703d9668e2478ed0de0d92a6ff
Reviewed-on: https://chromium-review.googlesource.com/581910
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491769}

This moves the network_property_list element and network
elements that depend on it (apnlist, ip_config, nameservers)
to a shared location so that they can be used by Web UI dialogs.

Bug: 748204
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9d4b57167c31a8ed1811aa680838e3ba38105df2
Reviewed-on: https://chromium-review.googlesource.com/596410
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491768}

Win.setup_environ_for_server copies a few more environment variables
for apache on Windows. I checked (in patchset one of this CL) whether
these are still necessary, and they are. This CL would just update
the comment.

Change-Id: Iae3b9c4e379cc77457ca6bc66cee4a95c9a46018
Reviewed-on: https://chromium-review.googlesource.com/590579Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491767}

The overlay scrollbar ThumbPosition method was losing precision at very
high scroll offsets. This would cause it to drift away from where we
actually show the thumb from the compositor so the hit testing would be
unreliable.

Looking at this method, there's no reason it should need to be any
different from the base class ScrollbarTheme::ThumbPosition which is
robust under high scroll offsets so the solution here is to simply
remove the override. Less code, less bugs.

Bug: 739668
Change-Id: Ib90152d989931cd0bcc0bddfb226d97d577ce575
Reviewed-on: https://chromium-review.googlesource.com/598734Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491766}

Swiping up from shelf to open app list is only for tablet currently.
So set state as FULLSCREEN_ALL_APPS directly to add the animation.
Otherwise, the app list will just snap to the top of the screen.

Bug: None
Change-Id: I281ae53700294221b0c96c9a2aa1d4c66822f2bf
Reviewed-on: https://chromium-review.googlesource.com/598740Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491765}

Previously, RenderPass::Replace...Color() was taking a reference
to the quad's rectangle, then replacing the quad.  Unfortunately,
that destroys the original rect before it can be re-used a few
lines later.

This CL just makes a copy of the rect instead.

BUG=751746

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ice4a5e147000813a1e19c60ba33de5f36b2b11d7
Reviewed-on: https://chromium-review.googlesource.com/598489
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491764}

Bug: 744703
Change-Id: Ibbded8b3ea454856543802eacc46cab8ff766cfc
Reviewed-on: https://chromium-review.googlesource.com/599009Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491763}

This CL was cloned from https://codereview.chromium.org/2965173002/.

Create a new class `ContextualSuggestionsService` to fetch experimental
contextual suggestions for the omnibox.

Bug: 692471,609084, 750985
Change-Id: Ib54be91b1c0e2cb1fcdaf9a7a43b71984e5c358c
Reviewed-on: https://chromium-review.googlesource.com/576284
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491762}

Bug: 661794
Change-Id: I9e9844e73583288581e9700228708edc39dfd580
Reviewed-on: https://chromium-review.googlesource.com/561147Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491761}

Bug: 
Change-Id: Iddb5e3162a028dbd805e2a823e2244fc8ddf4214
Reviewed-on: https://chromium-review.googlesource.com/600430Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491760}

After changing to the __builtin_available() syntax in
51938fff, crdmg's sandbox blocked
reading the SystemVersion.plist, which caused crdmg to not properly
detect the OS version.

Bug: 752128
Change-Id: I2d1035c4de8c2f0559ccabc06eaf046da2f6522b
Reviewed-on: https://chromium-review.googlesource.com/600129Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491759}

If a channel error is triggered from off-thread and posted to the IPC
thread, we weren't ensuring that a RequestContext was in TLS. If the
error lead to event notifications this would cause a nullptr deref.

Fixes that.

BUG=752137
TBR=jcivelli@chromium.org

Change-Id: Iae167a712c9b7d8d853fe805c06afef36d2c4572
Reviewed-on: https://chromium-review.googlesource.com/600291Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491758}

This is a reland of b4ee3ace
Original change's description:
> Position fixed backgrounds in table sections correctly
> 
> Bug: 35697
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I1d50b8027f30ea775af91db62ad9de3f8f697c62
> Reviewed-on: https://chromium-review.googlesource.com/594987
> Commit-Queue: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491294}

Bug: 35697
Change-Id: I99cabe9c8808eb973b88087c5be1115d18e80313
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/598240Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Robert Hogan <robhogan@gmail.com>
Cr-Commit-Position: refs/heads/master@{#491757}

Bug: 734150
Change-Id: I934af65ec2e0841aed86e0753071a8d6b091fc10
Reviewed-on: https://chromium-review.googlesource.com/596908
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491756}

This is a reland of d95936bd
Original change's description:
> Move the task runner creation to password store from the factory.
> 
> In addition the CL changes some tests to use ScopedTaskEnvironment where appropriate instead of MessageLoop.
> 
> Bug: 741660
> Change-Id: I9993eaba6bd92e30dfe4a39a5fb89518d5ba4a3d
> Reviewed-on: https://chromium-review.googlesource.com/584908
> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491693}

Bug: 741660
Change-Id: I9ef1b4304f69dbf6fb3dc98dcec5843e92fc6371
Reviewed-on: https://chromium-review.googlesource.com/600207Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491755}

Bug: 752122
Change-Id: I90870a875855161b49e03bd1b4e7870f76dec694
Reviewed-on: https://chromium-review.googlesource.com/600289Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491754}