GitLab

This CL will be followed by another to BVC use the new method.

Bug: 982030
Change-Id: Icf5c11e060f9bfdaf9af15da3a44f6a04542c4c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689923
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675734}

This is a follow-up CL from the comment at:
https://chromium-review.googlesource.com/c/chromium/src/+/1622706/8/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java#601

This CL uses setOnCancelListener instead of setOnDismissListener for the
dialog cancel event (without user action).

Bug: None
Change-Id: I5d7c609d585da07dbbd759574efb0dc741d1db55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682669Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675733}

This reverts commit ba345fef.

Reason for revert: Now that win32 stack has increased to 1.5MB[1] we
can reclaim perf. and revert this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1682227

Original change's description:
> [LayoutNG] Heap allocate algorithms to save stack space.
> 
> This moves NGLayoutAlgorithm onto the heap using partition alloc.
> 
> This (in mac-64bit) reduces the stack space from 1392 -> 864 bytes
> which is the same as legacy.
> 
> From pinpoint data, this only seems to have a slight performance
> regression.
> 
> A follow up patch will be sent so which performs a refactoring, so that
> this patch can be a simple cherry pick with the beta branch.
> 
> Bug: 977387
> Change-Id: I75a5b995b26c60e69976f41876cea192bc761486
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669917
> Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#672086}

TBR=cbiesinger@chromium.org,ikilpatrick@chromium.org,mstensho@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 977387
Change-Id: I694977bee640df021f79f0926e5da723d6f2b911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692239Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675732}

This feature has already been enabled by default on trunk, but
I'm adding this test config to satisfy the field trial lint message
that requests it.

Bug: 981338
Change-Id: I35781ee8919d8f7314164b81e45c7f560a9fc1df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692971Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675731}

This moves them out of ui/views/ since they aren't related, breaks
their dependency on the ui/views/ test base class, copying over the
bits needed for these tests, and adding OS_ANDROID support for anything
platform specific to use the Java PaymentRequest implementation on
Android.

This puts common test code in helpers under the :test_support target
in chrome/test/payments/, with both _desktop.cc and _android.cc
implementations of the helper class. Non-payment helpers go in
chrome/test/base/ and currently just depend on #ifdefs to separate
desktop and Android code since the differences are small. The
chrome_test_utils:: namespace is used for helpers that support Android
and desktop, as opposed to the ui_test_utils:: namespace designed for
desktop only.

JNI bridges go under chrome/test/payments/android/ and are also part of
the :test_support target so they may be used by the above helpers.

And Java helper classes go under chrome/test/android/test_support/ in
the org.chromium.chrome.test_support name space. They are in a
:test_support_java target, which should be depended on alongside
:test_support for including the Java classes into the target so that
the JNI bridges can find the Java implementations.

The JNI header generation for the Java classes are in the
:test_support_jni_headers target, which is depended on by :test_support
in order for the JNI bridges to include and use them.

The test harness subclass inherits from PlatformBrowserTest to give an
Android vs desktop outcome, but otherwise depends on the helper objects
to provide Android vs desktop behaviour.

R=rouslan@chromium.org

Bug: 961849
Change-Id: Ie5ffda4d0206ae2a1f28ef3156cef183e56ee163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682764
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675730}

This bug was a combination of older code before we had "forced" BFC
block-offsets.

We didn't correctly detect when we had a self-collapsing block (which
had floats within it) that needed relayout if the initial estimate
was wrong.

This makes sure we give ourselves enough information to detect these
cases.

Bug: 980803
Change-Id: Id1ea5e10d819cb4509fd7664564b75b876f0f7cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690720
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675729}

While adding class comments to Quota classes, I noticed that there are
no calls to StorageMonitor::AddObserver() outside of tests. Without any
observers, this class serves no other purpose.

Change-Id: I9066cbddad78b10de2eb1082cc3bb381e334cd9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679156Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675728}

It's not yet clear whether we need this histogram but we want to keep
it for 2 more milestones to better understand it.

This CL also makes msarda@ a histogram owner, since the current owner
no longer works in Chrome.

Bug: 975881
Change-Id: I654d3e3ae47acc89481068ddf03b79bda1458b3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689746Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675727}

The previous CL crrev.com/c/1680983 introduced compact rows with
alternating white & gray background colors. Because of CSS selector
specificity, the gray background prevented the filter background
applying.

Change-Id: I277e4e64ec9709c3da9f24f2e01adb59604c1046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692210Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675726}

Bug: 953284
Change-Id: Ic638c1ddfbc9dc8d05b30c480ff4b946ee3fb177
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687557
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675725}

TBR=kbr@chromium.org

BUG=882580
BUG=908866
BUG=angleproject:2407
BUG=908912
BUG=angleproject:2978

Change-Id: I4bfeb4a9dc297123cb5ee6728f419f4021bd5c23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692965Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675724}

In the previous patch (https://crrev.com/c/1678842) I added auto-generated
descriptions to changes_strings.grdp. In this patch, I'm adding the rest
of the descriptions. A follow-up patch will be made to add a presubmit
check that all grdp messages have descriptions.

Bug: 941561
Change-Id: I61e65143e7d5160ce1e880c58ec56afdf03819cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688716
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675723}

This reverts commit bb8a36eb.

Reason for revert: Created too much load on too-small Xenial
pool, resulting in large pending test shard times, resulting
in long builds, resulting in pending times, resulting in even
longer builds due to cold caches, resulting in even longer
pending times.

Original change's description:
> [testing] switch to use xenial for swarming test
> 
> This CL switches to use xenial for test as many as possible.
> 
> Sheriff:
> If this broke some ci/fyi builder, feel free to revert this.
> 
> TBR=jbudorick
> 
> Bug: 954450
> Change-Id: I98abfb50bb10ca3eeec0e23d197fe7672c8acc95
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689513
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#675527}

TBR=yyanagisawa@chromium.org,tikuta@chromium.org,jbudorick@chromium.org

Change-Id: I1244abdfa1cf627c7f9effa3048ccf8ed53091b8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 954450, 982335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692035Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675722}

Rename cryptauth_constants.cc/h to cryptauth_enrollment_constants.cc/h
to distinguish from CryptAuth constants related to DeviceSync.

Bug: 899080
Change-Id: Iba7801c2cb7ea46e3a23f86e66a4a8a1d5cef75d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693162
Commit-Queue: Josh Nohle <nohle@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675721}

https://chromium.googlesource.com/angle/angle.git/+log/9be098b52fbb..cb8b4a5716ba


git log 9be098b52fbb..cb8b4a5716ba --date=short --no-merges --format='%ad %ae %s'
2019-07-09 clemendeng@google.com Rename "opengl32" to "libGL"
2019-07-09 geofflang@chromium.org Move member initializers from Caps.cpp into the struct definitions.
2019-07-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 4b4b41a63499..8aa9a7bb8f74 (1 commits)
2019-07-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 9702d47c6fe4..0c4feb643b89 (7 commits)


Created with:
  gclient setdep -r src/third_party/angle@cb8b4a5716ba

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I1efe58ce6a6bc2dc49baaf1e75f6776924aab678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693085Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#675720}

Move optimization guide related experiments, features, and switches to //components/optimization_guide

Bug: 969558
Change-Id: Ia2403feb3f0afa826a58db02a6b4479f3a9e3d5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691013
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675719}

Eager sweeping was added to dispose of CachesStorage.
CachesStoreage is a member, so eager sweeping didn't do anything.

Bug: 981043
Change-Id: I418dabf6596188660d10b91fefddf80c9dd8dae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692984Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675718}

R=jwd@chromium.org

Change-Id: Ifd419096bc7f527d0698a3f5b869e4c714a2e9da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692577Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675717}

Pre-finalizer performs:
1) Inform context_proxy_ that parent is destroyed
2) Cancel requests to classic_script_loader_
3) Reset uniqueptr to factory_client_

Bug: 981043
Change-Id: I425513bcc91d7d8676d575d302be85c9ca114cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690584Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675716}

https://imgur.com/a/qnVs4lG

Bug: 686905, 934202
Change-Id: If51daf61ec4ddaa780aff7a1f11af6746330d198
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690564Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675715}

Bug: 883985
Change-Id: If43f93fe27ce84fddc098aca8870b3cc729d7541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692168
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675714}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/e9bb8f287417..1f2dec1e1234


git log e9bb8f287417..1f2dec1e1234 --date=short --no-merges --format='%ad %ae %s'
2019-07-09 dneto@google.com Remove app_dummy call in Android test (#756)


Created with:
  gclient setdep -r src/third_party/shaderc/src@1f2dec1e1234

The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=radial-bots+chrome-roll@google.com

Change-Id: I9e6a9a3efdde264299f00fc268e3ae753a6664df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693081Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#675713}

The comment above HTMLFrameOwnerElement::GetLayoutEmbeddedContent()
says:
  // Most subclasses use LayoutEmbeddedContent (either LayoutEmbeddedObject or
  // LayoutIFrame) except for HTMLObjectElement and HTMLEmbedElement which may
  // return any LayoutObject when using fallback content.
  LayoutEmbeddedContent* GetLayoutEmbeddedContent() const;

No new test because I couldn't reproduce the bug locally, but I believe this
will fix the clusterfuzz bug.

Bug: 981459
Change-Id: I3ecf8022111dc25a2e862c0311ffa56467d18c2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689336Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675712}

Bug: 930109
Change-Id: I82f98f11719978ba7944351383c456bc5e60f9b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692750Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: A Olsen <olsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675711}

Replaced DomTimer destructor with a prefinalizer that calls Stop().
Added flag is_stopped_ to make sure second call to Stop() (from
TimerBase dtor) is noop.

Bug: 981043
Change-Id: Iab1473fe2d96fd9d6bfaf0ff2d7e46099796670f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688928
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675710}

Bug: 981828
Change-Id: I39d4af3b988165bd5980f884647b7c59f3aff1e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691329Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675709}

Spec requires dropping y value for 2d translate if it's zero (*). The
current implementation contains bug that:

1. It rounds the value before checking, which results in incorrect
   dropping of '0.1px'

2. It calls DoubleValue() on calc() without type checking, while
   DoubleValue() on calc() is meaningless when the calc() doesn't
   resolve to a simple numeric value (e.g., 1px - 1%). This results in
   incorrect dropping of some calc().

Both are fixed by this patch.

This is also a preparation for adding DCHECK in DoubleValue() to ensure
that it's called only when calc() can be resolved into a simple numeric
value.

Bug: 979895
Change-Id: Ie8b846729b91e55006485a25fab0b65533983eac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692202Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675708}

This test fails consistently on win-asan.

Tbr: aboxhall@chromium.org
Bug: 835455
Change-Id: Ia4b348a8c2a6693f7c0fd18906445f19f9422e3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693026Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675707}

Bug: 959357
Change-Id: I14b723d2fa1f250b5dd97bf377391324d0752d48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686701Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Auto-Submit: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675706}

Makes the tests more stand-alone & easier to run when dropped
into non-chromium codebase.

Allows //base to maintain the assumption that all tests that
use its class runner also use its instrumentation.

Bug: 971715
Change-Id: I2620936ad6b745563cd6114362bcb131b951bcd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690094
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675705}

Discovered this use case @
https://chromium-review.googlesource.com/c/chromium/src/+/1686776/5
and extracted fix from it.

An example of how this can happen is
FtlMessageReceptionChannelTest.TimeoutIncreasesToMaximum
which uses FastForwardBy from a GMOCK WillRepeatedly() hook.

Also fix an issue in calls to AllowRunTasks(). Because of
nesting and the way RunUntilIdle() works (with separate
allow/disallow phases), it was possible to enter a nested call
from either an allow/disallow phase and break the state on exit.
This CL makes RunUntilIdle() always restore the previous state.

This will also be required in
https://chromium-review.googlesource.com/c/chromium/src/+/1686776
which will need to AllowRunTasks() from FastForwardBy().

R=fdoray@chromium.org

Bug: 946657
Change-Id: I634a6ab89add3424383b4f105069b080d6fa25b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687796
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675704}

Bug: 930109
Change-Id: I64848ce01b47350b3d04967be873f93ce5c4977a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692754Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675703}

This is needed so that checks that occur as part of navigation
don't get confused by the replication state (notably the origin)
of the portal guest contents being missing from the remote frame
in the host contents' renderer.

Since this state is pushed down into the blink::RemoteFrame,
we need InitializeCoreFrame to be called before we can set the
replication state. As a result WebRemoteFrame::CreateForAdoptedPortal
is created, which performs this initialization with the provided
HTMLPortalElement.

Included web test crashes before this CL.

Bug: 980937
Change-Id: I843192e5f5aa8e4e022a88d318fa4a5e1d46a3d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677163
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675702}

Partial revert of crrev.com/c/1689513.

chrome-swarming doesn't have xenial bots in the main chrome test pool:
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/4291

# Notry'ing to fix bots.
NOTRY=true

Bug: 954450
Change-Id: Ifbfb4c4dc099184f24714ac07a4c501830b75e5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692823
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675701}

Some libc++ tests fail when the mac_upload_clang bot is run on LUCI
instead of Buildbot, and it's not clear why.

Since we don't really care about testing libc++ here, don't run those
tests to unblock the LUCI migration.

Bug: 731375
Change-Id: I273e0345098795cf27cb527873b04ddf8945bb83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680546
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675700}

Bug: 980024
Change-Id: I49fdaac8ea558a6068a3de6ba7d74e922ee9de81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691255Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675699}

Undefined behavior occurs (observed as a crash) when the Feed Internals
page is loaded and the last_fetch_trigger_type_ var is uninitialized,
so wrapping it here in a nullable pointer to avoid this.

Bug: 981513
Change-Id: I8637412423ab14d1a1329a414997d1f38887daaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691046Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675698}

Bug: 39240
Change-Id: I9cdf9a9a9de76fcdbc77bd36c24196f48b9035dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692934
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Andrew Whalley <awhalley@chromium.org>
Reviewed-by: Andrew Whalley <awhalley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675697}

The hardcoded "Upload from device" and "No background" tiles
were slightly misaligned. Partly due to a single character space
being inserted between inline-block elements. Fix the issues by
moving some properties between elements and setting the font size
of the parent to 0px. This fixes some problems with keyboard
navigation as well as the slight visual misalignment.

Bug: 937570
Change-Id: Iab866d50ae288d9bf4d5dc12280053253e6f3767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691260Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675696}

Timings that should remain real-time even under MOCK_TIME are now
explicitly using subtle::TimeTicksNowIgnoringOverride().

ThreadPoolClock defaults to DefaultTickClock in this CL but will be
overridden under ScopedTaskEnvironment's upcoming multi-threaded
MOCK_TIME mode @
https://chromium-review.googlesource.com/c/chromium/src/+/1686776

Ultimately, when MOCK_TIME mode always mocks TimeTicks::Now(), we will
be able to remove this and use TimeTicks::Now() again directly for
these calls.

Bonus #1: Gets rid of a call to DeprecatedGetMockTickClock().

Bonus #2: Added thread annotations to DelayedTaskManager::queue_lock_.

R=fdoray@chromium.org

Bug: 946657, 789079, 905412
Change-Id: Ief86338388b670ad9ddafb926e6817df6d96a95a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687028
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675695}