GitLab

This patch changes |ShouldCreateBoxFragment()| to return |true| for producing
box fragments for plain SPAN when |LayoutNGPaintFragments| runtime feature
enabled, to locate |NGPhysicalFragment| associated to |LayoutInlinline| for
computing bounding box and other kinds rects.

Without this patch, we need to traverse fragment tree rooted by
|LayoutBlockFlow| containing |LayoutInline|.

In legacy layout tree, we don't generate |InlineBox| for |LayoutInline| for
performance optimization and called "Culled InlineBox". To compute rects in
legacy layout tree, we traverse layout tree and line boxes in |LayoutInline|.
This code makes |LayoutInline| implementation complicated. Note: There is a
flag disabling "Culled InlineBox" as |AlwaysCreateLineBoxesForLayoutInline|.

Once LayoutNG is stable enough to have profiling, we investigate whether
generating fragment for every SPAN causes performance regression or not.


[1] http://crrev.com/c/763188: ONE [LayoutNG] Utilize DCHECK(CanUseInlineBox())
in core/layout/

Bug: 789390
Change-Id: Ife87fc9ee487397891ae4515d1bcaea1afcf9c04
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/790177
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520865}

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957

Change-Id: Id32fe134ba35b64c9593c46297620e84e508d1ce
Reviewed-on: https://chromium-review.googlesource.com/789727Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520864}

Bug: 
Change-Id: I758cb6dd17216965bf78b71c918c8eb6a4baa1a4
Reviewed-on: https://chromium-review.googlesource.com/802375
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520863}

This reverts commit cd106529.

Reason for revert: The accompanied CL ( 
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/786080 ) is not going to make a branch cut today.  

This CL will be landed again after that CL is merged first. 

Original change's description:
> Update Arabic font preferences
> 
> sans-serif/standard: Noto Naskh Arabic UI => Noto Sans Arabic UI
> serif: Noto Kufi Arabic => Noto Naskh Arabic .
> 
> This is accompanied by the following CrOS-side change:
> 
> https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/786080
> 
> TEST=See bug commnet 1
> 
> Bug: 787944
> Change-Id: Ib9555abddd7576541f918a7331a0b20b9cc617af
> Reviewed-on: https://chromium-review.googlesource.com/790937
> Reviewed-by: Dan Erat <derat@chromium.org>
> Commit-Queue: Jungshik Shin <jshin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520235}

TBR=derat@chromium.org,jshin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 787944
Change-Id: I5b49733740624e802ecedacd98d4c96ee7a7371b
Reviewed-on: https://chromium-review.googlesource.com/802678Reviewed-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520862}

Expose GetActiveViewController from chrome_test_util.

Bug: 777313
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib819e24af2abb9f49ce6a4e44114142ba8d0ce42
Reviewed-on: https://chromium-review.googlesource.com/795095
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520861}

The test has recently been flaking on all platforms, so expand the
expectation from just Win7.

Bug: 790892
Change-Id: I83adcb388c4048a5e4a88fc17bfda37964cebc12
TBR: kozyatinskiy@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/802846Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520860}

ENOSYS is an expected failure case for memfd_create() -- we provide a fallback
codepath for kernels that do not support it.

This CL only logs if memfd_create failed with an error other than ENOSYS.  This
should help to reduce the log spam introduced on the bots which mostly have
older kernels that do not support memfd_create().

R=thestig@chromium.org

Change-Id: Ib4d217187d1543c7e32dd9e900ef02661bfb817b
Reviewed-on: https://chromium-review.googlesource.com/802814
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520859}

lgarron is no longer working on Chrome. For TODOs, I removed them if
I thought they were well-covered by bugs or if the institutional
memory is gone to know how to do the TODO.

Bug: 
Change-Id: Ib3b52995777af9079c62f259ce14f7cac6615429
Reviewed-on: https://chromium-review.googlesource.com/802396Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520858}

InputMethodController::SetComposition() works as follows:

1. The current composition range is selected (we don't show this to users).
2. The selection is replaced with the new text, which is left selected.
3. The resulting selection is converted to a composition range, and we change
   the selection to whatever the IME requested be selected afterwards.

Step 2 causes the open TypingCommand's ending selection to be set to the
resulting composition range. We need to update it after step 3 to fix two
problems:

1. Pressing enter on a physical keyboard on Android with an open composition
   range causes the text in the composition range to be incorrectly deleted.

2. Pressing Ctrl-Z to undo causes each word to be selected in turn (see video on
   https://crbug.com/787598).

There's another problem with undo on Android, which is that the TypingCommand is
closed out after every call to SetComposition() when we select the composition,
which means undo only undoes one character at a time. I might fix this in a
separate CL.

Bug: 787598, 772565, 772584
Change-Id: I29f09e3c0bd97c6c8e17e5455c5579b53aa34c1b
Reviewed-on: https://chromium-review.googlesource.com/783770
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520857}

BUG=739622
TEST=Ran trybots. Ran documentscan_AppTestWithFakeLorgnette on DUT.

Change-Id: I53358981be8b33e934ea5846391cad5fbc2af62b
Reviewed-on: https://chromium-review.googlesource.com/796491Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520856}

No behavior changes.

Bug: 779730
Change-Id: I956ccf9df49f3240c2fcb126d364f541417b098d
Reviewed-on: https://chromium-review.googlesource.com/752563
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520855}

The network overrides feature was reverted from enabled by default here:
https://chromium-review.googlesource.com/c/chromium/src/+/801574

TBR=pfeldman@chromium.org

Bug: 789652
Change-Id: Id90e76fae69712c644f8b8ea177636f638461249
Reviewed-on: https://chromium-review.googlesource.com/802321
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520854}

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/23e0b491fa58..423f74fab02f

$ git log 23e0b491f..423f74fab --date=short --no-merges --format='%ad %ae %s'
2017-11-30 dalecurtis Fixup OWNERS file for FFmpeg.

BUG=769026
TEST=none
TBR=wolenetz

Created with:
  roll-dep src/third_party/ffmpeg

Change-Id: Ib61e336ca7f79cbea6e59be44632683f81fce44a
Reviewed-on: https://chromium-review.googlesource.com/802183Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520853}

https://chromium.googlesource.com/catapult.git/+log/280aff07f5fc..6c4c2362a367

$ git log 280aff07f..6c4c2362a --date=short --no-merges --format='%ad %ae %s'
2017-11-28 sadrul Include the raw event latency data in the report.
2017-11-30 simonhatch Histograms - Fix deduplicate

Created with:
  roll-dep src/third_party/catapult
BUG=788841


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ibd00df50d2332b7d22a9891c541c50bc6f69b5b8
Reviewed-on: https://chromium-review.googlesource.com/802541
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520852}

The bindings for origin trials had two utility functions to detect the
presence of the [OriginTrialEnabled] attribute on a definition. Both of
these functions were being used semi-interchangeably to check for origin
trials.

This CL merges the two utility functions to simplify the logic.

Also, there was some basic support for a [FeaturePolicy] attribute in
the utility function. This logic was removed, as the [FeaturePolicy]
was never used, and is not intended to be used in the future.

Bug: 788196
Change-Id: I2eda8e25147d30e251a1d9d076abe9a4f4b29c8a
Reviewed-on: https://chromium-review.googlesource.com/802015
Commit-Queue: Jason Chase <chasej@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520851}

When denying a request with a certificate error, we've historically cancelled
it with a net error code of net::ERR_INSECURE_RESPONSE in
content/browser/ssl/ssl_error_handler.cc, instead of the actual error code that
was encountered (e.g. net::ERR_CERT_DATE_INVALID). This is a little awkward for
committed interstitials [1] because we won't be able to determine from the error
code along whether an error page is for a certificate error, and there are places
where we have only the error code available, not supplemental info like the SSLInfo
or CertStatus. (See for example NetErrorHelperCore::ErrorPageInfo.) This comes up
in other contexts as well where we only have the net error code available (see bug
for details).

Along the way, this change fixes a bug in ServiceWorkerScriptURLLoader. This
loader was using response_head.cert_status to detect certificate errors, but
that field was not being populated by URLLoader (and was only populated by
ResourceLoader when devtools was open). So this CL populates cert_status
unconditionally to avoid this problem. The corresponding test was buggily
passing: it was expecting ERR_INSECURE_RESPONSE due to a cert error, but was
actually producing ERR_INSECURE_RESPONSE due to an unrelated error (unexpected
mime type). Converting certificate errors to use the more specific certificate
error codes instead of ERR_INSECURE_RESPONSE should prevent this test from
regressing again. Finally, fixing the Service Worker certificate checking
revealed a number of other SW tests which were expecting certificate errors to
be ignored via --ignore-certificate-errors, which broke once the SW bug had been
fixed. This CL adds --ignore-certificate-errors support to the network service,
so that those tests pass again.

[1] https://docs.google.com/document/d/1rEBpw5V-Nn1UIi8CIFa5ZZvwlR08SkY3CogvWE2UMFs/edit

Bug: 789720,789682
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I963b172dcfa400ef256e89c7c94d3f91b8bc5697
Reviewed-on: https://chromium-review.googlesource.com/797536
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520850}

The second CompileScript() overload is used only by
WorkerOrWorkletScriptController.cpp only to supply
CachedMetadataHandler to inline scripts.

This CL merges the second CompileScript() into the first, by:
- Adding CachedMetadataHandler argument to the first
  CompileScript() overload, and
- Plumbing ScriptSourceCode in WorkerOrWorkletScriptController.

This is to make ScriptSourceCode be always used when CompileScript()
is called from outside V8ScriptRunner (except for tests) and
to make the further refactoring easy.

Bug: 788828
Change-Id: Ic3eaa5f2f15017c9093112111493d0759b0774fc
Reviewed-on: https://chromium-review.googlesource.com/786268Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520849}

Currently, when we convert a CSSUnitValue to a different unit, we
essentially consult a NxN table to figure out the scale factor, where
N is the number of units.

An easier way is to first convert to the canonical unit, then convert
from the canonical unit to the target unit. This only requires a lookup
table of size N instead of NxN, greatly simplifying the code.

Bug: 776173
Change-Id: Icb28386938f9cb7de4d917c72426154b8f45d6e6
Reviewed-on: https://chromium-review.googlesource.com/798930Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520848}

Bug: 788828
Change-Id: I45d9450cacce9613440496493a40098352dec4c7
Reviewed-on: https://chromium-review.googlesource.com/786530
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520847}

- Rename DialMediaSinkServiceProxy to DialMediaSinkService to be
  consistent with Cast.
- Changed the construction/destruction sequence of
  DialMediaSinkServiceImpl to be consistent with Cast.
-- Now both always create Impl on UI thread, then post task to start /
   stop / delete the Impl.
-- The Impl classes exposes a task_runner() method which can be used to
   post tasks to it.
- Get rid of MediaSinkService. It serves no real purpose since MR
  always references the impl class directly, and we do not do any
  mocking with it.
- Replaced the DialMediaSinkServiceObserver interface with a callback
  since it's only one method.
-- The callback is invoked on the Impl's task_runner(). It acts as a
   trampoline to invoke the real callback on UI thread.
- Get rid of RefCountedThreadSafe usage in Dial / Cast classes, and
  replaced with WeakPtrFactory where necessary.
- Moved MediaSinkServiceBase to chrome/common/media_router/discovery.
- CastSocketService requires that methods be invoked on its
  task_runner() only.
-- Corresponding changes to CastChannelAPI / CastMessageHandler.
- More stringent SequenceChecker / BrowserThread checks. The latter is
  necessitated by downstream dependencies.

Bug: 784758
Change-Id: I50b4658c73ad561a642c1ff2347a5e523d3c963a
Reviewed-on: https://chromium-review.googlesource.com/773378
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520846}

No behavior changes.

Bug: 779730
Change-Id: Iee799336a5f5f2db61d6990edfead3c31b377c50
Reviewed-on: https://chromium-review.googlesource.com/762342Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520845}

This reverts commit d4dd5c37.

Reason for revert: Causes 40+ layout tests to leak, e.g. https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/12726

Original change's description:
> v8binding: Stops using the copyable ver of v8::Persistent.
> 
> I learnt that v8::Persistent provides two variations of copying.
> One actually copies, and the other actually shares the underlying
> slot.
> 
> This patch changes CallbackFunctionBase::Persistent from the
> "share" version to the "copy" (= make another independent slot)
> version.
> 
> Bug: 779036
> Change-Id: I1fae7a1547af2abefa932458f398d8e2b50ecaa3
> Reviewed-on: https://chromium-review.googlesource.com/798820
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520528}

TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org

Change-Id: I15cccba7606269da57e4b3c48d8e9bfa3b1c103c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 779036
Reviewed-on: https://chromium-review.googlesource.com/802715Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520844}

Also add rebased expectations in CL for reviewers.

Bug: 700624, 727514
Change-Id: I25b4194786b234f36618feac3df708253a5efde9
Reviewed-on: https://chromium-review.googlesource.com/802461Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520843}

BUG=789424
TEST=none

Change-Id: If6f9a889c5b67684c7157c451ccfc3e459c9e50d
Reviewed-on: https://chromium-review.googlesource.com/799850Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520842}

  In order to roll GN 157d5de4..f3a5b8c1 (r514519:r520777) and pick up
  the following changes:

  7f86d891 gn: Check if formatting a single line list to multiple reduces penalty
  5accd24a Remove base::SizeToToString[16]
  8f449e3d gn: Fix formatting of file containing only 2 block comments
  e643f226 add jumbo support when building gn itself
  e4963ba3 Run clang-tidy modernize-use-equals-{delete,default} on //tools
  5eea716f GN: Fix references to lib_[dir_]prefix, which should be lib_[dir_]switch
  8b6898fe Add option to gn bootstrap to specify the build directory
  3667991e Use std::make_unique in GN code.
  e953738c Clarify GN nonfatal unused build arg messages.
  e03b10a9 Remove unneeded extern keywords in tools/gn.
  976fe5f3 Add observer_list_threadsafe.cc to gn bootstrap deps
  36d1a861 [CFI] Add protected memory container class

TBR=dpranke@chromium.org

Change-Id: I22d358ee205d68100bf6a0d8f0e8129450d89e98
Reviewed-on: https://chromium-review.googlesource.com/802677Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520841}

This reverts commit 252e8a49.

Reason for revert: Caused http://crbug.com/790739

Original change's description:
> Use DoublyLinkedList instead of ListHashSet in DocumentState
>
> The only operations carried out on form_controls_ are insertions, removals
> and iterating through the entire list. Insertion and removal can be done
> faster with a DoublyLinkedList.
>
> Since the nodes for the DoublyLinkedList are Oilpan objects, this CL
> introduces HeapDoublyLinkedList that uses Member for the head and tail
> pointers, and traces the pointers.
>
> This improves the performance of HTMLInputElement::InsertedInto and
> HTMLInputElement::RemovedFrom by ~15%.
>
> Bug:
> Change-Id: I5b4cd20737e0276bece2430edfb7ec9609690f04
> Reviewed-on: https://chromium-review.googlesource.com/758877
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Keishi Hattori <keishi@chromium.org>
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517876}

Bug: 790739
TBR=jbroman@chromium.org,haraken@chromium.org,keishi@chromium.org,adithyas@chromium.org,lfg@chromium.org

Change-Id: I48ddedd7b356efa6b1f6f69c58e2022e9a0872f1
Reviewed-on: https://chromium-review.googlesource.com/802774
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520840}

Short-cuts provider and history URL provider unit-tests each have an
AnonFakeAutocompleteProviderClient, which shares a little code with
the common FakeAutocompleteProviderClient. This CL has those two
classes derive from the common one, and move the common bits down.
It's a follow-up to 776643.

Bug: 780835
Change-Id: Ida2fc850df0c36a35a3a1898296e85aec0a28809
Reviewed-on: https://chromium-review.googlesource.com/782079
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520839}

Call UpdateOpenTabURLs inside FeatureExtraction so we can have
urls logged as well.

Bug: 784232
Change-Id: I403cafbfe9f2691fdcfc7a83b0d85219c487884e
Reviewed-on: https://chromium-review.googlesource.com/802655
Commit-Queue: Renjie Liu <renjieliu@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520838}

User interaction with NotificationViewMD should fire the appropriate
callback methods defined in MessageViewDelegate.

Especially, with the interaction in the actions row, we should fire
- ClickOnNotificationButon
- ClickOnNotificationButtonWithReply

This CL adds the following unit tests to test these callbacks.
- TestActionButtonClick
- TestInlineReply

TEST=message_center_unittests
BUG=789057

Change-Id: Iba71e1f928830071fe73a7e49feb44efe493c8dd
Reviewed-on: https://chromium-review.googlesource.com/799592
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520837}

BUG=789375

Change-Id: I752b5eb006f43df0949374acac464793db92115d
Reviewed-on: https://chromium-review.googlesource.com/795550
Commit-Queue: Wei Guan <weigua@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520836}

Check whether the tab was recently audible (last 2 seconds) when logging
the TabManager.TabMetrics UKM.

Bug: 784639
Change-Id: I755305fecf1c13668219e972ad41312da91ca568
Reviewed-on: https://chromium-review.googlesource.com/795175
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520835}

enum ServiceWorkerFetchEventResult does not have to be a common type for
both browser and renderer code, this CL moves it out of
content/common/service_worker/service_worker_types.h, and also removes
the unnecessary IPC traits for it from
content/common/service_worker/service_worker_messages.h.

BUG=789854
TBR=tsepez@chromium.org

Change-Id: I6bda299731b71b8b5f9c493b1a785b7f9889f45b
Reviewed-on: https://chromium-review.googlesource.com/799551
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520834}

Change-Id: I7263f9f0291b14f5bc0e4831b371465b073ebc96
Reviewed-on: https://chromium-review.googlesource.com/786639Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520833}

This relands 290a7939 which was
reverted by 16af3fb6, except
that it omits the changes to test that flaked.

TBR=asvitkine

Bug: 761524
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I6d68e0a7cab7307544c4ddda5df3d153bc3d69a4
Reviewed-on: https://chromium-review.googlesource.com/802415
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520832}

Bug: 778749
Change-Id: I34f85b22f6b292c05820cf010471d8fb9f861e3b
Reviewed-on: https://chromium-review.googlesource.com/789412Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ravi Mistry <rmistry@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520831}

OOBE screens has min-height:640px. If a user changed the display setting to
lower resolution (e.g. 640x400), the bottom part of migration UI will be hidden.
This CL make the migration UI shrinkable based on the screen resolution to make
the "Update" button in the bottom always visible to the user.
(See attached screenshots on the bug.)

Since we don't have enough time to test it before M63 goes stable, this change
applies only to the migration screen to minimize the impact.
Other OOBE screens will be OK without the patch since users will see them before
they can change the display resolution.

Bug: 787393
Test: Manually tested on kevin by setting screen resolution to 640x400.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9d092deb556b8ca0beda6db39c35d48bff223b09
Reviewed-on: https://chromium-review.googlesource.com/800190
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520830}

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957
This CL was uploaded by git cl split.

R=svaldez@chromium.org

Change-Id: I9de4d060616eb3f3eabe736033545eec93fc7dd6
Reviewed-on: https://chromium-review.googlesource.com/798912Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520829}

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1c7240c773aa3f71d2bb7158e8f76aa7340b0f2d
Reviewed-on: https://chromium-review.googlesource.com/790010Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520828}

This covers //net/base to //net/dns in alphabetical order.

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957

Change-Id: I72d8a83ee86d833dc2caa0c3b9103689439bf443
Reviewed-on: https://chromium-review.googlesource.com/789971Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520827}

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957

Change-Id: Ib4d1680c615407583a6ad72ce51634d2f444db99
Reviewed-on: https://chromium-review.googlesource.com/789742Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520826}