GitLab

Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/section-index.html#event-languagechange

BUG=365123

Review URL: https://codereview.chromium.org/284793003

git-svn-id: svn://svn.chromium.org/blink/trunk@175135 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To avoid the need to call ReThrow() on the v8::TryCatch that may or
may not be declared, and the risk of forgetting to do so in some case,
use an auto-rethrowing v8::TryCatch variant instead.

BUG=362388

Review URL: https://codereview.chromium.org/304223007

git-svn-id: svn://svn.chromium.org/blink/trunk@175134 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to Geolocation API specification getCurrentPosition and
watchPosition does not raise exception, and current RaisesException
for them in the Geolocation.idl are meaningless Because it never
affect to generating bindings codes at all. Therefore we do not
need to keep them in that idl.

BUG=368184

Review URL: https://codereview.chromium.org/297353002

git-svn-id: svn://svn.chromium.org/blink/trunk@175133 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
TBR=alph@chromium.org

Review URL: https://codereview.chromium.org/307093002

git-svn-id: svn://svn.chromium.org/blink/trunk@175132 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Geolocation spec defines default values for both timeout and 
maximumAge but current implementation is working with
hasTimeout and hasMaximumAge functions for emulating that.

Setting initial values of timeout and maximumAge is more proper than using these "has" functions.
In addition, hasZeroTimeout can be removed because it is
enough to check timeout is zero or not and clearMaximumAge
can also be removed, as it is enough to set 0 to maximumAge.

BUG=368184

Review URL: https://codereview.chromium.org/297143003

git-svn-id: svn://svn.chromium.org/blink/trunk@175131 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The lazy initialization required the way to check wheather audio thread is finished or not to avoid lazy initialization by creation of other node after context uninitialzation.

A m_audioThreadFinished is not needed anymore since initialization() will be called only once in construct.

BUG=none

Review URL: https://codereview.chromium.org/304103002

git-svn-id: svn://svn.chromium.org/blink/trunk@175130 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The SVGResourceCycleSolver checks for cycles from within the resources
a RenderObject references to the resources it references, or any resources
in the ancestor-chain of the starting RenderObject (including itself if
it is a resource container).
This suffers from a few issues. One is that a resource that is referenced
both by the starting RenderObject and another resource referenced from the
starting RenderObject will be flagged as a cycle because all the resources
are added to the resources set.
Another issue is that longer cycles may not be detected because only the
resources referenced by the starting RenderObject is checked, and
depending on how the render tree is built, some cycles could be missed.
Additionally, a resource defined within another resource can cause a
"false cycle" to be flagged when the inner resource references a resource
in the resource set - eventhough the inner resource itself is not reachable
from the starting RenderObject.

To fix the above, make the SVGResourcesCycleSolver traverse the entire
resource "graph", and verify that it is acyclic. The cycle-checking is
achieved by keeping track of the current "path" through the graph, and
checking any discovered references against that set. When traversing
a subtree looking for references, any resources discovered will be skipped
to avoid inject false dependencies that way.
Also keep a simple "cache" of sub-graphs that has been checked already
(and verified cycle-free) to avoid having to revisit them.

BUG=351713

Review URL: https://codereview.chromium.org/303693009

git-svn-id: svn://svn.chromium.org/blink/trunk@175129 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Required to keep chromium working until it handles the callback method.

BUG=162827

Review URL: https://codereview.chromium.org/302703003

git-svn-id: svn://svn.chromium.org/blink/trunk@175128 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To complete the move to transition types for Element in html/ and dom/,
convert PendingScript and the script runner objects to trace their
embedded script element references. The script runner objects
(ScriptRunner and HTMLScriptRunner) are now garbage collected objects,
with PendingScript being kept in-line or as a part objects of those
runner objects.

To enable detaching of HTMLScriptRunner without having to rely on its
host (HTMLDocumentParser), the HTMLScriptRunner is instead made the
client of the resources it loads. This simplifies dependencies, but
requiring some follow-on changes to the HTMLScriptRunnerHost interface.

Besides script element references, convert a few other remaining Element
{Pass}RefPtr uses to transition types.

R=ager@chromium.org,haraken@chromium.org,eseidel@chromium.org
BUG=357163

Review URL: https://codereview.chromium.org/298863010

git-svn-id: svn://svn.chromium.org/blink/trunk@175127 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/308073005

git-svn-id: svn://svn.chromium.org/blink/trunk@175126 bbb929c8-8fbe-4397-9dbb-9b2b20218538

|invokeMethodOnAllTargetProperties| is now only used from |endAnimation|.
The code is more readable when inlined.

BUG=378670

Review URL: https://codereview.chromium.org/305033004

git-svn-id: svn://svn.chromium.org/blink/trunk@175125 bbb929c8-8fbe-4397-9dbb-9b2b20218538

same while shaping Complex text. More than one langauge can point to
single Script and single font can have support for different languages.

BUG=372502

Review URL: https://codereview.chromium.org/276573010

git-svn-id: svn://svn.chromium.org/blink/trunk@175124 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Webkit has css properties through which custom scroll bars can be added.
In case the element's visibility property is hidden and custom scrollbar 
properties are applied the scrollbar width is not considered when querying
the element.clientWidth. In case of non-custom scrollbars whether the
element's visibility property is hidden or not correct scrollbar width is
considered.

When a custom scrollbar is created there is a check whether the renderer to
which scrollbar is added is visible or not. This check is not required since
for non-custom scrollbars the same check is not present. Also whether the
element's visibility property is hidden or not a placeholder is set for the
element.

Both behavior i.e custom and non-custom scrollbars should be same.

I already landed this patch on Webkit. Just modified the layout test file.
http://trac.webkit.org/changeset/155323

R=esprehn@chromium.org,eseidel@chromium.org
BUG=343521

Review URL: https://codereview.chromium.org/163383002

git-svn-id: svn://svn.chromium.org/blink/trunk@175123 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For open-ended intervals such as [3) - i.e. begin=3s and end/duration/etc
unspecified - every call to resolveFirstInterval() would think that a new
interval had been created, and notify/require a reschedule of the
animations.
Add a new type SMILInterval and a suitable operator for that, and then
use it to compare the raw values (i.e. if both endpoints are exacly the same.)

BUG=377329

Review URL: https://codereview.chromium.org/298043005

git-svn-id: svn://svn.chromium.org/blink/trunk@175122 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Long ago this was added in hopes of generating a FlakyTests file.
This patch finally finishes that work and adds the FlakyTests
file as well as renames the command to update-flaky-tests
and writes to the file instead of stdout.

TestExpectationLine changed syntax a little since
flaky-tests was written.  I've also added support
for specifying path and specifiers values so that
the resulting test output looks right.

I explored having it update TestExpectations directly
(which we're definitely very close to being able to do)
but the consensus was FlakyTests as a separate file would
work better, so lets start with that.

BUG=242366

Review URL: https://codereview.chromium.org/301853003

git-svn-id: svn://svn.chromium.org/blink/trunk@175121 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=369451

Review URL: https://codereview.chromium.org/303363002

git-svn-id: svn://svn.chromium.org/blink/trunk@175120 bbb929c8-8fbe-4397-9dbb-9b2b20218538

nodeUnderMouse function is unimplemented in the complete code, so removing it.

Review URL: https://codereview.chromium.org/297293007

git-svn-id: svn://svn.chromium.org/blink/trunk@175119 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes false assumption from CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary,
which attached test case breaks that.

In the test case attached test case, |upstreamStart| points empty UL elemnt,
but it is visble, and |upstreamEnd| points A element. Thus, |upstreamStart|
isn't descendant of |upstreamEnd|. When removing "style" attribute from UL
element to make it invisible, this test case doesn't cause assertion.

BUG=366068
TEST=LayoutTests/editing/execCommand/justify-center-empty-list-crash.html

Review URL: https://codereview.chromium.org/300023009

git-svn-id: svn://svn.chromium.org/blink/trunk@175118 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=yhirano

Review URL: https://codereview.chromium.org/310453002

git-svn-id: svn://svn.chromium.org/blink/trunk@175117 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of DevTools: excessive dumping for jump-to-previous-position.html test (https://codereview.chromium.org/285373011/)

Reason for revert:
Looks like test is not accidentally failing any more during last week. Reverting this debugging patch

Original issue's description:
> DevTools: excessive dumping for jump-to-previous-position.html test
> 
> This patch adds excessive dumping for jump-to-previous-position.html test.
> The changes are expected to be reverted as the reason of failures will
> be detected.
> 
> BUG=361588
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174171

TBR=vsevik@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=361588

Review URL: https://codereview.chromium.org/303383002

git-svn-id: svn://svn.chromium.org/blink/trunk@175115 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of DevTools: more excessive dumping for jump-to-previous-position.html test (https://codereview.chromium.org/290393002/)

Reason for revert:
Looks like test is not accidentally failing any more during last week. Reverting this debugging patch

Original issue's description:
> DevTools: more excessive dumping for jump-to-previous-position.html test
> 
> This patch, as well as r174171, adds even more excessive dumping for
> jump-to-previous-position.html test.
> The changes are expected to be reverted as the reason of failures will
> be detected.
> 
> BUG=361588
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174282

TBR=vsevik@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=361588

Review URL: https://codereview.chromium.org/302043003

git-svn-id: svn://svn.chromium.org/blink/trunk@175114 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of DevTools: even more logging for jump-to-previous-editing-location.html test (https://codereview.chromium.org/298723005/)

Reason for revert:
Looks like test is not accidentally failing any more during last week. Reverting this debugging patch

Original issue's description:
> DevTools: even more logging for jump-to-previous-editing-location.html test
> 
> Follow-up to r174282 to add some more logging into the test to figure out
> why the test fails from time to time. The core problem seems to be due to
> inconsistency in SimpleHistoryManager.
> The patch be reverted after the reason will be determined.
> 
> BUG=361588
> TBR=vsevik
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174502

TBR=
NOTREECHECKS=true
NOTRY=true
BUG=361588

Review URL: https://codereview.chromium.org/304303004

git-svn-id: svn://svn.chromium.org/blink/trunk@175113 bbb929c8-8fbe-4397-9dbb-9b2b20218538

V8TestingScope is a "scope" object, so it's not a good idea to allow people to create V8TestingScope on heap.
This CL forbids it. V8TestingScope should be used on stack or as a part of object.

NOTRY=true

Review URL: https://codereview.chromium.org/302893004

git-svn-id: svn://svn.chromium.org/blink/trunk@175112 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/305963006

git-svn-id: svn://svn.chromium.org/blink/trunk@175111 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
R=alph@chromium.org

Review URL: https://codereview.chromium.org/306803003

git-svn-id: svn://svn.chromium.org/blink/trunk@175110 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This also fixes "inspect element" for virtual viewport.

BUG=371843

Review URL: https://codereview.chromium.org/309473002

git-svn-id: svn://svn.chromium.org/blink/trunk@175109 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The HTMLImportsController wishes to become more of an Actor-style object,
and it being a root of the import tree leads to ambiguities in responsibilities.
So we should split these responsibilities cleanly.

R=morrita
BUG=

Review URL: https://codereview.chromium.org/301803002

git-svn-id: svn://svn.chromium.org/blink/trunk@175108 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Length destructor is nontrivial and every non-const Length
argument adds an unnecessary branch from calling Length's destructor.
This patch removes most of the non-const Length arguments which should
lead to a small performance improvement.

A few LengthSize, LengthPoint, and LengthBox arguments were also
constref'ified for consistency.

No new tests as there is no observable change in behavior.

Review URL: https://codereview.chromium.org/305883002

git-svn-id: svn://svn.chromium.org/blink/trunk@175107 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/303783002

git-svn-id: svn://svn.chromium.org/blink/trunk@175106 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When working with FloatPoints in mapToContainer we currently round the
accumulated offset before adding to the current point. This can lead to
incorrect results when we add the two values together.

This CL removes the rounding call on accumulatedOffset.

BUG=371640

Review URL: https://codereview.chromium.org/302023003

git-svn-id: svn://svn.chromium.org/blink/trunk@175105 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Though r174748 added a test case to check if scheme contains colon,
it would be better if scheme contains colon explicitly. This cl checks
scheme contains colon. if so, this cl generates syntax error exception.

BUG=none

Review URL: https://codereview.chromium.org/298273008

git-svn-id: svn://svn.chromium.org/blink/trunk@175104 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Node.textContent setter should treat undefined the same way as null.
Previously, undefined would get stringified to "undefined" in the
setter, instead of being treated as "". This is inconsistent with
what happens when assigning null and with the DOM specification:
http://dom.spec.whatwg.org/#dom-node-textcontent

Since the textContent attribute is nullable, both null and undefined
input should be treated as null as per the Web IDL specification:
http://heycam.github.io/webidl/#es-nullable-type

The new behavior is consistent with Firefox 29. However, IE11 returns
"undefined" in this case.

R=arv@chromium.org, tkent@chromium.org
BUG=378454
TEST=fast/dom/Node/textContent-set-undefined.html

Review URL: https://codereview.chromium.org/303163002

git-svn-id: svn://svn.chromium.org/blink/trunk@175103 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/305753005

git-svn-id: svn://svn.chromium.org/blink/trunk@175102 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/307813004

git-svn-id: svn://svn.chromium.org/blink/trunk@175101 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Scrollbar stores original scroll position in non-negative scroll coordinates.
When sending those coordinates to ScrollableArea, they should be offsetted
with minimumScrollPosition() first.

R=jchaffraix@chromium.org
BUG=377131

Review URL: https://codereview.chromium.org/302603009

git-svn-id: svn://svn.chromium.org/blink/trunk@175100 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mark the fast/text/decorations-transformed.html test as flaky on
Windows. Possibly caused by the switch to DW.

BUG=378610
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/304183004

git-svn-id: svn://svn.chromium.org/blink/trunk@175099 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Windows XP specific rebaselines for r175038 as the XP > Win7 fallback is
no longer valid for text tests.

TBR=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/301353002

git-svn-id: svn://svn.chromium.org/blink/trunk@175097 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add unittests for WebCore::WebSocket class.

BUG=NONE

Review URL: https://codereview.chromium.org/298893008

git-svn-id: svn://svn.chromium.org/blink/trunk@175096 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
BUG=379032

Review URL: https://codereview.chromium.org/301243004

git-svn-id: svn://svn.chromium.org/blink/trunk@175095 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=100004, 105447

Review URL: https://codereview.chromium.org/249133002

git-svn-id: svn://svn.chromium.org/blink/trunk@175094 bbb929c8-8fbe-4397-9dbb-9b2b20218538