- 17 Sep, 2020 40 commits
-
-
Peter Wen authored
New API related checks are some of our most valuable lint checks, as triggering an error causes a crash directly. This CL adds compile test targets to ensure that code with API level errors trigger lint warnings. This prevents lint being accidentally turned off. Also delete now obsolete //build/android/lint directory and remove some already-fixed suppressions from lint-suppressions.xml. This is a reland of 3f2f2acf with missing LintTest.java added back. Tbr: mheikal@chromium.org Bug: 1108309 Change-Id: Ic5ac63ccd8aac2ebd3193d26294b8e27b233c903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416575Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807963}
-
Mohamed Amir Yosef authored
This patches make sure the set the |in_store| member of the forms returned in PasswordStoreChange. Observers can draw the wrong conclusion about the location of those forms if the field isn't set properly. Bug: 1119286 Change-Id: I46d6bc7678f1535418c58cb1df3db151bb263bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416077Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#807962}
-
Chris Lu authored
Bug: 1128133 Change-Id: I1d39a7cd2ad407e68a926b0df17864ed456986d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410848Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#807961}
-
Danan S authored
Bug: 1128446 Change-Id: I5553441f4d533d516fdb45955e2be5431cb7a621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416893 Auto-Submit: Dan S <danan@chromium.org> Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#807960}
-
Xiaohan Wang authored
This reverts commit cbf7394d. Reason for revert: reland with fix The original CL works fine on Windows and on Mac x86_64 build. But it fails on Mac ARM64 build. In the test there's also a variable called "result", which might caused some naming conflict. Original change's description: > Revert "media: Trigger Infobar on Mac ARM on EME query failure" > > This reverts commit a98a8fa4. > > Reason for revert: causing test failure > > Original change's description: > > media: Trigger Infobar on Mac ARM on EME query failure > > > > CDM on Mac ARM is not ready yet. When requestMediaKeySystemAccess() > > fails on Mac ARM, we reject the promise with "Unsupported platform" and > > trigger an infobar to notify user. The infobar will be triggered at most > > once per render process. > > > > Since the infobar can only be triggered in the browser process, a new > > mojo service CdmInfobarService is added. Note that even though there > > already exists KeySystemSupport service, which is also implemented in > > the browser process, we cannot trigger the infobar there, because the > > infobar requires a WebContents context, while the KeySystemSupport > > service is bound to a render process instead of a render frame. > > > > Change-Id: Ia85a1f2b097b0c2d26d12cc3e9363c34a25691a3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404716 > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > > Reviewed-by: John Rummell <jrummell@chromium.org> > > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#807631} > > TBR=ellyjones@chromium.org,dcheng@chromium.org,xhwang@chromium.org,jrummell@chromium.org > > Change-Id: Ia3e06b8685f70b3e3e000df2bbf24054bcc97ada > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414759 > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807649} TBR=ellyjones@chromium.org,dcheng@chromium.org,xhwang@chromium.org,jrummell@chromium.org # Not skipping CQ checks because this is a reland. Change-Id: I91a251bd5bfc7f5cae2e9e70c380e727f913eaa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415274 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#807959}
-
Sammie Quon authored
Video recording in comment 9 of linked bug. This CL fills in the UpdateAnimation and EndAnimation stubs. UpdateAnimation is responsible for letting DeskActivationAnimation know when to request a new screenshot. This is done by checking the bounds of animation layer after updating, and seeing if it is about to pass the visible region. Adds a new method GetIndexOfMostVisibleDeskScreenshot. This checks which screenshot layer is most overlapped with the root window bounds which are visible to the user and returns the associated index. This index is used to determine which desk to animate to in EndAnimation and which desk to get a new screenshot in UpdateAnimation. Test: manual Bug: 1111445 Change-Id: I38fb3a685fd45b326cbbde79ed1af9250ef8cf30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401839 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#807958}
-
Jesse McKenna authored
This change stops browser_tests from creating "Cached Theme.pak" files in the Chromium source tree. These generated files frequently cause confusion when they are accidentally added to CLs, and linger in the Chromium repo. Background: "Cached Theme.pak" is a preprocessed version of a Chrome theme. It is created in the theme's directory when a theme is loaded, to speed up future loading. The chrome/test/data directory contains seed data for tests, including some sample themes. When browser tests load these themes, the "Cached Theme" files are created in the chrome/test/data directory in the source tree. To prevent this, this change adds method ThemeService::DisableThemePackForTesting() for browser tests to call before loading themes from chrome/test/data. Bug: 852623 Change-Id: Idc0ccfee80b9e9c26cc0f4d5467dadf35f8a85e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403588Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#807957}
-
Gabriel Marin authored
BUG=b:168615813 Change-Id: Ie4f7f2c13fd050ceeb28d8b70040ef0c34126e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412831Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#807956}
-
Sam Fortiner authored
When computing the bounding box for fixed-pos layers, the resulting bounding box was stored on AncestorDependentCompositingInputs in viewport space (absolute space adjusted by scroll offset). The scroll offset that was used is the current scroll offset during compositing inputs update time. Call this ScrollOffsetA. Later during compositing layer assignment, when computing overlap, the fixed layer bounding box is converted from viewport space to absolute space by adjusting it by the current scroll offset. The expectation is that this 2nd scroll offset is also ScrollOfffsetA. However, in some cases, a compositing update will be requested that will skip compositing inputs update and only do overlap and assignment. When the scroll offset changes between computing the fixed layer's viewport space bounds in the previous compositing inputs update and the later compositing assignment update, the wrong scroll offset will be used and the fixed layer bounds will fail to be converted to true absolute space, leading to overlap testing errors. This change addresses this issue by storing fixed layer bounds in absolute space instead. Note that this issue does not happen when the CompositingOptimizations feature is enabled as it doesn't use the cached bounds from compositing inputs update. Bug: 1124753 Change-Id: I85928386fd43ca0b5a86b34877ef2a4afdabd73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411693 Commit-Queue: Sam Fortiner <samfort@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#807955}
-
Alex Ilin authored
In order to reuse ChromeColorsService in non-NTP contexts, we need to move the 3p NTP check to the code that can be hit by 3p NTPs but not by non-NTP clients. SearchTabHelper handles requests from the local NTP renderer, so it's a natural fit. The observer for NTP-provider changes was actually redundant, so this CL removes it. Theme changes are reverted when the NTP navigates away without calling ConfirmThemeChanges. When the user changes the NTP-provider to third-party, all Google-NTP will be either: - closed which will trigger the theme revert (old NTP) - keep the same state so the user can continue modifying the theme (webUI NTP) Bug: 1128451 Change-Id: I3a72ce9ffbaccca580b52e1b43f5b348e9bb9feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411944 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#807954}
-
Nnamdi Theodore Johnson-Kanu authored
screenshot: https://imgur.com/VZbftgo Bug: 1093185 Change-Id: Ib208423df1ab6d06bf7d7042ed14719816c7a772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410918Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#807953}
-
Mike Dougherty authored
Bug: 1129482, 1129483, 1129484 Change-Id: Ic512a5f00bff81d1210b1a003ab3429dd30318a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416894 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#807952}
-
Jeroen Dhollander authored
Bug: b/165356952 Change-Id: Id93c881a4806aceac17435f97324e0fc9e1ed3b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416730 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#807951}
-
Xing Liu authored
This CL extends a few notification related flags. Bug: NONE Change-Id: I0e2d0d642215a34e4252c0cd4196ec17448245f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415329Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807950}
-
nancylingwang authored
BUG=1083331 Change-Id: I7b4845ba62b15af8037aa642fc160b27759a6c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407627 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#807949}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8da60e2523c7..83c7e1ae8626 2020-09-17 amy.liu@arm.com Fix the regression of color blit. 2020-09-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from e8ce4355ae1c to 34ef0c3fdc8e (5 revisions) 2020-09-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from f105898a102f to 46fc663a1cb3 (4 revisions) 2020-09-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b33e0b36a08c to fe878dedd5ad (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Test: Test: dEQP-GLES3.functional.fbo.blit.default_framebuffer.*_linear_* Change-Id: I1ae57bc4d33e23bcfdf671745b1865424ce0511a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416789Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807948}
-
Clark DuVall authored
The WebLayer module's AndroidManifest.xml depends on the base module's package name. The target that generates the manifest didn't realize the generated manifest was stale when the base package name changed, which caused build errors on the official bots. Bug: 1129288 Change-Id: I488f484d3dd87fb5774cf669df96b6e3a2babd6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416892 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#807947}
-
Andre Le authored
Add PhoneModel to PhoneStatusView and display phone data in the UI through a set up labels and icons. BUG=1106937,1126208 Change-Id: I0af9365e510940e5d1ac1ea15767b8c12c603cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410762 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#807946}
-
Vasiliy Telezhnikov authored
We observe small amount of users generates thousands of errors suggesting they are in tight loop recreating renderer and losing again for some reason. This CL adds CHECK to crash in this case. Bug: 1126490 Change-Id: I5bec28b04e23c5d8671cdff6f5721fd4e519f9a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416749Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#807945}
-
Piotr Bialecki authored
Initial fully functional implementation of depth API. Changes: - mojo - add new feature enum value (DEPTH), added XRDepthData struct to carry depth information from device to renderer via BigBuffer - WebIDL - XRDepthInformation needs to return a UV transform so that consumers of the API are able to correctly index into depth data; XRDepthInformation::getDepth() throws on out of bounds access; XRFrame::getDepthInformation() throws when XRFrame is inactive and when passed in view is not associated with the XRFrame - add feature descriptor, "depth", for the new feature Other minor changes: - `ArCoreGl::enabled_features_` is now an unordered_set, enabled features are also propagated to ArCore initialization - refactored CopyArCoreImage helper into a template so that same logic can be used for copying depth and lighting estimation data; added a variant that does not allocate memory - changed MatrixFromTransformedPoints to operate on base::span<T> instead of std::vector<T> - ImmersiveOverlay interface uses newly added XRRenderInfo struct instead of XRFrameData Bug: 1119487 Change-Id: Icf509faa30768c1f906ff55a9b7043df2b76a37b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391619Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#807944}
-
Ilya Sherman authored
R=mpearson@chromium.org Bug: none Change-Id: I0eb5768c4e24b585f19ceb352b59e3728a19ab5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415217 Auto-Submit: Ilya Sherman <isherman@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#807943}
-
Kyle Horimoto authored
This enum will be used to communicate potential failure types from a Nearby Connections attempt to a PendingConnectionRequest for the attempt. Bug: 1106937 Change-Id: If78f7f314ceff98112b5ce8a558055baa55d6d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413305 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#807942}
-
Michael Bai authored
This feature will make the related test easy. Change-Id: I93835a5ccdf7b3adea6e360e980432e482ddb1d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405704Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#807941}
-
Justin Cohen authored
This reverts commit ac412c60. Reason for revert: checkdeps is failing here: https://ci.chromium.org/p/chrome/builders/ci/device-builder/48206 Original change's description: > Have content/DEPS depend on components/variations. > > content/ already depends on components/variations in multiple places; > see the bug for more details. > > This will also eliminate the need to add additional variations-related > dependencies in content/renderer/DEPS and content/browser/DEPS, e.g. > https://chromium-review.googlesource.com/c/chromium/src/+/2411489/2. > > Bug: 1129078 > Change-Id: Id9c8ddef40e70671d4e42ef0b24cdb6239be2f5a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414842 > Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807885} TBR=jam@chromium.org,caitlinfischer@google.com Change-Id: I7802701fc7939b3d9e3e9d705b86e43e4e30d26b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129078, 1129491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416877Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807940}
-
David Black authored
Bug: 1129215 Change-Id: Ifc454d94a79feb7b16d257219279e4f58344547f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414702Reviewed-by:
-
Stepan Khapugin authored
Before this CL, MainController calls startUpChromeUI on the scene on iOS 12. With this CL, this exceptional call is removed. Instead, the call now always happens in SceneController. The follow-up call to startUpAfterFirstWindowCreated in MainController is now triggered through the appState:firstSceneActivated: observer callback in both old and new startup sequences. This requires a few minor changes: * AppState now observes SceneWillConnect and immediately adds itself as a SceneState observer. The UISceneDidActivateNotification observation is now replaced with sceneState:transitionedToActivationLevel:, which is available on both iOS 12 and 13. * SceneController now becomes an AppStateObserver immediately on init, instead of waiting to initializeUI. Minor win: SceneControllerGuts are no longer necessary. Bug: 1012697 Change-Id: Id82e6a10c5825e34f53f076fef19a1e6bf9e7908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398505 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#807938}
-
Pavel Yatsuk authored
This is a reland of 37dea4b3 Wasn't actually the culprit of failing tests. Original change's description: > Update message in permission dialog overlay warning > > The current overlay warning message does not directly address the > typical case: when dialer or chat bubble is displayed on the screen. > > One change in behavior is that "Cancel" button of overlay warning dialog > dismisses both overlay warning and permission dialog. > > BUG=1127455 > R=twellington@chromium.org > > Change-Id: I9d5c13a6c7d4e52a3fa73b3193d1ef463272ab64 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406148 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Andy Paicu <andypaicu@chromium.org> > Commit-Queue: Pavel Yatsuk <pavely@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807089} Bug: 1127455 Change-Id: Ia973a989f70d4a094b0d620b4ae4970482d21fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414672Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Auto-Submit: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#807937}
-
Rakib M. Hasan authored
Bug: 1041619 Change-Id: Ifab7a7de001c3193f031b1fa437b851cf7cc1c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415276Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#807936}
-
Justin Cohen authored
This reverts commit d777f5d0. Reason for revert: Lots of test failures here: https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/14202 Original change's description: > Reland "[Empties] Enable the IllustratedEmptyStates field trial testing config." > > This is a reland of 74b8ec6f > > Original change's description: > > [Empties] Enable the IllustratedEmptyStates field trial testing config. > > > > Change-Id: I664fa63b5b69369cb69fb4b87463ba3bb4cfc94d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386295 > > Reviewed-by: Sergio Collazos <sczs@chromium.org> > > Reviewed-by: Steven Holte <holte@chromium.org> > > Commit-Queue: sebsg <sebsg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#805136} > > Change-Id: Ieb3e461efb4c55e7ef601417819cc4470e8fe4cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401398 > Commit-Queue: sebsg <sebsg@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Auto-Submit: sebsg <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807867} TBR=isherman@chromium.org,sebsg@chromium.org,sczs@chromium.org Change-Id: I69b15363426ecabb9712f182e617166d148566e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416874Reviewed-by:
-
sandromaggi authored
This adds identifiers to the ProgressBar icons and adds a new path of updating the step using that reference. This also adds a new way to define the progress bar as complete, independent of which progress bar is being used. Bug: b/168611883 Change-Id: Iabf3fa02d2904b3a0819561f00aab50f32be6b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412338 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#807934}
-
Eugene But authored
This roll was done by ios_internal/google_internal/frameworks/roll_frameworks.py after changes in the following CL: https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/3200150 This CL creates appropriate directories, which are required by new roll_frameworks.py code Bug: 1112956 Change-Id: I8ba15b15ef40d539b51d17dc16bbea1ec3eeb72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337541Reviewed-by:
-
Mike Dougherty authored
Bug: 748410 Change-Id: I6ab9e1eabb776796342fdb94237d837fb309efd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414777 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Maksim Sadym authored
* Add `GetNodeIdByElement` to webView * Add `ExecuteGetComputedLabel` to Element Bug: chromedriver:3507 Change-Id: I53c558d73c57b588e27a8cc20c270619121d7fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410392Reviewed-by:
Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Maksim Sadym <sadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#807931}
-
Peng Huang authored
the system window server On macOS, overlay backings (IOSurface) can be still used by the system window server, after overlays are replaces by a new frame. So it is not safe to return overlay resources to client without checking them against the system window server. This CL addresses the issue by send released overlay mailboxes back to SkiaRenderer with SwapBuffersCompleteParams, and then return overlay resources when they are not used by the system window server anymore. This CL also turns on overlay render pass. Bug: 1100728 Change-Id: I0a844f0b2542cb1f776ceda2ac2d5250916b697e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404077Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#807930}
-
chrome://policyNikita Podguzov authored
This improves chrome://policy page readability. Screenshot of new chrome://policy page UI: https://screenshot.googleplex.com/3W4hzapHNNCqttn Bug: 1121478 Change-Id: Iee2d059d35cc00057bf5f3bfed9fa352ba8a7d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414257 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#807929}
-
Matthew Jones authored
This reverts commit 2346288a. Reason for revert: Suspected cause of failures of password related tests (testSelectedStoredPasswordIndexIsSameAsInShowPasswordEntryEditingView) on android-marshmallow-x86-rel and others: https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1349 Original change's description: > Add field trial testing config for password and safety check > > Make sure that tests which were not meant for Safety Check explicitly > disable the feature. > > Bug: 1070620, 1092444 > Change-Id: I83ba782b73cff33f6b4b6f5afa0df9d9e4db2fd6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410866 > Auto-Submit: Ioana Pandele <ioanap@chromium.org> > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807803} TBR=mpearson@chromium.org,ioanap@chromium.org,chouinard@chromium.org Change-Id: Ia51936bc2889d9fc9a8423f8d3c3186358fb045d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1070620 Bug: 1092444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416930Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#807928}
-
Joshua Pawlicki authored
This reverts commit 9d75cd80. Reason for revert: Suspect this causes AXPlatformNodeAuraLinuxTest.TestAtkPopupWindowActive failures on Linux Ozone Tester bots. Original change's description: > Enhances editing event intents by surfacing the input event type from Blink > > For every editing operation in Blink, this patch exposes to the browser and to automation clients > the "type" property of its input event from Blink. > > The enumeration listing event intents was too long, and it included > intents such as paste, type and replace. > To make using intents simpler, the list of commands is now trimmed down to a few > generic ones, such as insert, delete, format and SetSelection. > For intents attached to text changed and text attributes changed events, more information > is now provided in the intent's input_type member. > Values are provided by a new enumeration that uses the same members as the > W3C Input Events Specification. > This makes the information more detailed, accurate, as well as standard's based. > > The TextBoundary and MoveDirection enums were also modified to add the "kNone" member > so that event intents such as "kClearSelection" that have no boundary information and no directionality > need not use them. > > Finally, the equivalent struct that is used by WebKit for event intents on Mac was added, as well as a conversion function. > > AX-Relnotes: n/a. > > R=dmazzoni@chromium.org, aleventhal@chromium.org, dtseng@chromium.org > > Change-Id: Ifa2a94451596980cf36ecc13bb073ca7062e9587 > Bug: 989156 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401028 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Auto-Submit: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807909} TBR=dmazzoni@chromium.org,dtseng@chromium.org,nektar@chromium.org,rsesek@chromium.org,aleventhal@chromium.org Change-Id: I86623c1259ab81890e4982d1de300f6642c7ceed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416814Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#807927}
-
Dave Tapuska authored
The input target receiver should be reset during Close. The widget is GC'd so it can live longer but we shouldn't receive any messages after the WidgetBase has been destroyed. This matches the lifecycle of the receiver_. BUG=1129309 Change-Id: I4c3a3076e6d03890e59255d471c73d0e59ffe056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416391Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#807926}
-
Hiroki Sato authored
Bug: None Test: git cl format Change-Id: I08b4db32c18a7d8dd88058f834bf66448f84b284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413712 Auto-Submit: Hiroki Sato <hirokisato@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#807925}
-
Theresa Wellington authored
Move the last widget in //chrome/android/.../widgets/ to //components/ and delete the old directory. BUG=1003941 Change-Id: I407f883ec4bf03e15d87c5753565567d8f9b9f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410672Reviewed-by:
-
