- 06 Feb, 2020 40 commits
-
-
ckitagawa authored
This bug is due to not passing |same_document_| correctly to BuildDidCommitProvisionalLoadParams(). This causes some same-document navigations to behave as though they are cross-document in unit tests. This also fixes any unit tests that depended on this behavior to pass. Bug: 1049575 Change-Id: I81d08bee9c922c8070ab1d9d7a870141ff88c38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041797Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#739062}
-
Henrique Nakashima authored
Change-Id: Ib4cf8982b249b78d67e37d894d1c831cb0f5061d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042381Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#739061}
-
Ian Kilpatrick authored
Fixes: fast/text-autosizing/cluster-inline-grid-flex-box.html We weren't applying any of the text-autosizing logic. This adds the correct scope so we can apply it. Bug: 845235 Change-Id: Ie7496043f80959bad342a4fe7f8876a8a8eeb7b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037859 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#739060}
-
Wenyu Fu authored
Test are reporting failed with Mocktio exceptions on a subset of builder bots. Disable these test for now. Bug: 1049557 Change-Id: Id635b448d7c44dfcd3b8167633f4e72fd3c45aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042396 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7572c967ba08..e9dc0201af3a git log 7572c967ba08..e9dc0201af3a --date=short --first-parent --format='%ad %ae %s' 2020-02-06 brianosman@google.com GL: Mark unused uniform locations that were explicitly bound as ignored Created with: gclient setdep -r src/third_party/angle@e9dc0201af3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: Icf0b379cdb2431c21b73790ed896c63ddfdd7b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042237Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739058}
-
Filip Gorski authored
Bug: 1049263 Change-Id: I66c7249e913360cd0c5b2478ec78055b0bbe3a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039598 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Auto-Submit: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739057}
-
Vasiliy Telezhnikov authored
This CL implements External Stencil support for webview with SkiaRenderer by drawing to intermediate FBO and then drawing to main frame buffer the quad with it using stencil test. Bug: 805739 Change-Id: I00a3406cced343a08ee0ed3ad7264d3c8b65ca72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031556Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#739056}
-
Jonathan Backer authored
Bug: 1033001 Change-Id: Iafecf2e001c7c6535db1444c18bb4190bc8e5014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039592Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#739055}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/612c52d1..624f9f49 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I806df598668c1ccdbf18c984b7d374211b6a8c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041413Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739054}
-
Alex Moshchuk authored
The HasSecurityState() check was introduced as a temporary workaround to eliminate crashes caused by Mojo services trying to perform ChildProcessSecurityPolicy security checks after the RenderProcessHost has been destroyed. HasSecurityState() was used to detect that the process was gone and just fail open. Now, we have a better solution in place with ChildProcessSecurityPolicyImpl::Handle, which extends the lifetime of a process's security state even after the RPH has gone away. Switch local storage (StoragePartitionImpl::OpenLocalStorage) and session storage (SessionStorageNamespaceImplMojo::OpenArea) to use this approach instead. This takes care of the last two non-test uses of HasSecurityState() so we should be able to remove it in a followup CL. Bug: 943887 Change-Id: Ifc9d000f5bd89c4c058395954137db3d1bb474fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034095Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#739053}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/417d89c32ff9..50984a64faec git log 417d89c32ff9..50984a64faec --date=short --first-parent --format='%ad %ae %s' 2020-02-06 ehmaldonado@google.com Reland "presubmit_support: Add --all-files options." Created with: gclient setdep -r src/third_party/depot_tools@50984a64faec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042324 Tbr: agable@chromium.org Change-Id: If9f524ec04a3e1692ccac8f0694814020cb3c8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042249Reviewed-by:
-
Johannes Henkel authored
Upstream: "Remove Parser_{h,cpp}.template as promised." https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2040571 New rev: 9fd0f91cc4331f931b7ac4040ceaa36de43937d0 Change-Id: I107c015b9e6a3a93bbe7abf297a129a933f906c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039971Reviewed-by:Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#739051}
-
llin@chromium.org authored
Bug: b/144800297 Test: unit tests Change-Id: I28694447360b12592ebf7fcd5a701d56a687d951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040235 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#739050}
-
Colin Blundell authored
This class is a dependency of ChromeMetricsReporter, which we are going to componentize for sharing with WebLayer. Bug: 1030692 Change-Id: Ib233440b5768b2123c972d61537c2e6b75da0e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039456Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#739049}
-
Robert Ma authored
This reverts commit 6a196c81. Reason for revert: Unfortunately SVG files are not recognized as tests in WPT, so moving these files into WPT actually means that we stop running them altogether. See this CQ run: https://ci.chromium.org/p/chromium/builders/try/linux-rel/303153 Original change's description: > Move SMIL events tests to WPT > > Change-Id: Ie4c00b4b6b6eba3b55f86793620a502780590864 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041270 > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Commit-Queue: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#738955} TBR=pdr@chromium.org,fs@opera.com,schenney@chromium.org Change-Id: I09a5cde1c656ba765b710b7d5f01dd588c13da51 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042125Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#739048}
-
Alice Wang authored
This CL adds render tests for signout dialog of managed and not managed account. Bug: 1042222 Change-Id: Ie26de64c0f2f5b4e771aa8e461489d9c7e21431a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002809Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#739047}
-
Natalie Chouinard authored
Move Sync settings alongside Sync code. Bug: 1047357 Change-Id: I66839fc3a913ff3993a24afef051f5626f87ef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040444Reviewed-by:
-
Robert Flack authored
The devtools frontend roll in https://chromium-review.googlesource.com/c/chromium/src/+/2038189 broke web_tests text output on debug bot runs. TBR=tvanderlippe@chromium.org Bug: 1049641 Change-Id: I12f91f3ed99d1d945b2fd780dcd69c7cf52563a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041532Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#739045}
-
Nate Fischer authored
This adds a targetSdk quirk for WebView's CookieManager API. Starting for apps which target Android R, WebView will no longer accept cookies for insecure ('http' scheme) URLs which also specify the 'Secure' cookie directive. While this changed for Chrome in M58 (https://www.chromestatus.com/feature/4506322921848832), WebView has been working around this by fixing up the URL's scheme to 'https'. WebView will continue to do so for apps targeting < R. This adds a histogram to track the new case. Bug: 933981 Test: run_webview_instrumentation_test_apk -f CookieManagerTest#testSetSecureCookieForHttpUrl* Change-Id: Ie31f02911d38984983fdf4afeb4d6e1eb4f7d094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040685Reviewed-by:Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#739044}
-
Xianzhu Wang authored
When blink directly sets scroll offset in the scroll tree, we need to set the associated cc::Layer's NeedsPushProperties to ensure update of cc::LayerImpl's scroll related properties (see cc::LayerImpl::UpdateScrollable()). This reverts the change about cc::LayerTreeHost::LayerByElementId() in https://chromium-review.googlesource.com/c/chromium/src/+/2020554 because we still need it in layer list mode. Bug: 1048113 Change-Id: I686beebcf54e96cc517700c0f987aaceec880c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036834Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739043}
-
Peter Wen authored
Java targets use the contents of the res_sources_path file of all their dependencies to determine the resource_dirs value in the java target's build config. Thus these files need to be in its depfile through all_inputs. Also remove unused resource directory shortcut, and build/android/empty* Bug: 1049296 Change-Id: Icc8375bdeca1a4ba2d954a964a62bf852a81b788 Fixed: 1049296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042405 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#739042}
-
Luke Zielinski authored
Bug: 1049607 Change-Id: Id99fb07fc85539dad0d4928761e1abe2857541fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042371 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
-
Mustafa Emre Acer authored
The presubmit code for translation screenshots parses grd and grdp files modified in the CL. It does this by referring to the old and new contents of the files passed to it by the presubmit. grd files can refer to grdp files via <part> tags. This causes the messages in the grdp file to be included in the grd file. If a modified grd file's old contents refers to a now renamed or deleted grdp file, grd reader fails to open the grdp and crashes. This CL fixes this by ignoring <part> tags while loading grd files. This should be safe: The presubmit processes grdp files separately, so all grdp files should still be processed, just not when loading grd files. Additionally, grdp files cannot contain part files, so ignoring the tag while loading grdp files should also be safe. Bug: 1047487 Change-Id: I3d79aa028c4ae360d74a437a019628d0bdab494a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037027Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#739040}
-
Alex Ilin authored
This CL adds a new field to OAuth2MintTokenConsentResult proto, modifies the parsing function and plumbs this new field to GaiaRemoteConsentFlow::Delegate::OnGaiaRemoteConsentFlowApproved(). IdentityGetAuthTokenFunction is going to remember this gaia id and reuse the same account for the next calls. The usage of the gaia id will be added in future CLs. Bug: 1026237 Change-Id: Ieb407ee26d8b2ab9e4a4f4bb3c164f5c88c37440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042097Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#739039}
-
Rohit Rao authored
This will allow us to add dependencies to ensure that EG2 host apps are always compiled alongside their test modules. Previously, bots would incrementally compile only the test modules and then fail when the host app wasn't present. BUG=1019533 Change-Id: I42fca4f6767fba723dcb425b6485a1211c714b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949847 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#739038}
-
Jae Hoon Kim authored
BUG=b:145814572 Change-Id: I837389427d673c564fc2b3f147f8f56ac04e01ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036548Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#739037}
-
Manu Cornet authored
Split the |UpdateCollapseState| function in two: one const function |CalculateCollapseState| that returns a collapse state and the existing |UpdateCollapseState| that returns void. Also move the logic that alters the collapse state inside |CalculateButtonVisibilityForCollapsedState| out of that function and place it where it belongs. Bug: 1048119 Change-Id: I49eaa86f914cf9910b47afde698aa82c8eaa0aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040955 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Steve Kobes authored
This is a single browser test that verifies CLS metric values through four reporting mechanisms (web perf API, trace event, UKM, and UMA). Bug: 1045064 Change-Id: Ie1616e961b2771e792d9d2b15babaaa2125822d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943427Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#739035}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cc21d0c1f2ce..782a957f83c0 git log cc21d0c1f2ce..782a957f83c0 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 bungeman@google.com Update fontscalerdistortable to onOnceBeforeDraw. 2020-02-06 brianosman@google.com Remove SkMaxScalar and SkMinScalar 2020-02-06 egdaniel@google.com Switch SkImage_Base asTextureProxyRef to return view instead. 2020-02-06 tdenniston@google.com Reland: Initial checkin of GM verifier framework Created with: gclient setdep -r src/third_party/skia@782a957f83c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I9774f80862e32f00f906f64b1c9199fb79103960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042238Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d48320747592..74e27c36bc28 Created with: gclient setdep -r src-internal@74e27c36bc28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1010176 Tbr: jbudorick@google.com Change-Id: I65306687d4263b956435579a8298c32f94a00ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042241Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739033}
-
Kevin Babbitt authored
On non-desktop Windows SKUs such as Hololens, CreateStdAccessibleObject() will fail since MSAA is not available. That failure would cause us to exit LegacyRenderWidgetHostHWND::Init() before creating a UI Automation fragment root. Later on, an inbound UI Automation call would ask a web content fragment for its fragment root, we would attempt to look it up and find nothing, and crash. The fix is to ignore the failure from CreateStdAccessibleObject(). There are no subsequent calls in Init() that depended on it succeeding. I also took the opportunity to switch the return value to type void since the only caller wasn't doing anything with this information anyway. Bug: 928811 Change-Id: I11f63139575de131f41733be6f73192c118ec792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037963 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Cliff Smolinsky <cliffsmo@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#739032}
-
Rouslan Solomakhin authored
This patch adds a payment app factory for 3rd party native Android payment apps in accordance with the design at: https://bit.ly/cross-platform-pay-app-factory The factory is responsible for finding the payment apps (AndroidPaymentApp), filtering out apps that don't support the requested methods, verifying ability to use the method names, and querying the IS_READY_TO_PAY service when necessary. Bug: 1022512 Change-Id: Id3862e8a7e1aa6ace6ce70adde56cd90c20c23fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025229Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#739031}
-
Vasiliy Telezhnikov authored
GLPixelBufferRGBAResult in GLRendererCopier hold reference to context provider. When the results are sent to different thread we force all GPU work to happen before in ReadPixelsWorkflow::Finish, but we still hold the reference. If the results will outlive the SkiaOutputSurfaceImplOnGpu it will be the last reference and DirectContextProvider will be destroyed on a wrong thread. This CL fixes this by dropping reference to context_provider when we don't need it anymore. Bug: 1035881 Change-Id: I6e0bfe7013a61f96ec7f33d40bae377d6831ffc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041800Reviewed-by:
-
Mike Klein authored
SkTypes.h is the canonical way to get to this stuff. Change-Id: I3708082d0a4f2f5646f1040e83cce1c8b9967e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039131Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Mike Klein <mtklein@google.com> Cr-Commit-Position: refs/heads/master@{#739029}
-
Kyle Horimoto authored
After design discussions with jamescook@, we've decided to remove this enum, since it's not strictly needed for the metrics we're trying to compute (number of navigations until a setting has changed). This complexity is unnecessary at this time. Bug: 1047062 Change-Id: I6280115e051f9bbd67434e5a5faf25c1bc03854d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040913 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#739028}
-
Theodore Olsauskas-Warren authored
As part of the privacy settings redesign, the capability to display recently changed permissions to the user is required. This CL introduces the a handler to enable querying for this information from JS. The GetRecentSitePermissions provides the most recent permissions changes grouped by at most N unique origin/[incognito, normal] combinations. Existing functionality which is reused from the GetAllSites handler is also refactored out. Bug: 1032584 Change-Id: I885c859d455bc49d8ec9d91bf3101cf337c4ae51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002577 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#739027}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/065348503c2e..4f68f5398d7f git log 065348503c2e..4f68f5398d7f --date=short --first-parent --format='%ad %ae %s' 2020-02-06 sprang@webrtc.org Remove PlayoutDelayOracle and make RtpSenderVideo guarantee delivery Created with: gclient setdep -r src/third_party/webrtc@4f68f5398d7f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaeae7fdc7e992f09f8e6dd178d8d1f27ad1cd364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042239Reviewed-by:
-
Victor Costan authored
This CL makes the blink::CachedStorageArea constructor public and removes the Create*() factory functions. The functions recently became identical, with the exception of the blink::CacheStorageArea::AreaType value passed to the constructor. This small refactoring removes one layer of indirection, as well as the use of the bare new operator in the factory functions. Change-Id: I0e6606f3021771c712a79878d681290c3862acc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038035 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#739025}
-
Ayu Ishii authored
Bug: 1007677 Change-Id: Icb307b143a5776768d7b23e3c2d925b417d0dafa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040672Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#739024}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I150445ba27465e8949f6aafc954f5629ff075813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042242Reviewed-by:
-
