GitLab

When line breaker hits the end edge and looking for trailing items
such as trailing spaces, close tags, forced break, etc., under
certain conditions, it only includes trailing spaces and assume
it's done. When a forced break follows trailing spaces, this
behavior sends the forced break to the next line, causing an
unnecessary empty line inserted.

This patch fixes by setting the LineBreakState properly after it
handled trailing spaces.

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Idf591de35800479fe2be18dc5fc3a31f205b76b2
Reviewed-on: https://chromium-review.googlesource.com/992832Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547807}

VK_APPS is mapped to context menu key, which activates legacy menu on Android

Bug: b/822960
Test: manually tested with app in the solitia CQ app
Change-Id: Ic4ce4c5c0d3f0408cc2d1cb4c8601ec1a84c68df
Reviewed-on: https://chromium-review.googlesource.com/992355Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547806}

This updates the root stores for the 2018-01 update from Microsoft,
the macOS 10.13.0, 10.13.1, and 10.13.2 releases, the NSS CKBI 2.20
root store (part of NSS 3.35), and Android Oreo MR1.

This also introduces the concept of a 'legacy' SPKI, which is an SPKI
that is not trusted in the current Android or ChromiumOS root store.
This can be used to set more permissive policies for legacy Enterprises
that have relied on certain CAs being publicly trusted, despite not
adhering to the expectations of a publicly trusted CA.

BUG=none

Change-Id: Id2b358f1e46503deceaf9cd83256c8cd53ffe556
Reviewed-on: https://chromium-review.googlesource.com/990496Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547805}

Some more tests have started flaking on Windows in viz_browser_tests
with unknown timeouts. This disables them.

TBR=kylechar@chromium.org
TEST=viz_browser_tests

Change-Id: I7cc2c4a589d9517fcaf787f4a6aaa1642a1d6485
Reviewed-on: https://chromium-review.googlesource.com/993633Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547804}

This may resolve crashes seen in the WindowServer on swarming.

Tbr: miu@chromium.org
Bug: 828031
Change-Id: Iadbb4bcd74b03ab6abe75efc9b1f02a704ca3b74
Reviewed-on: https://chromium-review.googlesource.com/992453
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547803}

This works around a crash where a layout box references a filter that
contains a feImage filter primitive, which in turn reference content
that has a mask applied.

Bug: 814815, 825538
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib2433b3ba48b3ea56462a1eb64209d36aa37cfa4
Reviewed-on: https://chromium-review.googlesource.com/982114Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#547802}

In this part, we add the code to actually move the offline page,
update ADM, update the OfflinePageModel, and call back to the
java side code.

There is also a small refactoring to use the same symbol everywhere
for our database table name, it has moved into offline_store_utils.h.

Bug: 758690
Change-Id: Ia540cfdd9f94ac93a1211eb8b7184507b3906080
Reviewed-on: https://chromium-review.googlesource.com/985208
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547801}

Mac menus don't use a margin around the contents at all - the menu items
(especially their highlights) draw hard up to the menu edge.

TBR=sky@chromium.org

Bug: 828117
Change-Id: I0165bc8987d0f7d6c1ba29660098f91ad9478984
Reviewed-on: https://chromium-review.googlesource.com/993418Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547800}

gn analyze does not use depfile information, which causes it to not know
that builds need to happen when proguard flags change.

To work around this, this change marks the proguard_configs as inputs to
(somewhat arbitrary) java actions.

Bug: 827197
Change-Id: I1522daa0e3782ac1989cf4e234d8409663bf1357
Reviewed-on: https://chromium-review.googlesource.com/985900Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547799}

The race condition happens when UrlLoader::OnReceiveResponse() is
received, but the request is canceled in the meantime. In this case, there
are no more request and we must abort the loading.

It fixes the Android test:
android.webkit.cts.WebViewTest#testSetDownloadListener
in the Android compatibility test suite (CTS).

Bug: 828156
Change-Id: I6bd6c2e89ab055f05ddab51b5cddebf4ff93bb47
Reviewed-on: https://chromium-review.googlesource.com/993057
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547798}

I haven't landed a lot of CLs in this directory, but when the other
owners aren't around, I can step up and review not-too-complex CLs.

Here are the list of CLs I've landed - most of them are for IME and
tests though.

9195b0a9 Expose onCheckIsTextEditor correctly through WebView object
c1134a86 Allow user agent to be overridden in popup webview creation
68ee851d [WebView] Set up resources on non-UI thread in start up
eb8a057e Fix autofill focus handling for webview
a3970dd7 Add guarded logging for debugging webview autofill
2508b5fb Fix AwAutofillTest failure on L
00fe5149 More autofill tests for triggering, input types, and blur
9210616d Fortify autofill tests for WebView
ee89226f Revert of Migrate IME state update flow (patchset #4

e54ccdb9 Workaround for Samsung email issues
56ededfe Disable thread checking for LGE email app
f99c4ade Prevent thread assertion for HTC mail apk
5a6c5bf0 Overhaul WebView IME test
fcc3fbf1 Fix webview memory leak when keyboard was shown
945f5e29 Ensure input connection to be created on pressing next
button
cbfdec91 Resume cursor blinking on closing context menu
e04b8f53 Remove Android support for out-of-process KeyStores

id: 100001 of https://codereview.chromium.org/2777223004/ )
Change-Id: Ie9deb6e59fdc8d26af2da316c75c8c29eb87ebfc
Reviewed-on: https://chromium-review.googlesource.com/991402
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547797}

This reverts commit 802df057.

Reason for revert: suspected for causing memory regressions crbug.com/828026 and crbug.com/828027

Original change's description:
> Make CapurePageText capture textContent only on dirty layout
> 
> This is a partial revert for r536969 Change TranslateHelper to use a
> TextContent-like text dump.
> 
> r536969 is a workaround for a lifecycle violation bug that layout is
> still dirty after running layout update.
> 
> It turns out that textContent is not a good text dump for
> TranslateHelper, as pages may hide arbitrary content (e.g., JSON) in
> invisible text nodes, which can't be reliably filtered without checking
> element style or layout.
> 
> Since we don't always run CapturePageText() with dirty layout, there is
> no need to always dump textContent. Hence, this patch partially reverts
> r536969 that, we still dump innerText as long as layout is clean. We
> dump textContent only when layout is dirty, which is enough to get
> around the lifecycle violation bug.
> 
> Bug: 826174
> Change-Id: I63e97832caa9858e67992847fb9a22f6405183cb
> Reviewed-on: https://chromium-review.googlesource.com/984474
> Reviewed-by: Kent Tamura <tkent@chromium.org>
> Reviewed-by: Rachel Blum <groby@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547334}

TBR=groby@chromium.org,tkent@chromium.org,xiaochengh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 826174, 828026, 828027
Change-Id: I4c3200e5c7de0e6b3838ddcc40d53e751538f915
Reviewed-on: https://chromium-review.googlesource.com/992818Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547796}

https://chromium-review.googlesource.com/c/chromium/src/+/893401 added
a MockPlatform class in SourceKeyedCachedMetadataHandlerTest.cpp which
conflicts in jumbo builds with ResourceTest.cpp.  Let's rename one.

TBR=japhet@chromium.org

Bug: chromium:823663
Change-Id: I044cf979281fe4009601c3024139c57435fb4762
Reviewed-on: https://chromium-review.googlesource.com/992235
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547795}

Don't ask another function to do conditionally something the caller
could just do.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2fc0d8cf581f57ece9051a0a85bf0c2ac65dfabf
Reviewed-on: https://chromium-review.googlesource.com/993155Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547794}

Adds an experimental param on the connection robustness mechanism to
disable proxy bypass when the via header is missing.

Bug: 724704
Change-Id: I56286a06485b70c0c746850de14d79b2da755366
Reviewed-on: https://chromium-review.googlesource.com/990775
Commit-Queue: Robert Ogden <robertogden@google.com>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547793}

https://pdfium.googlesource.com/pdfium.git/+log/75304f915c5c..232b918d1f0f

$ git log 75304f915..232b918d1 --date=short --no-merges --format='%ad %ae %s'
2018-04-03 tsepez Re-arrange so inline vectors come last in structs.
2018-04-03 thestig Roll pdfium/third_party/freetype/src/ 713d68ee9..7109495c5 (21 commits)
2018-04-03 tsepez Off-by-one in CPDF_StreamParser::ParseNextElement()

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:828049


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I2892003f57e749fed8957a758722ec702d166bfd
Reviewed-on: https://chromium-review.googlesource.com/992888
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547792}

If the media starts playing whilst the loading panel is either showing
or cooling down we should hide it immediately as we are obscuring the
video.

BUG=827482

Change-Id: Ie0fb8159469fcc6740f624d052ac4b176f4f6876
Reviewed-on: https://chromium-review.googlesource.com/990192
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547791}

On further scrutiny of the Android codebase, the following constraints get used to identify |IsAccessibilityFocusable|, which gets used to decide whether a node contributes to the computed bounds of a node or not.

Any of these conditions makes a node "accessibility focusable", used here to mean "should use its rect" when sorting for child ordering
- actionable nodes
- top level scrollables with text

In ARC++, we cannot seem to rely entirely upon replicating the exact logic, but keep the spirit of what is meant. To that end, we want to sort nodes by layout.

This change gets much closer to what we want by:
- allowing computed bounds to be empty (meaning it has no meaningful content). In these cases, we simply rely upon tree ordering
- be very conservative when using a node's bounds. Only actionable nodes should matter. This potentially misses non-focusable nodes with text, or non-clickable nodes with text. However, mis-sorting a node is much much worse.

This change does not consider virtual hierarchies, which should likely not trigger reodering, since an author has explicit contorl over child ordering in those cases.

Change-Id: Iacffc5f2d88b6d52b732dadda8a01fd735665018
Reviewed-on: https://chromium-review.googlesource.com/989657
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547790}

Reorganizes the logic to make clearer when the Profile will be deleted
immediately, and when deletion can be deferred.

Preconditions are separated into separate DCHECKs to make the failing
conditions more visible, and basic information (e.g. RenderProcessHost
counts) are copied to the stack and base::Alias()ed, to appear in crash
dumps.

Bug: 720078
Change-Id: I2138b14d27a157883bc62aab3cccf6920891aa9f
Reviewed-on: https://chromium-review.googlesource.com/989120
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547789}

Change-Id: Ide6c3d4b2d9927dceb7b548200926c6933e9036e
Reviewed-on: https://chromium-review.googlesource.com/991396
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547788}

Bug: 825242
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I21ab64e7570f7600031dbf566fc46214051bbc67
Reviewed-on: https://chromium-review.googlesource.com/989034Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547787}

Just move the files and resolve all the includes, no functional change.

BUG=803135

Change-Id: Ib5a9d7958639526da697ba6556b0d9433d544cee
Reviewed-on: https://chromium-review.googlesource.com/991076Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547786}

Adding a key to cryptohome requires the associated UserContext. This
adds an AuthToken to quick_unlock which stores the UserContext
instance. The AuthToken automatically expires after a delay.

Bug: 623344
Change-Id: Ife3373599fb560dfe9f9055fcda54a9f001c6ac7
Reviewed-on: https://chromium-review.googlesource.com/980738
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547785}

Bug: 776495
Change-Id: Idfc2a6f82fa6bf6934e304c51eb2333659ce6f01
Reviewed-on: https://chromium-review.googlesource.com/993273Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547784}

Bug: None
Change-Id: I0d3f7a1228c935df57cb28cbcc5efc7dad4ea6f5
Reviewed-on: https://chromium-review.googlesource.com/989251Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547783}

NOTRY=true

Bug: 792780
Change-Id: I15c79b19873ea531c28d8b76105bf250bf112959
Reviewed-on: https://chromium-review.googlesource.com/992815
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547782}

new spec:
https://drive.google.com/file/d/1JNH0ZDknXSvV00C7TeT4xT_rFx48OdZd/view

Except this, UX asked to move icons 8px up and text 3px up.

Bug: 826064
Change-Id: Iad0b2df7e396f5563c3f8d6f9858750920561c8a
Reviewed-on: https://chromium-review.googlesource.com/990676
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547781}

https://chromium-review.googlesource.com/c/chromium/src/+/883944
restricted how often we would use shaders that clamped tex coords.
However, this confusingly regressed perf a little bit on Android,
which implies that program switching is expensive.

This patch changes GLRenderer to always texture clamp these quads
which reduces the number of shaders we use.

Bug: 806836,806826
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2b2e71b362d6a12f17758abe2edddf1759536016
Reviewed-on: https://chromium-review.googlesource.com/972546Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547780}

Make sure there is no text output when converting from PDF to PS for
text with size 0.

BUG=767343,827748

Change-Id: Id788b1f936d4f97b2201b7171a756a7ec2892bf1
Reviewed-on: https://chromium-review.googlesource.com/989299
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547779}

We probably already have enough crash reports from this that it won't
be useful to keep around, and there are good reasons not to keep uses
of dump-without-crashing around for too long.

Bug: 824024
Change-Id: Id02cd3eb11f436559b409df484ec204bfe6312aa
Reviewed-on: https://chromium-review.googlesource.com/991464Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547778}

This is to keep up to date with the logic change that the DBus service
uses. The logic has changed to use hard coded release version and
channel due to a bug in Finch.

BUG=chromium:800120
TESTED=manually tested.

Change-Id: Ic5c33d97c2100592732df4a0a14ab744197ec377
Reviewed-on: https://chromium-review.googlesource.com/987100Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547777}

Add a developerPrivate API function to install a file that was dragged
and dropped on the calling web contents, and add tests for the same.
This will allow us to move the MD extensions page away from using
chrome.send for this functionality.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id2b4f5417a94c330c516d4eb1432c59c89c31e32
Reviewed-on: https://chromium-review.googlesource.com/981119Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547776}

Recent regression from 1796079a

Bug: 827844
Change-Id: Ia29d752c0144d60e5e0fe74d6170671412375f0d
Reviewed-on: https://chromium-review.googlesource.com/991409Reviewed-by: Joy Ming <jming@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547775}

bustamanate@ reports occasional hanging on tests that use the
emulation server. This CL adds a timeout to ensure that a test
run doesn't totally hang because of a flake here.

Bug: 823776
Change-Id: I28bc040be9f9ae606f6b75481d2bf8dc21cc6957
Reviewed-on: https://chromium-review.googlesource.com/993272
Commit-Queue: Robert Ogden <robertogden@google.com>
Reviewed-by: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547774}

BUG=827329

Change-Id: I3ae863360df1b0374e367c094ca2c0d724c615c9
Reviewed-on: https://chromium-review.googlesource.com/986740Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547773}

This Cl annotates parameters to the SearchResult ctor. It only adds
comments. There's no logic changes.

Bug: None
Change-Id: Icb625ce10e6fb61216250c96e62057e1d7c9091b
Reviewed-on: https://chromium-review.googlesource.com/991397Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547772}

Allow extended mouse buttons to be injected via the automation code.

BUG=680741

Change-Id: I2a9936e813abf9e5d0d5d3ee6dc98d44477f47f5
Reviewed-on: https://chromium-review.googlesource.com/986469
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547771}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df968af49923..5e34303e0ea1

$ git log df968af49..5e34303e0 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ib5275c5feee22740503048f4459e9ec282dd0145
Reviewed-on: https://chromium-review.googlesource.com/992882Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547770}

This CL previously landed as
https://chromium-review.googlesource.com/c/chromium/src/+/842306
It was reverted because TabLifecycleUnits were not always
destroyed when tabs were closed, which caused invalid memory
accesses. This was solved by
https://chromium-review.googlesource.com/c/chromium/src/+/980587

TabManager discards tabs, but also ARC processes.
LifecycleUnit is an abstraction to help us having one
code path for all discards.

TBR=chrisha@chromium.org,thestig@chromium.org

Bug: 775644
Change-Id: Ib7f3dfd8b7e9b43ad75020c65e12d94229ba1a07
Reviewed-on: https://chromium-review.googlesource.com/980742Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547769}

This CL adds extra space above the search controls to make vertical
padding symmetric.

Screenshot: https://imgur.com/a/Txjbq

Bug: nonw
Change-Id: I1d8151a8320897c40b621f32d8c6960dab8d977b
Reviewed-on: https://chromium-review.googlesource.com/981174Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547768}