- 05 Oct, 2018 40 commits
-
-
Jialiu Lin authored
During the migration to IdentityManager, we noticed that some Arc* related tests setup are incomplete, such that they will potentially fail after IdentityManager migration. This CL adds more initial test setup to seed AccountTrackerService and SigninManager properly. No behavior or logic change. Bug: 883318, 892116 Change-Id: I4db443d7bd0c7df396e1c188743b869d2b9c2e82 Reviewed-on: https://chromium-review.googlesource.com/c/1265079Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#597361}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/37377c3e485a..edc5b1e7e7ce Created with: gclient setdep -r src-internal@edc5b1e7e7ce The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8d1f51e216bc8a187eec60a8f385528ca80dfb46 Reviewed-on: https://chromium-review.googlesource.com/c/1265917Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597360}
-
Aiden Benner authored
First iteration of the JNI annotation processor for static methods. Adds a new annotation @JNIStaticNatives that when used on an inner interface, will trigger the annotation processor to generate native declarations and a wrapper class. I provided a sample usage in example/jni_generator/SampleForAnnotationProcessor.java Change-Id: If888b6fd41eafccb54af32aebde3a850bab55849 Reviewed-on: https://chromium-review.googlesource.com/c/1239348 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#597359}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/78df3362ac21..450bf36f7918 git log 78df3362ac21..450bf36f7918 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 ynovikov@chromium.org Workaround Adreno driver not supporting unsized EXT_texture_rg formats Created with: gclient setdep -r src/third_party/angle@450bf36f7918 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ica3053cf8d719ea3d2b94352c089ad26df8cccd4 Reviewed-on: https://chromium-review.googlesource.com/c/1265916Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597358}
-
Chris Harrelson authored
Also, rename the recursive recalc methods to remove the "AfterStyleChange" suffix, because it may not only be due to style, and the update is not going to happen right after style soon. This is a pure refactoring patch. It is step 1 of work to split work to recompute visual overflow from work to recompute layout overflow. See the referenced bug for more details. Bug: 892347 Change-Id: I791c143da4486763cea256036fc4c68b1cf79264 Reviewed-on: https://chromium-review.googlesource.com/c/1265509Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597357}
-
Xiaoqian Dai authored
The refacotring CLs exposed an underlying issue that caused b/117075672. I need to revert all the refactoring for now, and fix the underlying issue first and then reland these refactoring cls. Basically the assumption of "--enable-touchview" USE flag is not longer true, thus Chrome can't reply on this flag to decide whether a device is capable of entering tablet mode. We need to find other ways to do so. Since it's a pure revert, TBR xiyuan@. Revert "TabletModeController refactoring II." This reverts commit 43b3f48d. Revert "TabletModeController refactoring III." This reverts commit 95f93d44. Revert "Fix the regression caused by the refactoring." This reverts commit 5b0a138d. Bug:887042, b/117075672 TBR=xiyuan@chromium.org Change-Id: I494a8d05be1fb07bea404cd714b0b1d9689e46d4 Reviewed-on: https://chromium-review.googlesource.com/c/1265996Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#597356}
-
mrefaat authored
Some websites try to open itunes app, then redirects immediatly to http itunes url, in that case Chrome present app launch prompt and while it's there itunes url is loaded, so it allocates a storekit view and tries to present it and fails. The problem is on subsequent itunes http navigations, the coordinator check if there's a controller allocated, if so it will exit. And because the one allocated in the previous case was never dismissed it breaks the expected behavior. Bug: 892503 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie08160e37c6f27c02a081e06c9b956bc835cf4c7 Reviewed-on: https://chromium-review.googlesource.com/c/1263876 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#597355}
-
Findit authored
This reverts commit ccb83d4a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 597330 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NjYjgzZDRhNTUxMjgwMmYxMTkzYTUwNmI1NDMxZTg1ZTAxMzgwNDMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8190 Sample Failed Step: compile Original change's description: > Implemented AXVirtualView > > Some widgets in Views, such as table and tree view controls, make use of lightweight objects to display their contents. > These lightweight objects are not View classes and hence have no native accessibility support. > To make them accessible, we introduce a virtual accessibility view that will be used to provide the accessibility support for those objects. > In addition, we could make use of virtual accessibility views to override the children of a real view and create a completely new accessibility tree hanging off that real view. > This creates more flexibility as it allows us to construct a virtual accessibility tree that is not always a mirror image of the hierarchy of the real views. > R=dmazzoni@chromium.org > > Bug: 101762 > Tested: unit tests > Change-Id: Iab8fea36ef44373e06d9408c407a27caa7c4219c > Reviewed-on: https://chromium-review.googlesource.com/c/1229234 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597330} Change-Id: Icc03389f14319c85bc30b101c9f30cc25aa16b75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 101762 Reviewed-on: https://chromium-review.googlesource.com/c/1265877 Cr-Commit-Position: refs/heads/master@{#597354}
-
Ned Nguyen authored
BUG:760498 This also reshard android_nexus5x_fyi_4_shard_map.json which may cause shifting data of heap_profiling.mobile.disabled benchmark TBR=pasko@chromium.org Change-Id: I561d9fbd628b2f53f6e043b524b93c32b03c56d1 Reviewed-on: https://chromium-review.googlesource.com/c/1265129 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#597353}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/be4e055bce62..b20364c99015 git log be4e055bce62..b20364c99015 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 thestig@chromium.org Make CPDF_RenderStatus matrix params const-ref. 2018-10-05 rharrison@chromium.org Remove SetSaveCalled API 2018-10-05 thestig@chromium.org Add methods to read specific field flags in CPDF_FormField. Created with: gclient setdep -r src/third_party/pdfium@b20364c99015 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If62ef591bb2d525a0c73c6192ea89464629d4778 Reviewed-on: https://chromium-review.googlesource.com/c/1265915Reviewed-by:
-
Kyle Horimoto authored
(1) Previously, <multidevice-setup> contained the following line: <slot name="forward-button" slot="backward-button"></slot> This should have read: <slot name="forward-button" slot="forward-button"></slot> (2) Change closing </paper-button> to </div>. These didn't seem to cause an error as the page still rendered correctly, but this CL fixes these issues anyway. Bug: 884058 Change-Id: Ib7131d3126f664c8dd4f7aac82f94ce0bf28e8dc Reviewed-on: https://chromium-review.googlesource.com/c/1255048 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#597351}
-
Erik Luo authored
Bug: 867940 Change-Id: If4fdb0c6f0e5a9eab22de9b05e226d215de73026 Reviewed-on: https://chromium-review.googlesource.com/c/1262963Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#597350}
-
Vladimir Levin authored
When the visual rect of the table row changes due to the cell's frame rect changing, we don't current invalidate the visual rect. This patch addresses that. R=wangxianzhu@chromium.org Bug: 892647 Change-Id: Iaf5de6f4b801175bb6e0a4e3e6df92468400451e Reviewed-on: https://chromium-review.googlesource.com/c/1265896Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597349}
-
Pedro Amaral authored
Announce for accessibility when the normal or incognito tab stack is selected. Bug: 892638 Change-Id: I8ca8e37d8374e5f57e8b4ef5181c05d00322158e Reviewed-on: https://chromium-review.googlesource.com/c/1265031Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#597348}
-
Xiaohan Wang authored
Adds cdm_type_converters.{h,cc} which collects all type converters between cdm:: and media:: types. Some conversion functions are renamed for consistency. Bug: 707128 Test: No functionality change. Change-Id: I0ac755f8820d4cf719f3b2c6c6885ec21f45f129 Reviewed-on: https://chromium-review.googlesource.com/c/1260488 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#597347}
-
Jared Saul authored
Please see the bug for the detailed cleanup plan. Bug: 891912 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifdb7cb4718917cdbf4f3e5137fe47a3c98c83997 Reviewed-on: https://chromium-review.googlesource.com/c/1260011 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#597346}
-
Krishna Govind authored
R=benmason@chromium.org Change-Id: I9435277c7769d1480196a1be52657a118332416b Reviewed-on: https://chromium-review.googlesource.com/c/1265876Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#597345}
-
Khushal authored
Use the conservative of the repetition count specified by the image and the animation policy when selecting the final repetition count for animated images. R=chrishtr@chromium.org Bug: 892683 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I32507feca552302cca43db4ccbbb0ba9c82ca152 Reviewed-on: https://chromium-review.googlesource.com/c/1265080Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#597344}
-
Robbie McElrath authored
Fix ExtensionWebRequestApiTest.WebRequestApiDoesNotCrashOnErrorAfterProfileDestroyed with network service on chromeos. This fixes ExtensionWebRequestApiTest WebRequestApiDoesNotCrashOnErrorAfterProfileDestroyed on chromeos with the network service enabled and removes it from the buildbot filter. Profiles in chromeos have to be associated with a user_manager::User unless it's the signin or lock screen profile. This makes chromeos::ProfileHelper always return the primary User when queried, which makes ProfileImpl think the new profile is associated with a user. Change-Id: Ic7a707da97891d6e86e5bb2b3a29a2f931f45429 Reviewed-on: https://chromium-review.googlesource.com/c/1260362Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#597343}
-
John Z Wu authored
Bug: 770984 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iad12bba9a759ba69771606144d8cec7f68b61eb2 Reviewed-on: https://chromium-review.googlesource.com/c/1257891Reviewed-by:
-
James Cook authored
This allows testing ChromeVox with multiple simultaneous mash apps. * Turn on a11y support in AuraInit::InitParams * Initialize ash window property transport Bug: 888147, 892743 Change-Id: I3114787aa687dd6a233b7411739fa3f938cf4399 Reviewed-on: https://chromium-review.googlesource.com/c/1265535 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#597341}
-
Jun Mukai authored
This expectation fails due to the button which is showing with Mash. This is basically for developers, so it's okay to skip the checks. BUG=892730 TEST=interactive_ui_tests Change-Id: Ibebe65891bdbb1d9539e89f42114c39435ff2737 Reviewed-on: https://chromium-review.googlesource.com/c/1265895Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#597340}
-
Matt Menke authored
This matches behavior of all other browsers. WPT tests were recently updated to check for the more common behavior, instead of Chrome's divergent behavior, so this CL also updates the expectations of a number of layout tests. Bug: 891251 Change-Id: I3b0b091fe52000d1adb597c7fe6491dd3d2371c4 Reviewed-on: https://chromium-review.googlesource.com/c/1256284 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#597339}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ef8a3eb5221c..4d6f60512341 git log ef8a3eb5221c..4d6f60512341 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d62b62d8..7099444b (597059:597172) Created with: gclient setdep -r src/third_party/webrtc@4d6f60512341 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I699f5ddfb91ba80f43580c16f7eb1544c64c0a45 Reviewed-on: https://chromium-review.googlesource.com/c/1265050Reviewed-by:
-
Becca Hughes authored
Add UMA metrics for tracking audio focus events. There are three histograms added in total; the first records RequestAudioFocus calls, the second records AbandonAudioFocus calls and the third records requested AudioFocusTypes. In the future we will probably switch these with UKM but UKM is not available for ARC++ yet. BUG=883958 Change-Id: I1092b9d1c638a13526687ac77b87d66490e4b89c Reviewed-on: https://chromium-review.googlesource.com/c/1238871 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#597337}
-
David Trainor authored
If we've failed to grab a thumbnail for a particular content id, don't try again to avoid lots of wasted file access and computation. BUG=892320 Change-Id: I9d980c0cce1644f2c0da3d8699c5e25e220af8f0 Reviewed-on: https://chromium-review.googlesource.com/c/1263416 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#597336}
-
Tommy C. Li authored
After this CL, when the user opens the page info bubble (for instance by clicking the lock icon), Chrome shows the full URL in the search bar. This is a way for users to show the full underlying URL for both the Steady State Elisions and Query in Omnibox features. We are currently gating this behavior on the Query in Omnibox flag, since it's still under active experimentation. Bug: 874592 Change-Id: Icdb1b8ac79f6f8f3a90b9f82dcd838c5af6b767f Reviewed-on: https://chromium-review.googlesource.com/c/1265497 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#597335}
-
Ryan Hansberry authored
Bug: 892477 Change-Id: If64554bc2e0a779c896520bcee25d7948b873200 Reviewed-on: https://chromium-review.googlesource.com/c/1265899 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#597334}
-
Xianzhu Wang authored
Such objects are not actual stacking contexts. For now we know LayoutTableCol is one of such objects for now, though it should support effects (crbug.com/892734). Bug: 890615 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7fe4b09e5b95731b0ce3805583b6391677419216 Reviewed-on: https://chromium-review.googlesource.com/c/1262927 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597333}
-
Marijn Kruisselbrink authored
The test is still flaky on Linux TSan builder. Tbr: mpearson@chromium.org Bug: 891959 Change-Id: I1233fb7a8fb60465064e5e4bd80fcc5a57e41858 Reviewed-on: https://chromium-review.googlesource.com/c/1265823Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#597332}
-
Matt Menke authored
The latest spec can be found at https://mimesniff.spec.whatwg.org/ In particular, this CL makes the parser: * Trim whitespace within quotes. * Not ignore first "(" in a charset or anything after it. * Allow quoted empty strings. * Prefer values closed to the beginning of the string. This makes a number of previously failing WPT layout tests pass, though there still remain some deviations from the spec: * When there are multiple Content-Type lines, we use the last. * We don't restrict the characters we allow in Content-Type fields. * We trim whitespace before the first quote characters (The spec indicates that if there's a space after the "=", it's treated as a non-quoted string). Bug: 788491, 772343 Change-Id: Ieeb11eb76d824a9df5130d8c5dc0be3b442ca366 Reviewed-on: https://chromium-review.googlesource.com/c/1257443 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Nektarios Paisios authored
Some widgets in Views, such as table and tree view controls, make use of lightweight objects to display their contents. These lightweight objects are not View classes and hence have no native accessibility support. To make them accessible, we introduce a virtual accessibility view that will be used to provide the accessibility support for those objects. In addition, we could make use of virtual accessibility views to override the children of a real view and create a completely new accessibility tree hanging off that real view. This creates more flexibility as it allows us to construct a virtual accessibility tree that is not always a mirror image of the hierarchy of the real views. R=dmazzoni@chromium.org Bug: 101762 Tested: unit tests Change-Id: Iab8fea36ef44373e06d9408c407a27caa7c4219c Reviewed-on: https://chromium-review.googlesource.com/c/1229234 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#597330}
-
Gabriel Marin authored
Original CL: - https://chromium-review.googlesource.com/c/chromium/src/+/777963 Make some tcmalloc constants truly const. Change-Id: I84e036d5c71373ce3572d4b67b06fcadb25bb347 Reviewed-on: https://chromium-review.googlesource.com/777963 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#517642} BUG=724399,b:70905156 Change-Id: I21e732e8001eeea57b7fea95cc9ec6df21f12dea Reviewed-on: https://chromium-review.googlesource.com/c/1130809Reviewed-by:
-
mrefaat authored
Detect download failure when a corrupted PDF was downloaded and log the OpenIn download result in all cases. Bug: 888545 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I19eefd9c1b6da0c9d6b18bfcc0f3953fb33ef391 Reviewed-on: https://chromium-review.googlesource.com/c/1259295Reviewed-by:
-
Henrique Nakashima authored
Change-Id: Icd771944352b9c161933c477fe714492aa38bbe7 Reviewed-on: https://chromium-review.googlesource.com/c/1265637Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#597327}
-
Xiaohui Chen authored
Disable screen reader reading voice query result because Assistant is going to respond with voice anyway. Bug: b:113734839 Test: locally build and test Change-Id: Ifa1079a6c551e8682857b8ab8e8afe0dd05218a7 Reviewed-on: https://chromium-review.googlesource.com/c/1232883Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#597326}
-
Marijn Kruisselbrink authored
Bug: 892772 Change-Id: Id0359aeda04a4d4fbe41d3b7b6fb6df8897da60f Tbr: schenney@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1265816Reviewed-by:
-
Ken Rockot authored
Adds a new ServiceBinding helper to the Service Manager's client library. This is intended as a replacement for ServiceContext, because ServiceContext is cumbersome in its insistence to own the corresponding Service object. ServiceBinding, like ServiceContext, deals with the IPC interface between a local Service instance and the Service Manager, exposing interesting events to the Service implementation while also providing it access to its Connector and assigned Identity. Some particularly gnarly tests have been updated to use ServiceBinding in lieu of ServiceContext. Furthermore, without ServiceContext and with a lot of its legacy motivations gone, ServiceRunner isn't terribly useful either. The tests have also been trivially updated to manage their own MessageLoop instead of using ServiceRunner. This is the first in a series of patches which aim to completely eliminate ServiceContext, ForwardingService (in service.h), and ServiceRunner, requiring Service implementations to write a little more boilerplate in exchange for flexibility with ownership semantics. Bug: 891780 Change-Id: Ib0c1d3263f34a5e33a167a8187edad1d52413f73 Reviewed-on: https://chromium-review.googlesource.com/c/1259485Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#597324}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cc81511e. With Chromium commits locally applied on WPT: 65d72632 "Make DTMF tone change more deterministic" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25886 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: Ie11269620d31a49ab9ae1640a6e6edf4fb96c4af Reviewed-on: https://chromium-review.googlesource.com/c/1265027 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#597323}
-
Raymond Toy authored
The Media nodes should be on the AudioContext, not BaseAudioContext. Make it so. This also implies that the constructors for these nodes should take an AudioContext, not BaseAudioContext. Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/H29uXnsIN54/BKXDqxoJAQAJ Chrome feature entry: https://www.chromestatus.com/feature/5258622686724096 Bug: 845913, 842225, 697123 Change-Id: Ic2a82a2343fa4a169a26733375c646fec61769ed Reviewed-on: https://chromium-review.googlesource.com/c/1069692 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#597322}
-
