- 27 Jul, 2020 40 commits
-
-
Austin Eng authored
In preparation for updating WebGL's bindings to use V8 FastCalls, this CL adds some helper classes to assist in safely implementing Fast bindings. The WebGLFastCallHelper provides mechanisms for setting up a scoped temporary object which toggles the in_fast_call_ bit automatically on construction/destruction. And, it provides mechanisms to signal deopt or defer WebGL warning/error messages. Bug: chromium:1101475 Change-Id: I2d9d355fc9fb3d510130fc2cb729769e9e349885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309143 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791970}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595851043-c48b6bdf39deda41f847276998118df921bfd4ef.profdata to chrome-mac-master-1595872800-d57a770d7bc200213efd65ae14b0000c1824f2dd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I00f39b5d34f78d9dd8dcf76cf0b7f873988545c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321090Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791969}
-
James Cook authored
Specifically, record a "launch_on_login" pref whenever lacros successfully starts. Set the pref false when lacros terminates. Prefs are flushed to disk periodically, so this means the pref is in the right state even if ash-chrome crashes mid-session. Bug: 1109050 Change-Id: If7ca21a570b73b56cbbef838cf59526034092b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318648Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#791968}
-
Luis G Garcia authored
Validate the provided view for XrWebGLBinding::getCameraImage(...) is contained within the provided frame. Design Doc: https://docs.google.com/document/d/1X4zhSCYqzOKrbC4iGA5SOV983vmI0mqz9tQxRvyrYlk/edit?usp=sharing Fixed: 1100978 Change-Id: I0177303e67d7ffc7da7a79d5b781d5f2b9b51959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315639 Commit-Queue: Luis Garcia <luisggarcia@google.com> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#791967}
-
Lijin Shen authored
Google material standards usually prefer curly double/single quotes to neutral quotes. The presubmit detects these punctuations in string resources and then prints warnings. Bug: 1100941 Change-Id: Id85ef0a9f299fccc0fabe795e6e1bb385d5379ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319541Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#791966}
-
Regan Hsu authored
Before, the terms of service link would cause the OS settings window to navigate to the ToS page without a back button. Fixed: 1096892 Change-Id: Ieb8452ad969013e4242b7552d3fb4bcb0daadf5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314159Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791965}
-
Archana Simha authored
Add methods for to get and set dictionary, time and list extension specific ExtensionPrefs. Design Doc: http://go/extprefrefactor Bug: 1069560 Change-Id: I4afa211b9eb1a15f87797cb3cea6e20da9fe47ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314992 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791964}
-
Dylan Cutler authored
The CookieStore spec recently changed to disallow setting cookies using this API: https://github.com/WICG/cookie-store/pull/150 This CL updates the implementation of CookieStore in Blink to perform this additional check and updates the web platform tests to reflect the new changes to the spec. Bug: 1108964 Change-Id: I1bc60332551308498509c0e8bbc6823bd8375ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316622Reviewed-by:
Ayu Ishii <ayui@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#791963}
-
Chris Sharp authored
Bug: 1018157 Change-Id: Ic42b98cb72897d43ea140dbf5ad8470c724b8e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295706 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791962}
-
Daniele Castagna authored
crrev.com/c/2220875 added buffer timing infos to latency metrics. This CL adds the new viz breakdown entries to GetStageName and histograms.xml in order to record UMAs. Additionally, this CL adds a NOTREACHED in GetStageName to make sure if we add another viz breakdown entry we catch if we forget to add the entry in that function. Bug: 947077 Test: about://histograms now contains SubmitCompositorFrameToPresentationCompositorFrame.BufferAvailableToBufferReady and the other entries Change-Id: I0542eb3fda4de50e6396579c89587012c9944a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316412Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#791961}
-
Randy Rossi authored
onTtsEvent() should null out currentUtterance_ like 'interrupted' and 'end' events do. Otherwise, the call to startSpeakingNextItemInQueue_ will bail immediately since it thinks an utterance is still speaking. Bug: NONE Test: cast on display assistant after TTS_EVENT_ERROR dispatched to chromevox Change-Id: Iee5b35d763e526f85ace9d9bfcef85580ca61291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317986Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#791960}
-
Daniel McArdle authored
Bug: 1052476 Change-Id: I22813f7509da06b51cb83837b829801a830a5c7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318050Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#791959}
-
Dominic Mazzoni authored
Some of these are tracked in a PLX dashboard, which the automatic bot that extends deadlines doesn't catch. All of these are still interesting and things we still need to track. Bug: 1088520 Change-Id: Idc3718fad9fff4f9109e971d00227c471e3d75a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319339 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#791958}
-
Andre Le authored
Enable the redesign of UI to show more information when device is managed. New UI screenshot: https://screenshot.googleplex.com/OoKao0qUf8O https://screenshot.googleplex.com/9wiTBpnxxc1 BUG=921267,1076316 Change-Id: I175f07aefc760fcbff7bd200c748350fbaec43bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316154Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#791957}
-
Lukasz Anforowicz authored
Before this CL, the test would look for "Process Model Internals" substring in page contents. This substring is present, but is populated dynamically in the "Frame Trees" pane: - WebContents: Process Model Internals, 1 frame. To make the test less dependent on when the dynamic text is added, this CL starts looking instead for "Process Internals" substring which is statically present in //content/browser/resources/process/process_internals.html Additionally, after this CL the test inspects page contents via gMock, rather than via innerHTML.search API. Hopefully, the change in this CL will make test failures easier to diagnose in the future (i.e. gMock should display mismatched |page_contents|). Before this CL, the test failure would just say that |innerHTML.search| API returned -1. Bug: 1107995 Change-Id: I83e5f45563a780b5dc8919e36ad71b2e171ac2ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317852 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#791956}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4181.3-1595240638-benchmark-86.0.4208.0-r1 to 86-4183.25-1595848892-benchmark-86.0.4208.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I835a2d5e73b782212458eadf7ddf13287c46ab0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321015Reviewed-by:
-
Jeff Yoon authored
Passing xctest to the iOS test runner (run.py) for unittests to run with the xc test runner object. This requires the GN argument enable_run_ios_unittests_with_xctest to be True. Bug: 1001667 Change-Id: Ib7f14c5835dbe4a116f11074646704bee8754d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314134Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#791954}
-
Guillaume Jenkins authored
In preparation for moving ReportScheduler to components, the kLastUploadTimestamp and kCloudReportingEnabled prefs name must first be moved to components. Only the names are moved, so platforms need to register their own copy of the prefs. Bug: 1092432 Change-Id: I49e8bb1dd7c037de1ed5c729c42965a4cef5734c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303024 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
Yann Dago authored
Bug: 1095307 Change-Id: Ia2f45e05154e0cbd129c6aac1284c76aa23a00ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316337 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Adrian Taylor authored
Each time a dependency is changed, the script will now check for known vulnerabilities. This is not perfect since ideally we'd be checking on a regular cadence; it's likely that equivalent functionality will be moved into Vomit or some other automated system in the future, but this is a good interim step to ensure that a large fraction of Chrome's open-source dependencies (212 out of 717) have some automated monitoring for vulnerabilities, where they previously had only manual monitoring. Testing done: * Add this line to build.gradle and ensure fetch_all.py fails with the desired diagnostics. compile "org.jetbrains.kotlin:kotlin-stdlib:1.2.70" * Add --ignore-vulnerabilities and ensure it continues. Bug: 1105911 Bug: 895969 Change-Id: If017d73765ef366959595facb000fc52a528cd08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317706 Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#791951}
-
Maria Villarreal authored
Issue: - When On startup setting is set to "Continue where you left off", the initial focus is not set after launching the browser. - Users have to press Tab to focus the window. - This affects users who rely on screen readers since the window information is not announced on launch (on UIA mode). More context: - The line calling SetInitialFocus was previously in the code but got removed after a startup focus refactor: https://chromium-review.googlesource.com/c/chromium/src/+/1313728 - The refactor added the call to RestoreFocus on BrowserView::OnWidgetActivationChanged if the property restore_focus_on_activation_ is set to True. This property gets set during BrowserView::Show, but only in the case of session restore, Show gets called after OnWidgetActivationChanged so RestoreFocus is never called. - The inverted call stack on session restore is because AddRestoredTab on browser_tabrestore calls Activate before showing the window. Fix: - Similar to what we currently have for MacOS, only call Activate in AddRestoredTab if it is not |from_session_restore|. This way Show will be called before Activate and thus focus will be set as expected. - This change is only made on Windows due to a couple of reasons 1) crbug.com/1102685 is only present on this platform. 2) Making this change on Linux would re-introduce crbug.com/1019048. Bug: 1102685 Change-Id: I6e62ebad7693eb5d908770364ba7c8d755ccaa70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284382Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Liquan (Max) Gu authored
Change: * Move NativeObserverForTest from PRImpl to CPRImpl. * Use a visible-in-test setter to set the observer instead of passing it from the constructor, so that ComponentPRImpl can own it (it's PRFactory who instantiates PRImpl). * Clean up unused variable PaymentRequestTestBridge#skipUiForBasicCard Bug: 1107102 moving a "ForTest" class, not adding any new one. Binary-Size: Silence the "for-test" alert because this CL is only Change-Id: Id384208f27eaa1830288402c7dc30be8be24bebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317835Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#791949}
-
Richard Knoll authored
When FastInitiationManager calls the |error_callback_| from StartAdvertising we destroy the instance in NearbySharingServiceImpl. After that we can't access local fields anymore as they point to freed memory. Bug: b:154846208, 1109581 Change-Id: Ibdecd4c5759051b778ce833a0f70debd2b9b8e3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320174 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#791948}
-
Theresa Wellington authored
Disable two tests that cause Pie x86 bot to flakily fail: - #testErrorPageNotRecorded - #testBackgroundedPageNotRecorded TBR=alexilin@chromium.org BUG=1062055 Change-Id: I1ddd909312dc4a51b97a8943bec828d6bf7951e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320084Reviewed-by:
-
Sophey Dong authored
Bug: 1109649 Change-Id: Idc383783d2eb0e5a03fee54dcf19aa61e5f28124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318555Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#791946}
-
Miriam Zimmerman authored
This metric will be used as a denominator for the recently-added Crash.Sender.FailedCrashRemoval metric. BUG=chromium:1060019 TEST=CQ Change-Id: I7f2781cafcebe2b70e668d98ffde42403d432772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317297Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#791945}
-
Ben Blake authored
This change implements an accessor in the AutofillClient interface. In the case of ChromeAutofillClient and AwAutofillClient, we can access WebContents::GetLastCommittedURL(). In the case of ChromeAutofillClientIOS and WebViewAutofillClientIOS, we can access WebState::GetLastCommittedURL(). TBR=tobiasjs@chromium.org,mahmadi@chromium.org Change-Id: Iaa6eb19dee88bb5870a8c59b8603ae1f8591c5e6 Bug: 1093057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289355 Commit-Queue: Ben Blake <fiorito@google.com> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#791944}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.25-1595237914-benchmark-86.0.4208.0-r1 to 86-4183.39-1595845830-benchmark-86.0.4208.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I242532002127694099c42ecc012ad10db5d689f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320204Reviewed-by:
-
Evan Stade authored
The Android file has been unused since b63cf141 Bug: 1097271 Change-Id: I740d6483792113c73d9d0d47614dde0f73c673fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317298 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#791942}
-
Ayu Ishii authored
Bug: 1054441 Change-Id: I9ef24a035cd9942a3a9196509ac550221ae53005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315219Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#791941}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/34c9aac3f30d..25a8165f50bc 2020-07-27 rharrison@google.com Clean up issues discovered by Infer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I639cfa98d922ae7c3762a6ac440fab595fd3175e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320198Reviewed-by:
-
Robert Sesek authored
The order of the get_parts() dict is different between 2 and 3, which causes entitlements to be copied in different order. Fix this by sorting the entitlements before processing. Also fixes a bytes vs str issue and a set() stringification difference. Change-Id: If3e5594ce1e9d505a2ce2e3042c35a257f121daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320414Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#791939}
-
Zhenyao Mo authored
BUG=711140 TEST=none TBR=asvitkine@chromium.org Change-Id: Idb70f3b9d518523eeb7ef2d27cea98e0b056e481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320415Reviewed-by:
-
Theresa Wellington authored
TBR=sinansahin@google.com BUG=1109965 Change-Id: I157f44d8557a457390321194e9e81be53fe2ea07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319344Reviewed-by:
-
Xiaohui Chen authored
Name cannot directly use binary data, convert to base64 instead sans the path divider. Bug: None Change-Id: Ibb0a7d4dfe749fee50ac2812b55280850f1284ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318479Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#791936}
-
Ken Rockot authored
This CL moves Chrome's renderer-side error page auto-reload behavior implementation to a new browser-side NetErrorAutoReloader helper within the error_page component. Correpsonding tests are rewritten as browser tests within components_browsertests. Bug: 1098578 Change-Id: I42e7af0a3d23364d5065e474312f35620299ff54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302927Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#791935}
-
My Nguyen authored
As policy is disabled by default, giving managed users more choices when the policy is enabled. Bug: 1108233 Change-Id: I86a2dd347116ea78d72134261fdc51c80f6d0d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312023Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
-
George Steel authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2303353 addressing post-submission comments. Add missed test case and fix list sorting. Bug: 1105144 Change-Id: I307065b3a8f4915a8b400c328ef2998fa8305e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314296Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#791933}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.25-1595242326-benchmark-86.0.4208.0-r1 to 86-4183.39-1595842708-benchmark-86.0.4208.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I49798df8826d23fdb5605a86771cb80e7ee5ab0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320201Reviewed-by:
-
Henrique Nakashima authored
This fixes some lint warnings, so we can remove the suppressions. Bug: 1107950 Change-Id: Idbe53038d4595fb571d374f04665671dd68e4d93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310789 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
-
