GitLab

The tabs are ordered from the most recent to the least recent ones
in the tab grid and carousel in start surfaces.

Bug: 982018
Change-Id: I974c492555751c5f2d7eebe8c6d871d05a41fb22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746907Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Auto-Submit: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688515}

Changed NULL to nullptr where the presubmit complained (due to new line wrapping).

Generated by: https://chromium-review.googlesource.com/c/chromium/src/+/1689216

Bug: 981415
Tbr: gab@chromium.org
Change-Id: I9c7ea90816e2a2418981108f657bc52cee8c06ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703541
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688514}

Currently in this function, we apply a roundf on a double value. We
should never do a roundf on a double value, it should just be round.

Bug: 994800
Change-Id: I6208d9db51661b2587ba54f949b9945ec47dcf3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761690
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688513}

This change adds a UI flag for the password leak detection feature.

Bug: 986298
Change-Id: I0dde3c0afa4464bd97bd11c57b8fa7b5de7a8600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761605
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688512}

This didn't serve any purpose anymore, since fragmentation of
inline-level floats is currently broken (no pun intended). See
crbug.com/915929

Change-Id: Ib852e68daae9d0ebe47f844d7395ae897100d047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761274Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688511}

This is the same as crrev.com/c/1724754 but for android webview.
We need a didicated connector for the IO thread to create
{URLLoader,WebSocketHandshake}ThrottleProviders.

Bug: 989781
Change-Id: Ia0c883d243e8f856ede2d2747e124b80c2253dec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760646Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688510}

Looking at the flakiness dashboard, all of the failures are due to
timers running within 200ms of the expected time. The test is intended
to detect the difference between timers running at 100ms intervals and
at 1000ms intervals, so the greater tolerance still provides adequate
coverage.

BUG=971590
R=alexclarke@chromium.org

Change-Id: I7b9ea31ad6dce2ba3c2cbfb9f3afa0eb8ea29ff3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758662Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688509}

Keeping the manual reset of navigation_handle as discussed in:
https://chromium-review.googlesource.com/c/chromium/src/+/1751983

Bug: 916537
Change-Id: I83c3da139d4932d712f1a39d55aabea210a5989a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761281Reviewed-by: Lowell Manners <lowell@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688508}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ebcc14092998..5288d5c6c2d9


Created with:
  gclient setdep -r src-internal@5288d5c6c2d9

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None,chromium:954450,chromium:956776
Change-Id: Ibad1efa24cf8c19f92077dcfd1bf04c90e3bd1ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762193Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688507}

Using wpt-import in Chromium b35d45fc.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Ide81c522b3dbdb313b6f685150f16da99dac85a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757859Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688506}

https://webrtc.googlesource.com/src.git/+log/e21f3f574b59..a85492181380

git log e21f3f574b59..a85492181380 --date=short --no-merges --format='%ad %ae %s'
2019-08-20 titovartem@webrtc.org Enable custom metrics gathering from stats API in PC framework.

Created with:
  gclient setdep -r src/third_party/webrtc@a85492181380

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: I5c1e1fffd4a71d85603df7a81723d2010b68a72a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762194Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688505}

Synchronize with HarfBuzz' removal of the back-conversion/multiplication
from "ptem" to "CoreText points", in other words, synchronize with a
change in HarfBuzz in how the unit of hb_font_set_ptem is
interpreted. More details in [1].

https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/60485ab04736..bbad1b829812

$ git log 60485ab04..bbad1b829 --date=short --no-merges --format='%ad %ae %s'
2019-08-20 ebrahim [trak] minor, use roundf instead round to normalize the use
2019-08-20 ebrahim [readme] add oss-fuzz badge
2019-08-20 ebrahim [test] Rebase 10.14 trak related test
2019-08-19 behdad Minor touch-up for recent change
2019-08-07 ebrahim [avar] Implement inverse map, unmap
2019-08-07 ebrahim [fvar] Implement inverse normalize, unnormalize
2019-08-19 behdad Minor
2019-08-18 ebrahim Remove continuous development helper script
2019-08-16 khaledhosny [ot-shape] Keep horizontal_features array sorted
2019-08-16 khaledhosny [ot-shape] Enable abvm/blwm features by default
2019-08-16 khaledhosny [ot-shape] Enable dist feature by default (#1908)
2019-08-14 ebrahim Move HB_NO_VAR to a better place in hb-font.cc
2019-08-14 ebrahim minor
2019-08-14 ebrahim Minor, remove trailing spaces in hb-font.{cc,h} as .editorconfig
2019-08-14 ebrahim Fix caret_count value when AAT is disabled
2019-08-14 ebrahim [lcar] Use multiformat convention
2019-08-14 ebrahim [opbd] Use multiformat convention on the table
2019-08-14 ebrahim [opbd] Turn OpticalBounds fields to FWORD
2019-08-13 behdad 2.6.0
2019-08-13 behdad Rename hb_ot_meta_get_entries() to +hb_ot_meta_get_entry_tags()
2019-08-13 behdad [pool] Fix alignment assertion
2019-08-11 ebrahim Increase subset fuzzer timeout to 16s
2019-08-11 ebrahim [ci] Disable vcpkg thus running the test suit in Windows
2019-08-11 ebrahim Implement opbd table parsing
2019-08-10 ebrahim [os2] Replace null pool addr compare by checking vital fields (#1896)
2019-08-07 ebrahim [fvar] Use roundf instead hardcoding round logic
2018-12-17 tor.arne.vestbo Remove assumption about Core Text working in 96 DPI

[1] https://github.com/harfbuzz/harfbuzz/pull/1484

Created with:
  roll-dep src/third_party/harfbuzz-ng/src
R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org

Bug: 995721
Change-Id: I1eea18a1f1e4e3bad86fede7291f4acf0b4bef71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761282
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688504}

Aim: Remove the QR Scanner Specific methods out of the camera controller so that a similar subclass of the generic camera controller super class can be implemented for the credit card scanner.

Architecture:
Superclass - cameraController
Subclasses - qrScannerCameraController

Methods shifted:

1. - (void)continueLoadCaptureSession:(AVCaptureVideoPreviewLayer*)previewLayer;
Modifies the method to move the section that configures the QR scanner metadata output to a separate method 'configureScannerWithSession', implemented in the QR Scanner Camera Controller.

2. - (void)captureOutput:(AVCaptureOutput*)captureOutput
    didOutputMetadataObjects:(NSArray*)metadataObjects
              fromConnection:(AVCaptureConnection*)connection;
Moves this method to the QR Scanner Camera Controller. It reads and processes the scanned QR code data.

Bug: 990744

Change-Id: If07340c62b0c5c11c70a1e6c4d0a6782dd2c774e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754008
Commit-Queue: Tanisha Mandre <tanishamandre@google.com>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688503}

If an inner multicol container had a fixed height so large it required
an outer fragmentation break, we might fail to break and would instead
let it overflow the outer fragmentainer. We relied on child content
being present in order to be able to break.

Share code between NGBlockLayoutAlgorithm and NGColumnLayoutAlgorithm to
fix this.

This fix also changed how the NGColumnLayoutAlgorithmTest.Nested unit
test got laid out. It turned out that the expectations were wrong there.
There was a 100px tall inner multicol with top and bottom padding of 1px
each. This should give a border box of 102px. It was fragmented across
three outer columns, with room for 30px in the first, 50px in the next,
and the rest would fit in the third one. We used to expect 23px in the
third outer column, but 30px + 50px + 23px is 103px, not 102px.

This change makes the web test
fast/multicol/nested-very-tall-inside-short-crash.html time out
(actually just incredibly slow), since we'll now create millions of
fragments, as we should. Not sure if it's worth it to get it to perform
decently. Skipping for now.

Bug: 829028
Change-Id: If38b2c028ca33d2f4e8fd7d4b8d533a24cd75438
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760958
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688502}

We were still waiting on the middleboxes of the world to update so we
can enforce this. However, the reminder is much appreciated since it
looks like the numbers got dramatically better than the last time we
looked, so perhaps this'll be the last time!

Bug: none
Change-Id: Ice4d465cb4c80a90d6631d0151c1b3d653a8431d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761137
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688501}

OOPR is still in the process of being launched on desktop platforms and
SurfaceControl will be rolled out with Android Q release.

R=ellyjones@chromium.org

Change-Id: I28f9c3f3c18c1e33dcd80bda768d93e948f4b194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761321
Auto-Submit: Khushal <khushalsagar@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688500}

Change-Id: I6716b187bcbdaf10bbe547ec0124a272977175cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761136
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688499}

This is still useful for some ongoing rollouts, so let's keep it a
while longer.

Bug: 984279
Change-Id: I5aedc343a5c6a7c77f7f935a35b6959fa97efd20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760917
Auto-Submit: Marc Treib <treib@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688498}

Bug: 954442
Change-Id: I589d5aa4c78bdfb582017db3bdecb7890a7baa7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760418Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688497}

Found by presubmit checks for
https://chromium-review.googlesource.com/c/chromium/src/+/1756247.
Not cleaned up then by fear of other files using this include
implicitly relying on it.

Bug: 992483
Change-Id: I6ed169ff70b1f36b4a54f00caf5b3dbb9b5b88e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760272
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688496}

This is a reland of 23a46517

These tests will be changing slightly again.

Original change's description:
> Suppress two canvas layout tests to roll Skia rect blur changes
>
> Bug: 990918
> Change-Id: I766e507d5173f847b95ae94bdc2b3857913ec9bb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754542
> Auto-Submit: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Cr-Commit-Position: refs/heads/master@{#686955}

Bug: 990918
Change-Id: I88ca5e26e889e588f84c0abfabd4a842a98a4e79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758337Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#688495}

The hack is no longer necessary. Also remove some other obsolete
TODO's.

BUG=796145
R=yukishiino@chromium.org

Change-Id: Ie84e143759d8e882f7403da48da6f882a962998a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760984Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688494}

...instead of re-implementing the same logic. Note that the
unconsented primary account is supported on exactly those platforms
(Win, Mac, Linux) for which kSyncSupportSecondaryAccount was enabled,
so this brings no behavior difference.

After this CL, the feature kSyncSupportSecondaryAccount has no
effect (and some tests which used to explicitly set it need to be
#ifdef'd to the right platforms now). Cleaning the flag up is left for
a follow-up.

Bug: 990745, 983182
Change-Id: Ic720439de2cc04a1ce6aa6c16f16d1b98721c25f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752826Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688493}

The trybot was failing consistently.
Some failures were introduced by CL:1757606 - rebaselined expectations.
One failure was caused by CL:1757165 - added to expectations file.

The remaining tests had been failing for some time already (but prior
to the bot rename [1] this wasn't a problem for landing, apparently),
so I just added those to the expectations file as well.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1754528

TBR=cbiesinger@chromium.org,eae@chromium.org,kojii@chromium.org

Bug: 995713
Change-Id: I9035114153cd81e8c65938299bf454d106a62f6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761278Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688492}

https://webrtc.googlesource.com/src.git/+log/93d4c10ffccc..e21f3f574b59

git log 93d4c10ffccc..e21f3f574b59 --date=short --no-merges --format='%ad %ae %s'
2019-08-20 nisse@webrtc.org Revert "Delete mac_utils.h and mac_utils.cc"
2019-08-20 tommi@webrtc.org Make the callbacks to PollStats for RampUp* tests more regular.
2019-08-20 nisse@webrtc.org Delete mac_utils.h and mac_utils.cc
2019-08-20 peah@webrtc.org Removing all external access to the integer sample data in AudioBuffer

Created with:
  gclient setdep -r src/third_party/webrtc@e21f3f574b59

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None,chromium:993688,chromium:None
Change-Id: I66d7b5127df296ab6cfa68fbd6d246e88ddfb178
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761831Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688491}

Observer for the password list in PasswordEntryViewer should be removed while the view still
exists, to avoid calling findViewById on an empty View.

Previously, the observer was removed in onDestroy() which happens when the View is already
gone and passwordListAvailable could call setRowText which uses findViewById.

Bug: 994010
Change-Id: I10fbea31dd6faad777b24ec8783c7572e91484ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761589Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Ivana Zuzic <izuzic@google.com>
Cr-Commit-Position: refs/heads/master@{#688490}

Add tests to ensure the "Install with Linux" context menu item is
shown/hidden when Crostini root access is allowed or disallowed by
kUserCrostiniRootAccessAllowedByPolicy policy preference control.

The feature flag kCrostiniAdvancedAccessControls is enabled for file
manager browser tests always and its associated pref is set "on" by
default. FilesApp test JS can send a message to the browser test C++
set the pref on/off as needed with the setCrostiniRootAccessAllowed
command adding in this CL.

Test: browser_tests --gtest_filter="ContextMenu*Install*DebianFile*"
Bug: 983997, 993369
Change-Id: I8a5ee0cb21e43937a0f4a80cd68b7916ee2343c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752825
Commit-Queue: Christopher Gunadi <chrisgunadi@google.com>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688489}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d07afa7409e5..ebcc14092998


Created with:
  gclient setdep -r src-internal@ebcc14092998

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I3dda691872934d01459fe1be8e7b9f76e91bd18d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761830Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688488}

Bug: 778674
Change-Id: Iab56d84cf26975f9c476680d74037a9088ec1c78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760837
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688487}

TBR=dmurph@chromium.org

Bug: 995716
Change-Id: Ie57626524bd894e89fcd21a0ca5ba267156b76c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761599Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688486}

The only GAIAServiceType that is passed to ProfileMenuView in
the code is GAIA_SERVICE_TYPE_NONE. Therefore the parameter
is removed from ProfileMenuView::ProfileMenuView and all
preceding and succeeding method calls.

Bug: 966388
Change-Id: I9521931460c5c1e2e8a98d920b18fad67497f7ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762067Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688485}

TracedGlobal references (without callback) are eagerly cleared during
unified heap garbage collections before sweeping is started. This
change performs similar eager clearing for Blink stand-alone garbage
collections.

This allows for removing the destructor of v8::TraceGlobal and its
wrapping type TraceWrapperV8Reference.

Bug: 995684
Change-Id: Ie0394bb23ee4c5e1ecf4d1ad2a591aa77787ab00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760922
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688484}

Bug: 992355
Change-Id: Iddb778995efaab12cd0ad87b18d5a2096f019c29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755992
Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688483}

Previously, if a CL only modified annotations.xml, CQ wouldn't run
check_network_annotations because the file doesn't appear in the
dependency tree for shipped_binaries.

This CL adds annotations.xml to shipped_binaries, solving that issue.

TESTED=Created a dependent CL that updates only annotations.xml and
       checked that it fails on CQ:
   https://chromium-review.googlesource.com/c/chromium/src/+/1758433

Change-Id: Ib33099df057f1cef882c46858862ea5fca5b91e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757297Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688482}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5c013580..9781db33

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie918523e6aa3655ad6248d97e0dfcbffb49dca55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762167Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688481}

This reverts commit d7878194.

Reason for revert: [Sheriff] blink_platform_unittests fails on Cast Audio Linux bot.
Sample failure: https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/50660

Original change's description:
> Make UTF16RagelIterator::operator*() to use DCHECK() instead of CHECK()
> 
> This patch changes |UTF16RagelIterator::operator*()| to use |DCHECK()| instead
> of |CHECK()| for improving performance because this function is called many
> times as number of characters in the page.
> 
> In text heavy page, I observe 12% speed up.
> 
> Change-Id: I5febb53f0f096b3bd76e6330a70b6464b9cb4758
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760846
> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
> Commit-Queue: Dominik Röttsches <drott@chromium.org>
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#688476}

TBR=yosin@chromium.org,eae@chromium.org,drott@chromium.org

Change-Id: If3d54ab8ae171d55be5f989c3e7d4fccf254d9fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761279Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688480}

https://chromium.googlesource.com/catapult.git/+log/939b6b1f1c56..428149962b00

git log 939b6b1f1c56..428149962b00 --date=short --no-merges --format='%ad %ae %s'
2019-08-20 perezju@chromium.org [Telemetry] Encode tags in test result entries as dicts

Created with:
  gclient setdep -r src/third_party/catapult@428149962b00

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=crouleau@google.com

Bug: chromium:966835
Change-Id: I77c3ac1d11d0d4924ba4a0708ac6c07c0607983e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761633Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688479}

Bug: 994910,994305
Change-Id: I452263ac86f7b584b8be5792902833e6cb52643a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757021
Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org>
Auto-Submit: Emilio Cobos Álvarez <emilio@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688478}

https://webrtc.googlesource.com/src.git/+log/a0b52b570853..93d4c10ffccc

git log a0b52b570853..93d4c10ffccc --date=short --no-merges --format='%ad %ae %s'
2019-08-20 kthelgason@webrtc.org Declare references as constant in the metal renderers.
2019-08-20 nisse@webrtc.org RTCError as return type for PeerConnectionInterface::SetConfiguration
2019-08-20 qingsi@webrtc.org Sanitize the address field of peer-reflexive remote candidates.
2019-08-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 21d23ea5..5a34954f (688221:688384)
2019-08-19 steveanton@webrtc.org Remove jeroendb@webrtc.org from OWNERS

Created with:
  gclient setdep -r src/third_party/webrtc@93d4c10ffccc

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None,chromium:968161,chromium:None,chromium:None
Change-Id: Ifa8e5e4b9e1a2ed70dfe51f83b029f15a99c38e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761704Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688477}

This patch changes |UTF16RagelIterator::operator*()| to use |DCHECK()| instead
of |CHECK()| for improving performance because this function is called many
times as number of characters in the page.

In text heavy page, I observe 12% speed up.

Change-Id: I5febb53f0f096b3bd76e6330a70b6464b9cb4758
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760846
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688476}