GitLab

Remove ChromeSigninController and migrate to IdentityManager.GetPrimaryAccount.

Bug: 1049640
Change-Id: I5ffeb523335c64826dde84b7d08a16e70ac388e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066760
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744348}

This cl cleans up old comment. Chrome on Chrome Os and
web apps' time limit are going to be set through
android chrome's time limit. This is because chrome browser
on Chrome Os and android chrome are represented together
in the Family Link app.

Bug: 1015661
Change-Id: Ib3ac4b0ab6109aba07a7e12c9bbeaf4493d5d68f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071140
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744347}

https://skia.googlesource.com/skia.git/+log/9f00494951f9..7a6db4cbf48b

git log 9f00494951f9..7a6db4cbf48b --date=short --first-parent --format='%ad %ae %s'
2020-02-25 benjaminwagner@google.com [infra] Move app installation to install method

Created with:
  gclient setdep -r src/third_party/skia@7a6db4cbf48b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jlavrova@google.com
Change-Id: I2f0b9e5ce4ead1ef2fecdaa8ff032c58a81a5e72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072448Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744346}

This patch forces all activatable locks in case of a find-in-page query. This
is a stop-gap measure to ensure sites that heavily rely on css-render-subtree
for performance can also be used with find-in-page reliably.

There is a longer term goal of having a better find-in-page which considers
the fact that some layout state might not be available (crbug.com/1045517)

However, since it is likely that render-subtree is going to be available
before the bug is fixed, we're landing this patch for now.

R=chrishtr@chromium.org, rakina@chromium.org

Change-Id: I67953e2f82910dd8ca52cb3b6d7d4ba99acd82d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065052Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744345}

Relying on GetWindowAndroid() returning a non-null value causes crashes
in various instances. With this CL, the window is null-checked before
use an creation is deferred to when it's actually used.
If creation doesn't succeed on first try (e.g. because the window isn't
yet attached), a consecutive call might succeed.

This approach also has the advantage that the interface remains clean
and doesn't require handling the rare Android failure explicitly. This
is acceptable since failing to create the surface means, that the UI
isn't ready to show any information anyway or anymore.

Bug: 1051034
Change-Id: I8e1e8ea8f3eb8e8d59f9654b4c627365d63316c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067771
Commit-Queue: Synthia Islam <synthia.is@samsung.com>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744344}

After XC11.4+ TestHostBundleIdentifier is required key in xctestrun,
otherwise tests fail wit error

xcodebuild[51335:6042032] [MT] DVTAssertions: ASSERTION FAILURE in /Library/Caches/com.apple.xbs/Sources/IDEFrameworks/IDEFrameworks-16118.3/IDEFoundation/Testing/IDETestRunSpecification.m:818
   (self.bundleIdForTestHost) should not be nil.
   <IDETestRunSpecification: 0x7fa7b9bcd950>
   Method:   -bundleIdentifierForInstallationTracking

Fixed: 1054223
Change-Id: Ie8f7b222d3422a5629c755e05a28701a7e6c2395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065420
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744343}

mContainerView is a ViewGroup, but some layout code assumed it was a
FrameLayout. Update that code to allow any kind of ViewGroup for which
the LayoutParams subclasses MarginLayoutParams (including FrameLayout,
RelativeLayout, etc).

It would be nice to add an assertion to setContainerView so that
failures are caught earlier, but I don't see a clean way to do so.

Bug: 1054106
Change-Id: If45a16c2864ef200461a08b783b425ea42346f2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067247
Commit-Queue: Bo <boliu@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744342}

Roll ChromeOS orderfile from 82-4028.0-1580727110-benchmark-81.0.4044.14-r1 to 82-4044.15-1581938780-benchmark-82.0.4065.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Ifb8f3950402c91f70a11d67cac69eced7f2558cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072605Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744341}

R=bsheedy@chromium.org, harringtond@chromium.org

Bug: 1028976
Change-Id: I2633728fb7db20bf736f9f23da3558d9030bfe31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072132Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Arthur Wang <wuwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744340}

TBR=drott@chromium.org

Bug: 1054656
Change-Id: Idcdc79682709fafed8ea6255c895133df6449829
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072518Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744339}

The format for lists has changed since Draft 13, to allow for both
inner and outer list members to carry parameters. (This is directly
supporting the needs of the Reporting API).

Items now intrinsically have parameters, which are ordered. These will
be serialized if present.

The allowed token characters are also changed with this CL, the
characters "!", "#", "$", "&", "'", "+", "^", "`", "|", and "~" are now
allowed in tokens.

This CL updates the parser and serializer to support the new format.

Bug: 1048752
Change-Id: Ib6a6ffdb497d64cf15601fe4a4fa6601809d4ed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037344
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744338}

http://crrev/0f21e26 did a mechanical replacement of
|TraceWrapperMember| to |Member|, and this comment is no longer relevant
(and also doesn't make any sense!)

Change-Id: I77b888c5ec1092be392742e0651dafc43bcbe4ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067280Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Will Cassella <cassew@google.com>
Commit-Queue: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#744337}

This CL is just a simple refactor of
AXPlatformNodeTextRangeProviderWin::GetEnclosingElement. It introduces
GetLowestAccessibleCommonPlatformNode, which returns the lowest common
accessible platform node for a range.

I think the refactor makes this method a bit easier to understand.

Bug: 928948
Change-Id: Ic8bd371d076505c14961c9ec79ccb43943c5a3b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068925Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#744336}

This test is flaking sometimes with an error message about
a nonexisting flag. This removes the attempt to use that flag.
This is not the reason the test is flaking, but the message is
misleading.

Bug: 986021
Change-Id: I847ddee6b63a52b25040c49567de29cad91e2560
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071018Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744335}

Currently these paths in content verification is
base::FilePath::StringType, which can be unintentionally converted
from any base::FilePath. This CL make the concept strong typed,
using util::StrongType. This CL also names it with a hint that
this is a relative path and not a full path.

No behavior changes are expected with this CL.

Bug: 1051401
Change-Id: Ib4117e4d2f83e58ae3b294a22b6d7e2720ed5fb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059572
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Oleg Davydov <burunduk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744334}

This change:
https://chromium-review.googlesource.com/c/chromium/src/+/2065416
introduced an observer method that is called in the ViewAndroid
destructor, and thus all observer need to outlive the ViewAndroid
or be removed before it is destroyed.  The test was not designed
for this, so this updates the tests and add some testing for
the destroy observer call as well.

BUG=1048851

Change-Id: I9eb88eacf1badcd13df168dcf5b264b182ba5062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071107Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744333}

Starting the HomepageSettings, the RadioButtonGroupHomepagePreference
will gain focus automatically and have a highlight background on it.
This CL disables the focusableInTouchMode attribute in the xml.

Bug: 1052498
Change-Id: If89f92fca8195bd4289648511356a2264a55bbcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060657
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744332}

In addition to relanding the original crash fix described below:
- Turn extra mac nodes back on, which were temporarily turned
off until we could figure out the right fix
- Delete table info from the table info map when their nodes are deleted
- Clear table info map on shut down

When a table is updated, it clears the extra mac nodes. This means the
cached _children in BrowserAccessibilityCocoa need to be invalidated.

By adding a call to OnAtomicUpdateFinished(), the correct
invalidation code path is now executed. It calls OnDataChanged() on
each node, which calls childrenChanged() on BrowserAccessibilityCocoa.

Bug: 1050598,1054158
Change-Id: I0dbf3c3e77fcaccf530affc17af5703e5466c387
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066063
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Reviewed-by: Victor Fei <vicfei@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#744331}

https://swiftshader.googlesource.com/SwiftShader.git/+log/b1dd9acac569..c1e60dcf1165

git log b1dd9acac569..c1e60dcf1165 --date=short --first-parent --format='%ad %ae %s'
2020-02-25 srisser@google.com Log instead of warn of unsupported extensions

Created with:
  gclient setdep -r src/third_party/swiftshader@c1e60dcf1165

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Icb06f4c5a831bbe3d834e994d3219f2d5da7f3bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072443Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744330}

Many browsertests are using WaitForLoadStop to wait for navigations to finish,
but they aren't checking WaitForLoadStop's return value,
which indicates whether a navigation was successful.


Bug: 1014186
Change-Id: I9fb5785ae27f791cd27b73c43908ae7e144d731b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981952Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Synthia Islam <synthia.is@samsung.com>
Cr-Commit-Position: refs/heads/master@{#744329}

Refactoring the logic for caching Tab UI flags in the following ways:
- TabManagementModuleProvider.isTabManagementModuleSupported() is not
cached anymore, either to prefs or in memory.
- When DeviceClassManager.enableAccessibilityLayout() is true, the
flags are not cached as false. That is equivalent since the default
return value and the cached value in this case match (both false). Not
having to specify both reduces the risk of inconsistency when the code
is changed.
- Features are referenced by name from ChromeFeatureList, not
prefs key from ChromePreferenceKeys.

A follow up CL will move this logic to TabUiFeatureUtilities and
inline many of the methods into clients. I kept this CL small so it is
easier to review.

Bug: 1012975
Change-Id: I8f9d7ad3d3b935064e568bc8561d6336e44839b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063416Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744328}

This CL has two goals,
  1. Use To<StaticBitmapImage> and DynamicTo<StaticBitmapImage> as new
   downcast helper
  2. Use IsA<StaticBitmapImage>(element) in place of
   IsStaticBitmapImage(element)

Bug: 891908
Change-Id: Idabe825959a6f14eab699177cfdc4fc4ba3576b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071444
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744327}

Bug: 958893
Change-Id: I5423d68fe7459ea2f1f90f4f4da8d3750304d3aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067813
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744326}

When using DOM Overlay mode, if the session is ended from Blink, wait
for fullscreen mode to exit before resolving the session end promise.
This avoids a race condition in WPT where the next test was starting
while still in fullscreen mode, leading to the session entry click
not registering.

Bug: 1054750
Change-Id: I400526befb75a2c3eb27231f6b12c125725c26ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071493Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744325}

This makes the buttons of the <pin-keyboard> element
untabbable. It affects the Chrome OS smart card SAML PIN
screen, the quick_unlock PIN setup screen, the quick_unlock
login keypad in the WebUI user pod.

This should NOT be an accessibility regression, since these
buttons don't provide any extra functionality: i.e., the PIN
can still be directly entered into the input field via other
methods. The change was also approved by the a11y team (see
the attached bug).

This should also resolve some a11y bugs related to these
buttons, because their normal behavior wasn't quite
a11y-friendly (for example, it's hard to deal with the focus,
for which it makes sense to keep it at the pressed button,
but at the same time this confuses ChromeVox and prevents it
from saying "bullet").

Bug: 1043194
Test: start SAML login using a smart card, proceed to the PIN dialog, try to press Tab a few times, verify that the buttons of the PIN keyboard ("1", "2", etc., "backspace") don't get selected
Change-Id: Ic70ac0d4550d969f2f25d79e2a08a432e3b29c82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066910Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744324}

https://dawn.googlesource.com/dawn.git/+log/5a921f8fadba..6c1d646ee9d4

git log 5a921f8fadba..6c1d646ee9d4 --date=short --first-parent --format='%ad %ae %s'
2020-02-25 enga@chromium.org Change extern const DawnTestParam helpers to functions

Created with:
  gclient setdep -r src/third_party/dawn@6c1d646ee9d4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I92cc66d0416be0c8660d2ee3a73bafca1295f035
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072440Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744323}

https://webrtc.googlesource.com/src.git/+log/1dea1ea41202..0165d5c32c87

git log 1dea1ea41202..0165d5c32c87 --date=short --first-parent --format='%ad %ae %s'
2020-02-25 deadbeef@webrtc.org Adding deadbeef back to OWNERS files
2020-02-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a8299810..e1d61e44 (744151:744256)
2020-02-25 danilchap@webrtc.org Reduce RtpFrameReferenceFinder fuzzer input to more reasonable value
2020-02-25 ilnik@webrtc.org Add BW limited vp9 k-svc test
2020-02-25 hbos@webrtc.org [Overuse] Make Most Adaptation Preconditions Explicit
2020-02-25 asapersson@webrtc.org Only update the current time of a played out frame if a new frame is played out.
2020-02-25 phoglund@webrtc.org Whitespace change to kick bots.
2020-02-25 titovartem@google.com Fix potential memory exhaustion in DefaultVideoQualityAnalyzer
2020-02-25 danilchap@webrtc.org In Vp8 temporal layering fix generic info at non-first key frame
2020-02-25 hbos@webrtc.org [Overuse] Can[Increase/Decrease][Resolution/FrameRate]?
2020-02-25 phoglund@webrtc.org Add PerfResultsReporter.
2020-02-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6b07a87f..a8299810 (744028:744151)
2020-02-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6d601765..6b07a87f (743892:744028)
2020-02-24 philipp.hancke@googlemail.com loosen ice-ufrag/ice-pwd ice-char restrictions further
2020-02-24 danilchap@webrtc.org Add an integration test frame encryption works with DependencyDescriptor
2020-02-24 natim@webrtc.org VoIP interface headers in api/voip directory. This separates the implementation that will come in audio/voip.
2020-02-24 sprang@webrtc.org Reland "Refactors UlpFec and FlexFec to use a common interface."
2020-02-24 peah@webrtc.org Optimizations and refactoring of the APM 3-band split filter
2020-02-24 phoglund@webrtc.org Roll chromium_revision ce459ab3..6d601765 (742528:743892)
2020-02-24 phoglund@webrtc.org Improve comment in perf_test.h.
2020-02-24 danilchap@webrtc.org Reland "Delete legacy DataSize and DataRate factories"
2020-02-24 kthelgason@webrtc.org Reland "Update RTCEncodedImage to not use deprecated mutable_data call."
2020-02-22 lambroslambrou@chromium.org Revert "Reland "Reland "Reland "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5."""""
2020-02-21 jianj@google.com Only set vp9 config when it's changed.
2020-02-21 mirtad@webrtc.org Do not request encoder switch when the video is suspended.
2020-02-21 natim@webrtc.org Refactoring mock_transport to be used separately
2020-02-21 hta@webrtc.org Reland "Remove old-style OnFailure callbacks"
2020-02-21 phoglund@webrtc.org Roll chromium_revision dd5a54c2..ce459ab3 (736224:742528)

Created with:
  gclient setdep -r src/third_party/webrtc@0165d5c32c87

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1029452,chromium:1051476,chromium:1052323,chromium:1053482,chromium:1053756,chromium:396091,chromium:589455
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Iff637f3cbd52cefed90c6a2fdab4fd64283c56f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072444Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744322}

Consolidating existing file operations into a separate file.
This is a no-op change.

Bug: 993920
Change-Id: I695bac9da35f670d4d5efae488226aa249a111f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063037
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744321}

https://android.googlesource.com/platform/external/perfetto.git/+log/5c63cc2bc39b..e58e709f7730

git log 5c63cc2bc39b..e58e709f7730 --date=short --first-parent --format='%ad %ae %s'
2020-02-25 treehugger-gerrit@google.com Merge "Use GTEST_SKIP when skipping perf cts tests"
2020-02-25 lalitm@google.com Merge "tp: fix issue with exporting dynamic db tables"
2020-02-25 lalitm@google.com Merge "tp: fix wrong source table being used in counter with dur table"
2020-02-25 hjd@google.com Merge "Add focus regex for heapprofiles"

Created with:
  gclient setdep -r src/third_party/perfetto@e58e709f7730

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ifc76c8bd2839affb6619cca64dc9361c76b8a800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072442Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744320}

This is a re-land; the migration originally landed but broke compilation
of the 'all' meta-target, passing the CQ but breaking the waterfall.

Fuchsia's Vulkan rules have been fixed now, so things build cleanly
with this CL, and the trace-engine is now correctly specified by the
Vulkan rules themselves, rather than needing to be specified by Chromium.

Bug: 1050703, fuchsia:46115
Change-Id: I571ef1513a704cfc5ca6d92e548dfaa87562643f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064219
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744319}

This brings back the behavior from
https://chromium-review.googlesource.com/c/chromium/src/+/1978103 that
was lost in
https://chromium-review.googlesource.com/c/chromium/src/+/2027075 . Now,
if a flex item with overflow: auto gets a scrollbar, we add the width of
the scrollbar to the intrinsic size. Blocks has similar behavior but
gets there differently. This could cause performance degradation.

This fixes the "inner dimensions" test from
css3/flexbox/overflow-auto-resizes-correctly.html .


I removed the intrinsicHeightBox part of the test. It asked that we give
the item 100px height in this case:

<flexbox column height:auto>
  <item style="min-height: min-content; flex: 0 1 0;">
    <div style="min-height: 100px">

This requires laying out the item to determine what the min-content is.
Legacy does this, Firefox doesn't. NG doesn't do it for blocks, e.g. the
outer div gets 0 height here:

<div style="height:0px; min-height: min-content">
  <div style="height: 100px;">

Bug: 845235
Change-Id: I35ba43d63676798f7a632c33ead4e147ea36f34f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058066
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744318}

This is a port of the CL that was made for <cr-button>:
https://crrev.com/c/2069144.

Same as in that CL, the goal is to allow to customize the
"tabindex" attribute in a robust way, now for the
<cr-icon-button> Polymer element. (See that other CL for
more context.)

Bug: 1043194
Test: add element '<cr-icon-button tab-index="-1">' to a Polymer page, verify that it's not tabbable
Change-Id: I09b8f101f611bf937c6ce05cd28b22a5b8a4615e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066933Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744317}

BUG=1034666

Change-Id: I18336ab0f3d36adbe2b47f0784baed6e4ac9f2f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072577
Commit-Queue: Robert Liao <robliao@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744316}

We assumed that TransitionEnded() would happen almost every time we
interact with the page switcher, but some edge cases don't animate a
transition, particularly after a scroll. For this edge cases, we delete
the mask layer when ScrollEnded(). We also check if the mask layer still
exists when TransitionEnded() to reset it if needed (i.e. when no scroll
is involved in page switching)

Bug: 1049275
Change-Id: I8bdebd6a0b0776f202ac5ee6af8990f41bb22ea4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070795Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744315}

This cl changes the remaining payments PlatformBrowserTests to use
utility functions from the newly added PaymentRequestPlatformBrowserTestBase
rather than redefininig them for each test class.

Bug: 1052169
Change-Id: I1e621d8ef00e34e55419b51890b79cfe7d83f8e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063666Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744314}

Bug: 1055573
Change-Id: I435be1e417a25ef922d81a53571c75cbff7679f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071777Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744313}

This is part of the base::Callback migration.

Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40

Bug: 714018
Change-Id: I25bbcdd96b395a9e5b2fe90c5b509f383845327d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070237
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Auto-Submit: Jose Lopes <jabolopes@google.com>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744312}

The policy is now ready for prime time.

BUG=1034641

Change-Id: I302b6ca48c0745f0c356205c7591b41706e35b2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071267
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744311}

Using wpt-import in Chromium 90dcda95.
With Chromium commits locally applied on WPT:
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
mek@chromium.org:
  external/wpt/webmessaging

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I9f423ae2ae23b6db05d2cd27fd3ac20b9807c5af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070870Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744310}

Previously, the code assumes that if there's no
primary account, that the profile is still signed
in. This may not be the case.

Bug: 946605
Change-Id: I4b19d0c2c57f8a8b7107075522b979163401f415
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071578Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744309}