- 10 Jun, 2020 40 commits
-
-
arthursonzogni authored
Without this, several reports from COOP-access-reporting would show in between and cause most of the tests to fail. BUG=1090273 Change-Id: I360b82da4b6a2dcb0380dfa4dce5a678e6ad73a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235851Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776930}
-
Christoph Schwering authored
The event handler resets the iframe's AutofillHandler. This ensures that unique renderer IDs are actually unique within AutofillHandler and avoids false positive cache hits in the FormStructure cache. Specifically, this concerns the FormRendererId for synthetic forms. Without resetting the AutofillHandler, a pre-navigation synthetic form cache entry persists and leads to false positives. Bug: 1064709 Change-Id: Iface6ded3027c7b31322685122f2ea1fc8427607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120721 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#776929}
-
Christoph Schwering authored
This CL removes FormStructure::operator==() and replaces it with direct comparison of the unique renderer ID. It appears that operator==() attempts to implement equality in terms of underlying <form> tags, i.e., FormStructure == FormData iff they originate from the same <form> tag. However, the implementation preceded renderer IDs and thus could only approximate the intended relation. Since there is no canonical way of defining equivalence between FormStructure and FormData, it seems best to compare the renderer IDs directly. Renderer IDs suffice to uniquely identify forms and fields within AutofillHandler since there is a one-to-one mapping from RenderFrameHosts to AutofillDrivers and from AutofillDrivers to AutofillHandlers. Bug: 1007974,1064709 Change-Id: I9a3f1b02d06bab345d6e9df86273020ee888903a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113574 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
-
Stepan Khapugin authored
This reverts commit 096c1762. Reason for revert: new tests fail on iphone-simulator (see crbug.com/1093306) Original change's description: > [iOS] Make password leak checks toggleable when Safe Browsing is not available > > This CL fixes a regression from http://crrev.com/c/2174995 > that prevents users who do not yet have Safe Browsing > rolled out to them from toggling the password leak check setting. > > This CL ensures that the value of the Safe Browsing opt-out > pref is always initialized in GoogleServicesSettingsMediator, > regardless of whether Safe Browsing has been rolled out. With > this change, the other logic changes in > http://crrev.com/c/2174995 work as expected, whether or not > Safe Browsing is available. > > Bug: 1090406 > Change-Id: I901f04faad60f136b89161091eeb6504415718a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237716 > Commit-Queue: Ali Juma <ajuma@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776646} TBR=ajuma@chromium.org,sczs@chromium.org Change-Id: Iac9d50cbbdd03ee5098565cb83d5a3c2ae4b6deb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1090406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239841Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776927}
-
Aya ElAttar authored
1. Removed PolicyMap::Entry::get_value which accepts unique_ptr. 2. Changed all its references to use the new one with base::Optional instead. Bug: 1092471 Change-Id: Iaa1246f55e63bc3737e36141bb349905d48335e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237974 Auto-Submit: Aya Elsayed <ayaelattar@google.com> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#776926}
-
Swapnil authored
A utility file is created to convert extension events to base::Value so that we can upload extension events using ExtensionInstallEventLogUploader. This is a prework for extension event based reporting. Bug: 1081211 Change-Id: I66a7c5811af16ffa3a658e1f6b8e8f544dfb8f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193582 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#776925}
-
Sreeja Kamishetty authored
RenderFrameHostImpl::is_active is used either when the RFH is in pending deletion or in back forward cache. We would like to remove all the |is_active| occurrences to avoid confusion with all the other methods and use specific methods like: - RenderFrameHost::IsCurrent() - RenderFrameHostImpl::IsPendingDeletion() - RenderFrameHostImpl::IsInBackForwardCache() - RenderFrameHostImpl::IsInActiveAndDisallowReactivation() This patch updates the callers of |is_active| and make use of above mentioned methods along with removing RenderFrameHostImpl::is_active(). Detailed list of investigations for each is_active usage is presented in this spreadsheet: https://docs.google.com/spreadsheets/d/1TTzZ5r0m7nHBS_TkrEAdcFGs0M2iXO_tS0-lJmbQ3EY/edit?usp=sharing BUG=1073449 Change-Id: I3be34f9ac66389edb36f53a73fc806f2d9d942a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186641 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776924}
-
Gauthier Ambard authored
Allowing BVC to become first responder is letting it answer keyboard shortcuts. It also makes sure that the BVC is set as first responder when shown. Fixed: 1088068 Change-Id: I04cab9d4d9e20487778f64b0cbba49d64f611408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235849Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#776923}
-
Chris Hamilton authored
This allows enterprise admins to force-enable or force-disable the feature. BUG=1075553 Change-Id: I1ca1a6373945100f92f0a84f2e27d323000154a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232772Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#776922}
-
Eric Willigers authored
AppListTestBase was recently updated to better support kDesktopPWAsWithoutExtensions. AppContextMenuTest tests pass even if the flag is enabled. Bug: 1082877 Change-Id: I8306a6e5492c8fe66080bd3e0f7157a921755065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235223 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#776921}
-
Dylan Cutler authored
The purpose of the instrumentation in this study is to collect the maximum amount of bytes this API exposes to sites and builds a digest of the result. Our belief is that the amount of bytes revealed by API has been reduced to the point where it no longer leaks any bits that sites can use to identify users. The goal of including this API in the identifiability study is to either prove or disprove this hypothesis. Bug: 973801 Change-Id: Id1a03f9ad46d758323e537a8d21f4f2f911bfdb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225333Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#776920}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fc2a45b99357..b45583d6eab0 2020-06-10 aerotwist@chromium.org [Performance] Bumps reload wait time 2020-06-10 fawazm@google.com Add WebAuthn Tab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1034663 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4b358051cafc99dc1e021433817d6d590c9c82a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239476Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776919}
-
Victor Hugo Vianna Silva authored
Instead of using a custom string, the page should just display the same "Saved passwords will appear here" string as chrome://settings/passwords in case one of the subsections is empty. Bug: None Change-Id: I9236e544d5bc988bf6aa89c18524f4591dceeba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238054Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#776918}
-
Fergal Daly authored
TBR=altimin@chromium.org Change-Id: Iea211bdf026d6d2948422ba2d053762eb0c028c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237543Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#776917}
-
Benoit Lize authored
This CL adds support for the 'use_allocator = "partition"' GN argument on Android and Linux. This is not meant to ship, but to ease experimentation. Without this flag, there is no behavior change. With it, malloc() and new calls are redirected to PartitionAlloc. For DCHECK_IS_ON() builds, PartitionAlloc doesn't support the right alignment guarantees to suppose posix_memalign(), which is required at least on Linux. This is due to the addition of a "cookie" on both sides of the allocation, meant to detect improper memory writes. With this CL, the cookies are temporarily disabled with PartitionAlloc when it is used as the malloc() implementation. Change-Id: I1b1b6fc855fb48bbad04a82a2b60e320194943fd Bug: 998048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167281 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#776916}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2d27b1ab0c85..8498c259b987 2020-06-10 philipp.hancke@googlemail.com test: use kCnCodecName instead of hardcoding "CN" 2020-06-10 hbos@webrtc.org [Stats flake] Mark outbound-rtp.framesPerSecond as optional. 2020-06-10 jakobi@webrtc.org Remove packet loss rate optimization and minimum field trial. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I085c0117ff4adee1de38fdb045528907f7453039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239477Reviewed-by:
-
Vasilii Sukhanov authored
Additionally the CL introduces the password check flag on Android only. Bug: 1049177 Change-Id: Ibe8d60de32fc03eca96406a0c5bbf14d1b232ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236478 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#776914}
-
Swapnil authored
ArcAppInstallEventLog and SingleArcAppInstallEventLog classes are used for storing logs on the disk and prepare for upload. Similar classes are implemented for extension events. ArcAppInstallEventLog::Load method is refactored to extract the common code into SingleInstallEventLog class. Bug: 1081192 Change-Id: I20731598f52d37cc0c890b5254011787f04ff97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199282Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
-
Olesia Marukhno authored
Previous cl was reverted because of: New tests are failing on Mac, see e.g.: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/51174 All failing bots: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests Fix tests failing on mac by removing unnecessary check of if browser is active. Bug: 1019129 Change-Id: Ibbb2b64e84f688bfdce873fb8990525a73786516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236481Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#776912}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8710a4f9740a..e5d1f8690561 2020-06-10 dberris@chromium.org operations: Remove deletion API/UI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1092865 Tbr: sadrul@google.com Change-Id: I44d3030bcbade774329d27685aac4c656e619a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239475Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/00a045e4..4caabe11 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I42a62e9a471d966c960849d82f8fdb9fcace20c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239169Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776910}
-
Finnur Thorarinsson authored
This disables AwContentsClientOnRendererUnresponsiveTest tests due to persistent failure on Android bots. Tests being disabled: AwContentsClientOnRendererUnresponsiveTest#testOnRendererUnresponsive__multiprocess_mode AwContentsClientOnRendererUnresponsiveTest#testTransientUnresponsiveness AwContentsClientOnRendererUnresponsiveTest#testTransientUnresponsiveness__multiprocess_mode Most narrow CL blamelist I could find (where error started) was this: https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/25652 TBR: ctzsm@chromium.org Bug: 1093270 Change-Id: I11fe2767804ef36cb979b2e34ccec1df473bce11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238113Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#776909}
-
Sreeja Kamishetty authored
Currently, the FileChooser window is not explicitly closed when navigating away. This CL disables BackForwardCache when RunFileChooser is invoked to avoid any renderer interactions when the page is in BackForwardCache and user seeing any unexpected behaviour. To make FileChooser bfcache compatible is is the next step. BUG=1071232 Change-Id: I219143190425107a7604f2f23dd25c5e462d7106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193932 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#776908}
-
Rushan Suleymanov authored
This patch introduces check for unsyncable nodes while loading metadata from the disk and throws away metadata if unsyncable node is tracked. Bug: 1093024 Change-Id: Ib07c8999670b5831a3955d26734bf6704eb6232b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238826 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#776907}
-
Fergal Daly authored
TBR=altimin@chromium.org, scottmg@chromium.org Change-Id: Ia91b1aacb0e761042630822acc72f86b96c1752c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239738Reviewed-by:
-
Yifan Luo authored
Changed the CSP violation report sample string for Trusted Types from `eval|(function anonymous(xxxx` to `Function|xxxx`. Bug: 1048604 Change-Id: I6484ef73f78ea245d39efe219e30f5a0ed5d4f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235621 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#776905}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5165a7a61b1d..fc2a45b99357 2020-06-10 yangguo@chromium.org Seed more owners If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1082687 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iceca903843fccc203d12af2bb04773517da76bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239656Reviewed-by:
-
Nick Diego Yamane authored
This contains a major rework of DataSource support in Ozone Wayland backend. Just like other recent refactors in data exchange related code, such as https://crrev.com/c/2205881, the primary goal of this one is to decouple "client code" from core implementation and interface of *DataSource classes, so making it easier to maintain, extend, read, etc etc as well as maximizing code reusage and will reduce complexity to implement use cases such as Tab/Window Dragging. To accomplish it, this CL: 1. Switches DataSource implementations to a template-based (instead of using inheritance) approach in order to support *slightly* different backing protocol extensions and maximize code reusage and consistency on what is shared. For now there are 2 variants, one for the standard wl_data_source protocol object and another one for gtk-primary-selection extension (and probably a new one coming soon [2]). 2. Introduces DataSource::Delegate interface, through which the relevant data source events are forwarded to "client code", eg: WaylandClipboard, WaylandDataDragController, etc. 3. Refactors DataSource clients, mainly WaylandClipboard, making use of the new template class instances to reach a cleaner and easier to extend implementation of PlatformClipboard, seamlessly supporting both regular and primary selection clipboard buffers. 4. Get rid of unneeded classes and source files. No functional changes is expected and follow up changes should be done in the future to switch the Device and Offer counterparts to a similar architecture. [1] https://gitlab.gnome.org/GNOME/mutter/-/blob/master/src/wayland/protocol/gtk-primary-selection.xml [2] https://bugs.chromium.org/p/chromium/issues/detail?id=1088132 Bug: 896640 Change-Id: Iaf035dd106c6ab9488f44cfd8fb425ff3cd354db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222147Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#776903}
-
Ankit Kumar authored
This CL ensures that current focused annotation is scrolled into view if not already in view on key events. This ensures that user can see the annotation in the viewport while performing key events on the same. Bug: 1085614 Change-Id: I41162be9a096219e04682ec5240508819a5baf48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228250 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#776902}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0c3062efcb3b..2d27b1ab0c85 2020-06-10 handellm@webrtc.org Mutex: Temporarily add re-entry CHECK. 2020-06-09 danilchap@webrtc.org Add av1 structures for 3 spatial and/or 3 temporal layers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idea6a33fcbd71f44cae3e60c68bb239f5ea1c80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239655Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d80d9044857e..277f64ca79c3 2020-06-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 7c213720bb46 to c01f826bc67f (1 revision) 2020-06-10 syoussefi@chromium.org Vulkan: Fix RTs attached to textures with non-0 mip If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Iada81a17a092789e8f5b6b2c5883fcf2091bd0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239653Reviewed-by:
-
Nigel Tao authored
Bug: 1086733 Change-Id: If2f08ecb345051677ec5dc249fa5e5922229e633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235253 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#776899}
-
Javier Ernesto Flores Robles authored
Bug: 1066803 Change-Id: I4311c1010a1a7b0f6c061d2f0c17dfcb4a917481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235793 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#776898}
-
Alexey Baskakov authored
Sometimes last_committed_nav_entry_unique_id != entry->GetUniqueID() in WebAppDataRetriever::OnGetWebApplicationInfo() which resulted in kGetWebApplicationInfoFailed. And kGetWebApplicationInfoFailed is a showstopper: generated icons. WebAppDataRetriever::GetWebApplicationInfo() should return some initial info to unblock CheckInstallabilityAndRetrieveManifest() stage. This CL doesn't introduce significant behavior changes. It returns non-nullptr info for the `entry->GetUniqueID() != last_committed_nav_entry_unique_id` edge case. Bug: 1093251 Change-Id: Ia3bbcbdf229a3c74fc93f173892ebec404a2fc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239727 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#776897}
-
Sergey Poromov authored
While the feature is launched on the client side, it's currently in GA process to launch on server side for 100% customers, so the first metrics would be still useful there. Also changing the owners. Bug: 1089609, 1089611, 1089615, 1089617 Change-Id: I94aea37ac182b688db5a6b0e197b393b45f74e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224263Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#776896}
-
Rune Lillesveen authored
The 'no-preference' value was removed from the spec per CSSWG resolution. Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ragu5Is6vCw Bug: 1091806 Change-Id: I6410f99badd26ad18fddadf014115dd754ca6aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232922Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#776895}
-
Hitoshi Yoshida authored
CheckForTypeError returned a String, and it is non-empty if TypeError is expected. This style is not obvious. This CL makes it to return what canShare() returns, and do not process URL if |data.url| is not present. Bug: 839389 Change-Id: Ie7eede5e33b16947aeffcb5c144f95940bb5d82a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237213 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#776894}
-
Illia Klimov authored
This patch fixes a bug that prevents displaying incognito origins in Category Settings. Bug: 1073942 Change-Id: I4c7e95dcabc492c947149bc11ce74749e7253656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237971Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#776893}
-
Rainhard Findling authored
* Adds tests to check for the existence of the Chrome cleaner child if the platform requirements are fulfilled and if the corresponding flag is enabled. * Adds a mock of an incoming Chrome cleaner event from the safety check backend to the existing safety check page test. Bug: 1087263 Change-Id: I89f04c03c1bcca59b72120b4379f7ad03fe7d572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236139 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#776892}
-
Arthur Hemery authored
The current logic is implemented in the RenderFrameHostManager, but it would make more sense to have decisions taken in the NavigationRequest. This allows us to both clarify logic, as explained below, and to remove one mutator from the NavigationRequest interface. One single block of code that was doing a number of things is now split in three different logical parts, with some redundancy: - When we start a navigation, we do some coop inheritance heuristic to make sure the special case of instantly committing a speculative RFH in a sad tab does not mess up with attributes and proxy clearing. - When we hit a redirect, we recompute the COOP decision given the redirect headers. - When we receive the final headers, we compute the final COOP decision and do reporting if necessary. This clarifies the different bits of the COOP puzzle of setting require_browsing_instance_swap. Bug: 1076879 Change-Id: Ibf96084b59b5aa62e2241df1abbdb24b2c20e1e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218092 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
-
