- 02 Oct, 2020 40 commits
-
-
Cathy Li authored
clipping. This fixes clipping for feed header IPH. Bug: b/168859910, 1130592 Change-Id: I19efd691190f05826c7e1ecfd288f8d6bf4df6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442361 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#813043}
-
Ian Barkley-Yeung authored
Untrusted input? Complex C++ parsing code? Put a fuzzer on it! Bug: chromium:1121816 Change-Id: Iddb65e2568d88bbd32157bae49ceacaa1755c04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443396 Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#813042}
-
Karandeep Bhatia authored
Change it to accept a dictionary instead of individual arguments for better future compatibility. Also rename it to setExtensionActionOptions for further flexibility. Note that this is a breaking change but we'll reach out to the current users to make sure that they update their extensions. Skipping presubmit since this seems to be hitting crbug.com/956368. BUG=1131746 No-Presubmit: True Change-Id: I6b800985ca2eaff4f52900b984ef5519e3fac266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429260Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#813041}
-
Bailey Berro authored
Enables clients to implement the MemoryUsageObserver interface and register themselves as an observer in order to receive periodic updates about the usage of memory on the device. Example use - crrev.com/c/2424505 Bug: 1128204 Change-Id: I17eaf3b8eb58c287e96d8ff217d3356d3d84c06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439475Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#813040}
-
Tomasz Wiszkowski authored
This change introduces a very simplistic MostVisitedTilesProcessor. The only functionality wired up at this point is updating the Omnibox Editing text with the associated URL and very basic keyboard navigation. Bug: 1106109 Change-Id: Iac224b2c625eb11d9e1a99ff21465c2b3680b3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437690 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#813039}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b677e985297d..69e30b23c45f 2020-10-01 vadimsh@chromium.org [lucicfg] Update to 1.21.0. 2020-10-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1133442 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I924ca88e53208345b4446a4a55b016a13a19e019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444152Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813038}
-
Jeremy Roman authored
dtapuska already owns and reviews blink/public/common/. (Sorted because these lists get harder to read the longer they get.) Change-Id: I3fb849854948bcaf01847b93add9f133ad7b5026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442632Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#813037}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ab4a49259c0e..7f0e83e82ba9 2020-10-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3211fba0..fa57522d (812728:812874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3a95b2f5523f296e04eaf3c9b63b908f8df3c7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444158Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813036}
-
Akihiro Ota authored
This change: 1. Adds the earcons lesson to the interactive tutorial. Functionality for this is included in buildEarconLesson() in i_tutorial.js 2. Adds a test for the lesson. 3. To reduce flakiness, we needed to change how we wait for the tutorial. Now, we wait for all lesson content to finish loading before we perform commands and make assertions. focused. This change also includes an automated test. Test: Manually verify on-device that earcons are played when text is Change-Id: I89d2f3c050a74b8d35df47091d88ba443105dadb Fixed: 1124078 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426968 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813035}
-
Daniel Classon authored
Turns the swap mouse button toggle into a dropdown with Left button and Right button as options, as per the bug. String screenshots: https://storage.cloud.google.com/chromium-translation-screenshots/0de32bdc0a9e5c95680629877c323c11d242cf03 https://storage.cloud.google.com/chromium-translation-screenshots/037c4cf7a5c655f6e15a4ca3c906230359440d50 Fixed: 1132518 Change-Id: I55836c82115a2fc1473d4863b2f96ed9b94f4a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436750 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#813034}
-
Naoki Fukino authored
Lacros-Chrome and ChromeOS-Chrome use different animation curves for fling scroll. To make them consistent, this disables ExperimentalFlingAnimation flag for Lacros-Chrome as ChromeOS-Chrome doesn't enable it. Bug: 1129263 Change-Id: Ibe4c80f08f077a951e529f3a670f7db914dc1394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439816Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#813033}
-
minch authored
Make UnifiedSliderButton as ImageButton only and decorate it with kIconButtonSmallOrMedium. Bug: 1133748 Change-Id: Ic154c6ef63770d66ae4d09eb4b3cf1190be056cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441190 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813032}
-
Andrew Beggs authored
For AArch64 a restricted ptrace call will result in an error when trying to access PAC keys. Malicious code could derive the key via the system call and potentially defeat any PAC control-flow integrity checks. The ptrace call to set registers, PTRACE_SETREGSET, is already blocked, so they cannot be changed. Change-Id: I6954e3b038912871a964d413a305c69f8a57d543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438130Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#813031}
-
Guillaume Jenkins authored
Adds a metric to record the number of Chrome Siri Shortcuts the user has created in the Siri Shortcuts app. This is recorded once at startup, as a delayed startup task on the IO thread (to avoid hangs while querying iOS for the list of shortcuts). Bug: 935211 Change-Id: I70766050ba7faf5fb343e3515c98ff6ddca98bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429306 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813030}
-
David Tseng authored
R=anastasi@google.com, dmazzoni@chromium.org Fixed: 1127250 AX-Relnotes: n/a Change-Id: Ib716aedf39c80333ef5181cf2a40f6d40e52e298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443535Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#813029}
-
Darwin Huang authored
This simplifies the interface a bit, and allows us to avoid any potential issues with argument ordering in RenderFrameHostImpl::FromID, or otherwise. Change-Id: I0c9d9fe921a5b0ca8765e9d7c8ae6196dc329e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419663Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813028}
-
nancylingwang authored
Fix unit tests when the flag is disabled. BUG=1083331 Change-Id: Ic4cdc5a089ca672b4a79b345eff18ebcb4ccd82b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442989Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#813027}
-
bttk authored
Bug: 1133482 Change-Id: I9745a5d58c3a933e3c59059976f1c47fe210886c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439430 Commit-Queue: who/bttk <bttk@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#813026}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia5b01e969f167acb60a408fc94eaa772e7c6a951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444157Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813025}
-
minch authored
Bug: 1133748 Change-Id: Ie076a61324e6337e0f5f7c559a592a56f33203d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441287 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813024}
-
Piotr Bialecki authored
Step 3/N of moving ARCore device into device/vr. Previous steps: 1. https://crrev.com/c/2341811 2. https://crrev.com/c/2405538 Changes: - create new target, device/vr/android:vr_android, with mailbox to surface bridge and web xr presentation state - move most of ARCore implementation out of chrome/browser/android/vr:vr_android target, into device/vr/android/arcore:arcore - remove default constructor from ArCoreDevice - it needs to be created by ArCoreDeviceProvider that hands it the ArCoreJavaUtils instance - moved MailboxToSurfaceBridge to a new component, components/webxr, to address the layering violation - it now implements the interface defined in device/vr/android and can be provided to lower layers by the consumers that can depend on content/ - other mechanical changes related to the move Bug: 843374 Change-Id: I039a6e7038e13d6b9f6ab2df9eb734ea2fdf4027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413288 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#813023}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6b79223314a5..8c88c750bd45 2020-10-01 bsheedy@chromium.org [Devil] Add install sanity check If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1132297 Tbr: skyostil@google.com Change-Id: I4286da640e44824b892e32ca5d699f11bb7afb73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443775Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813022}
-
Jie Jiang authored
L2CAP LE socket is added in Android from Q and these two patches implements for ARC++. The code for this new socket is quite similar to the existing code for RFCOMM. Since we cannot just change the name of an existing interface, in the next patch, we will add two new interfaces (listen and connect socket) which can be used for both RFCOMM and L2CAP, and deprecates the old ones, when both P and R get the corresponding patch(es). This patch doesn't change any functionalities. It just refactors the current code a bit, including: - Renaming RFCOMM-specific stuff into more generic ones; - Changing to calling bind() for both listen and connect sockets: calling bind() for RFCOMM connect sockets is not required but needed by L2CAP LE sockets; - Changing type of |channel| in some methods to uint16_t for PSM value; - Fixing a wrong usage of PLOG. BUG=b:163099156 TEST=RFCOMM tests in cts verifier on octopus Change-Id: If09794e00fa60599e8c9e9ec941d06cfdeb28741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368615Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Jie Jiang <jiejiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#813021}
-
Joe Mason authored
Fix a crash when GetFrameNodeForRenderFrameHost is called before the RenderFrameCreate notification. R=fdoray Bug: 1134162 Change-Id: Ia51f7031680554e888479ed4f7f4507be92f47cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443110 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#813020}
-
George Burgess IV authored
Unless it's guaranteed that `std::forward` always turns into an rvalue ref, using `std::move(x)`, where `x`'s type is a universal reference, is generally unsafe. `std::forward` is preferred for these cases. Bug: 1134310 Change-Id: I57310023f83236b42a185d5c1b401ae3a338a94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443849 Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: George Burgess <gbiv@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#813019}
-
Malay Keshav authored
This patch uses glClear to draw the solid color draw quad whenever possible. It also replaces the usage of color transform matrix used in the fragment shader for solid color draw quad with a precomputed color that is in the correct color space. Improves draw time of a full screen solid color quad by approximately 80% on Atlas. (From ~1.5ms to about ~0.25ms) Also adds a feature flag that is disabled by default and will be enabled in subsequent CLs. (For easy revert of feature) Bug: 1072895,1072910 Test: Manually tested on Chrome OS Change-Id: I0d0174bffa802d146bce26f985bc3150e051dc05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343970 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#813018}
-
evliu authored
This CL adds a browser test for the Speech Recognition Service using the Speech On-Device API (SODA) binary and test file. Bug: 1122784 Change-Id: Ib143827f9ef1ee44c366f98752e36c4ed219d072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440311Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#813017}
-
Peter Boström authored
Used to test grt@'s hypothesis in https://crbug.com/677806. Bug: 677806 Change-Id: I1f2fa6c799fdd765f7dfbe2530f4fb5916fbb5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443976 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#813016}
-
Mustafa Camurcu authored
Uses GFX metrics to trace and report frame jankiness to UMA. Traces are done in 5 minute intervals. BUG=b:169211158 TEST=Manually tested on PlayStore and other apps and looked at results. Change-Id: I87a381193bc9d0dbd00d81386cc4c0396c9afdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430505 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Auto-Submit: Mustafa Camurcu <camurcu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813015}
-
Weilun Shi authored
Add back --inputs to the generate_expired_histograms_array script. A follow up cl will add an assertion in the _GenerateFile function to make sure that the input always keeps in sync the most updated list of metadata description. TBR=rohitrao Bug: 1133102 Change-Id: Ic4a28adf60f9a5cf9331414defedb5bd91e99d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444449 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#813014}
-
Sinan Sahin authored
TBR=wychen@chromium.org Bug: 1134361 Change-Id: Id061120cc3e8003a674584613e291d3293b5107a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444134Reviewed-by:
Sinan Sahin <sinansahin@google.com> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#813013}
-
Harald Alvestrand authored
The chromium feature is https://www.chromestatus.com/feature/5410592384876544 The intent-to-implement-and-ship thread is https://groups.google.com/a/chromium.org/g/blink-dev/c/dAeG7K7HPG8 The feature is covered by WPT tests. Bug: chromium:980879 Change-Id: Icac0d2f4b116bc775a9635c7441f6f8cbad371a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438065Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#813012}
-
Callistus authored
- Added |IsLSSEnabled| to help_app_ui.mojom. - LSS methods in receiver forward requests via message pipe. - Implement message handlers in browser_proxy. - Added browsertest to ensure LSS methods used by delegate. Bug: b/166047521 Change-Id: Iadc5fba94e79631d7b293be0e5b917f72bdc8fc8 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437560Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
dstockwell <dstockwell@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Callistus Tan <callistus@google.com> Cr-Commit-Position: refs/heads/master@{#813011}
-
Yao Xiao authored
The version needs to be passed around, and for a single floc computation cycle, the blocklist service is supposed validate the version from sorting-lsh output to make sure they are in sync. This is to address race conditions when a new component comes between the 2 file reads. Bug: 1062736 Change-Id: I597565902fb8e893c7481cee496411880c6839b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443495 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813010}
-
Scott Violet authored
This way the embedder can readily detect when and if a Browser or Tab has been destroyed. BUG=1134085 TEST=covered by tests Change-Id: I2e316e023d18c04d4aec6139306d1815e1ee65cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443402Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#813009}
-
Felix Andrew authored
Bug: 1132914 Changes to base::Value to use absl::variant made it necessary to change the .natvis to aid in debugging. Change-Id: I1f3d99afeb28bdb5a9d132d3bb578103befc6525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436320Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#813008}
-
Mihai Sardarescu authored
This CL adds a "supervised" argument to the X-Chrome-Connected header when the account that is signed in to Chrome is a child account. Design document (Google internal): https://docs.google.com/document/d/1u5PUBIeTxXiKSpqJHDiSuc9hJ2Y9_Te4ja5eJdLfZk4/edit?usp=sharing Bug: 1103228 Change-Id: Ic90021207213d926ed2dbb54b78eb4d9559a0da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431524 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#813007}
-
Peter Boström authored
Auto-grouping a pinned tab would unpin it, which is likely not what the person intended. Bug: 1133147 Change-Id: I504ed6e2117c96f53840a24993fd7891d6b3c30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444269Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#813006}
-
Dave Tapuska authored
Change to use gfx::Size over WebSize for WebView/WebViewClient. BUG=738465 Change-Id: Ic3470cd85b61cdbb8719aa924a138fdaf34db8fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441193 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#813005}
-
Nico Weber authored
After https://chromium-review.googlesource.com/c/chromium/src/+/2426564, not having a sources assignments filter is the default. No behavior change. Bug: 1018739 Change-Id: I6e0e4aa4499d7a99908a63851b899c639543a3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443690 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#813004}
-