GitLab

Screenshot (<1024px) : http://screen/ktdXzvCgc0c
Screenshot (<512px) : http://screen/kPDKQRi0dyo

Bug: 994545, 993915
Change-Id: Iecf2c2c7865e9d8aaf905fe43124193f03b2beda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757290
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688592}

Bug: 993962
Change-Id: Iaa4ada2faf2384a4bdb142756bece266d80fddd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761297
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688591}

This CL updates the expiry milestone for the GPU AppContainer flag to
M82. While this file is being modified remove the entry for the old
renderer AppContainer flag which has already been removed from the
codebase.

Change-Id: I75ddee725bc86a1ed0a6063b77a9c2e4c56bf4eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758342Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688590}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b88012e339bf..7a6df9bfe5fd


Created with:
  gclient setdep -r src-internal@7a6df9bfe5fd

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: I576796369c22bec219158b991358e2fa9f5e85a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762270Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688589}

Enable openxr input tests in webxr_vr_input_browser_test.cc by changing
tests using IN_PROC_MULTI_CLASS_BROWSER_TEST_F2 to
WEBXR_VR_ALL_RUNTIMES_BROWSER_TEST_F.

Bug: 992575
Change-Id: I1799b3c332424530b16e1f865b0785aa51755639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744675
Commit-Queue: Zheng Qin <zheqi@microsoft.com>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688588}

This test is still flaky. crrev.com/c/1760892 didn't disable it correctly.

TBR=eirage@chromium.org

Bug: 995285
Change-Id: I1459e5a753d9e2435393242a990c20741be77a91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761637Reviewed-by: Yi Gu <yigu@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688587}

This is for test only.

Bug: 993298
Change-Id: I1ad64dc60828040403be5bc0e8265d89c1ddf60c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757311
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688586}

both for implementors and users. The previous version used out parameters
combined with usual net style maybe-async methods, which were also cancelled
if the backend was destroyed. This has caused multiple complexities:
1) Managing lifetime of the place where the out parameter is written to is
   messy for the client.

2) The cancellation requirement on the backend is a bit tricky since it needs
   to post asynchronously, so there are multiple ways of getting it wrong and
   either overruning the lifetime of target pointer or leaking a pointer that
   shouldn't leak, and I think I did pretty much all of them?

3) (This was pointed out by comments in CacheStorage code): if the callback to
   is  bound to a weak pointer, then it was very easy for just-opened entries
   to leak if the destination became null.  This was a problem before CL internally in
   SimpleCache, and despite having these helpful comments on some ops, CacheStorage
   had it wrong in others. GeneratedCodeCache (which I reviewed, *cough*, *cough*),
   had that leak. I think the HTTP and shader caches might have been the only places
   to get it exactly right...

So instead, return / pass to callbacks a move-only EntryResult type which owns the
entry until it's released from it.  This type still has a net error code, so
the pending pattern still largely follows, but there are no longer any out pointers,
and if a callback is cancelled the entry gets closed.

Bug: 586174
Change-Id: I9b747766dff0b3cad031a1e04658ea7ad96643b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735974Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688585}

These were not being assigned to a var, so were immediately getting
destroyed. I did the same thing for one of my crash keys so thought I
would look around to see if anyone else made the same mistake.

Bug: 824649
Change-Id: Ib253e01f4eedeae8412a80fb91650639b06c84e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761014
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688584}

- This change disables non ipp/ipps protocols for autoconf printers,
  since selecting one for an autoconf printer could put the user in
  a broken state.
- Since we will disable the make/model dropdown in the edit dialog for
  autoconf printers, we want to prevent users from selecting a protocol
  that would require users to select their own PPD make/model.

Bug: 947183
Test: End to end manual, browsertest
Change-Id: I0d46626113f98a128e05cc7b6d95678e6e9301cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747148
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688583}

Just some spelling corrections.

Change-Id: I5d3105901de21b444014f599dafad74d29ea4571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761475Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688582}

https://crrev.com/c/1666270 uses recyclerView.removeViewAt to
manually remove dropped view, but this will lead to crash on KitKat
devices because this is not the most ideal method to manually
remove child from recyclerView. This CL fixes this issue.

Bug: 988400
Change-Id: I61f643dddf1870c7c9007b692ca85630ec2c79b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733423
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688581}

This is a reland of 9e12e07d

Original change's description:
> Refactor dependency on memory_instrumentation.mojom out of process.mojom
>
> Deprecates use of memory_instrumentation.mojom.GlobalMemoryDump struct
> in process.mojom and ArcProcessService. Uses new struct ArcMemoryDump
> instead.
>
> manager for Android memory footprint
>
> Bug: b:139190852
> Test: Build cheet_x86 and flash betty-arcnext, check Chrome OS task
> Change-Id: Ib21dfcf8ab7c23dfd60573341dfdddbcb744f166
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749456
> Commit-Queue: Willie Koomson <wvk@google.com>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#688212}

Bug: b:139190852
Change-Id: I956b640fae3127e65c148ae40c474142ad685ee8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761292Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Willie Koomson <wvk@google.com>
Cr-Commit-Position: refs/heads/master@{#688580}

After buttons are changed as unscrollable, users can reload policy or
export them to Json file without scrolling the page to the top. That's
will be more convenient.

Bug: 991296
Change-Id: Ic9a0b70cb888a1eb36f58c8ac2317ea96b781aab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761603Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Yann Dago <ydago@chromium.org>
Commit-Queue: Anqing Zhao <anqing@google.com>
Cr-Commit-Position: refs/heads/master@{#688579}

This CL creates the SystemMemoryPressureEvaluator for MacOS, as part
of a refactoring of the MemoryPressureMonitor to use the
Voter-Aggregator design described here:
https://docs.google.com/document/d/1W3FPDyjIAKBcFGNYsHA3EKR1FHrJlbBaqT4_RUnxzq0/edit?ts=5d3f5714#heading=h.7nki9mck5t64
This Evaluator calculates memory pressure and emits notifications
identically to the previous Monitor, but does so by casting its votes
for memory pressure through a MemoryPressureVoter.

Bug: 980965
Change-Id: I7a065bd2adb635520744870ed9bd680a5dcb4178
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742510
Commit-Queue: Ryan Powell <ryanpow@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688578}

This converts a few more files to expect the right result from
NavigateToURL(), fixing behavior in several tests in the process.
Most of these files had tests that would fail if we simply added
EXPECT_TRUE to their use of NavigateToURL().  Some of the causes of
that were:

- Navigating to invalid/broken URLs
  (MHTMLGenerationTest.InvalidPath, TracingControllerTest.*)

- Navigating to javascript URLs that actually ended up navigating
  the page (or some other frame) somewhere else.
  (BookmarkletTest.Redirect*, SessionHistoryTest.*)

- Navigating to URLs that redirect to other URLs
  (VerifyCrossSiteRedirectURL, RedirectAndRespondWithNavigationPreload)

- Navigating to URLs with a broken test server that was incapable
  of actually serving the right files.
  (NetworkServiceBrowserTest.SyncXHROnCrash)

- Navigating to URLs that result in a crash
  (SecurityExploitBrowserTest.DidCommitInvalidURL)

- Navigating to a webui URL that doesn't exist in content/
  (WorkerNetworkIsolationKeyBrowserTest).  Bonus points for
  then relying on cross-process behavior of error page
  isolation to accidentally satisfy the test's requirements.

Bug: 425335
Change-Id: I471479b5811f89793f105dce429fa13f342e0df5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759900Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688577}

ServerInfoMaps now use NetworkIsolationKeys in addition to
SchemeHostPorts as indices. These new indices are stored on disk. This
CL also introduces a feature to enable respecting these indices when
creating the keys.

The on-disk format of the ServerInfoMap changes from:
[{<server1>: {<values1>}},{<server2>: {<values2>}}]
to
[{<values1>},{<values2>}]

And <values> dictionaries now contain both the server HostPortPairs,
and the NetworkIsolationKeys. As a result of this change, ServerInfo
data from old prefs files will be lost, though other entries will
be retained.

This CL does not add an API to actually set NetworkIsolationKey when
using an HttpServerProperties object, that will come in another CL.

Bug: 969890
Change-Id: I8b115f5e704358c3178052e225087de2ef5446a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745820Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688576}

touchable_icon_size is no longer necessary as the icon is sized at the
MenuItemView level.

touchable_icon_color is also removed. The foreground color for Chrome
OS menus (in normal/light mode) is GG900, and DeriveDefaultIconColor
(by design) computes a value very close to GG700 from that input. Thus,
this is a slight behavioral change, but it removes one more instance of
a hard-coded color, and prepares Chrome OS to support dark mode.

Bug: 989353
Change-Id: I3a4cd11624b461c05e00bd3b8c82acbce3f75d9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759084Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688575}

ArcAppsPrivateApiTest.OnInstalled creates a FakeAppInstance, but the instance
is torn down without clearing the underlying connection. This causes test
flakes where the App Service is still trying to resolve callbacks against the
FakeAppInstance that is now destroyed at the end of the test.

This CL fixes the test by creating the FakeAppInstance as a member variable on
the test, and adding a TearDown step to properly clean up the connection.

BUG=992839

Change-Id: I748fcc6c64d66392848ad0c49ec7916e7e8686b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757950
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688574}

"Purpose: prefetch" is not standardized, and is not
considered in the CORS spec. To obey the CORS spec
strictly, we need to perform a CORS preflight handshake,
but this is undesirable.

Until we standardize this header in the spec, we decided
to use "cors_exempt_headers" mechanisms. Blink already
uses it, but the PrerenderURLLoaderThrottle is overlooked.

This won't break anything, but will reduce benefits of
prerendering.

This patch adopt the "cors_exempt_headers" fix even for
the PrerenderURLLoaderThrrole case, and solve the
potential performance issue.

This is affecting some large sites as observing increased
OPTIONS requests.

Bug: 995733
Change-Id: I7efd365d48bf24e27e18847f2c26da15c6613a22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757415
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688573}

Bug: 914410
Change-Id: I9510cd8eda7d8b678b1579798670b9d01d82a755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761243
Commit-Queue: Nathan Parker <nparker@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688572}

This patch introduces a VirtualAuthenticatorRequestDelegate that
replaces ChromeAuthenticatorRequestDelegate when the virtual environment
is enabled. This lets us do the following things:

* Disable the UI when the virtual environment is enabled, regardless of
  whether content shell or chrome is running.
* Have IsUserVerifyingPlatformAuthenticatorAvailable return `true` if a
  virtual authenticator with internal transport is available.
* Make the support for resident keys better by implementing
  SelectAccount. This is not ideal (the first credential is chosen) but
  better than hanging the request and can be improved in the future.

Bug: 991675, 991666
Change-Id: I30a00fac8d9d75fe5d297ef598c82b6ae1030b95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752541
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#688571}

This is the updater's equivalent to mini_installer.

Bug: 995805
Change-Id: I6e126fc3dd0e56073a28299a6e9ef3c39fca8232
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761636
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688570}

Bug: 990918
Change-Id: Iba9863e480e93a4618e56f8f1998327a0e03c5f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758912Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#688569}

Some sites have very wide layouts which cause the tests to not find
elements if they are not on the initial screen, and save scrolling.

This fixes a couple tests on windows (sephora and carsforsale)

Change-Id: I9b959e76b48831bdb9d924764a81a754e1f829b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761212Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Ian Struiksma <ianstruiksma@google.com>
Cr-Commit-Position: refs/heads/master@{#688568}

If we could somehow add a tab without triggering BrowserViewLayout::Layout()
(which seems plausible in theory although I could not make it happen in
practice), the new tab's background offset would not be set correctly.  Just
initializing the member to 0 would not fix this.  Instead, keep the current
background offset on the tabstrip, which ensures tabs always see the most
up-to-date value.

This also happens to use (trivially) less memory.

Bug: 869933
Change-Id: I71c43dfd16472c048d54168271ef851e4e8e9afb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761491
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688567}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I7e9ee359a12151754e0a006a8732383c567f8120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761481Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688566}

TBR=tkent@chromium.org

Bug: 981719
Change-Id: I18b4d6582ce9cf66e54b9941631acb902b2c016f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761147Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688565}

Due to modifications to the string lists in css_proto_converter.cc,
the proto definition no longer matched up with the proto converter.
Update both lists to match, including some additional properties/values
not previously included. Also remove the restriction on building the
fuzzer for Windows, as it appears to build now.

Bug: 990327
Change-Id: I0c2b22a0db2aae3c53bb95eb5f539b151be3dddf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742727Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688564}

This reverts commit 6e49ee86.

Reason for revert: Apparently we use --gtest_repeat to retry failures :(. See, e.g., https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8904608481037328864/+/steps/webkit_layout_tests__without_patch_/0/stdout

Original change's description:
> Remove obsolete --gtest* flags to run_web_tests.
> 
> run_web_tests supported the --gtest_repeat,
> --gtest_also_run_disabled_tests, and --gtest_filter flags for
> compatibility with FindIt; however FindIt eventually moved
> to using the --isolated-script-test flags instead, and these
> flags should no longer be used or needed, so this CL removes them.
> 
> This is a prelude to cleaning up and implementing proper support
> for multiple --isolated-script-test-filter args.
> 
> Bug: 893235, 994943
> Change-Id: Id7a8ef5f43855b54eeb76193ceca45310b426890
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759138
> Reviewed-by: Chan Li <chanli@chromium.org>
> Reviewed-by: Robert Ma <robertma@chromium.org>
> Reviewed-by: Rakib Hasan <rmhasan@google.com>
> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#688190}

TBR=dpranke@chromium.org,chanli@chromium.org,robertma@chromium.org,rmhasan@google.com

Change-Id: Iefbc7390a69046bd0ab3205f090f003944d9874c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 893235, 994943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761638Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688563}

Tbr: schenney@
Change-Id: I2be033328741a747e94beca1b61ca9fd4a6a7841
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762218Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688562}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/90c00916229f..210fac8904dc

git log 90c00916229f..210fac8904dc --date=short --no-merges --format='%ad %ae %s'
2019-08-20 zoddicus@users.noreply.github.com Rolling 4 dependencies (#779)

Created with:
  gclient setdep -r src/third_party/shaderc/src@210fac8904dc

The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=radial-bots+chrome-roll@google.com

Bug: None
Change-Id: I757bb9bc0714db0f9a84abcb349e25a1bd9c7d48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762054Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688561}

This CL fixes the UseCounter for LargestContentfulPaint by moving it to
the PerformanceObserver::observe() method. Before, it would be triggered
in Performance::getEntriesByTypeInternal(), which would be triggered
only when requesting LCP entries with the buffered flag. While at it, we
move ElementTiming UseCounter to this method too (no important change).
We do not move the EventTiming UseCounter because if 'event' is observed
then we will add to the UseCounter even though it's not shipped yet.
Once issue 994332 is fixed, we could move the UseCounter logic.

This CL also adds a UseCounter for calling observe() with the buffered
flag. We trigger it with any call to observe() where the buffered flag
is set to true.

Bug: 995455
Change-Id: Id8c443b8403cbc4b909c5815213fef8e97623715
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760981Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688560}

The latter didn't originally exist, but most of these methods have a NetworkContext associated with them so we should route it there.

Change-Id: I7d1bfbea4a36cc1b851725531c841ddd799797dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759297Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688559}

Currently, if the color picker or color suggestion picker is open and
the type of the owning input element changes from color to something
else, the popup to choose a new color remains open even though the type
of the input has changed. This can be seen in the
color-picker-appearance-set-type test, when run with the form controls
refresh flag enabled. This change is fixing this issue, which results
in the popup being dismissed when the input's type is changed.

This behavior is not spec'ed and neither is there consistency between
browsers on how this scenario should behave - Firefox does not dismiss
popups on type change, while Edgehtml-based Edge does. However, from a
user's perspective, it is strange to see the old popup once the type of
the input has changed. Additionally, in the case of the date control,
the picker does get dismissed when a type change occurs. Hence, it
makes sense to do the same for the color control, so that there is
consistent behavior across controls in Chromium.

Note that this change is not limited to the form controls refresh flag
as the color suggestion picker, which pre-dates the form controls
refresh project, is also being fixed. A test is being added for this
case to validate the new behavior.

Bug: 985889
Change-Id: Idcf7c5ad056b21bf59870496a8fe618ee2309d05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759226Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Sanket Joshi <sajos@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#688558}

This CL converts CookieChangeListenerPtr and
CookieChangeListenerRequest to new Mojo types.
It updates AddChangeListener from
restricted_cookie_manager.mojom,
AddCookieChangeListener and AddGlobalChangeListener
from cookie_manager.mojom.

Bug: 955171, 978694
Change-Id: I315979060078f10b8b73827b9a42a3b705d0a45d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753371
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688557}

The flow of the crash
- PasswordManager::OnGeneratedPasswordAccepted is called when a generated password is accepted.
- It can bring up the "Update Password?" bubble
- Focus lost event is happening, the dropdown is closed, the controller is destroyed.
- PasswordManager::OnGeneratedPasswordAccepted finishes.
- PasswordGenerationPopupControllerImpl tries to hide the UI again but everything is gone already.

Bug: 995321
Change-Id: I791c969ea6af1b6fc305219a5c22d49424ab38ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762214Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688556}

Because test_driver Action API created a "none" type for "pause" action
not just adding "pause" action in the pointer action sequence, we need
to not include "none" type for pointer action index.

Bug: 606367
Change-Id: I503327c41f76b0587ee84cdea4a1313f6fa572f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752350
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688555}

This CL builds the implementation of Web Share Target for TWAs
on top of the previous one (http://crrev.com/c/1715374):

- Adds TwaIntentHandlingStrategy for TWA-specific logic of intent
handling. It sends the intent to TwaSharingController to check
whether it's a sharing intent.

- Adds TwaSharingController that parses share
target json, constructs and launches GET requests, and delegates
handling POST requests to WebApkPostShareTargetNavigator.

- Adds unit tests for share target parsing, and a few integration
tests for the whole sharing process.


Bug: 985331
Change-Id: Ifa98e46a5e5c681a30442aecfbd6df57a60d9e39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724686
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688554}

R=pdr@chromium.org

Bug: None
Change-Id: Ia263c5503c93fffcb913fa5bfc58bf23edac2e85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760882
Auto-Submit: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688553}