GitLab

Before, wifi_config_view expected to read only a plain PKCS#11 ID from the shill::kEapCertIdProperty. However the format changed to '<slot_id>:<key_id>' since the system token is enabled in ChromeOS. This lead to the view not correctly pre-selecting the previously configured certificate.
With this change, the property is correctly parsed and the pre-selection works again for certificates from the user's slot.

BUG=358366, 396181

Review URL: https://codereview.chromium.org/410113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285806 0039d316-1c4b-4281-b951-d872f2087c98

Can be reenabled after this test was moved to browser_tests.

BUG=396497
TBR=joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/420963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285805 0039d316-1c4b-4281-b951-d872f2087c98

It adds a new TLSSocket type in the extensions:: namespace, that acts similarly
to TCP/UDPSocket.  Failures to enable TLS will auto-close the socket.

API Proposal: https://docs.google.com/a/google.com/document/d/1XSjBtLjyGXQmgB0XE4kxuvM0p2yKI_8T5aOiKDJ9lFg/edit

BUG=132896
TESTED=some, mostly with a custom chrome app, and with the included test.

Review URL: https://codereview.chromium.org/76403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285804 0039d316-1c4b-4281-b951-d872f2087c98

Notification promos currently have start, end times, and a number of maximum
views. However, the length of time a promo can be visible was not capped.
This change adds a flag to cap the length of time a promo is visible by
max_seconds_.

BUG=None
Test=None

Review URL: https://codereview.chromium.org/419033007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285803 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381820

Review URL: https://codereview.chromium.org/420603014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285802 0039d316-1c4b-4281-b951-d872f2087c98

This is the refactoring to prepare newlib switching.
By this CL, we can easily use elf_loader defined in native_client repository, even for making a working demo.

TEST=Ran trybots.
BUG=358465
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32

Review URL: https://codereview.chromium.org/418133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285801 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn extensions/browser
R=brettw@chromium.org
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/418763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285800 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367364

Review URL: https://codereview.chromium.org/423543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285799 0039d316-1c4b-4281-b951-d872f2087c98

RSA properties such as n, e, d, p, q, dp, dq, qi are big integers encoded as base64 url-safe, big-endian octet strings.

 * Reject big integers that contain leading zeros, since by the JWA rules they must be minimal.
 * Reject big integers that are the empty octet string (since 0 is the minimal representation of the big-endian number 0, not empty string).

This also changes the exception message and type when one of the optional parameters p, q, dp, dq, qi are missing. Before it would give an OperationError, because NSS was unable to infer the missing parameters. Now it gives a DataError explaining that the parameter is required.

BUG=374927,383998

Review URL: https://codereview.chromium.org/416993009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285798 0039d316-1c4b-4281-b951-d872f2087c98

This is an optimization to speed up in-page navigations. We want those to be
blazingly fast, and currently the pixel readback done while taking a
screenshot takes 40ms on a GPU on Pixel. This may be reverted once
screenshotting is optimizaed.

Also changed the background color shown bu GestureNav when there is no
screenshot available from gray to white to make it look less broken.

BUG=379983

Review URL: https://codereview.chromium.org/417343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285797 0039d316-1c4b-4281-b951-d872f2087c98

The toolbar's superview chromeContentView was incorrectly sized and was too
small. This happened because chromeContentView's layout was not being updated
in -[BrowserWindowController layoutSubviews].

I updated the unit tests in browser_window_controller_unittest.mm with 2 changes:
- All layout checking should use window coordinates, to ensure consistency.
- Layout checking should ensure that the frame of each view is within the
bounds of the superview.

BUG=396740

Review URL: https://codereview.chromium.org/419683008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285796 0039d316-1c4b-4281-b951-d872f2087c98

The status tray change made it so that a view must be accessiblity focusable to be read. Tabs are now accessibility focusable so now they will be read with the status tray change.

Review URL: https://codereview.chromium.org/414203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285795 0039d316-1c4b-4281-b951-d872f2087c98

In record_wpr, _ParseArgs will take a list of arguments that can be provided
by tests to be used instead (rather than being extra).

BUG=397725

Review URL: https://codereview.chromium.org/414223009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285794 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346956

Review URL: https://codereview.chromium.org/419503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285793 0039d316-1c4b-4281-b951-d872f2087c98

This change adds the infrastructure for unit testing the JS parts of
apps and extensions APIs implemented on top of Mojo services. The test
environment provides a partial implementation of the JS test API
provided to browser tests. A TestServiceProvider implementation is
used to provide test implementations of the appropriate Mojo services to
the JS code.

BUG=389016

Review URL: https://codereview.chromium.org/399363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285792 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393873
R=dbeam@chromium.org,khorimoto@chromium.org

Review URL: https://codereview.chromium.org/415863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285791 0039d316-1c4b-4281-b951-d872f2087c98

Hitting Escape repeatedly to close an overlay can trigger a TypeError
if Escape is pressed again before the overlay is fully hidden.

overlays.js and options_page.js have differing opinions on when an
overlay is visible, so overlays.js will send the Esc event while
the overlay is animating out.

R=estade@chromium.org

Review URL: https://codereview.chromium.org/423583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285790 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285789 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390222,384185

Review URL: https://codereview.chromium.org/419973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285788 0039d316-1c4b-4281-b951-d872f2087c98

It's trying to append to a list that doesn't exist yet.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/424453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285787 0039d316-1c4b-4281-b951-d872f2087c98

With --use-surfaces, the frame data from a renderer is now put into a surface, and a SurfaceLayer is put in the browser compositor's layer tree. We still rely on the browser compositor redrawing to schedule a redraw of the entire surface tree.

Review URL: https://codereview.chromium.org/417943004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285786 0039d316-1c4b-4281-b951-d872f2087c98

TEST=checked that selection handles show up when dragging from outside
     selectable region, e.g. text, and drop inside selectable region using
     a stylus while pressing a button.
BUG=397468

Review URL: https://codereview.chromium.org/416383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285785 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397261

Review URL: https://codereview.chromium.org/416333009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285784 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285783 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/423583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285782 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/d6aeb6dc8fe21066f1a2c4813a4256a3acd3edf5..048f422ec666cb18089c8fa7507e6bdca60d373c

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=robertphillips@google.com
BUG=

Review URL: https://codereview.chromium.org/424443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285781 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Failing ASAN tests because of leak.

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/5391

Original issue's description:
> Add a chrome://interstitials page.
> 
> Screenshots:
> https://docs.google.com/file/d/0B9q2eN9gDoUIUUhrMlpydVNTVXc/edit?pli=1
> https://drive.google.com/file/d/0B9q2eN9gDoUIMjdhQ1p3M05zNDQ/edit?usp=sharing
> 
> BUG=389749
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285766

NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/418293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285780 0039d316-1c4b-4281-b951-d872f2087c98

Should be last step before moving chrome.runtime.setUninstalURL to stable.

BUG=84556
TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/414303005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285779 0039d316-1c4b-4281-b951-d872f2087c98

This is a re-land of https://codereview.chromium.org/412943002/
which broke on the official builder.

BUG=284540
TBR=sky@chromium.org, mathp@chromium.org, jwd@chromium.org

Review URL: https://codereview.chromium.org/421663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285778 0039d316-1c4b-4281-b951-d872f2087c98

Creates a CryptographerProvider interface that can be used to expose the
syncable::Directory's Cryptographer without exposing the directory
itself.  Since the directory's cryptographer is protected by a lock,
this requires the creation of several helper classes to manage the
acquistion of the lock.

This CL includes the interface, an implementationthat exposes the
directory's cryptographer (DirectoryCryptographerProvider) and
a SimpleCryptographerProvider that wraps a non-owned Cryptographer for
testing purposes.

These interfaces will be used to implement and test encryption of
non-blocking sync types.

BUG=351005

Review URL: https://codereview.chromium.org/413833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285777 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=WindowTargeterTest.ScopedWindowTargeterWindowDestroyed

Review URL: https://codereview.chromium.org/423503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285776 0039d316-1c4b-4281-b951-d872f2087c98

BUG=388893

Review URL: https://codereview.chromium.org/413353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285775 0039d316-1c4b-4281-b951-d872f2087c98

This enables the Chrome to query permission_broker for access
to hidraw device paths when running on Chrome OS.

HidService has been refactored so that it is owned by the
extensions API embedder, rather than being a singleton.

Because hid has just moved to //extensions as well, this also establishes a new ShellExtensionsAPIClient to create a HidService for app_shell.

BUG=367145
TEST=manual test on ChromeOS dev build
TBR=derat@chromium.org for mechanical app_shell changes

Review URL: https://codereview.chromium.org/419713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285774 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285773 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in a fix that is needed to roll NaCl.

BUG=none

Review URL: https://codereview.chromium.org/414283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285772 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/413353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285771 0039d316-1c4b-4281-b951-d872f2087c98

A regression where we stopped showing the manifest error was introduced in
r283852. Fix it.

TBR=finnur@chromium.org

BUG=397467

Review URL: https://codereview.chromium.org/422533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285770 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394940

Review URL: https://codereview.chromium.org/408633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285769 0039d316-1c4b-4281-b951-d872f2087c98

This is an implementation of session APIs without wifi passwords. Will add wifi passwords in separate CL.

BUG=

Review URL: https://codereview.chromium.org/411783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285768 0039d316-1c4b-4281-b951-d872f2087c98

In preparation for out-of-process iframes, move almost all accessibility
functionality from RenderView to RenderFrame, and from RVHI and RWHI
to RFHI.

In addition, the accessibility mode is moved to WebContents, and changing
the mode triggers changing it on all frames.

BUG=368298
R=jam@chromium.org, kenrb@chromium.org, nick@chromium.org

Review URL: https://codereview.chromium.org/273423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285767 0039d316-1c4b-4281-b951-d872f2087c98