- 09 Sep, 2016 40 commits
-
-
sammiequon authored
- Pin keyboard backspace can be held down to keep deleting. - Pin keyboard key events used to doubled on settings/options. - Pin keyboard placeholder displays correct message. - Removed "clear" string, since the backspace is icon only now. - Bubble now disappears when user presses a pin keyboard button after a wrong password has been entered. BUG=642587 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2302483003 Cr-Commit-Position: refs/heads/master@{#417514}
-
falken authored
It fails rather than times out after: https://crrev.com/6f3528e03445a08f492462007724dd25120d372a BUG=508734 TBR=jsbell Review-Url: https://codereview.chromium.org/2324763004 Cr-Commit-Position: refs/heads/master@{#417513}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/8e6237357 BUG=643623 TBR=fmalita@chromium.org Review URL: https://codereview.chromium.org/2313353004 . Cr-Commit-Position: refs/heads/master@{#417512}
-
jeffcarp authored
BUG= Review-Url: https://codereview.chromium.org/2304453003 Cr-Commit-Position: refs/heads/master@{#417511}
-
jri authored
R=rch@chromium.org CC=jokulik@chromium.org,fayang@chromium.org BUG= Review-Url: https://codereview.chromium.org/2325733004 Cr-Commit-Position: refs/heads/master@{#417510}
-
drcrash authored
(Redo due to http://crbug.com/645052) By returning a signed simple challenge that can actually be parsed as SignedData, we allow callers of the FakeCryptohomeClient to extract the original data back and process it, making for better fake behavior and simpler tests. Note that the signature is purposedly not verifiable in the FakeCryptohomeClient. BUG=643245 TEST=chromeos_unittests; unit_tests and components_unittests also pass TBR=xiyuan@chromium.org Committed: https://crrev.com/911199cb30f608636c79d47e50dca84735e3a08f Cr-Commit-Position: refs/heads/master@{#417118} patch from issue 2297193006 at patchset 120001 (http://crrev.com/2297193006#ps120001) Review-Url: https://codereview.chromium.org/2324793003 Cr-Commit-Position: refs/heads/master@{#417509}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2f63c684f0aa..091029905a83 $ git log 2f63c684f..091029905 --date=short --no-merges --format='%ad %ae %s' 2016-09-08 benjhayden Make ValueSet use an ES6 Map. 2016-09-08 benjhayden Improve usability of value-set-table's groupby-picker. TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2318933009 Cr-Commit-Position: refs/heads/master@{#417508}
-
dgozman authored
This is a step towards turning all tree outlines into independent web components, removing global styles related to it and allowing more components to encapsulate their inner details. BUG=none Review-Url: https://codereview.chromium.org/2325003002 Cr-Commit-Position: refs/heads/master@{#417507}
-
allada authored
Currently, we only send encodedDataLength for redirects. However, we already know how much we read when sending ResponseReceived. This will improve reporting for failed requests, as they don't get loadingFinished with full encodedDataLength. Previous CL: https://codereview.chromium.org/2101073002 BUG=622018 Review-Url: https://codereview.chromium.org/2167853003 Cr-Commit-Position: refs/heads/master@{#417506}
-
jamescook authored
NativeWidgetMus::SetBounds() was not correcting for the display origin. Also fix NativeWidgetMus::GetBoundsInScreen(), which had the same problem. BUG=645291,644895 TEST=run mash with --multi-display, shelf appears on second display Review-Url: https://codereview.chromium.org/2328523003 Cr-Commit-Position: refs/heads/master@{#417505}
-
fmalita authored
SVGImageForContainer tracks a container zoom factor independently of the actual container size. This zoom factor needs to be accounted for in imageForCurrentFrame() -- otherwise we end up producing an SkImage with a different size than reported by SVGImageForContainer::size(). The easiest way to accomplish this is to use size() when calling SVGImage::imageForCurrentFrameForContainer(), instead of the unzoomed m_containerSize. BUG=643623 R=fs@opera.com,davve@opera.com Review-Url: https://codereview.chromium.org/2323853002 Cr-Commit-Position: refs/heads/master@{#417504}
-
dbeam authored
Potentially used in: https://codereview.chromium.org/2280513002/ R=tsergeant@chromium.org BUG=598017 Review-Url: https://codereview.chromium.org/2321883004 Cr-Commit-Position: refs/heads/master@{#417503}
-
yhirano authored
BUG=641215 Review-Url: https://codereview.chromium.org/2319013006 Cr-Commit-Position: refs/heads/master@{#417502}
-
haraken authored
Now that Oilpan is shipped, we no longer need public/features.gni. BUG= Review-Url: https://codereview.chromium.org/2320343002 Cr-Commit-Position: refs/heads/master@{#417501}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d046985fcb95..2f63c684f0aa $ git log d046985fc..2f63c684f --date=short --no-merges --format='%ad %ae %s' 2016-09-08 benjhayden Approve Destructuring and Subclassable Built-ins in style-guide.md. 2016-09-08 benjhayden Display "(empty)" and "(missing)" in value-set-table TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2321863005 Cr-Commit-Position: refs/heads/master@{#417500}
-
changwan authored
Assertions are removed from some of the InputConnection methods that merely post on UI thread. In doing so, mPendingAccent was changed to be accessed only on UI thread. However, beginBatchEdit() / endBatchEdit() implementations are quite complicated and no evidence calling those on UI thread was found so far. Also, for get* methods we return cached results. BUG=643477 Review-Url: https://codereview.chromium.org/2299913003 Cr-Commit-Position: refs/heads/master@{#417499}
-
eroman authored
This removes some duplicated code. BUG=634443 Review-Url: https://codereview.chromium.org/2326923002 Cr-Commit-Position: refs/heads/master@{#417498}
-
einbinder authored
If a _loadCompletions was started while an earlier one was active, the earlier one could still be used. BUG=none Review-Url: https://codereview.chromium.org/2319393002 Cr-Commit-Position: refs/heads/master@{#417497}
-
dominickn authored
This CL adds a new UMA metric to record the identifier of an infobar which was visible to the user and hid another infobar behind it. This CL also updates the visible/hidden check to simply query whether or not another infobar exists. This is to correct an overcounting issue that recorded infobars which appeared after another infobar was dismissed as being hidden. BUG=589163 Review-Url: https://codereview.chromium.org/2321923002 Cr-Commit-Position: refs/heads/master@{#417496}
-
dgozman authored
This is a step towards turning all tree outlines into independent web components, removing global styles related to it and allowing more components to encapsulate their inner details. BUG=none Review-Url: https://codereview.chromium.org/2328643002 Cr-Commit-Position: refs/heads/master@{#417495}
-
meacer authored
BUG=468355 Review-Url: https://codereview.chromium.org/2321823002 Cr-Commit-Position: refs/heads/master@{#417494}
-
chrome-cron authored
Cr-Commit-Position: refs/heads/master@{#417493}
-
thakis authored
New: * win: Speculative fix for LNK1285/delete-pdb-and-rebuild * win: Support for [] ATL-style uuid() attributes * win: __nop intrinsic now has a definition * win: complete codeview debug info for vptrs Also switch to gnuwin-5, which is identical to gnuwin-4 except that it has gnuwin32's od.exe too. Also switch to the python version of the Android NDK "make standalone toolchain" script, since the .sh version is deprecated and stopped working after the recent NDK update. BUG=644351,644976,644977 Review-Url: https://codereview.chromium.org/2317123004 Cr-Commit-Position: refs/heads/master@{#417492}
-
dglazkov authored
It's more idiomatic in Blink land. R=esprehn BUG= Review-Url: https://codereview.chromium.org/2316423002 Cr-Commit-Position: refs/heads/master@{#417491}
-
kqyang authored
BUG=644373 Review-Url: https://codereview.chromium.org/2326893002 Cr-Commit-Position: refs/heads/master@{#417490}
-
rdevlin.cronin authored
In the renderer, extensions use sync IPCs to request port ids and request the i18n message bundle. We're looking into fixing this, but it'll be useful to know how much time it's taking now. BUG=645261 Review-Url: https://codereview.chromium.org/2316093004 Cr-Commit-Position: refs/heads/master@{#417489}
-
flandy authored
Often times we are doing double work parsing color text to handle invalid colors and then parsing color text again in setColorText. We should just parse once and pass in the Color object to ColorSwatch. BUG=642782 Review-Url: https://codereview.chromium.org/2310633002 Cr-Commit-Position: refs/heads/master@{#417488}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3d918b93..d87b834b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2313333004 Cr-Commit-Position: refs/heads/master@{#417487}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/3b96eccc03f1e5ab9efa74b1afdfb5edc8c5feb0 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/c958da49797facf429100595bceb4c49e8c94cd3 Switch bot_update to use exponential backoff on clone (agable@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=472386 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2326953002 Cr-Commit-Position: refs/heads/master@{#417486}
-
peria authored
It is expected to fix flaky build failures in the BUG. Using source code names, this CL adds a dependency chrome/test/base/ui_test_utils.cc --> content/public/browser/render_process_host.h Other dependencies content/public/browser/render_process_host.h --> services/shell/public/cpp/interface_registry.h --> out/Release/gen/services/shell/public/interfaces/interface_provider.mojom.h are already written. BUG=633077 Review-Url: https://codereview.chromium.org/2321563004 Cr-Commit-Position: refs/heads/master@{#417485}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d674036d5ba7..d046985fcb95 $ git log d674036d5..d046985fc --date=short --no-merges --format='%ad %ae %s' 2016-09-08 benjhayden Make metric tests examine Histograms instead of Scalars 2016-09-08 benjhayden Move displaying errors from value-set-table to metric-side-panel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2320853004 Cr-Commit-Position: refs/heads/master@{#417484}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/cf7ac195266f..cba85abc8a9d $ git log cf7ac1952..cba85abc8 --date=short --no-merges --format='%ad %ae %s' 2016-09-08 jaepark CPWL_Color::ConvertColorType should compare current color type with the given convert color type. TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2324063002 Cr-Commit-Position: refs/heads/master@{#417483}
-
mdjones authored
This change adds a method to the ResourceManager that allows users to create a tinted version of a static resource. These resources are cached until the layout changes. In practice, this new functionality is used to tint the border resource and close button in the tab switcher. BUG=641517 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2293573002 Cr-Commit-Position: refs/heads/master@{#417482}
-
thestig authored
Review-Url: https://codereview.chromium.org/2319253002 Cr-Commit-Position: refs/heads/master@{#417481}
-
dbeam authored
Also removes class toggling hackery. R=alancutter@chromium.org BUG=643651 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2321913003 Cr-Commit-Position: refs/heads/master@{#417480}
-
stanisc authored
According to crash dump OOM happens when GetWorkingSetKBytes is invoked via OomMemoryDetails from tab discarding code when it reacts to critical memory pressure. The available memory is already low at that moment so allocating 1.4-1.5 MiB to gather Working Set details is likely to fail. The fix uses UncheckedMalloc to avoid triggering an OOM crash and allow GetWorkingSetKBytes to fail, which the code calling GetWorkingSetKBytes should already handle. Another part of the fix is to reduce the extra buffer size allocated by this code from 25% to 10%. BUG=642186 Review-Url: https://codereview.chromium.org/2289123003 Cr-Commit-Position: refs/heads/master@{#417479}
-
emircan authored
The problem was addressed in r403353. We can reenable tests. BUG=604056 Review-Url: https://codereview.chromium.org/2321183003 Cr-Commit-Position: refs/heads/master@{#417478}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/026e0bb03aa139c5c43be38dd37d1f2f33e90c03 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/3dd7436899f87b0bb1538b43c4332e327fd70a98 Remove unused PATCH_TOOL and resulting dead code from bot_update. (iannucci@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=643885 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2325903002 Cr-Commit-Position: refs/heads/master@{#417477}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/b3cb2142725f..426a2459290a $ git log b3cb21427..426a24592 --date=short --no-merges --format='%ad %ae %s' 2016-09-08 halcanary SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName. 2016-09-08 kjlubick Fix strange failures on Android N CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=caryclark@google.com Review-Url: https://codereview.chromium.org/2326783003 Cr-Commit-Position: refs/heads/master@{#417476}
-
caseq authored
BUG= Review-Url: https://codereview.chromium.org/2314173003 Cr-Commit-Position: refs/heads/master@{#417475}
-